dnrops
/
rfcs
mirror of https://github.com/rust-lang/rfcs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,349 Commits 9 Branches 0 Tags 50 MiB
Commit Graph

6170 Commits

Author SHA1 Message Date
Niko Matsakis 50b4af037f rename the file 2024-07-18 10:55:21 -04:00
Niko Matsakis 5296fb3d6d ADD GOAL 
* Begin resolving `cargo-semver-checks` blockers
  for merging into cargo -- cargo team (approved)
 2024-07-18 10:22:07 -04:00
Ralf Jung 7b66fc7daf add a paragraph on NaN debugging 2024-07-18 13:57:17 +02:00
Ralf Jung 9042b9e2ac add some notes and comments from the lang team discussion 2024-07-18 09:04:45 +02:00
Niko Matsakis 39dcb71567 refresh with the latest edits 
NEW GOALS

* User-wide caching (orphaned, cargo team)

REMOVED GOALS

* Experiment with relaxing the Orphan Rule dropped
  for bandwidth concerns. (We may reframe.)

SIMPLIFIED GOALS

* Patterns of empty types -> moral support
 2024-07-17 15:01:39 -04:00
EtomicBomb 3d0dd8c4d8 version number is prefixed with V 2024-07-17 17:37:43 +00:00
Michael Goulet f8c6e9f524 whoops 2024-07-16 18:59:59 -04:00
Michael Goulet 3681ffd3e9 more nits 2024-07-16 18:58:06 -04:00
EtomicBomb 63107f90c2 add versioning, --include-rendered-docs flag 2024-07-16 18:17:30 +00:00
EtomicBomb 7b82ab9f78 typos, --mode=auto -> --mode=read-write 2024-07-16 16:18:57 +00:00
Travis Cross e17e19ac7a Merge RFC 3627: Match ergonomics 2024 
The FCP for RFC 3627 completed 2024-07-14 with a disposition to
merge.  Let's merge it.
 2024-07-14 06:29:07 +00:00
Travis Cross 28b91fb2b4 Prepare RFC 3627 to be merged 2024-07-14 06:28:00 +00:00
Travis Cross 88267c9839 Add the numbered match ergonomics rules adopted by lang 
In the lang design meeting on 2024-06-26, we adopted a slate of five
rules for match ergonomics.  We later amended *Rule 4* in our meeting
on 2024-07-03.

These five rules, as amended, form the normative description of what
the lang team means for the rules to be.  Therefore, in the
reference-level explanation, let's include these rules verbatim and
note that the remaining sections describe these rules further.
 2024-07-14 06:27:55 +00:00
Travis Cross 4a0401d571 Merge RFC 3654: Return type notation (RTN) 
The FCP for RFC 3654 completed on 2024-06-27 with a disposition to
merge.  Let's merge it.
 2024-07-12 05:47:22 +00:00
Travis Cross 4928bbcb18 Prepare RFC 3654 to be merged 
We've been using "tracking issue" rather than "rust issue" recently,
so let's adjust that.  Let's also use sentence case for the title and
remove some remaining bits left over from the RFC template.  And let's
replace some Unicode characters that don't have ubiquitous font
support with ASCII equivalents.
 2024-07-12 05:40:04 +00:00
Travis Cross d01b3f27f1 Clean up whitespace 2024-07-12 05:16:20 +00:00
Niko Matsakis 6e9855a597 rename file 2024-07-11 16:27:14 -04:00
Niko Matsakis cb38881904 link 2024-07-11 16:27:14 -04:00
Niko Matsakis d02a6cc7cb
Merge pull request #3621 from Darksonn/derive-smart-pointer 
RFC: #[derive(SmartPointer)]
 2024-07-11 16:24:27 -04:00
Niko Matsakis c73149a285 update document with nits 2024-07-11 09:32:07 -04:00
Michael Goulet ee9b0cd5fd
Update text/3668-async-closure.md 
whoops forgot a mut

Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
 2024-07-10 23:52:45 -04:00
Niko Matsakis 7d713bdbe8 fix URLs 2024-07-10 15:01:28 -04:00
Niko Matsakis c228fee09a cleanup the formatting 2024-07-10 15:00:25 -04:00
Michael Goulet 662654b36a Slightly elaborate drawback with non-nameable RTN 2024-07-10 12:03:53 -04:00
Michael Goulet 2e35b78151 Elaborate slightly the section on FnOnce 2024-07-10 11:41:08 -04:00
Niko Matsakis 7956b8df56
Update text/0000-Project-Goals-2024h2.md 
Co-authored-by: lcnr <rust@lcnr.de>
 2024-07-10 09:17:55 -04:00
Niko Matsakis 4fc3a00021 RFC for project goals 2024-07-09 20:58:47 -04:00
Alice Ryhl 85ef575ed2 Remove details about how repr(transparent) constraint is implemented 
And add #[repr(transparent)] to the examples.
 2024-07-09 14:01:19 +02:00
Jules Bertholet 97bf386e8e
`&` constrains inference 2024-07-04 10:59:53 -04:00
Michael Goulet 694d0df479 Why no AsyncFnOnce::Output 2024-07-03 18:17:33 -04:00
Michael Goulet 59e0eb2285 More writing 2024-07-03 17:47:30 -04:00
Michael Goulet 88faa5bfc0 Recommend for users to write 2024-07-03 12:09:47 -04:00
Michael Goulet 3298481e17 Fix hackmd-ism 2024-07-03 12:06:42 -04:00
Jules Bertholet 27717e6fd0
Incorporate TC's additions 2024-07-03 10:53:47 -04:00
Jules Bertholet d623f9c2a5
`&` matches `&mut` on all editions 2024-07-03 10:42:02 -04:00
Michael Goulet b2a8e07d50
Update text/3668-async-closure.md 
Co-authored-by: Yosh <github@yosh.is>
 2024-07-03 10:14:46 -04:00
Michael Goulet 26ded68308 Oops, missing words 2024-07-02 15:00:00 -04:00
Michael Goulet 23b9af8356 Grammar nit wrt ? and async 2024-07-02 14:59:02 -04:00
Michael Goulet febff99d06 One more caveat about AsyncFn* and built-in impls 2024-07-02 14:59:02 -04:00
Michael Goulet 90ea425bae Clarify the ?for<'a> weirdness 2024-07-02 14:59:02 -04:00
Michael Goulet 86fc14aeab Motivate why non-async closures should implement AsyncFn 2024-07-02 14:39:38 -04:00
Michael Goulet 3938f65cf2 Add missing generics 2024-07-02 14:36:17 -04:00
Michael Goulet 29582aa37d More clarifications 2024-07-02 14:35:03 -04:00
Michael Goulet d2446cb34e No perma 2024-07-02 14:33:59 -04:00
Travis Cross a514d3b4ac Clarify section about associated types being reserved 
We specify that the details about the traits, including the associated
types, are implementation details.  Let's make the section describing
this, with respect to the associated types, more clear and give an
example.

(Thanks to RalfJ and Yosh for raising that this section could be
clarified.)
 2024-07-02 18:31:04 +00:00
Michael Goulet 6000a0c244 update numbers 2024-07-01 17:45:40 -04:00
Michael Goulet 80249c9923 Add async closure redux RFC 2024-07-01 17:42:13 -04:00
EtomicBomb eba7fc4753 --include-info-json and --write-info-json take path directly to crate-info.json 2024-06-28 00:16:27 +00:00
Ed Page 872f285924 Fix 3416's tracking issue link 2024-06-26 22:42:26 -04:00
Ed Page 9fe5140fa7
Merge pull request #3416 from tgross35/feature-descriptions-doc-cfg 
RFC: Unblock Cargo feature metadata
 2024-06-26 21:36:45 -05:00
Ed Page a8c6163ff4
Add tracking issue 2024-06-26 21:36:24 -05:00
Daniel Paoliello 50a3735bf2 Merge branch 'basepath' of https://github.com/dpaoliello/rfcs into basepath 2024-06-26 16:30:52 -07:00
Daniel Paoliello 707870d6c7 Remove support for manifest, rename to path-base 2024-06-26 16:29:36 -07:00
Alice Ryhl 4fcfcca48f Require `#[repr(transparent)]` 2024-06-25 16:21:27 +02:00
EtomicBomb cbd62bb6e5 nits 2024-06-25 00:01:46 +00:00
Daniel Paoliello b18416d5cd
Apply suggestions from code review 
Co-authored-by: Eric Huss <eric@huss.org>
 2024-06-24 14:53:37 -07:00
Carol (Nichols || Goulding) e70fa73aea
Merge pull request #3646 from carols10cents/no-crate-transfer-help 
Change crates.io policy to not offer crate transfer mediation
 2024-06-24 15:58:16 -04:00
EtomicBomb 3326b10443 typos 2024-06-24 18:34:58 +00:00
EtomicBomb 97cf6c6630 changes in response to jsha and notriddle 2024-06-24 18:15:37 +00:00
Phosphorus Moscu 622075d617
fix typo 
remove `ds` and change a misspelling, the correct identifier is `hc`
 2024-06-24 05:14:28 -03:00
Max Niederman 0581da516e
add Unison and Wolfram langs as prior art 2024-06-22 13:29:22 -07:00
Daniel Paoliello 247ff65973 Address PR feedback 2024-06-21 15:10:51 -07:00
EtomicBomb 23e34e081b address comments from P1n3appl3 2024-06-21 21:22:28 +00:00
Daniel Paoliello 4af121b612 Address PR feedback 2024-06-21 09:44:37 -07:00
Daniel Paoliello e9f7566645 Rewrote motiviation 2024-06-20 16:23:59 -07:00
Daniel Paoliello 5ccbe52fb2 Update RFC number 2024-06-20 15:45:27 -07:00
Daniel Paoliello 4bd6953b50 Add named path bases to cargo (v2) 
Introduce shared base directories in Cargo configuration files that in turn enable base-relative path dependencies.
 2024-06-20 15:45:26 -07:00
EtomicBomb 7db0a4a8e2 remove work in progress 2024-06-20 18:50:13 +00:00
EtomicBomb 0f01c9b713 typo 2024-06-20 17:54:48 +00:00
EtomicBomb 499425169b whitespace and clear lines 2024-06-20 17:46:30 +00:00
EtomicBomb ef10ed5353 fix typos 2024-06-20 17:44:15 +00:00
EtomicBomb 08ac8a2b55 merged -> rendered in flags 2024-06-20 17:35:41 +00:00
EtomicBomb 8c78a93f0e fix typos 2024-06-20 17:29:01 +00:00
EtomicBomb fdc1b70e3b generates no files by default 2024-06-20 16:58:58 +00:00
EtomicBomb 542dcbb0d1 add `mergable_rustdoc_cross_crate_info` 2024-06-19 02:52:00 +00:00
Travis Cross 784b515547 Merge RFC 3467: UnsafePinned 
The FCP for RFC 3467 completed on 2024-06-16 with a disposition to
merge.  Let's merge it.
 2024-06-18 17:22:29 +00:00
Travis Cross b950de505a Add tracking issue for RFC 3467 2024-06-18 17:11:00 +00:00
Travis Cross 519aeb6075 Clean up trailing whitespace 2024-06-18 17:08:59 +00:00
Niko Matsakis 0e86f5591f
Update text/0000-return-type-notation.md 
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
 2024-06-18 06:07:30 -04:00
Max Niederman 486ac8a520
use valid let binding as example for parsing in assignment-like contexts 2024-06-17 14:21:41 -07:00
Ralf Jung 3efb695381 update filename and RFC number 2024-06-17 12:53:29 +02:00
Travis Cross c5a9e18638
Merge pull request #3655 from SteveLauC/FromRawFd_link 
fix links of I/O safety RFC
 2024-06-14 04:42:46 +00:00
Steve Lau a3c1e794f7 docs: add missing 'stable' part 2024-06-14 12:29:55 +08:00
Ed Page 69026e14d3 Call out impact to third party parsers 2024-06-11 10:16:41 -05:00
Ed Page f38d7dc4f6 Capture cargo team meeting notes and clean up 2024-06-11 10:14:42 -05:00
David Wood 20947d8ec0
compiler team: trusted contributor 
Signed-off-by: David Wood <david@davidtw.co>
 2024-06-11 15:10:25 +01:00
Niko Matsakis a9de4555bb add an unresolved question 2024-06-10 15:47:04 -04:00
Niko Matsakis b01d0ad3dc add another idea for how `let` ettc can look 2024-06-10 15:47:04 -04:00
Niko Matsakis c6a06d9f63 collapse into single-line paragraphs 
github markdown makes newlines significant
 2024-06-10 15:47:04 -04:00
Niko Matsakis 27643b2664
Update text/0000-return-type-notation.md 
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
 2024-06-10 14:06:57 -04:00
Steve Lau 67d5353286 fix links of I/O safety RFC 2024-06-08 14:23:26 +08:00
Mara Bos 17da70abf0
Suggest Once instead of AtomicBool. 
Co-authored-by: Kevin Reid <kpreid@switchb.org>
 2024-06-07 15:37:13 +02:00
Niko Matsakis 5485a0fe89
Apply suggestions from code review 
Thanks kennytm!

Co-authored-by: kennytm <kennytm@gmail.com>
 2024-06-05 17:44:19 -04:00
Niko Matsakis 231bcf0948 add return type notation RFC 2024-06-05 05:28:24 -04:00
riemannstein 7523e23196 change wording of 2094 2024-06-05 15:20:15 +08:00
Travis Cross b57be11a58 Merge RFC 3617: Precise capturing 
The FCP for RFC 3617 completed on 2024-05-04 with a disposition to
merge.  Let's merge it.
 2024-06-05 06:12:58 +00:00
Travis Cross 11dc4e43c1 Do some copyediting 
In a final read through the document, we found a few miscellaneous
words and commas worth tweaking here and there, so let's tweak them.
 2024-06-05 06:07:35 +00:00
Travis Cross dc258ba2a2 Be less decisive in a statement about the syntax 
Since we're leaving as open the question of whether to say `impl
use<..> Trait` or `use<..> impl Trait`, we had earlier weakened some
language that was previously decisive.  We missed one spot, though, so
let's make this sentence less decisive as well.
 2024-06-05 06:06:07 +00:00
Travis Cross 8f641ec3c0 Clarify that `use<..>` appears before any bounds 
The `use<..>` syntax is not part of any bound and must appear before
all bounds.  Let's say this a bit more clearly in one place.
 2024-06-05 06:02:31 +00:00
Travis Cross ee785c81b2 Clarify where the older lifetime capture rules apply 
We had a sentence that would be correct if we had not already
stabilized RPIT in trait impls.  Since we have, let's more precisely
describe where lifetime parameters are not implicitly captured.
 2024-06-05 05:59:43 +00:00
Travis Cross 3ede8f137d Leave the syntax as a partially unresolved question 
We had in this RFC chosen `impl use<..> Trait`.  But there's been
meaningful discussion about whether this should instead be `use<..>
impl Trait`, so let's mark this question as unresolved.
 2024-05-31 07:36:03 +00:00
Ralf Jung 474389fed2 add open question around naming 2024-05-29 22:12:26 +02:00
Ralf Jung e98f367533 add fixed code example 2024-05-29 19:18:50 +02:00
Amanieu d'Antras 95594f7688 Add more alternatives 2024-05-28 23:21:03 +01:00
Josiah Bills 3f17ff8ec8 First pass at adding associated constants to the RFC. 2024-05-27 12:45:07 -04:00
Josiah Bills 6d1c8f2ee1 Addressed some review comments. 2024-05-27 12:22:59 -04:00
Josiah Bills ff679c005c Fixed typo 2024-05-27 12:18:34 -04:00
Josiah Bills f8cb64c6eb Added note about importing parent traits. 2024-05-27 12:17:37 -04:00
Max Niederman 5e826a04f7
fix capitalization inconsistincies in code comments 2024-05-24 22:20:56 -07:00
Max Niederman 452d9d0cc8
add E language as prior art 2024-05-24 22:13:52 -07:00
Alice Ryhl 5cfbde5182 Add missing link 2024-05-24 17:48:35 +02:00
Alice Ryhl afe5534cb2 Add unresolved concern about naming 2024-05-24 17:37:41 +02:00
Alice Ryhl 17b4d18102 Propose specific solution for Pin unsoundness issue 2024-05-24 17:37:03 +02:00
Carol (Nichols || Goulding) 05ea84fce7
Add PR number 2024-05-24 08:55:27 -04:00
Carol (Nichols || Goulding) 17cee39aa2
Change crates.io policy to not offer crate transfer mediation 2024-05-24 08:51:41 -04:00
Mara Bos 1e18872a90 Add note on a global registration lang feature. 2024-05-22 16:25:36 +02:00
Mara Bos 71364c4c00 Add relevant history. 2024-05-22 15:20:43 +02:00
Mara Bos 2acdaebc69 Add thread_spawn_hook rfc. 2024-05-22 14:07:01 +02:00
Travis Cross e4bff822b9 Merge RFC 3336: MaybeDangling 
The FCP for RFC 3336 completed on 2024-05-09 with a disposition to
merge.  Let's merge it.
 2024-05-20 08:01:21 +00:00
Travis Cross d04f509aa2 Prepare RFC 3336 to be merged 
The FCP for RFC 3336 has completed.  Let's prepare it to be merged.
 2024-05-20 07:57:34 +00:00
Travis Cross ee08c28c75 Cleanup trailing whitespace 2024-05-20 07:57:26 +00:00
Travis Cross 73dde930d8 Merge RFC 3550: New range types 
The FCP for RFC 3550 completed on 2024-05-10 with a disposition to
merge.  Let's merge it.
 2024-05-20 07:46:32 +00:00
Travis Cross e72abc53ee Prepare RFC 3550 to be merged 
The FCP for RFC 3550 completed.  Let's prepare it to be merged.
 2024-05-20 07:44:43 +00:00
Travis Cross 5b0e3643e4 Cleanup trailing whitespace 2024-05-20 07:43:23 +00:00
Travis Cross c81432d048 Merge RFC 3484: Unsafe extern blocks 
The FCP for RFC 3484 completed on 2024-05-04 with a disposition to
merge.  The lang team further confirmed its happiness with the RFC in
a meeting on 2024-05-08.  Let's merge the RFC.
 2024-05-20 07:18:39 +00:00
Travis Cross 45590fe36d Do some copyediting 
We had earlier made clarifying edits to many sections, but not to all
of them.  Let's clarify some text in these remaining sections.
 2024-05-20 07:13:59 +00:00
Travis Cross 3b6ae2bbf9 Prepare RFC 3484 to be merged 
The FCP for RFC 3484 has completed with a disposition to merge.  Let's
prepare to merge it.
 2024-05-19 22:36:40 +00:00
Eric Huss 72ba5cc4e7
Merge pull request #3502 from epage/script 
RFC: cargo-script
 2024-05-17 07:46:40 -07:00
Jules Bertholet 04501bc53a
Fix fairer example 2024-05-16 23:19:44 -04:00
Jules Bertholet c2bdf38088
Fairer examples 2024-05-16 23:14:22 -04:00
Max Niederman 2080f874e2
add section on guard patterns as macro arguments 2024-05-16 20:14:11 -07:00
Max Niederman 8b63437ca4
rewrite parsing section for clarity 2024-05-16 19:57:00 -07:00
Jules Bertholet b07848501c
Fix typo 
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
 2024-05-16 20:41:27 -04:00
Jules Bertholet 3ff0267761
Fix typo 
Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
 2024-05-16 15:34:39 -04:00
Max Niederman be09503e9c
clarify precedence of `if` relative to `|` 2024-05-15 23:08:06 -07:00
Jules Bertholet 07b35d840a
Add more examples to "no `ref mut` behind `&`" rationale 2024-05-15 14:32:18 -04:00
Jules Bertholet 099b71f0ea
No more implicit `mut ref mut` 2024-05-15 14:21:56 -04:00
Ed Page 7b9d962402 fix: Clarify portability of env -S 2024-05-15 12:23:10 -05:00
Ed Page 87ffdecb5c
fix: Typo in example command 
Co-authored-by: kennytm <kennytm@gmail.com>
 2024-05-15 12:19:22 -05:00
Max Niederman a84f01b0e2
further explain behavior localization example 2024-05-15 01:18:28 -07:00
Max Niederman 64a234a7fa
fix typos 2024-05-15 01:04:06 -07:00
Max Niederman 55acb0b265
add guard-patterns pr number 2024-05-15 00:09:32 -07:00
Max Niederman cb5a69b69c
add first draft of guard-patterns 2024-05-14 23:59:14 -07:00
Mara Bos db5aeba6a3 Put diagram svg in this repository. 2024-05-14 17:24:53 +02:00
Mara Bos 36df98336e Add diagram back to RFC 3606. 2024-05-14 14:03:33 +02:00
Jules Bertholet 19e0c7cf44
Fix example 
Arrays are homogeneous…
 2024-05-13 23:43:47 -04:00
Jules Bertholet 5754a9cd32
Migration lint macro troubles 2024-05-12 13:05:41 -04:00
Alice Ryhl 1eec5b3351 Also modify `DispatchFromDyn` for `Pin` 2024-05-11 11:16:59 +02:00
Alice Ryhl 7f4e36beed Add section on non-derive macros 2024-05-11 11:16:01 +02:00
Alice Ryhl a9104e7814 Mention custom allocators in future possibilities 2024-05-11 11:05:33 +02:00
Alice Ryhl cd05ef26a9 Explain what the macro requires without reference to `DispatchFromDyn` 2024-05-11 11:01:12 +02:00
Alice Ryhl 44e8727c2c Add drawback about trait name not matching 2024-05-11 10:49:13 +02:00
Alice Ryhl 4cd0f76661 Add `#[smart_pointer::pointee]` 2024-05-11 10:45:12 +02:00
Alice Ryhl 211abb3466 Adjust how the macro expands trait bounds 
Without this adjustment, it would not be possible to use this macro with
types such as the `ARef` type that was discussed on the RFC thread [1],
since we need `AlwaysRefcounted` to be specified for both T and U.

Link: https://www.github.com/rust-lang/rfcs/pull/3621#issuecomment-2094094231 [1]
 2024-05-11 09:28:59 +02:00
Jules Bertholet ab8be9af22
Remove emphasis 2024-05-11 00:23:25 -04:00
Jules Bertholet a75166ce94
Update "desirable property" 2024-05-11 00:21:43 -04:00
Ralf Jung be7581cc66 set RFC number 2024-05-09 14:43:43 +02:00
Jules Bertholet e649309b19
Expand on deref patterns 2024-05-08 21:26:07 -04:00
Jules Bertholet 0e1306bf7e
Expand "no `ref mut` behind `&`" motivation 2024-05-07 23:14:46 -04:00
Jules Bertholet 9b44733384
Fix typo in example 2024-05-07 15:38:42 -04:00
Travis Cross 39795a03fa Fix optionality of `safe`/`unsafe` in guide section 
The 2023-10-11 consensus from lang on how to move forward included
that the `safe` and `unsafe` keywords would be optional within an
`unsafe extern` block.

The reference-level section correctly followed this consensus, but the
guide-level section did not, and suggested that annotating items with
these keywords was required.  Let's fix that.
 2024-05-07 17:12:31 +00:00
Travis Cross c19839632d Remove unused "prior art" section 2024-05-07 17:09:42 +00:00
Travis Cross 9f36a9256a Remove issue 46188 as a motivation 
This RFC had used as one motivation that undefined behavior can
currently result simply from having an incorrect `extern` block even
if the items within are not used from Rust code.

This motivation was not cited in the lang team's 2023-10-11 consensus
for how and why to proceed with this RFC, and it's possible that we
may be able to resolve this issue in other ways, so let's remove that
motivation from this RFC.

(Thanks to RalfJ for raising this point and suggesting this.)
 2024-05-07 17:06:49 +00:00
Travis Cross c1192da628 Fix typo 2024-05-07 17:03:04 +00:00
Travis Cross 2c106c3c7e Clarify about `unsafe_code` and edition migration 
When people migrate to the new edition, if they have turned up the
severity of the `unsafe_code` lint and they have `extern` blocks that
need to be marked `unsafe`, they will see this lint as intended.
Let's make a note of that.

(Thanks to kennytm for raising this point.)
 2024-05-07 16:20:34 +00:00
Travis Cross efc671cf08 Clarify about fixing LLVM despite C 
Even if the C standard allows for what LLVM is doing, we could still
conceivably fix LLVM.  In the text, let's draw this out a bit more
finely.

(Thanks to RalfJ for raising this point.)
 2024-05-07 15:38:57 +00:00
Ed Page ed8ebc954f fix(ref): Clarify we aren't locking down target dir 2024-05-07 10:04:30 +02:00
Travis Cross ca7713cba6 Add alternative of fixing LLVM (if it is a fix) 
One possibility we should mention is that of changing the behavior of
LLVM and then not adding `unsafe extern`, so let's mention that.

(Thanks to RalfJ for raising this point.)
 2024-05-07 06:50:21 +00:00
Travis Cross 09a088c113 Address feedback and questions 
As this RFC was reviewed in the GitHub thread, many alternatives were
proposed and questions raised.  As those of us who were a bit too
close to it were cursed with knowledge, the rationale for rejecting
these alternatives were not fully articulated and not all of these
questions were clearly answered.

Let's better document these alternatives, the rationale for rejecting
each, and the answers to various known questions.

(Thanks to GoldsteinE, madsmtm, kennytm, samih, and tmccombs for
raising these alternatives and questions.)
 2024-05-07 04:36:51 +00:00
Jules Bertholet e222363d4b
Add comment to new example 2024-05-06 20:44:02 -04:00
Jules Bertholet 1d1d1f4909
Expand on "no `ref mut` behind `&`" 2024-05-06 20:40:06 -04:00
Jules Bertholet 8e4b83cdab
Add link in footnote 2024-05-06 18:42:40 -04:00
Jules Bertholet 70650acac6
Fix typos in examples 2024-05-06 18:39:40 -04:00
Jules Bertholet 9e1bb8e528
Expand motivation and examples 2024-05-06 18:26:21 -04:00
Jules Bertholet 6081324b2b
Fix another typo 
Co-authored-by: kennytm <kennytm@gmail.com>
 2024-05-06 17:44:05 -04:00
Jules Bertholet f42a677d6d
Fix typo 
Co-authored-by: kennytm <kennytm@gmail.com>
 2024-05-06 17:29:58 -04:00
Jules Bertholet cbf6f22fac
Add match ergonomics 2024 RFC 2024-05-06 16:45:42 -04:00
Travis Cross b423b2bfff Lowercase "undefined behavior" 
The term "undefined behavior" is not a proper noun, so let's make this
lowercase.
 2024-05-06 20:28:27 +00:00
Travis Cross 4684d53b8a Unwrap lines 
This document had a mix of line wrapping styles.  Let's consistently
unwrap the lines.
 2024-05-06 20:19:01 +00:00
Ed Page ec8d3ad12f
feat(alt): New lockfile format 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
 2024-05-06 04:33:10 -05:00
Ed Page 761049c303
fix: Typo 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
 2024-05-06 04:32:23 -05:00
Ed Page 381419619d
fix: Be more specific in std stream redirection 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
 2024-05-06 04:32:10 -05:00
Ed Page e5f16b4bc7
fix: Be consistent on possible binary name 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
 2024-05-06 04:31:51 -05:00
Ed Page d72712e850
fix: Be more specific in std stream redirection 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
 2024-05-06 04:31:33 -05:00
Ed Page 03c24f7c29
fix: Be consistent on possible binary name 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
 2024-05-06 04:30:54 -05:00
Ed Page e38e566d9e fix(future): Typo 2024-05-06 11:21:30 +02:00
Ed Page cd310848e1 feat(future): Add overhead problems with ideas 2024-05-06 11:20:42 +02:00
Amanieu d'Antras de6a4cfdc8 Clarify that this only triggers when both traits are in scope 2024-05-06 11:09:27 +02:00
Travis Cross 5cc4cc3137 Clarify that we will "eventually" lint 
This RFC means to specify that we will *eventually* issue a lint in
all editions when `extern` is not prefixed with `unsafe`.  Let's
specify this more clearly.

(Thanks to Waffle and joshtriplett for raising this point.)
 2024-05-06 07:08:02 +00:00
Travis Cross fc53654996 Add reference to Rust issue 46188 
There's a long history of discussion on how incorrect declarations in
`extern` blocks might cause UB in programs compiled using LLVM.  Let's
link to one of the issues in that history.

(Thanks to madsmtm for raising this question, and to RalfJ for
providing this citation.)
 2024-05-06 06:59:31 +00:00
Travis Cross 60631ce721 Clarify what we're replacing in the Reference 
This RFC suggests replacements to text within the Rust Reference.
Let's clarify where those sections are.

(Thanks to Waffle for raising this point.)
 2024-05-06 06:47:00 +00:00
Travis Cross 176d73f744 Clarify extent of UB 
An incorrect declaration in an `extern` block may cause undefined
behavior in the resulting program.  Let's clarify that in the text.

(Thanks to Waffle for raising this point.)
 2024-05-06 06:35:48 +00:00
Travis Cross 842bd55b04 Fix typo 
(Thanks to spastorino for noticing this.)
 2024-05-06 06:13:36 +00:00
Travis Cross 1cef0263cc Improve wording of where `safe` is allowed 
Let's improve the wording related to where the `safe` keyword is
allowed.

(Thanks to Waffle for raising this point.)
 2024-05-06 06:01:45 +00:00
Travis Cross 23f0acfe26 Improve wording of the drawback 
During the FCP, people noticed that the wording of the drawback
probably fit better with an earlier draft of this RFC.  Let's
incorporate that feedback before merging.

(Thanks to Waffle for raising this point.)
 2024-05-06 05:57:39 +00:00
Travis Cross 6dba902b3c Cleanup whitespace 2024-05-06 05:54:36 +00:00
Travis Cross 55a275cb04 Merge RFC 3325: Unsafe attributes 
The FCP for RFC 3325 completed on 2024-04-04 with a disposition to
merge.  Let's merge it.
 2024-05-06 05:38:17 +00:00
Travis Cross 5d148ba815 Prepare RFC 3325 to be merged 
The FCP has completed for RFC 3325.  Let's prepare it to be merged.
 2024-05-06 05:35:20 +00:00
Travis Cross a57b4bcfd8 Merge RFC 3593: Reserve unprefixed guarded strings 
The FCP for RFC 3593 completed on 2024-04-13 with a disposition to
merge.  Let's merge it.
 2024-05-06 05:27:50 +00:00
Travis Cross 09566259f9 Prepare RFC 3593 to be merged 
The FCP for RFC 3593 has completed, so let's prepare it to be merged.
In this case, that means changing the file name to use dashes rather
than underscores as separators and updating the tracking issue.
 2024-05-06 05:26:29 +00:00
Travis Cross 95e7a42181 Merge RFC 3606: Shorter temp lifetimes in tail exprs 
The FCP for RFC 3606 completed on 2024-04-14 with a disposition to
merge.  Let's merge it.
 2024-05-06 05:07:10 +00:00
Travis Cross 929c584a28 Prepare RFC 3606 to be merged 
The FCP has completed on RFC 3606, so let's prepare it to be merged.

First, we'll shorten the name of the feature flag a bit; this should
still be unambiguous.

Second, we're going to remove the graphic from the summary.  While it
may be illustrative, the text and the other examples seem clear enough
without it, and its benefits have to be weighed against the fact that
we want the content in this repository to be easily editable and
freestanding.  Pulling in an SVG file from an outside host pulls
against that.  If we come to think the graphic is critical, we could
always add it back in a separate PR that would add an editable version
of this SVG file into the repository itself.

Third, let's make the H1 title of the document a bit more clear.
 2024-05-06 05:05:48 +00:00
Travis Cross 0d835b13ee Merge RFC 3519: Arbitrary self types v2 
The FCP for RFC 3519 completed on 2024-04-19 with a disposition to
merge.  Let's merge it.
 2024-05-06 00:58:08 +00:00
Travis Cross ab248bbd88 Prepare RFC 3519 to be merged 
The FCP for RFC 3519 ("Arbitrary self types v2") is complete.  Let's
reuse the existing `arbitrary_self_types` feature flag for this work,
and similarly, let's reuse the existing tracking issue.
 2024-05-06 00:49:08 +00:00
Travis Cross de7a342f51 Add clarifications on refinement, reparameterization 
During the FCP, some questions came up related to how refinement and
reparameterization in the impl are handled.  This handling is implied
by other text in the RFC and by the existing behavior of Rust, so
let's go ahead and add clarifications to address these questions.

The hardest of these questions relate to how things would behave if we
were to allow `use<..>` in trait definitions to not capture the
generic input parameters to the trait (including `Self`).  It's
unlikely this will be possible for the foreseeable future, and while
we will not leave these as open questions, certainly much might be
learned between now and the point at which that might become possible,
so we'll make note of that.

We'll also add a clarification to address a question that came up in
the 2024-04-24 design meeting about what it means to capture a const
generic parameter.

(Thanks to aliemjay for raising many of these great questions.)
 2024-05-05 07:58:16 +00:00
Amanieu d'Antras b32c37ef87 Supertrait item shadowing v2 2024-05-04 00:38:34 +01:00
Alice Ryhl 8f029b2fcc Fix typos 2024-05-03 16:07:42 +02:00
Ralf Jung bfb8c4bf05 expand back-compat note 2024-05-03 14:08:43 +02:00
Ralf Jung 76a4035eff make UnsafePinned derive Copy, Send, Sync 2024-05-03 14:08:31 +02:00
Alice Ryhl f77582569b Transparent containers implement both traits 2024-05-03 10:44:23 +02:00
Ralf Jung 1f31c7b6f9
fix code example 
Co-authored-by: Travis Cross <tc@traviscross.com>
 2024-05-03 08:28:09 +02:00
Ralf Jung ff2cab8744 insert RFC number 2024-05-02 13:33:25 +02:00
Alice Ryhl 8a62c64af6 Apply suggestions by lqd 2024-05-02 11:39:34 +02:00
Alice Ryhl 061c786c77 RFC: #[derive(SmartPointer)] 
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2024-05-02 09:49:17 +02:00
Ralf Jung d6bfbe76ab UnsafeAliased -> UnsafePinned 2024-04-30 16:41:19 +02:00
Peter Jaszkowiak ef301caa7f add unresolved questions for Ecosystem Disruption 2024-04-29 23:27:55 -06:00
Peter Jaszkowiak e25ddad2f6 minor changes of wording, layout, and clarification 2024-04-29 23:22:16 -06:00
Peter Jaszkowiak 88a97dcd9a remove `to_legacy` 2024-04-29 22:40:53 -06:00
Peter Jaszkowiak 020700820a `std::range` instead of `std::ops::range` 2024-04-29 22:39:37 -06:00
Travis Cross f06ae6ad48 Simplify RPITIT desugaring 
We had added an RPITIT desugaring that was rather complicated.  This
complication was due to trying to explain what it would mean to not
capture generic parameters that are part of the trait header.

However, it's likely that there's no good way to express that semantic
in the surface syntax.  Let's instead simplify the desugaring and make
a note of its limitations.
 2024-04-29 23:54:14 +00:00
Eric Huss 0f62578621
Merge pull request #3614 from nikomatsakis/project-goals 
experimental project goal program for 2024 H2
 2024-04-29 09:12:44 -07:00
Eric Huss 390458c87e Add RFC PR link. 2024-04-29 09:10:21 -07:00
Eric Huss 044267c119 Rename 3614 project goals. 2024-04-29 09:09:40 -07:00
Travis Cross 972be3401a Extend and improve reference desugarings 
We had included a reference desugaring of `use<..>` in RPIT using
ATPIT.  Let's add a similar desugaring for `use<..>` in RPITIT.

In doing this, we'll make some changes to the RPIT desugaring so that
it better parallels the RPITIT one.  In particular, we want to
turbofish all generic parameters for clarity, and we want to eliminate
all function arguments for conciseness.  Doing this means that all of
the lifetimes become early bound.  This seems fine, since it's rather
orthogonal to the semantics we're trying to demonstrate here.

We also want to demonstrate using const generics in the hidden type.
We could do this using arrays, e.g. `[(); N]`, but it seems more clear
to just define a type constructor that uses all of the generics, so
we'll sacrifice a bit of conciseness to do it that way.
 2024-04-28 10:30:12 +00:00
Travis Cross b02f1aabcc Improve example on avoiding HR lifetime capture 
We have an example showing how to avoid capturing a higher ranked
lifetime in a nested opaque type so that the code can be migrated to
Rust 2024.  However, because we didn't parameterize the trait in the
example with a lifetime, the code could be migrated by just removing
the `for<..>` binder.  This makes the example weaker than it could be,
so let's strengthen it by parameterizing the trait.

(Thanks to aliemjay for raising this point.)
 2024-04-28 03:54:30 +00:00
Travis Cross f01222877d Extend discussion on `use<..> impl Trait` syntax 
We had earlier written up a section on `use<..> impl Trait` syntax
that mostly focused on why we had not adopted it.  We didn't spend
much text on why it's appealing, probably because we are in fact
sympathetic to it and consider the reasons that it's appealing
obvious.

Still, we should write all those reasons down.  Let's extend the
section on this syntax with the best possible argument in favor.

We also see more clearly now the fundamental intuitive tension behind
this syntax and `impl use<..> Trait`, so let's write that down too.

Finally, let's describe the historical and other factors that led to
picking one syntax over the other.

(Thanks to tmandry for suggesting the `use<..> impl Trait` syntax and
many of the arguments in favor of it.)
 2024-04-27 09:22:55 +00:00
Travis Cross 9fbce80d84 Add guide-level section on the trailing comma 
As with other lists of generic arguments in Rust, the grammar for
`use<..>` specifiers supports an optional trailing comma.  This is
already specified in the formal grammar, but let's also note this in
the guide-level section.

(Thanks to Josh Triplett for raising this point.)
 2024-04-26 07:30:37 +00:00
Travis Cross 26911c8b30 Fix plurality of "parentheses" 
We had meant to say "parentheses" but had said "parenthesis" in two
places.  Let's fix that.
 2024-04-24 23:36:57 +00:00
Travis Cross 76cb0ae10c Discuss the `use<..> impl Trait` alternative 
In the T-lang design meeting on 2024-04-24, a new syntax option was
raised: `use<..> impl Trait`.

While some people liked this, others did not, and no clear consensus
formed to change the main proposal in this RFC.  Nevertheless, let's
discuss this as an alternative.
 2024-04-24 23:34:24 +00:00
Travis Cross dc8f93d315 Rework the syntax specification 
For the formal syntax, we had used the existing `GenericParams`
production.  However, that production isn't exactly appropriate for
this case.  What's needed here is essentially a generic argument list
that only accepts generic parameters as elements.

Since none of the other existing productions provide this, we'll
define our own.

(Thanks to @kennytm for pointing this out.)
 2024-04-24 22:03:53 +00:00
Niko Matsakis ad89d62047 add some more dates 2024-04-24 10:47:12 -04:00
Niko Matsakis e776f4e0c7 clarify the shiny future 2024-04-24 10:45:41 -04:00
Niko Matsakis 8afa6b3f93 more official prcoess comes in 2025 2024-04-24 10:45:41 -04:00
Niko Matsakis e85dc93108
Update text/0000-project-goals.md 
Co-authored-by: Jeff Parsons <jeff@parsons.io>
 2024-04-24 10:41:03 -04:00
Travis Cross 585458cc82 Remove stray `use<T>` 
We had included one `use<T>` in a pre-migration example when it should
have only appeared in a post-migration example.  Let's fix this error.

(Thanks to @kennytm for pointing this out.)
 2024-04-24 14:24:17 +00:00
Travis Cross 312f5a1407 Add observation about `use` bringing things into scope 
One way to think about `use<..>` is that, in Rust `use` brings things
into scope, and here we are bringing certain generic parameters into
scope for the hidden type.  Let's point this out.
 2024-04-24 14:21:28 +00:00
Travis Cross 5ac2eb1b40 Add RFC 3617 for precise capturing 
To fully stabilize, in Rust 2024, the Lifetime Capture Rules 2024 that
we accepted in RFC 3498, we need to stabilize some means of precise
capturing.  This RFC provides that means.

We discussed this feature, the need for it, and the syntax for it in
the T-lang planning meeting on 2024-04-03.  The document here follows
from that discussion.
 2024-04-24 08:10:00 +00:00
Eric Huss fab408e9bc
Merge pull request #3595 from carols10cents/move-crates-io-under-dev-tools 
Move the Crates.io Team under the Dev Tools team
 2024-04-23 19:25:48 -07:00
Eric Huss 55f95129ce
Merge pull request #2872 from nellshamrell/add-github-access-policy-rfc 
rust-lang org GitHub access policy
 2024-04-23 19:21:27 -07:00
Ed Page 93e8b1faca fix(drawback): Call out losing build cache 2024-04-23 11:52:25 -05:00
Ed Page db1bbda935 refactor: Group target directory drawbacks 2024-04-23 11:51:13 -05:00
Ed Page 457801fc27 fix: Remove a drawback as its future possibility 2024-04-23 11:50:33 -05:00
Ed Page 8d6aae12b7 fix: Expand on precedence 2024-04-23 11:38:31 -05:00
Ed Page 15bb6a824c fix: Update for new syntax 2024-04-23 11:23:04 -05:00
Ed Page f9cb938d39 fix(future): Cover release profile support 2024-04-23 11:17:56 -05:00
Josh Triplett 130caeb2bc
Merge pull request #3503 from epage/frontmatter 
RFC: Syntax for embedding cargo-script manifests
 2024-04-23 17:07:54 +01:00
Ed Page d0abe6be1e fix: Adjust the config file search path for security reasons 2024-04-23 11:04:12 -05:00
Niko Matsakis a0cc1e43e5 clarify eholk's questions 2024-04-19 11:49:47 -04:00
Niko Matsakis 5676d2e216 update timeline to not promise an RFC 
Focusing on second slate of goals is way more
important.
 2024-04-19 11:49:47 -04:00
toofooboo cdf8dd5948 text: fix typos in comments 
Signed-off-by: toofooboo <cmaker@foxmail.com>
 2024-04-19 19:37:30 +08:00