From 7201651f826e1b5374090bc30078c2b18ab77304 Mon Sep 17 00:00:00 2001 From: Mazdak Farrokhzad Date: Sat, 11 Aug 2018 17:05:18 +0200 Subject: [PATCH] rfc, cfg-path-version: crater stuff not a drawback. --- text/0000-cfg-path-version.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/text/0000-cfg-path-version.md b/text/0000-cfg-path-version.md index 9e4b0cb69..5174329ce 100644 --- a/text/0000-cfg-path-version.md +++ b/text/0000-cfg-path-version.md @@ -299,11 +299,9 @@ and `path_exists = ..` are added to those as well. # Drawbacks [drawbacks]: #drawbacks -## It becomes harder to `crater` - -As we get more version based conditional compilation, it can get harder to -use the `crater` tool because regressions are not tested on an old compiler -that may not have certain paths defined. +One argument is that hypothetically, if the standard library removed +some unstable item, then we might "not notice" if everyone uses it through +`cfg(path_exists = ..)`. ## Incremental garbage code and its collection