Commit Graph

5 Commits

Author SHA1 Message Date
Gulshan Singh 6af4753d8e
Add support for formatting the code directly from lint.sh (#1140) 2022-09-09 22:45:18 +02:00
Gulshan Singh 544ea0eab7
Linting/formatting improvements (#1138)
* Fix flake8 F403 warnings

* Fix more flake8 errors and warnings

* Run isort on the root directory
2022-09-09 04:46:46 +02:00
Disconnect3d b7ddf3a070
fix #1111 errno command edge case (#1126)
* fix #1111 errno command edge case

This commit fixes the case when errno command causes a binary to
segfault when the `__errno_location` symbol was defined but its .plt.got
entry was not filled yet by the dynamic loader (ld.so), so e.g. when the
glibc library was not loaded yet.

In such a case, us triggering a call to `__errno_location` function
triggered a jump to an unmapped address. Now, we dereference that
.plt.got symbol and see if it lives in mapped memory.

* add tip about errno command

* errno: fix case when __errno_location@got.plt is missing

* fix lint

* fix sh lint

* fix errno test
2022-09-05 14:56:37 +02:00
Gulshan Singh cc50024417
Format shell scripts with shfmt (#1123)
* Add lint.sh script

* Format shell scripts with shfmt and add to lint.sh

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
2022-09-05 13:24:52 +02:00
Gulshan Singh bbf1397a2b
Add lint.sh script (#1122) 2022-09-05 13:18:40 +02:00