From 26a18f1d70cd3685010f771030a3602a7368601d Mon Sep 17 00:00:00 2001 From: Victor Chan Date: Sun, 3 Jan 2021 18:51:50 +1100 Subject: [PATCH] Remove quotes from command option interpolation (#876) There was a quoting bug as `INSTALLFLAGS` contains both the option key and value. This causes the subsequent commands to look something like `python ... '--target foo'...`, causing the command to treat the entire string `--target foo` as an option key rather than a key-value pair. --- setup.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/setup.sh b/setup.sh index 775774d2..687a0ee6 100755 --- a/setup.sh +++ b/setup.sh @@ -144,14 +144,14 @@ fi # Make sure that pip is available if ! ${PYTHON} -m pip -V; then - ${PYTHON} -m ensurepip "${INSTALLFLAGS}" --upgrade + ${PYTHON} -m ensurepip ${INSTALLFLAGS} --upgrade fi # Upgrade pip itself -${PYTHON} -m pip install "${INSTALLFLAGS}" --upgrade pip +${PYTHON} -m pip install ${INSTALLFLAGS} --upgrade pip # Install Python dependencies -${PYTHON} -m pip install "${INSTALLFLAGS}" -Ur requirements.txt +${PYTHON} -m pip install ${INSTALLFLAGS} -Ur requirements.txt # Load Pwndbg into GDB on every launch. if ! grep pwndbg ~/.gdbinit &>/dev/null; then