mirror of https://github.com/GNOME/gimp.git
784f166815
Some coding style fixes, also one warning fix, and a lot of shuffling around to reorganize the code. Basically removing the prototype listing at the file start is a big error. This file is huge and without a minimum of organization, it's a huge mess to understand what's what. Basically a class file must always start by the class_init(), then the init(), then the various object methods (constructed() or finalize() if any, etc.), and possibly other parent classes' implementations. These are the entry points, it's normal to start here (not from leaf functions!). Then we get the public functions which are other entry points (calls from other parts of the code). And only after, private functions such as signal or action callbacks, and utilities at the very end. This requires a well organized prototype listing, which works as a menu, and prevents the implementation order to depend on call order (this gets us completely random order and imply usually that top functions are the less important ones, such as utilities, just how it was before this commit). Anyway I'm not sure why I spent time on this because we deprecated this plug-in, but if we still want to push nice updates (like MR !519), we should at least do it well and clean. Also it's a good first example for plug-in rewrite in modern no-GtkAction code. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile.am | ||
| dialog.c | ||
| dialog.h | ||
| help-browser.c | ||
| meson.build | ||
| uri.c | ||
| uri.h | ||