gimp/app/tools
Michael Natterer 09454fb2a4 some general cleanup.
2005-09-03  Michael Natterer  <mitch@gimp.org>

	* app/base/pixel-region.[ch]: some general cleanup.

	(pixel_region_init_temp_buf)
	(pixel_region_init_data): new functions which initialize pixel
	regions on TempBufs and on raw contiguous arrays of pixel data.

	(pixel_region_configure): fixed a bug that has probably been there
	forever: when processing contiguous (non-tiled) data, interpret
	the original x and y coordinates of the region as offsets into
	the data. Before this fix, the initial x and y were simply ignored
	(by using them in a broken way), thus always forcing the upper
	left corner of the region being the beginning of the passed data.

	Lots of code was working around this problem by setting the
	pixel_region's data pointer to the proper starting pixel of the
	region in the middle the buffer.

	* libgimp/gimppixelrgn.c: some general cleanup.

	(gimp_pixel_rgn_configure): same fix as above. Fortunately, nobody
	seems to know that libgimp pixel regions can be used on arrays of
	data, just as core ones. Only two plug-ins were using this
	feature, and they are antique and written by spencer and federico,
	respectively. They both don't use offsets into the buffers and are
	not affected by this change. It's highly unlikely that anybody out
	there knows/uses this feature, so it can IMHO be safely changed.

	* app/base/temp-buf.c
	* app/core/gimpbuffer.c
	* app/core/gimpdrawable-combine.c
	* app/core/gimpdrawable-preview.c
	* app/core/gimpimage-preview.c
	* app/core/gimplayer.c
	* app/paint/gimpbrushcore.c
	* app/paint/gimpclone.c
	* app/paint/gimpconvolve.c
	* app/paint/gimpdodgeburn.c
	* app/paint/gimppaintcore.c
	* app/paint/gimpsmudge.c
	* app/tools/gimpiscissorstool.c
	* app/tools/gimppainttool.c: use the pixel_region_init_foo()
	functions instead of initializing regions of TempBufs and raw data
	manually. Removed lots of workarounds for the broken offset
	handling. The changed places of code are much more readable now.
2005-09-03 17:16:58 +00:00
..
.cvsignore configure.in app/Makefile.am moved all tool sources to app/tools 2001-01-22 01:46:28 +00:00
Makefile.am app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimp-tools.c added gimp_scan_convert_render_value(), a variant of 2005-07-29 01:48:56 +00:00
gimp-tools.h Let the user decide whether tool options are persistant or not as 2005-04-11 21:17:59 +00:00
gimpairbrushtool.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpairbrushtool.h took the fade options out of GimpGradientOptions and added them to the new 2003-07-15 15:38:24 +00:00
gimpalignoptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-06-03 17:05:01 +00:00
gimpalignoptions.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-06-03 17:05:01 +00:00
gimpaligntool.c applied capitalization patches contributed by Stephan Binner. Fixes bug 2005-08-23 00:18:08 +00:00
gimpaligntool.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-06-07 20:12:23 +00:00
gimpblendoptions.c app/actions/channels-commands.c app/actions/qmask-commands.c 2005-08-22 23:39:12 +00:00
gimpblendoptions.h added "gboolean reverse" to gimp_gradient_get_color_at() so all gradients 2003-07-22 14:24:11 +00:00
gimpblendtool.c app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimpblendtool.h app/tools/Makefile.am added gimp_tool_motion_constrain(), 2004-08-22 21:48:50 +00:00
gimpbrightnesscontrasttool.c Make color correction tools more responsive. 2005-09-03 15:45:04 +00:00
gimpbrightnesscontrasttool.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-05-31 19:33:14 +00:00
gimpbrushtool.c some general cleanup. 2005-09-03 17:16:58 +00:00
gimpbrushtool.h app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimpbucketfilloptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpbucketfilloptions.h Re-enabled filling the whole selection using the bucket fill tool. Fixes 2004-01-27 15:26:11 +00:00
gimpbucketfilltool.c added GimpPickable::get_opacity_at() 2005-07-11 19:21:52 +00:00
gimpbucketfilltool.h Removed support for pluggable tools: 2003-04-15 14:20:19 +00:00
gimpbycolorselecttool.c applied capitalization patches contributed by Stephan Binner. Fixes bug 2005-08-23 00:18:08 +00:00
gimpbycolorselecttool.h bumped version number to 1.3.9 2002-08-22 12:49:01 +00:00
gimpclonetool.c The previous commit added tons of code just to completely break clone 2005-08-29 20:48:26 +00:00
gimpclonetool.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-16 19:12:08 +00:00
gimpcolorbalancetool.c app/tools/gimpcolorbalancetool.c app/tools/gimphuesaturationtool.c minor 2005-09-03 16:01:15 +00:00
gimpcolorbalancetool.h More color correction stuff cleanup: 2002-09-04 15:25:15 +00:00
gimpcolorizetool.c Make color correction tools more responsive. 2005-09-03 15:45:04 +00:00
gimpcolorizetool.h changed the range of the "lightness" parameter to [-100..+100], where -100 2003-11-18 16:06:47 +00:00
gimpcoloroptions.c increased maximum radius for color picking to 300 pixels and made the 2005-02-12 21:06:05 +00:00
gimpcoloroptions.h Let all GimpImageMap tools remember the state of the preview toggle (bug 2004-02-22 14:28:53 +00:00
gimpcolorpickeroptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpcolorpickeroptions.h Fixed a 1.2 -> 2.0 regression that was forgotten: 2004-06-30 12:10:08 +00:00
gimpcolorpickertool.c added new public function gimp_dockable_blink_cancel() which stops title 2005-07-13 17:03:44 +00:00
gimpcolorpickertool.h new enum GimpColorFrameMode. 2003-10-15 15:16:50 +00:00
gimpcolortool.c app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimpcolortool.h More sample point stuff. Addresses bug #137776. 2005-03-09 00:23:19 +00:00
gimpconvolvetool.c transparently handle cursor vs. toggle cursor in the cursor accessor 2005-07-30 20:46:05 +00:00
gimpconvolvetool.h app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] 2002-05-03 11:31:08 +00:00
gimpcropoptions.c app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimpcropoptions.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimpcroptool.c applied capitalization patches contributed by Stephan Binner. Fixes bug 2005-08-23 00:18:08 +00:00
gimpcroptool.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimpcurvestool.c applied capitalization patches contributed by Stephan Binner. Fixes bug 2005-08-23 00:18:08 +00:00
gimpcurvestool.h app/tools/gimpcurvestool.[ch] removed obsoleted variables. 2004-02-25 12:31:18 +00:00
gimpdodgeburntool.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpdodgeburntool.h app/actions/qmask-actions.c prepared qmask_actions_update() and the qmask 2004-04-21 10:55:45 +00:00
gimpdrawtool.c Fix the parameter check at the beginning of gimp_draw_tool_draw_boundary, 2005-08-20 04:01:13 +00:00
gimpdrawtool.h added some const qualifiers. 2005-07-31 16:05:06 +00:00
gimpeditselectiontool.c renamed puclic functions, defines and enums to live in a proper "boundary" 2005-08-20 15:46:37 +00:00
gimpeditselectiontool.h added new parameter "gboolean propagate_release" to 2004-10-06 21:04:13 +00:00
gimpellipseselecttool.c app/tools/gimpellipseselecttool.c applied a patch by Nils Bjorklund that 2005-03-07 21:31:22 +00:00
gimpellipseselecttool.h app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] 2002-05-03 11:31:08 +00:00
gimperasertool.c transparently handle cursor vs. toggle cursor in the cursor accessor 2005-07-30 20:46:05 +00:00
gimperasertool.h app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] 2002-05-03 11:31:08 +00:00
gimpflipoptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpflipoptions.h Getting rid of some legacy filenames: 2003-06-29 20:40:45 +00:00
gimpfliptool.c added GimpPickable::get_opacity_at() 2005-07-11 19:21:52 +00:00
gimpfliptool.h app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] 2002-05-03 11:31:08 +00:00
gimpforegroundselectoptions.c app/base/siox.[ch] app/core/gimpdrawable-foreground-extract.[ch] 2005-08-09 20:43:44 +00:00
gimpforegroundselectoptions.h app/base/siox.[ch] app/core/gimpdrawable-foreground-extract.[ch] 2005-08-09 20:43:44 +00:00
gimpforegroundselecttool-undo.c added GIMP_UNDO_FOREGROUND_SELECT. 2005-08-03 01:54:27 +00:00
gimpforegroundselecttool-undo.h added GIMP_UNDO_FOREGROUND_SELECT. 2005-08-03 01:54:27 +00:00
gimpforegroundselecttool.c removed reference to SIOX algorithm from tooltip, it's an implementation 2005-08-18 21:09:16 +00:00
gimpforegroundselecttool.h reordered parameters to match the order of parameters in 2005-08-06 20:01:22 +00:00
gimpfreeselecttool.c reordered parameters to match the order of parameters in 2005-08-06 20:01:22 +00:00
gimpfreeselecttool.h reordered parameters to match the order of parameters in 2005-08-06 20:01:22 +00:00
gimpfuzzyselecttool.c renamed puclic functions, defines and enums to live in a proper "boundary" 2005-08-20 15:46:37 +00:00
gimpfuzzyselecttool.h removed gdisp->scale, gdisp->dot_for_dot, the scaling marcos and the 2002-06-26 22:16:59 +00:00
gimphistogramoptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimphistogramoptions.h call gimp_image_colormap_changed() after installing the colormap. 2004-02-12 14:09:35 +00:00
gimphuesaturationtool.c app/tools/gimpcolorbalancetool.c app/tools/gimphuesaturationtool.c minor 2005-09-03 16:01:15 +00:00
gimphuesaturationtool.h app/base/hue-saturation.[ch] applied a patch from Joao S. O. Bueno 2005-03-12 12:25:57 +00:00
gimpimagemapoptions.c continuing commit after broken pipe 2005-01-25 19:11:26 +00:00
gimpimagemapoptions.h app/tools/gimpcurvestool.[ch] app/tools/gimpimagemapoptions.[ch] 2004-02-25 10:23:43 +00:00
gimpimagemaptool.c app/dialogs/module-dialog.c app/dialogs/palette-import-dialog.c 2005-08-03 09:34:55 +00:00
gimpimagemaptool.h app/tools/gimpimagemaptool.[ch] app/tools/gimpcurvestool.c allow to 2004-10-22 19:44:03 +00:00
gimpinkoptions-gui.c themes/Default/images/Makefile.am 2005-07-29 18:04:59 +00:00
gimpinkoptions-gui.h app/paint/Makefile.am app/paint/gimpink-blob.[ch] app/paint/gimpink.[ch] 2004-05-26 15:34:45 +00:00
gimpinktool.c Fixed bug #165618: 2005-03-04 11:42:46 +00:00
gimpinktool.h app/paint/Makefile.am app/paint/gimpink-blob.[ch] app/paint/gimpink.[ch] 2004-05-26 15:34:45 +00:00
gimpiscissorstool.c some general cleanup. 2005-09-03 17:16:58 +00:00
gimpiscissorstool.h app/gui/edit-commands.c added "Fill with Pattern" menu entry as suggested 2003-07-02 18:01:19 +00:00
gimplevelstool.c app/dialogs/module-dialog.c app/dialogs/palette-import-dialog.c 2005-08-03 09:34:55 +00:00
gimplevelstool.h app/tools/gimpcurvestool.[ch] removed obsoleted variables. 2004-02-25 12:31:18 +00:00
gimpmagnifyoptions.c removed the GUI for the Threshold option; it is more confusing than 2005-05-07 09:37:03 +00:00
gimpmagnifyoptions.h app/tools/gimpmagnifyoptions.[ch] applied a patch from William Skaggs that 2004-05-10 17:02:20 +00:00
gimpmagnifytool.c transparently handle cursor vs. toggle cursor in the cursor accessor 2005-07-30 20:46:05 +00:00
gimpmagnifytool.h new utility function which takes GimpZoomType and zooms "scalesrc" and 2003-05-05 14:48:15 +00:00
gimpmeasureoptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpmeasureoptions.h Getting rid of some legacy filenames: 2003-06-29 20:40:45 +00:00
gimpmeasuretool.c app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimpmeasuretool.h added width and height to the info displayed in the statusbar and the info 2005-03-21 10:27:36 +00:00
gimpmoveoptions.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpmoveoptions.h app/config/gimpguiconfig.[ch] app/config/gimprc-blurbs.h 2004-10-30 15:02:39 +00:00
gimpmovetool.c app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimpmovetool.h app/config/gimpguiconfig.[ch] app/config/gimprc-blurbs.h 2004-10-30 15:02:39 +00:00
gimpnewrectselectoptions.c app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimpnewrectselectoptions.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimpnewrectselecttool.c app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimpnewrectselecttool.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimppaintbrushtool.c cursors/Makefile.am cursors/cursor-none.png new empty cursor images. 2004-06-04 23:08:29 +00:00
gimppaintbrushtool.h app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] 2002-05-03 11:31:08 +00:00
gimppaintoptions-gui.c swapped the opacity scale and the paint mode menu to be consistent with 2005-07-11 22:03:22 +00:00
gimppaintoptions-gui.h Getting rid of some legacy filenames: 2003-06-29 20:40:45 +00:00
gimppainttool.c some general cleanup. 2005-09-03 17:16:58 +00:00
gimppainttool.h app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimppenciltool.c app/tools/gimpairbrushtool.c (gimp_airbrush_tool_register) add 2004-09-23 21:04:39 +00:00
gimppenciltool.h took the fade options out of GimpGradientOptions and added them to the new 2003-07-15 15:38:24 +00:00
gimpperspectivetool.c changed all transform utilities to modify the passed transform matrix 2005-03-21 19:10:11 +00:00
gimpperspectivetool.h Transform tool cleanup: 2004-08-06 16:27:13 +00:00
gimpposterizetool.c Use the canonical form for signal names. 2005-05-27 16:51:39 +00:00
gimpposterizetool.h Color correction tool chopping: 2002-08-26 11:35:56 +00:00
gimprectangleoptions.c app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectangleoptions.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectangleselectoptions.c app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectangleselectoptions.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectangleselecttool.c app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectangleselecttool.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectangletool.c fix canceling the tool. 2005-08-29 17:49:16 +00:00
gimprectangletool.h app/tools/gimprectangletool.[ch] transform into an interface. 2005-08-15 14:23:28 +00:00
gimprectselecttool.c app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimprectselecttool.h app/tools/gimpellipseselecttool.c applied a patch by Nils Bjorklund that 2005-03-07 21:31:22 +00:00
gimpregionselecttool.c renamed puclic functions, defines and enums to live in a proper "boundary" 2005-08-20 15:46:37 +00:00
gimpregionselecttool.h removed gdisp->scale, gdisp->dot_for_dot, the scaling marcos and the 2002-06-26 22:16:59 +00:00
gimprotatetool.c changed all transform utilities to modify the passed transform matrix 2005-03-21 19:10:11 +00:00
gimprotatetool.h Transform tool cleanup: 2004-08-06 16:27:13 +00:00
gimpscaletool.c applied capitalization patches contributed by Stephan Binner. Fixes bug 2005-08-23 00:18:08 +00:00
gimpscaletool.h removed the recently added "gdouble aspect_ratio"... 2004-08-06 16:39:11 +00:00
gimpselectionoptions.c the "Antialias" toggle got lost, resurrect it. 2005-08-21 21:43:34 +00:00
gimpselectionoptions.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-03-02 18:18:19 +00:00
gimpselectiontool.c added GimpPickable::get_opacity_at() 2005-07-11 19:21:52 +00:00
gimpselectiontool.h renamed init_edit_selection() to gimp_edit_selection_tool_start(). Removed 2004-07-26 14:50:51 +00:00
gimpsheartool.c changed all transform utilities to modify the passed transform matrix 2005-03-21 19:10:11 +00:00
gimpsheartool.h Transform tool cleanup: 2004-08-06 16:27:13 +00:00
gimpsmudgetool.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-04 20:47:42 +00:00
gimpsmudgetool.h app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] 2002-05-03 11:31:08 +00:00
gimpsourcetool.c The previous commit added tons of code just to completely break clone 2005-08-29 20:48:26 +00:00
gimpsourcetool.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-02-16 19:12:08 +00:00
gimptextoptions.c app/tools/gimpcolorbalancetool.c app/tools/gimphuesaturationtool.c minor 2005-09-03 16:01:15 +00:00
gimptextoptions.h app/text/gimptextlayout.[ch] allow to adjust letter-spacing. 2005-03-02 12:54:54 +00:00
gimptexttool.c Use the canonical form for signal names. 2005-05-27 16:51:39 +00:00
gimptexttool.h preserve the text tool on image changes. Instead connect to the text 2004-03-22 14:32:47 +00:00
gimpthresholdtool.c Use the canonical form for signal names. 2005-05-27 16:51:39 +00:00
gimpthresholdtool.h Histogram cleanup: 2002-09-07 17:27:32 +00:00
gimptool.c transparently handle cursor vs. toggle cursor in the cursor accessor 2005-07-30 20:46:05 +00:00
gimptool.h app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs. 2005-05-07 13:24:47 +00:00
gimptoolcontrol.c transparently handle cursor vs. toggle cursor in the cursor accessor 2005-07-30 20:46:05 +00:00
gimptoolcontrol.h transparently handle cursor vs. toggle cursor in the cursor accessor 2005-07-30 20:46:05 +00:00
gimptooloptions-gui.c removed the recently added utility functions again. 2004-10-12 12:06:50 +00:00
gimptooloptions-gui.h removed the recently added utility functions again. 2004-10-12 12:06:50 +00:00
gimptransformoptions.c oops, I didn't meant to commit that yet 2005-05-07 09:38:29 +00:00
gimptransformoptions.h oops, I didn't meant to commit that yet 2005-05-07 09:38:29 +00:00
gimptransformtool-undo.c app/core/gimpundo.[ch] app/core/gimpitemundo.[ch] removed all _new() 2004-07-12 16:59:36 +00:00
gimptransformtool-undo.h app/tools/gimptransformtool.c removed old path undo stuff. 2003-05-18 10:44:09 +00:00
gimptransformtool.c added GimpPickable::get_opacity_at() 2005-07-11 19:21:52 +00:00
gimptransformtool.h applied patch from Sven Neumann which removes code that prevents layers 2004-12-06 14:37:00 +00:00
gimpvectoroptions.c applied capitalization patches contributed by Stephan Binner. Fixes bug 2005-08-23 00:18:08 +00:00
gimpvectoroptions.h Since GimpVectorTool is no GimpSelectionTool, it does not make sense to 2003-11-14 23:10:24 +00:00
gimpvectortool.c cursors/Makefile.am cursors/gimp-tool-cursors.xcf 2005-08-18 21:35:06 +00:00
gimpvectortool.h Applied Patch by Sven Neumann to use the new statusbar functionality. 2005-04-08 13:43:10 +00:00
makefile.msc updated dont include "gimpmessagedialog.c" to avoid redefinitions. Instead 2005-07-10 16:24:57 +00:00
tool_manager.c Use the canonical form for signal names. 2005-05-27 16:51:39 +00:00
tool_manager.h app/tools/gimptool.[ch] added boolean return value to 2004-06-24 10:16:08 +00:00
tools-enums.c Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-03-02 20:47:59 +00:00
tools-enums.h Bill Skaggs <weskaggs@primate.ucdavis.edu> 2005-03-02 20:47:59 +00:00
tools-types.h Let all GimpImageMap tools remember the state of the preview toggle (bug 2004-02-22 14:28:53 +00:00
tools-utils.c broken pipe on previous commit, finishing 2005-01-22 00:43:31 +00:00
tools-utils.h app/tools/Makefile.am added gimp_tool_motion_constrain(), 2004-08-22 21:48:50 +00:00