2001-02-27 Michael Natterer <mitch@gimp.org>
* app/tools/Makefile.am: build the measure tool again.
* app/tools/gimpcolorpickertool.c: correct prototypes for some
functions so we don't get warnings about incompatible assignments
in "class_init", chain up in "control".
* app/tools/gimpdrawtool.c: added an implementation of "control"
which can be called from subclasses so we don't need to call
GimpDrawTool's methods directly from there.
* app/tools/gimppaintbrushtool.[ch]: create it's tool options so it
doesn't crash. Commented out the non_gui stuff. We need a different
interface for this.
* app/tools/gimppainttool.[ch]: some cleanups: call the draw tool's
"control" function, fixed "cursor_update", fixed indentation.
* app/tools/measure.[ch]: made it work again (properly subclass
GimpDrawTool).
* app/tools/tool.c: re-added the non_gui paintbrush STUB()'s
* app/tools/tools.c: don't allocate the non_gui stuff.
GimpPaintTool is an abstract superclass, so we cannot create
an instance of it. Moreover, the current non_gui stuff assumes
that there is something like a "paint_core" and changes it's
virtual function pointers, breaking the object system totally.
2001-02-21 Michael Natterer <mitch@gimp.org>
* configure.in: forgot one s/gimptool/gimptool-1.4/
* app/appenums.h: removed "UPDATE_CURSOR" from the ToolAction enum.
* app/context_manager.c: removed the toolbox toggle button updating
code here...
* app/toolbox.c: ...and handle it in the toolbox itself.
* app/devices.c: removed some obsolete old tool suff.
* app/tools/Makefile.am
* app/tools/move.[ch]: reactivated. Disabled the edit_selection
stuff for now. We need a way to temporary push tools to some stack
of the tool manager.
* app/tools/tool.[ch]: removed lot of stuff that is obsolete or
handled by the GimpToolInfo object now.
* app/tools/tool_manager.[ch]: stripped all tool options stuff
because they will be able to follow tool changes themselves.
Renamed some functions to be consistent.
* app/tools/tools.c: register the move tool again.
* app/cursorutil.c
* app/disp_callbacks.c
* app/gimage_mask.c
* app/global_edit.c
* app/tools/color_picker.c
* app/tools/measure.[ch]
* app/tools/tool_options.c: changed accordingly.
2001-02-21 Michael Natterer <mitch@gimp.org>
Made the tool system work again and integrated it back with the
GimpContext. It's a hack between old, new and freshly hacked
stuff. There are still lots of warnings but at least we can switch
tools again.
* app/tools/Makefile.am
* app/tools/gimptoolinfo.[ch]: resurrected as real object.
The GimpToolInfo objects are derived from GimpData, which gives
us the tool icon stuff for free. Also, we need a list of _objects_
which is allocated all the time. All tools are required to have
a "register" function which registers themselves with the list
of GimpToolInfo objects which is maintained by the tool manager.
* app/tools/tool.[ch]: made a real GtkObject with properly named
functions out of it. The former "active_tool_control" is of
course not the default implementation of the tool's "control"
method but a hack _around_ it, so it went to the tool manager.
* app/tools/color_picker.[ch]
* app/tools/measure.[ch]: ditto. Added "register" functions and
"destroy" implementations so the tools go away after use.
* app/tools/tool_manager.[ch]: badly hacked at the moment to keep
both the list of class structures _and_ the tool info list.
* app/tools/tools.c: call the tools' register functions.
* app/gimpcontext.[ch]: store a pointer to a GimpToolInfo object
as "active_tool" in the context, so we're independent of tools
being allocated or not. It's treated just like a brush or pattern
now.
* app/gimpdnd.[ch]: made tool DND work like all other DND types.
* app/devices.[ch]: also here: the tool is just a normal data object
now, resulting in removal of lots of code.
* app/commands.c
* app/context_manager.c: updated the tool select and context stuff
to work again.
* app/toolbox.c: removed the old pixmap buttons and put GimpPreviews
inside the tool buttons. Still needs an own preview type to
look nice.
* app/disp_callbacks.c
* app/about_dialog.c
* app/app_procs.c
* app/appenums.h
* app/apptypes.h
* app/gimage.c
* app/gimppalette.c
* app/gimppreview.c
* app/gimprc.c
* app/info_window.c
* app/menus.c
* app/palette_select.h
* app/scale.c
* app/scroll.c: lots of changes to make it work again.
2000-12-29 Michael Natterer <mitch@gimp.org>
* app/Makefile.am
* app/channel_pvt.h
* app/drawable_pvt.h
* app/gdisplayF.h
* app/gimpdrawableP.h
* app/gimpimageP.h
* app/layer_pvt.h
* app/toolsF.h: removed these files.
* app/apptypes.h
* tools/pdbgen/enums.pl: added tons of opaque typedefs and enums.
* tools/pdbgen/pdb/brush_select.pdb
* tools/pdbgen/pdb/brushes.pdb
* tools/pdbgen/pdb/channel.pdb
* tools/pdbgen/pdb/color.pdb
* tools/pdbgen/pdb/convert.pdb
* tools/pdbgen/pdb/display.pdb
* tools/pdbgen/pdb/drawable.pdb
* tools/pdbgen/pdb/fileops.pdb
* tools/pdbgen/pdb/gradient_select.pdb
* tools/pdbgen/pdb/gradients.pdb
* tools/pdbgen/pdb/help.pdb
* tools/pdbgen/pdb/image.pdb
* tools/pdbgen/pdb/layer.pdb
* tools/pdbgen/pdb/pattern_select.pdb
* tools/pdbgen/pdb/patterns.pdb
* tools/pdbgen/pdb/selection.pdb
* tools/pdbgen/pdb/tools.pdb
* app/*: chainsaw #include cleanup:
- Never (never!!) include stuff in header files except where we
need access to structures' contents (like derived objects).
- Added prototypes and proper formating in many files.
- The #include order in *all* *.c files is as follows:
#include "config.h"
#include <system stuff>
#include <gtk/gtk.h>
#include "apptypes.h"
#include "gimp stuff"
#include "libgimp stuff"
#include "libgimp/gimpintl.h"
By following this scheme we can easily see a file's dependencies
from it's #include's and can grep for the inclusion to find out
where a file is used.
* tools/pdbgen/app.pl: changed to follow the include scheme above.
* libgimp/Makefile.am
* libgimp/gimpuitypes.h: new file, included from libgimp/gimpui.h
and from app/apptypes.h.
* libgimp/gimpcolorbutton.[ch]
* libgimp/gimpdialog.[ch]
* libgimp/gimphelpui.[ch]
* libgimp/gimpparasite.[ch]
* libgimp/gimppatheditor.[ch]
* libgimp/gimpprotocol.c
* libgimp/gimpquerybox.[ch]
* libgimp/gimpsizeentry.[ch]
* libgimp/gimptypes.h
* libgimp/gimpui.h
* libgimp/gimpunit.h
* libgimp/gimpunitmenu.[ch]
* libgimp/gimpwidgets.[ch]: changed accordingly.
* plug-ins/FractalExplorer/Dialogs.c
* plug-ins/gdyntext/message_window.c
* plug-ins/imagemap/imap_default_dialog.c
* plug-ins/imagemap/imap_file.c: these files used to include
"libgimp/gimpui.h" without including "libgimp/gimp.h". This is
no longer possible because the libgimpui headers don't inlcude
"libgimp/gimpunit.h" any more.
Michael Natterer