2003-12-21 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpitemtreeview.c: reset container_view->dnd_widget
in gimp_item_tree_view_constructor() instead of
gimp_item_tree_view_new().
2003-12-21 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpcontainerview.c: this was starting to bit-rot on
my disk: added "container" and "context" properties.
(gimp_container_view_set_size_request): fixed scrollbar_width
calculation for deprecated uses of the widget (should never happen
but the code should be correct anyway).
2003-12-21 Michael Natterer <mitch@gimp.org>
* app/core/gimpdrawable-stroke.c (gimp_drawable_stroke_boundary):
fixed cut'n'paste bug: always use offset_x, not offset_y for x
coordinates (spotted by Olivier Gondouin).
2003-12-21 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpitemtreeview.c: made "item-type" and
"signal-name" CONSTRUCT_ONLY properties. Configure the DND dests
in gimp_item_tree_view_constructor(), not in
gimp_item_tree_view_new().
2003-12-21 Sven Neumann <sven@gimp.org>
* app/vectors/gimpvectors-export.[ch]: removed the GError parameter
from gimp_vectors_export_string() and implemented this function.
2003-12-21 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpdnd.c: return a boolean indicating success from
all drop handlers.
(gimp_dnd_data_drop_handle): finish the drop correctly by calling
gtk_drag_finish() with the above success value.
2003-12-20 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpdnd.[ch]: changed unused SVG dnd API to speak in
terms of "guchar *data", "gint data_len" instead of GimpVectors.
2003-12-20 Sven Neumann <sven@gimp.org>
* app/gui/gradient-editor-commands.c
(gradient_editor_replicate_response): applied patch from Shlomi Fish
that fixes an obvious cut'n'paste bug in the code that replicates a
gradient segment (bug #129738).
2003-12-19 Simon Budig <simon@gimp.org>
* app/tools/gimpvectortool.[ch]: Removed private statusbar
gdisplay pointer. Now help texts are only shown on the gdisp
of the tool. Fixes bug #128209
2003-12-17 Michael Natterer <mitch@gimp.org>
* app/display/gimpcanvas.c (gimp_canvas_gc_new): restore the
cap_style and join_style properties for the XOR GdkGC to the
values GimpDrawTool's GC used to have. Fixes the result of
gdk_draw_segments().
* app/tools/gimpfuzzyselecttool.c (gimp_fuzzy_select_tool_motion):
CLAMP the threshold to its possible values when setting it in the
selection options.
(gimp_fuzzy_select_tool_button_release): restore the original
threshold after selecting.
2003-12-16 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpsessioninfo.c (gimp_session_info_restore): free
GimpSessionInfoAux structs using gimp_session_info_aux_free()
instead of g_free() so we don't leak its members.
2003-12-16 Michael Natterer <mitch@gimp.org>
* app/text/gimptextlayout-render.c (gimp_text_layout_render):
multiply the layout's offsets with PANGO_SCALE, not -PANGO_SCALE.
Fixes bug #129405.
2003-12-16 Michael Natterer <mitch@gimp.org>
* tools/pdbgen/pdb/image.pdb (image_add_layer_mask)
* tools/pdbgen/pdb/layer.pdb (layer_add_mask): don't unref the
mask after adding it because the layer now takes ownership using
g_object_ref()/gimp_item_sink().
* app/pdb/image_cmds.c
* app/pdb/layer_cmds.c: regenerated.
2003-12-15 Michael Natterer <mitch@gimp.org>
* app/widgets/gimphistogramview.[ch]: draw the selection in
GTK_STATE_SELECTED's colors, not inverted. Fixed selection
rendering to snap to value boundaries.
2003-12-13 Michael Natterer <mitch@gimp.org>
* tools/pdbgen/pdb/procedural_db.pdb: added a hack that allows to
dynamically allocate the strings returned by a PDB query. Construct
more useful "blurb" and "help" strings for deprecated procedures.
* tools/pdbgen/pdb/image.pdb: did the same change manually for
gimp_image_add,remove_layer_mask.
* app/pdb/procedural_db_cmds.c
* app/pdb/image_cmds.c: regenerated.
2003-12-12 Manish Singh <yosh@gimp.org>
* Makefile.am
* app/composite/Makefile.am
* themes/Default/images/Makefile.am: comestics.
* app/gui/color-notebook.c (color_notebook_new): no need to cast to G_OBJECT for g_signal_connect.
* plug-ins/common/mkgen.pl
* plug-ins/common/plugin-defs.pl: properly handle the libgimpoldpreview
stuff.
* plug-ins/common/Makefile.am: regenerated.
* plug-ins/common/decompose.c: cbrt() is in C99, so check for that
in addition to GNU libc.
2003-12-12 Hans Breuer <hans@breuer.org>
[
I've postponed my reservations against pangoft2/fontconfig/freetype2
usage, so The Gimp should now build with msvc without patching it.
]
* app/makefile.msc app/text/makefile.msc : use $(PANGOFT2_CFLAGS) etc.
* libgimpthumb/makefile.msc : (new file)
* makefile.msc : added libgimpthumb
* libgimpthumb/gimpthumbnail.c : include gimpwin32-io.h
* libgimpthumb/gimpthumb-utils.c : don't compare size pointer
with GIMP_THUMB_SIZE_FAIL but *size
* plug-ins/makefile.msc : handle libgimpoldpreview
* plug-ins/common/decompose.c : define cbrt() if not __GLIBC__
* plug-ins/common/winclipboard.c : make it compile without gimpcompat.h
* plug-ins/imagemap/imagemap_csim_lex.c : its a generated file
but still win32/msvc has no unistd.h
* plug-ins/pygimp/makefile.msc : (new file) to use the binary you
need to patch glib, see bug #98737
* plug-ins/libgimpoldpreview.c : use <libgimp/gimp.h> instead of "gimp.h"
* **/Makefile.am : added makefile.msc to EXTRA_DIST
2003-12-12 Sven Neumann <sven@gimp.org>
* app/tools/gimpcurvestool.c: use GimpHistogramOptions instead of
GimpColorOptions and connect the options to the histogram view.
2003-12-12 Michael Natterer <mitch@gimp.org>
* app/widgets/gimphistogramview.[ch]: added a hack that allows to
render the histogram in a brighter color. Fixed initial range for
views that are not selectable.
* app/tools/gimpcurvestool.[ch]: replaced the GtkDrawingArea by a
bright GimpHistogramView and render the curves tool controls on
top of the histogram. Fixes bug #71633.
2003-12-11 Sven Neumann <sven@gimp.org>
* app/widgets/gimpdockable.c (gimp_dockable_init): suppress
button_press events that reach the dockable widget but don't
originate from the title area.
2003-12-11 Michael Natterer <mitch@gimp.org>
* app/widgets/gimphistogramview.[ch]: added properties "border-width"
and "subdivisions". Fixed rendering (it off-by-one worked just
accidentially because border-width was hardcoded to 1).
* app/widgets/gimphistogrambox.c: use the histogram view's border
width for the color area below the histogram. Conect to the right
signal to update the area. Added (#ifdef DEBUG_VIEW) debugging
spinbuttons to change the histogram view's new properties on the
fly.
2003-12-11 Michael Natterer <mitch@gimp.org>
* app/widgets/gimphistogramview.[ch]: applied (modified) patch
from Ed Halley which adds "quintile marks". Fixes bug #129050.
Render the histogram on a base_gc background and use text_gc and
text_aa_gc for rendering the histogram and the helper lines.
Fixed rendering of the 1px border around the histogram. Removed
separate drawing of baseline, left and right helper lines and draw
a rectangle which marks the entire area of possible values. Fixed
size_request calculation. Added missing getters. Cleanup.
* app/tools/gimpcurvestool.c: use the same color scheme as the
histogram.
* app/tools/gimpcurvestool.c (curves_load,save_callback)
* app/tools/gimplevelstool.c (levels_load,save_callback):
gtk_window_present() the file dialog if it is already visible.
2003-12-11 Sven Neumann <sven@gimp.org>
* app/display/gimpdisplayshell-callbacks.c (gimp_display_shell_events):
switch off fullscreen mode on Escape key press events only. The shell
should not react on the key release event it gets when a dialog is
closed using the Escape key.
2003-12-09 Michael Natterer <mitch@gimp.org>
* app/core/gimpimage-scale.c (gimp_image_scale_check): renamed
variable and added comments to make the calculation clear.
2003-12-09 Michael Natterer <mitch@gimp.org>
* app/core/gimpimage-duplicate.c: Removed unused #includes. Copy
the colormap using the provided API. Use gimp_item_convert()
instead of gimp_item_duplicate() and gimp_item_set_image() to
create layers, channels and vectors for the new image. Don't leak
the new image's grid. Cleanup.
2003-12-09 Michael Natterer <mitch@gimp.org>
Fixed memory management of layers and channels which were created
using the PDB:
* app/core/gimpitem.[ch]: added "gboolean floating" flag to
GimpItem. Items are created with floating == TRUE. Added
gimp_item_sink() which resets the floating flag and unrefs the
item if it was TRUE. Added gimp_item_is_floating() accessor.
* app/core/gimpimage.c (gimp_image_add_layer,channel,vectors):
g_object_ref()/gimp_item_sink() added items to take ownership of
them.
* app/core/gimplayer.c (gimp_layer_add_mask):
g_object_ref()/gimp_item_sink() the mask.
* app/gui/layers-commands.c
* app/xcf/xcf-load.c: don't unref layer masks after adding them to
the layer.
* tools/pdbgen/pdb/drawable.pdb (drawable_delete):
gimp_item_sink() the drawable if it's floating and fail if it's
not. Fixes bug #128881.
* tools/pdbgen/pdb/layer.pdb (layer_create_mask): fixed docs.
* app/pdb/drawable_cmds.c
* app/pdb/layer_cmds.c
* libgimp/gimplayer_pdb.c: regenerated.
2003-12-09 Michael Natterer <mitch@gimp.org>
* app/core/core-enums.[ch]: removed enum value
GIMP_UNDO_GROUP_EDIT_COPY (I have no idea why we used to push an
undo group around "Copy"...).
* app/core/gimp-edit.c (gimp_edit_extract): new utility function
which does everything needed for cut and copy and does not push an
undo group for copy.
(gimp_edit_cut,copy): removed lots of duplicated code and call
gimp_edit_extract().
(gimp_edit_paste,paste_as_new): no need to call
gimp_item_set_image() on newly created layers.
2003-12-09 Michael Natterer <mitch@gimp.org>
* app/widgets/gimptoolbox-dnd.c (gimp_toolbox_drop_drawable): use
gimp_item_convert() instead of gimp_item_duplicate() to create
the layer for the new image. Cleanup.
2003-12-09 Michael Natterer <mitch@gimp.org>
* app/base/tile-manager.c (tile_manager_get_memsize): return a
more exact result.
* app/core/gimpimage-scale.[ch] (gimp_image_scale_check): estimate
the new memsize by separating parts of the image that are constant
from parts that will scale. Also take undo logic into account.
Return the estimated new memsize since it's not trivial to
calculate.
* app/gui/image-commands.c (image_scale_callback): use the memsize
returned by gimp_image_scale_check() for the warning message. Free
allocated strings.
2003-12-09 Michael Natterer <mitch@gimp.org>
* app/core/core-enums.h: changed GimpImageScaleCheckType enum
values to GIMP_IMAGE_SCALE_*.
* app/core/gimpimage-scale.c (gimp_image_scale_check): return
GIMP_IMAGE_SCALE_TOO_BIG only if we are scaling up.
* app/gui/image-commands.c: changed accordingly. Whitespace and
indentation cleanup.
2003-12-09 Michael Natterer <mitch@gimp.org>
* tools/pdbgen/pdb/image.pdb (image_list): iterate gimp->images
directly rather than building a (leaked) temp GList using
gimp_container_foreach(). Removed gimlist_cb() utility function.
* app/pdb/image_cmds.c: regenerated.
2003-12-08 Dave Neary <bolsh@gimp.org>
* app/core/core-enums.h:
* app/core/gimpimage-scale.[ch]: Added the GimpImageScaleCheckType
enum and used it in gimp_image_scale_check() which used to be
gimp_image_check_scaling().
* app/gui/image_commands.c: Used the above when checking
scaling parameters to display a message if the image is too big
or too small after scaling. Closes bug #21028.
2003-12-08 Michael Natterer <mitch@gimp.org>
Some PDB fixes/cosmetics before doing real changes again:
* tools/pdbgen/pdb/drawable.pdb
* tools/pdbgen/pdb/layer.pdb: changed order of generated functions
to make more sense.
* tools/pdbgen/pdb/misc_tools.pdb: doc cosmetics, removed unused
subroutines.
* tools/pdbgen/pdb/image.pdb: reordered generated functions as
above, fixed resolution and unit accessors to use functions
instead of setting gimage->foo directly, use &image_accessors()
for the tattoo_state functions, cleanup.
* app/pdb/drawable_cmds.c
* app/pdb/image_cmds.c
* app/pdb/layer_cmds.c
* app/pdb/misc_tools_cmds.c
* libgimp/gimpdrawable_pdb.[ch]
* libgimp/gimpimage_pdb.[ch]
* libgimp/gimplayer_pdb.[ch]
* libgimp/gimpmisctools_pdb.c: regenerated.
2003-12-08 Sven Neumann <sven@gimp.org>
* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_load_thumb): don't
scale the pixbuf, always return the pixbuf as loaded from disk.
* app/core/gimpimagefile.c (gimp_imagefile_get_description):
return NULL when being asked for a description on a thumbnail
without an image_uri.
Michael Natterer