mirror of https://github.com/GNOME/gimp.git
16 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Michael Natterer
|
18d9161eea |
Get rid of the "current_context" which was in fact just a bunch of global
2004-04-15 Michael Natterer <mitch@gimp.org> Get rid of the "current_context" which was in fact just a bunch of global variables. Instead, pass the needed context all the way from the GUI and the PDB to the core. This is a prerequisite for macro recording and generally helps separating the various subsystems from each other. Work in progress... * app/core/gimp.[ch]: removed member "current_context" and gimp_[get|set]_current_context(). * app/core/gimp-edit.[ch] * app/core/gimpdrawable-blend.[ch] * app/core/gimpdrawable-bucket-fill.[ch] * app/core/gimpdrawable-offset.[ch] * app/core/gimpdrawable-transform.[ch] * app/core/gimpimage-crop.[ch] * app/core/gimpimage-flip.[ch] * app/core/gimpimage-merge.[ch] * app/core/gimpimage-resize.[ch] * app/core/gimpimage-rotate.[ch] * app/core/gimpimage.[ch] * app/core/gimpimagefile.[ch] * app/core/gimpitem-linked.[ch] * app/core/gimpitem.[ch] * app/core/gimplayer.[ch] * app/core/gimpselection.[ch] * app/core/gimptemplate.[ch] * app/file/file-open.[ch] * app/file/file-save.[ch] * app/pdb/procedural_db.[ch] * app/text/gimptext-compat.[ch] * app/text/gimptextlayer-transform.[ch] * app/gui/brush-select.[ch] * app/gui/font-select.[ch] * app/gui/gradient-select.[ch] * app/gui/palette-select.[ch] * app/gui/pattern-select.[ch]: added tons of "GimpContext *context" parameters and use the passed context instead of gimp_get_current_context(). * app/app_procs.c * app/batch.c * app/core/gimpchannel.c * app/core/gimpdrawable.c * app/paint/gimperaser.c * app/paint/gimppaintbrush.c * app/plug-in/plug-in-message.c * app/plug-in/plug-ins.c * app/text/gimptextlayer.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpcroptool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpfliptool.c * app/tools/gimpinktool.c * app/tools/gimptransformtool.c * app/vectors/gimpvectors.c * app/gui/convert-dialog.c * app/gui/drawable-commands.c * app/gui/edit-commands.c * app/gui/file-commands.c * app/gui/file-new-dialog.c * app/gui/file-open-dialog.c * app/gui/file-save-dialog.c * app/gui/image-commands.c * app/gui/layers-commands.c * app/gui/offset-dialog.c * app/gui/select-commands.c * app/gui/vectors-commands.c * app/widgets/gimpdnd.c * app/widgets/gimpdocumentview.c * app/widgets/gimphelp.c * app/widgets/gimpthumbbox.c: pass gimp_get_user_context() or GIMP_CONTEXT(tool_options) or whatever is the right context to the changed core functions. * tools/pdbgen/app.pl: pass "GimpContext *context" to all generated PDB invokers. * tools/pdbgen/pdb/brush_select.pdb * tools/pdbgen/pdb/brushes.pdb * tools/pdbgen/pdb/drawable.pdb * tools/pdbgen/pdb/edit.pdb * tools/pdbgen/pdb/font_select.pdb * tools/pdbgen/pdb/gradient_select.pdb * tools/pdbgen/pdb/gradients.pdb * tools/pdbgen/pdb/image.pdb * tools/pdbgen/pdb/layer.pdb * tools/pdbgen/pdb/paint_tools.pdb * tools/pdbgen/pdb/palette.pdb * tools/pdbgen/pdb/palette_select.pdb * tools/pdbgen/pdb/palettes.pdb * tools/pdbgen/pdb/paths.pdb * tools/pdbgen/pdb/pattern_select.pdb * tools/pdbgen/pdb/patterns.pdb * tools/pdbgen/pdb/selection.pdb * tools/pdbgen/pdb/text_tool.pdb * tools/pdbgen/pdb/transform_tools.pdb: pass the new context parameter to the changed core functions. * app/pdb/*_cmds.c: regenerated. |
|
|
Michael Natterer
|
009e834994 |
removed the "feature" of creating dialogs without action area by passing
2002-11-18 Michael Natterer <mitch@gimp.org> * libgimpwidgets/gimpdialog.c: removed the "feature" of creating dialogs without action area by passing "_delete_event_" as button text. Also changed the delete_event() implementation: don't remember a callback and call it manually but gtk_widget_activate() the button for which "connect_delete" was passed as TRUE. * app/gui/test-commands.c: added a "Close" button to the multi view. * app/gui/brush-select.[ch] * app/gui/gradient-select.[ch] * app/gui/palette-select.[ch] * app/gui/pattern-select.[ch]: ditto. Removed the "context" parameter of the *_select_new() functions. All sorts of cleanups in all dialogs. * app/gui/convert-dialog.c * tools/pdbgen/pdb/brush_select.pdb * tools/pdbgen/pdb/gradient_select.pdb * tools/pdbgen/pdb/palette_select.pdb * tools/pdbgen/pdb/pattern_select.pdb: changed accordingly. * app/pdb/brush_select_cmds.c * app/pdb/gradient_select_cmds.c * app/pdb/palette_select_cmds.c * app/pdb/pattern_select_cmds.c: regenerated. |
|
|
Michael Natterer
|
17d655c1c3 |
app/gimprc.[ch] app/gui/preferences-dialog.c
2002-03-12 Michael Natterer <mitch@gimp.org> * app/gimprc.[ch] * app/gui/preferences-dialog.c * app/paint/gimppaintoptions.[ch] * app/tools/paint_options.[ch] * app/tools/tool_manager.[ch]: removed the "global_paint_options" gimprc option because it doesn't quite fit the new dockable dialog architecture. * app/gui/brush-select.[ch] * app/gui/gradient-select.[ch] * app/gui/palette-select.[ch] * app/gui/pattern-select.[ch]: removed the "Global Brush/Pattern/... Selection" part of them. They are now only used for temp popup selections and the PDB. *Lots* of cleanup. * app/gui/convert-dialog.c * app/gui/dialogs-constructors.[ch] * app/gui/dialogs.c * app/gui/gui.c * app/gui/menus.c * app/gui/palette-import-dialog.c * app/plug-in/plug-in.c: changed accordingly. Cleaned up the palette and other data PDB stuff: * tools/pdbgen/Makefile.am * tools/pdbgen/groups.pl: added "palette_select" and "palettes". * tools/pdbgen/pdb/palette_select.pdb: new file. Makes the palette selection PDB controllable. * tools/pdbgen/pdb/palettes.pdb: new file cut out of palette.pdb because of API symmetry with brushes, patterns, ... * tools/pdbgen/pdb/palette.pdb: removed from here. * tools/pdbgen/pdb/brush_select.pdb * tools/pdbgen/pdb/brushes.pdb * tools/pdbgen/pdb/gradient_select.pdb * tools/pdbgen/pdb/gradients.pdb * tools/pdbgen/pdb/palette.pdb * tools/pdbgen/pdb/pattern_select.pdb * tools/pdbgen/pdb/patterns.pdb: lots of cleanup. Autogenerated stuff: * app/pdb/Makefile.am * app/pdb/palette_select_cmds.c * app/pdb/palettes_cmds.c: new files. * app/pdb/brush_select_cmds.c * app/pdb/brushes_cmds.c * app/pdb/gradient_select_cmds.c * app/pdb/gradients_cmds.c * app/pdb/internal_procs.c * app/pdb/palette_cmds.c * app/pdb/pattern_select_cmds.c * app/pdb/patterns_cmds.c: regenerated. * libgimp/Makefile.am * libgimp/gimp_pdb.h * libgimp/gimppalettes_pdb.[ch] * libgimp/gimppaletteselect_pdb.[ch]: new files. * libgimp/gimpgradientselect_pdb.[ch] * libgimp/gimppalette_pdb.[ch] * libgimp/gimppatterns_pdb.c: regenerated. * devel-docs/libgimp/tmpl/gimpgradients.sgml * devel-docs/libgimp/tmpl/gimppalette.sgml: regenerated. |
|
|
Sven Neumann
|
4ba6db4e94 |
Michael Natterer <mitch@gimp.org>
2001-12-03 Sven Neumann <sven@gimp.org> Michael Natterer <mitch@gimp.org> * app/paint-funcs/paint-funcs-mmx.h: removed redefiniton of HAS_ALPHA macro. * app/core/gimp.c: reverted Daniel's change; it doesn't make the code simpler, only more error-prone. * app/gui/info-dialog.h * app/gui/resize-dialog.h * app/core/gimp.h * app/core/gimpbrushgenerated.h * app/core/gimpbrushpipe.h * app/core/gimpchannel.[ch] * app/core/gimpcontainer.h * app/core/gimpcoreconfig.h * app/core/gimpdata.h * app/core/gimpdatafactory.[ch] * app/core/gimpdrawable-blend.c * app/core/gimpdrawable.[ch] * app/core/gimpimage.h * app/core/gimpimagefile.h * app/core/gimplayer.h * app/core/gimplayermask.h * app/core/gimpmoduleinfo.h * app/core/gimppalette.h * app/core/gimpundo.h * app/widgets/gimpbrushfactoryview.h * app/widgets/gimpconstrainedhwrapbox.h * app/widgets/gimpcontainermenu.h * app/widgets/gimpcontainerview.h * app/widgets/gimpdialogfactory.h * app/widgets/gimpimagedock.h * app/widgets/gimplistitem.h * app/widgets/gimpmenuitem.h * app/widgets/gimpnavigationpreview.h * app/widgets/gimppreview.h * app/gimprc.h * app/pathP.h * app/tools/gimpbezierselecttool.h * app/tools/gimpcolorbalancetool.h * app/tools/gimpcurvestool.h * app/tools/gimpdodgeburntool.c * app/tools/gimpfreeselecttool.h * app/tools/gimphuesaturationtool.h * app/tools/gimpinktool-blob.h * app/tools/gimpinktool.h * app/tools/gimpiscissorstool.h * app/tools/gimpmagnifytool.h * app/tools/gimpmeasuretool.h * app/tools/gimppainttool.h * app/tools/gimppathtool.h * app/tools/gimprectselecttool.h * app/tools/gimpthresholdtool.h * app/tools/gimptool.h * app/tools/gimptransformtool.h * app/base/base-config.h * app/base/gimplut.[ch] * app/base/pixel-region.h * app/base/pixel-surround.[ch] * app/base/temp-buf.[ch] * app/base/tile-manager-private.h * app/base/tile-manager.[ch] * app/base/tile-private.h * app/base/tile.[ch] * app/display/gimpdisplay.h * app/display/gimpdisplayshell-selection.h * app/display/gimpdisplayshell.h * app/gui/brush-select.h * app/gui/gradient-editor.h * app/gui/gradient-select.h: reverted most of Daniel's changes. There's no reason to use unsigned integers here and in lots of places it is even wrong. Then it's way too early to convert gbooleans into bitfields. This change may make sense in a few places but can happen later when the API has settled and the code is more stable. * app/gimprc.c: reverted Daniel's change. This is a GCC-ism and this code is about to die soon anyway. |
|
|
Daniel Egger
|
1ed9180112 |
Convert ugly comments into named structure fields. Much cleaner and less
2001-12-02 Daniel Egger <degger@fhm.edu> * app/gimprc.c: Convert ugly comments into named structure fields. Much cleaner and less errorprone though may cause troubles on older compilers and then needs to be reverted. Please report! * app/base/base-types.h: Add FIXME reminder. * app/base/gimplut.c: Use CLAMP macro instead of if-cascade. * app/base/temp-buf.c: Remove duplicated calculations and simplify checks. * app/base/tile-manager.c: - (tile_manager_get_tile_num): Return success and take an additional pointer for the tilenumber. - Simplify logic in the rest of the file as a result. - Remove rotten debugging cruft. * app/core/gimpbrushgenerated.c: Fix two stylistic nits. * app/app_procs.c: Include <stdlib.h> for exit () prototype. * app/core/gimpdrawable-blend.c: Include <stdlib.h> for abs () prototype. * app/display/gimpdisplay.c: Include <string.h> for memcpy () prototype. * app/core/gimpimage-convert.c: (HIST_RGB): First parameter is not const. Fixes a gcc warning for a wrong return value. * libgimpwidgets/gimpunitmenu.c * app/core/gimpunit.c: Add suggested (by gcc 3.1 cvs) parentheses to group correct logic tests together. * app/paint-funcs/paint-funcs-generic.h: Fix my HAS_ALPHA macro to avoid gcc 3.1 cvs warning. * app/gimprc.h * pathP.h * base-config.h * app/base/boundary.h * app/base/gimplut.[ch] * app/base/pixel-region.h * app/base/pixel-surround.[ch] * app/base/temp-buf.[ch] * app/base/tile-manager-private.h * app/base/tile-manager.c * app/base/tile-private.h * app/base/tile.[ch] * app/core/gimp.h * app/core/gimpbrushgenerated.h * app/core/gimpbrushpipe.h * app/core/gimpchannel.[ch] * app/core/gimpcontainer.h * app/core/gimpcoreconfig.h * app/core/gimpdata.h * app/core/gimpdatafactory.[ch] * app/core/gimpdrawable-blend.c * app/core/gimpdrawable.[ch] * app/core/gimpimage.h * app/core/gimpimagefile.h * app/core/gimplayer.h * app/core/gimplayermask.h * app/core/gimpmoduleinfo.h * app/core/gimppalette.h * app/core/gimpundo.h * app/display/gimpdisplay.h * app/display/gimpdisplayshell-selection.h * app/display/gimpdisplayshell.h * app/gui/brush-select.h * app/gui/gradient-editor.h * app/gui/gradient-select.h * app/gui/info-dialog.h * app/gui/resize-dialog.h * app/tools/gimpbezierselecttool.h * app/tools/gimpcolorbalancetool.h * app/tools/gimpcolorpickertool.h * app/tools/gimpcurvestool.h * app/tools/gimpdodgeburntool.c * app/tools/gimpfreeselecttool.h * app/tools/gimpfuzzyselecttool.h * app/tools/gimphuesaturationtool.h * app/tools/gimpinktool-blob.h * app/tools/gimpinktool.h * app/tools/gimpiscissorstool.h * app/tools/gimpmagnifytool.h * app/tools/gimpmeasuretool.h * app/tools/gimppainttool.h * app/tools/gimppathtool.h * app/tools/gimprectselecttool.h * app/tools/gimpthresholdtool.h * app/tools/gimptool.h * app/tools/gimptransformtool.h * app/tools/path_toolP.h * app/widgets/gimpbrushfactoryview.h * app/widgets/gimpconstrainedhwrapbox.h * app/widgets/gimpcontainermenu.h * app/widgets/gimpcontainerview.h * app/widgets/gimpdialogfactory.h * app/widgets/gimpimagedock.h * app/widgets/gimplistitem.h * app/widgets/gimpmenuitem.h * app/widgets/gimpnavigationpreview.h * app/widgets/gimppreview.h: Unsignify lots of variables and parameters and use bitfields in structs where possible. First part of a huge cleanup all over the code... |
|
|
Michael Natterer
|
552e26715f |
removed gradients_get_gradient_data() here...
2001-10-26 Michael Natterer <mitch@gimp.org> * tools/pdbgen/pdb/gradient_select.pdb: removed gradients_get_gradient_data() here... * tools/pdbgen/pdb/gradients.pdb: ...and added it here. * app/pdb/gradient_select_cmds.c * app/pdb/gradients_cmds.c * app/pdb/internal_procs.c * libgimp/gimpgradients_pdb.[ch] * libgimp/gimpgradientselect_pdb.[ch]: regenerated. * app/core/gimpgradient.h: added GIMP_GRADIENT_DEFAULT_SAMPLE_SIZE here... * app/gui/gradient-select.h: ...removed it here. * libgimp/Makefile.am * libgimp/gimp.h * libgimp/gimpgradientselect.[ch]: removed. We don't wrap _gradients_get_gradient_data() with gradients_get_gradient_data() any more but call the PDB wrapper directly. API CHANGE: Arguments 2 and 3 are swapped now! * plug-ins/FractalExplorer/Dialogs.c: changed accordingly. |
|
|
Michael Natterer
|
8b5b8df82d |
generate app/file/Makefile
2001-10-25 Michael Natterer <mitch@gimp.org> * configure.in: generate app/file/Makefile * app/Makefile.am * app/file-open.[ch] * app/file-save.[ch] * app/file-utils.[ch]: removed... * app/file/Makefile.am * app/file/file-open.[ch] * app/file/file-save.[ch] * app/file/file-utils.[ch]: ...and added here. * app/gui/file-commands.c * app/gui/file-open-dialog.c * app/gui/file-save-dialog.c * tools/pdbgen/pdb/fileops.pdb: changed includes accordingly. * app/app_procs.[ch]: removed app_exit_finish() and app_exit_finish_done() from the public API, call gtk_main() here, pass "no_data" to gimp_new() and "restore_session" to gui_restore(). * app/main.c: removed global variable "double_speed", don't call gtk_main() in main.c. Added some missing log domains. * app/appenv.h: removed "double_speed". * app/core/gimp.[ch]: added "gboolean no_data" property which must be passed to gimp_new(). * app/display/gimpdisplay-foreach.[ch]: added gdisplays_set_busy() and gdisplays_unset_busy(). * app/gui/about-dialog.c: don't include "appenv.h", declare "double_speed" extern. * app/gui/brush-select.[ch] * app/gui/gradient-select.[ch] * app/gui/palette-select.[ch] * app/gui/pattern-select.[ch]: made the list of dialogs and the global selection dialogs private. Added functions which get a dialog by PDB callback_name. Pass a "Gimp" and the callback_name to the constructors. Don't include "app_procs.h" for "the_gimp" and "appenv.h" for "no_data" any more. Use the passed "Gimp" instead and look at gimp->no_data. * app/gui/toolbox.[ch]: pass a "Gimp" to the constructor. * app/gui/gui.[ch]: use the new gdisplays_[un]set_busy() functions, use the passed "Gimp" all over the place, don't include "appenv.h" and "app_procs.h". gui_really_quit_dialog() takes a "quit_func" callback now and calls it instead of calling app_exit_finish() (which is now private) directly. * app/gui/convert-dialog.c * app/gui/dialogs-constructors.c * app/gui/palette-import-dialog.c * tools/pdbgen/pdb/brush_select.pdb * tools/pdbgen/pdb/gradient_select.pdb * tools/pdbgen/pdb/pattern_select.pdb: changed accordingly. * app/pdb/brush_select_cmds.c * app/pdb/fileops_cmds.c * app/pdb/gradient_select_cmds.c * app/pdb/pattern_select_cmds.c: regenerated. 2001-10-25 Michael Natterer <mitch@gimp.org> * POTFILES.in: app/file-*.c -> app/file/file-*.c |
|
|
Michael Natterer
|
f283b957b1 |
app/session.[ch] removed the old dialog session management code...
2001-04-17 Michael Natterer <mitch@gimp.org> * app/session.[ch] * app/gimprc.c: removed the old dialog session management code... * app/widgets/gimpdialogfactory.[ch]: ...and manage all dialogs here. * app/gui/dialogs-constructors.[ch]: dialog factory compliant constructors for all session managed toplevel dialogs. * app/brush_select.[ch] * app/devices.[ch] * app/docindex.[ch] * app/errorconsole.[ch] * app/gradient_select.[ch] * app/info_dialog.c * app/lc_dialog.[ch] * app/palette.[ch] * app/pattern_select.[ch] * app/toolbox.[ch] * app/tools/tool_options_dialog.[ch]: all dialog constructors have to return the dialog now (even the legacy ones that will go away). Removed the session management code as this is now done for the dialogs, not by them. * app/app_procs.c * app/color_select.c * app/commands.[ch] * app/indicator_area.c * app/menus.c * app/palette_select.c * app/preferences_dialog.c * app/gui/dialogs.c * app/gui/dialogs-commands.[ch] * app/gui/gui.c * app/tools/gimptool.c * app/widgets/gimpdock.c: changed accordingly. |
|
|
Michael Natterer
|
a80dd4d071 |
added DND source functions which work by GtkType.
2001-02-18 Michael Natterer <mitch@gimp.org> * app/gimpdnd.[ch]: added DND source functions which work by GtkType. * app/commands.c * app/brush_select.c * app/gradient_select.[ch] * app/pattern_select.c: removed the DND code here because it's all done by the GimpContainerView now. * app/gimpbrushpreview.c * app/gimpgradientpreview.c * app/gimppalettepreview.c * app/gimppatternpreview.c: use the DND by-type connect functions. * app/gimpbrushgenerated.c: implemented "duplicate", cleanup. * app/gimpcontainergridview.c * app/gimpcontainerlistview.c * app/gimpcontainerview.[ch]: added a "activate_item" signal method which is emitted by the subclasses to indicate double click. * app/gimpdatafactoryview.c: connect to "activate_item" and show the editor. * app/convert.c * app/gimppalette.[ch] * app/palette.c * app/paletteP.h * app/palette_import.c * app/palette_select.[ch]: major cleanup: Behaves like the other datatypes now: DND, context stuff, GimpContainerListViews in the dialogs etc. Mostly just removal of code. * app/gradient_editor.c: fixed signal blocking/unblocking. * plug-ins/script-fu/scripts/Makefile.am: install the "Test Sphere" script again. |
|
|
Michael Natterer
|
656d1fae86 |
app/gradient_editor.[ch] use GimpContainerListView instead of cooking an
2001-02-13 Michael Natterer <mitch@gimp.org> * app/gradient_editor.[ch] * app/gradient_select.[ch]: use GimpContainerListView instead of cooking an own list. * app/gimpgradient.[ch]: removed the GdkPixmap from the gradient. * app/gimpcontainerlistview.c: connect the viewable's "name_changed" signal to the label. * app/gimpmarshal.[ch] * app/gimppreview.[ch]: new virtual function "get_size", * app/gimpgradientpreview.c: implement "get_size" and return a 3:1 aspect ratio. * app/gradients.c * app/palette_select.[ch] * app/palettes.c: removed the dialog freeze/thaw functions. * app/brush_select.c * app/pattern_select.c * app/plug_in.c: stuff. |
|
|
Michael Natterer
|
07300cf385 |
app/Makefile.am app/gradientP.h removed.
2001-02-10 Michael Natterer <mitch@gimp.org> * app/Makefile.am * app/gradientP.h * app/gradient_header.h: removed. * app/gimpgradient.[ch]: new object -- bye bye "gradient_t" * app/gradients.[ch]: new files for managing the gradient list. * app/gradient.[ch]: containes only the gradient editor now (which still badly poked aroung in the GimpGradient structure). * app/app_procs.c * app/apptypes.h * app/devices.c * app/gimpcontainerlistview.c * app/gimpcontext.[ch] * app/gimpcontextpreview.[ch] * app/gimpdnd.[ch] * app/gradient_select.[ch] * app/indicator_area.c * app/palette_import.c * app/pdb/gradient_select_cmds.c * app/pdb/gradients_cmds.c * app/tools/airbrush.c * app/tools/blend.c * app/tools/paint_core.c * app/tools/paintbrush.c * app/tools/pencil.c * tools/pdbgen/pdb/gradient_select.pdb * tools/pdbgen/pdb/gradients.pdb: changed accordingly, some changes to the preview and view stuff. * app/gimppreview.[ch]: removed the "context" attribute again because it was overkill (a simple gtk_signal-connect_object does the same as doing the autoconnection magic inside the GimpPreview object). * app/commands.[ch] * app/menus.c: example views on the gradient container. |
|
|
Michael Natterer
|
8d6c335f8f |
app/Makefile.am app/channel_pvt.h app/drawable_pvt.h app/gdisplayF.h
2000-12-29 Michael Natterer <mitch@gimp.org> * app/Makefile.am * app/channel_pvt.h * app/drawable_pvt.h * app/gdisplayF.h * app/gimpdrawableP.h * app/gimpimageP.h * app/layer_pvt.h * app/toolsF.h: removed these files. * app/apptypes.h * tools/pdbgen/enums.pl: added tons of opaque typedefs and enums. * tools/pdbgen/pdb/brush_select.pdb * tools/pdbgen/pdb/brushes.pdb * tools/pdbgen/pdb/channel.pdb * tools/pdbgen/pdb/color.pdb * tools/pdbgen/pdb/convert.pdb * tools/pdbgen/pdb/display.pdb * tools/pdbgen/pdb/drawable.pdb * tools/pdbgen/pdb/fileops.pdb * tools/pdbgen/pdb/gradient_select.pdb * tools/pdbgen/pdb/gradients.pdb * tools/pdbgen/pdb/help.pdb * tools/pdbgen/pdb/image.pdb * tools/pdbgen/pdb/layer.pdb * tools/pdbgen/pdb/pattern_select.pdb * tools/pdbgen/pdb/patterns.pdb * tools/pdbgen/pdb/selection.pdb * tools/pdbgen/pdb/tools.pdb * app/*: chainsaw #include cleanup: - Never (never!!) include stuff in header files except where we need access to structures' contents (like derived objects). - Added prototypes and proper formating in many files. - The #include order in *all* *.c files is as follows: #include "config.h" #include <system stuff> #include <gtk/gtk.h> #include "apptypes.h" #include "gimp stuff" #include "libgimp stuff" #include "libgimp/gimpintl.h" By following this scheme we can easily see a file's dependencies from it's #include's and can grep for the inclusion to find out where a file is used. * tools/pdbgen/app.pl: changed to follow the include scheme above. * libgimp/Makefile.am * libgimp/gimpuitypes.h: new file, included from libgimp/gimpui.h and from app/apptypes.h. * libgimp/gimpcolorbutton.[ch] * libgimp/gimpdialog.[ch] * libgimp/gimphelpui.[ch] * libgimp/gimpparasite.[ch] * libgimp/gimppatheditor.[ch] * libgimp/gimpprotocol.c * libgimp/gimpquerybox.[ch] * libgimp/gimpsizeentry.[ch] * libgimp/gimptypes.h * libgimp/gimpui.h * libgimp/gimpunit.h * libgimp/gimpunitmenu.[ch] * libgimp/gimpwidgets.[ch]: changed accordingly. * plug-ins/FractalExplorer/Dialogs.c * plug-ins/gdyntext/message_window.c * plug-ins/imagemap/imap_default_dialog.c * plug-ins/imagemap/imap_file.c: these files used to include "libgimp/gimpui.h" without including "libgimp/gimp.h". This is no longer possible because the libgimpui headers don't inlcude "libgimp/gimpunit.h" any more. |
|
|
Sven Neumann
|
c668aaa437 |
app/gradient.c reviewed the gradient code. The old code used to use list
2000-12-21 Sven Neumann <sven@gimp.org> * app/gradient.c * app/gradient_select.[ch]: reviewed the gradient code. The old code used to use list indices which led to bug #35612 and other problems. We now attach a pointer to the gradient to each row in the GtkClists and retrieve the matching row for a gradient using gtk_clist_find_row_from_data(). Additionally I have added similar code as we use for brushes to assure that no two gradients have the same name. |
|
|
Sven Neumann
|
dfa2bed505 |
Last-minute cleanup:
2000-12-16 Sven Neumann <sven@gimp.org> Last-minute cleanup: * app/gimpdrawableF.h * app/gimphistogramF.h * app/gimpimageF.h * app/gimplistF.h * app/gimplutF.h * app/gimpobjectF.h * app/gimpsetF.h * app/layerF.h * app/parasitelistF.h: removed these files * app/Makefile.am * tools/pdbgen/Makefile.am: changed accordingly * app/[almost every file]: include cleanup |
|
|
Michael Natterer
|
0302ed0a10 |
app/brush_select.[ch] app/gradient.c app/gradient_select.[ch]
1999-11-03 Michael Natterer <mitch@gimp.org> * app/brush_select.[ch] * app/gradient.c * app/gradient_select.[ch] * app/interface.[ch] * app/palette.c * app/pattern_select.[ch]: allow dragging a brush/pattern/... from the selections with mouse2 without changing the active element in the dialog. * app/channels_dialog.c * app/color_area.c * app/color_panel.c * app/color_select.c * app/colormap_dialog.i.c * app/devices.c * app/gimpcontextpreview.[ch] * app/gimphelp.[ch] * app/gimpui.[ch] * app/indicator_area.c * app/interface.[ch] * app/layers_dialog.c * app/lc_dialog.c * app/ops_buttons.[ch] * app/paths_dialog.c * app/preferences_dialog.c * app/tools.[ch]: wrapped gtk_tooltips_set_tip() with gimp_help_set_help_data() and moved it to gimphelp.[ch]. This should (hopefully) be the final state of the help system. The New function allows a "private tip" to be set without a visible tooltip. This way the tooltips inspector (shift+F1) can search for help data in the parent containers of the clicked widget. E.g. the ops buttons in the layers dialog have private tips like "#new_layer" which gets composed with the help data of the layers dialog notebook page resulting in a complete help path. Allow mouse2 for all dnd operations. Mouse1 still works like before. |
|
|
Michael Natterer
|
79e27e984a | More context & dnd stuff... |