mirror of https://github.com/GNOME/gimp.git
37 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Sven Neumann
|
27042a7b36 |
app/tools/gimppainttool.[ch] unified tool and paint-tool statusbar APIs.
2005-05-07 Sven Neumann <sven@gimp.org> * app/tools/gimppainttool.[ch] * app/tools/gimptool.[ch]: unified tool and paint-tool statusbar APIs. * app/tools/gimpblendtool.c * app/tools/gimpclonetool.c * app/tools/gimpcolortool.c * app/tools/gimpcroptool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimpnewrectselecttool.c * app/tools/gimprectangletool.c * app/tools/gimprectselecttool.c * app/tools/gimpvectortool.c: changed accordingly. * app/tools/gimpselectiontool.c: give more hints in the statusbar. Some of the selection tools should probably override these. |
|
|
Michael Natterer
|
76d95a10d0 |
added new parameter "gboolean propagate_release" to
2004-10-06 Michael Natterer <mitch@gimp.org> * app/tools/gimpeditselectiontool.[ch]: added new parameter "gboolean propagate_release" to gimp_edit_slection_tool_start() and remember it in the GimpEditSelectionTool struct. If requested, propagate GimpTool::button_release() to the tool below in the tool stack. * app/tools/gimpselectiontool.c (gimp_selection_tool_start_edit): pass FALSE so we don't get the button_release(). * app/tools/gimpmovetool.[ch]: pass TRUE so we get button_release(). If moving a layer or path in "pick active" mode, remember the old active layer/path and switch back to it in button_release(). Fixes bug #97734. Unrelated: * app/tools/gimpeditselectiontool.c (gimp_edit_selection_tool_motion): set "first_move" to FALSE only if a move actually happened. Fixes un-undoable moves at high zoom factors. |
|
|
Michael Natterer
|
d50a2db779 |
renamed init_edit_selection() to gimp_edit_selection_tool_start(). Removed
2004-07-26 Michael Natterer <mitch@gimp.org> * app/tools/gimpeditselectiontool.[ch]: renamed init_edit_selection() to gimp_edit_selection_tool_start(). Removed enum EditType. * app/tools/tools-enums.h: added enum GimpTranslateMode instead. * app/tools/gimpmovetool.c: changed accordingly. * app/tools/gimpselectiontool.[ch]: added protected utility function gimp_selection_tool_start_edit(). * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimprectselecttool.c: use the new function instead of duplicating the same code three times, don't include "gimpeditselectiontool.h". * app/tools/gimpiscissorstool.c: don't include "gimpeditselectiontool.h". |
|
|
Michael Natterer
|
c5ec0d4f70 | *** empty log message *** | |
|
Simon Budig
|
3c1b7fe68f |
renamed the "arrow_key" member to "key_press", since it is now no longer
2004-06-12 Simon Budig <simon@gimp.org> * app/tools/gimptool.[ch]: renamed the "arrow_key" member to "key_press", since it is now no longer about just the arrow keys. * app/tools/gimpcroptool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpeditselectiontool.h * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimpselectiontool.c * app/tools/gimptexttool.c * app/tools/gimpvectortool.c * app/tools/tool_manager.c: Changed accordingly. |
|
|
Michael Natterer
|
714d63fcda |
cursors/Makefile.am cursors/cursor-none.png new empty cursor images.
2004-06-05 Michael Natterer <mitch@gimp.org> * cursors/Makefile.am * cursors/cursor-none.png * cursors/xbm/cursor-none.xbm: new empty cursor images. * app/config/gimpdisplayconfig.[ch] * app/config/gimprc-blurbs.h * app/widgets/widgets-enums.h * app/widgets/gimpcursor.c * app/display/gimpdisplayshell-cursor.c * app/tools/gimppainttool.[ch] * app/tools/gimpinktool.c * app/gui/preferences-dialog.c: applied patches from Philip Lafleur which implement hiding the cursor completely for paint tools. Changed the name of the config option from "hide-paint-tool-cursor" to "show-paint-tool-cursor" and default to TRUE because this needs the brush outline being visible while painting to be really usable. Fixes bug #132163. * app/widgets/widgets-enums.h: renamed all GimpCursorType and GimpToolCursorType enum values to GIMP_CURSOR_* and GIMP_TOOL_CURSOR_*. * app/widgets/gimpcursor.c * app/display/gimpdisplayshell-callbacks.c * app/display/gimpdisplayshell-cursor.c * app/tools/gimp*tool.c; changed accordingly. |
|
|
Michael Natterer
|
79e13a1ca0 |
app/tools/gimpdrawtool.c app/tools/gimpselectiontool.c
2004-03-10 Michael Natterer <mitch@gimp.org> * app/tools/gimpdrawtool.c * app/tools/gimpselectiontool.c * app/tools/gimptool.c * app/tools/gimptransformtool.c: minor cleanup. |
|
|
Michael Natterer
|
69e11c9af2 |
added "GimpVectorMode saved_mode" to the GimpVectorTool struct.
2003-09-17 Michael Natterer <mitch@gimp.org> * app/tools/gimpvectortool.[ch]: added "GimpVectorMode saved_mode" to the GimpVectorTool struct. (gimp_vector_tool_modifier_key): use it to correctly keep track of the modifier state. * app/tools/gimpselectiontool.c (gimp_selection_tool_modifier_key): moved variable to local scope. |
|
|
Michael Natterer
|
e837849934 |
removed the _value() and _is_empty() wrappers.
2003-09-03 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask.[ch]: removed the _value() and _is_empty() wrappers. * app/display/gimpdisplayshell.[ch]: removed gimp_display_shell_mask_value() since it is not used. * app/core/gimpdrawable-blend.c * app/core/gimpdrawable-transform.c * app/core/gimpedit.c * app/core/gimpimage.c * app/core/gimplayer.c * app/gui/image-menu.c * app/gui/vectors-menu.c * app/tools/gimpclonetool.c * app/tools/gimpfliptool.c * app/tools/gimpinktool.c * app/tools/gimpmovetool.c * app/tools/gimpselectiontool.c * app/tools/gimptransformtool.c * tools/pdbgen/pdb/misc_tools.pdb: changed accordingly. * app/pdb/misc_tools_cmds.c: regenerated. |
|
|
Michael Natterer
|
9981c4645c |
added "gboolean cut_image" parameter so we can float selections without
2003-05-16 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask.[ch] (gimp_image_mask_extract): added "gboolean cut_image" parameter so we can float selections without cutting them from the original drawable. * app/gui/select-commands.c * tools/pdbgen/pdb/selection.pdb: pass cut_image == TRUE. * app/pdb/selection_cmds.c: regenerated. * app/tools/tools-enums.[ch]: added SELECTION_MOVE_COPY value to the SelectOps enum. * app/tools/gimpselectiontool.c: use the new mode when <ctrl>+<alt>-dragging a selction (yes, this is evil but there are no modifiers left). * app/tools/gimpeditselectiontool.[ch]: extended EditType enum by EDIT_MASK_COPY_TO_LAYER_TRANSLATE and pass cut_image == FALSE if it's passed to init_edit_selection(). * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimprectselecttool.c: pass the new mode to GimpEditSelectionTool. |
|
|
Michael Natterer
|
8cee4963fb |
check for GIMP_IS_DISPLAY(gdisp) again.
2003-04-15 Michael Natterer <mitch@gimp.org> * app/tools/gimptool.c: check for GIMP_IS_DISPLAY(gdisp) again. * app/tools/gimptool.h: don't #include "gimptoolcontrol.h" * app/tools/[all tools].c: #include "gimptoolcontrol.h" |
|
|
Manish Singh
|
5bc3a7a31d |
app/tools/gimpbucketfilltool.c app/tools/gimpconvolvetool.c
2003-02-27 Manish Singh <yosh@gimp.org>
* app/tools/gimpbucketfilltool.c
* app/tools/gimpconvolvetool.c
* app/tools/gimpcroptool.c
* app/tools/gimpdodgeburntool.c
* app/tools/gimperasertool.c
* app/tools/gimpfliptool.c
* app/tools/gimpfuzzyselecttool.c
* app/tools/gimpinkoptions.c
* app/tools/gimpmagnifytool.c
* app/tools/gimpmovetool.c
* app/tools/gimprectselecttool.c
* app/tools/gimpselectiontool.c
* app/tools/gimptexttool.c
* app/tools/gimptransformtool.c
* app/widgets/gimpcellrendererviewable.c
* app/widgets/gimpcontainertreeview.c: remove unecessary G_OBJECT()
from g_object_set calls.
* plug-ins/common/bumpmap.c: use g_signal_handlers_(un)block_by_func
instead of gtk_signal_handler_(un)block_by_data.
|
|
|
Michael Natterer
|
d24dac6833 |
app/tools/transform_options.[ch] removed...
2003-02-08 Michael Natterer <mitch@gimp.org> * app/tools/transform_options.[ch] * app/tools/selection_options.[ch]: removed... * app/tools/gimpselectionoptions.[ch] * app/tools/gimptransformoptions.[ch]: ...and added here. * app/tools/Makefile.am * app/tools/gimpbezierselecttool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpellipseselecttool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpiscissorstool.c * app/tools/gimpperspectivetool.c * app/tools/gimprectselecttool.c * app/tools/gimprotatetool.c * app/tools/gimpscaletool.c * app/tools/gimpselectiontool.c * app/tools/gimpsheartool.c * app/tools/gimptransformtool.c * app/tools/gimpvectoroptions.h: changed accordingly. * app/tools/gimpinkoptions.[ch]: renamed "sensitivity" to "size_sensitivity". Reordered properties. Added utility constructors blob_button_new() and brush_widget_new(). * app/tools/gimpinktool.c: changed accordingly. |
|
|
Michael Natterer
|
eeec3cedb8 |
Added object properties for almost all tool_options values and registered
2003-02-07 Michael Natterer <mitch@gimp.org> Added object properties for almost all tool_options values and registered lots of enums with the type system: Part I (enum and type cleanup): * app/core/core-enums.[ch] * app/core/core-types.h: removed InternalOrientaionType and register GimpOrientationType. Register GimpChannelOps. Removed GimpToolOptionsGUIFunc. * app/xcf/xcf-private.h: added XcfOrientationType with the same values as the old InternalOrientationType * app/xcf/xcf-load.c * app/xcf/xcf-save.c: translate between GimpOrientationType and XcfOrientationType. * app/core/gimpdrawable-transform-utils.[ch] * app/core/gimpdrawable-transform.[ch] * app/core/gimpimage-crop.c * app/core/gimpimage-duplicate.c * app/core/gimpimage-guides.c * app/core/gimpimage-resize.c * app/core/gimpimage-scale.c * app/core/gimpimage.h * app/display/gimpdisplayshell.c * tools/pdbgen/stddefs.pdb * tools/pdbgen/pdb/transform_tools.pdb: changed accordingly. * app/pdb/guides_cmds.c * app/pdb/transform_tools_cmds.c * libgimp/gimpenums.h * libgimpproxy/gimpproxytypes.h * plug-ins/script-fu/script-fu-constants.c * tools/pdbgen/enums.pl: regenerated. * libgimptool/gimptoolenums.[ch]: added GimpTransformGridType. * libgimptool/gimptooltypes.h: removed GimpToolOptionsResetFunc, added GimpToolOptionsGUIFunc. Part II (tool options changes): * app/config/gimpconfig-utils.c (gimp_config_reset_properties): don't reset object properties because they have NULL as default value. * app/widgets/gimppropwidgets.[ch]: added gimp_prop_[enum|boolean]_radio_frame_new(), gimp_prop_paint_mode_menu_new() and gimp_prop_scale_entry_new(), which are all needed by the new tool options GUI code. * app/tools/tool_options.[ch]: removed the "reset_func" since the virtual reset() method is used now. * app/paint/gimpairbrushoptions.[ch] * app/paint/gimpcloneoptions.[ch] * app/paint/gimpconvolveoptions.[ch] * app/paint/gimpdodgeburnoptions.[ch] * app/paint/gimperaseroptions.[ch] * app/paint/gimppaintoptions.[ch] * app/paint/gimpsmudgeoptions.[ch]: added properties all over the place and removed the widget and default_value members from the structs. Renamed some values (e.g. s/type/clone_type/). Don't #include <gtk/gtk.h>. * app/paint/gimpairbrush.c * app/paint/gimpclone.c * app/paint/gimpconvolve.c * app/paint/gimpdodgeburn.c * app/paint/gimperaser.c * app/paint/gimppaintbrush.c * app/paint/gimppaintcore-stroke.c * app/paint/gimppaintcore.c * app/paint/gimppencil.c * app/paint/gimpsmudge.c * app/paint/paint-types.h * app/paint/paint.c: changed accordingly. Don't #include <gtk/gtk.h>. * tools/pdbgen/pdb/paint_tools.pdb: changed accordingly. * app/pdb/paint_tools_cmds.c: regenerated. * app/tools/gimpblendoptions.[ch] * app/tools/gimpbucketfilloptions.[ch] * app/tools/gimpcolorpickeroptions.[ch] * app/tools/gimpcropoptions.[ch] * app/tools/gimpflipoptions.[ch] * app/tools/gimpinkoptions.c * app/tools/gimpmagnifyoptions.[ch] * app/tools/gimpmeasureoptions.[ch] * app/tools/gimpmoveoptions.[ch] * app/tools/gimptextoptions.c * app/tools/paint_options.[ch] * app/tools/selection_options.[ch] * app/tools/transform_options.[ch]: ditto: added properties and removed widget and default_value stuff. Removed most reset functions. Use gimp_prop widgets all over the place, renamed some values as above. * app/tools/Makefile.am * app/tools/gimpairbrushtool.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpconvolvetool.c * app/tools/gimpcroptool.c * app/tools/gimpdodgeburntool.c * app/tools/gimperasertool.c * app/tools/gimpfliptool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmovetool.c * app/tools/gimpselectiontool.c * app/tools/gimpsheartool.c * app/tools/gimpsmudgetool.c * app/tools/gimptransformtool.c * app/tools/gimpvectoroptions.c: changed accordingly. Ported the paint_options GUI constructors to gimp_prop widgets. * app/widgets/gimpselectioneditor.c * app/gui/tool-options-dialog.c: changed accordingly. |
|
|
Michael Natterer
|
aa9f82d127 |
Made GimpToolOptions a GimpContext subclass and objectified all tool
2003-02-05 Michael Natterer <mitch@gimp.org> Made GimpToolOptions a GimpContext subclass and objectified all tool options types. * app/core/core-types.h: replaced GimpToolOptionsNewFunc by GimpToolOptionsGUIFunc. * libgimpproxy/gimpproxytypes.h: regenerated. * app/core/gimppaintinfo.[ch]: added "GType paint_options_type". * app/core/gimptoolinfo.[ch]: added "GType tool_options_type", removed tool_info->context since GimpToolOptions are a GimpContext now. Added "gboolean use_context" as a temp_hack. * libgimptool/gimptooltypes.h: added the tool_options_type to the tool registering callback. * app/tools/tool_options.[ch]: is a real GimpContext subclass now. * app/paint/paint-types.h * app/paint/paint.c: added the paint_options_type to the paint registering stuff. * app/paint/gimppaintoptions.[ch]: is a real GimpToolOptions subclass now. * app/paint/Makefile.am * app/paint/gimpairbrushoptions.[ch] * app/paint/gimpcloneoptions.[ch] * app/paint/gimpconvolveoptions.[ch] * app/paint/gimpdodgeburnoptions.[ch] * app/paint/gimperaseroptions.[ch] * app/paint/gimpsmudgeoptions.[ch]: new files holding GimpPaintOptions subclasses. * app/paint/gimpairbrush.[ch] * app/paint/gimpclone.[ch] * app/paint/gimpconvolve.[ch] * app/paint/gimpdodgeburn.[ch] * app/paint/gimperaser.[ch] * app/paint/gimppaintbrush.c * app/paint/gimppaintcore.c * app/paint/gimppencil.[ch] * app/paint/gimpsmudge.[ch]: removed paint options stuff, lots of related changed & cleanups. * tools/pdbgen/pdb/paint_tools.pdb: changed accordingly. * app/pdb/paint_tools_cmds.c: regenerated. * app/tools/Makefile.am * app/tools/gimpblendoptions.[ch] * app/tools/gimpbucketfilloptions.[ch] * app/tools/gimpcolorpickeroptions.[ch] * app/tools/gimpcropoptions.[ch] * app/tools/gimpflipoptions.[ch] * app/tools/gimpinkoptions.[ch] * app/tools/gimpmagnifyoptions.[ch] * app/tools/gimpmeasureoptions.[ch] * app/tools/gimpmoveoptions.[ch] * app/tools/gimptextoptions.[ch] * app/tools/gimpvectoroptions.[ch]: new files holding the various tool options classes. * app/tools/selection_options.[ch] * app/tools/transform_options.[ch]: made them objects. * app/tools/paint_options.[ch]: contains only the paint_options GUI and reset stuff. * app/tools/tools-types.h: removed SelectionOptions typedef for now. * app/tools/[all tools]: removed the tool options stuff except some GUI constructors. Tons of related changes. * app/tools/tool_manager.[ch]: changed tool registration / restore / switching accordingly. * app/widgets/gimpdrawablelistview.c * app/widgets/gimpselectioneditor.c: changed accordingly. |
|
|
Michael Natterer
|
a74a8997b4 |
devel-docs/Makefile.am new file documenting the core's include policy.
2002-05-03 Michael Natterer <mitch@gimp.org> * devel-docs/Makefile.am * devel-docs/includes.txt: new file documenting the core's include policy. * HACKING: mention it here. * libgimptool/gimptooltypes.h: removed GimpToolOptions here. * app/core/core-types.h: and added it here. This is a temp hack needed because GimpToolInfo needs to know the GimpToolOptions type. * libgimpproxy/gimpproxytypes.h: regenerated. * libgimptool/gimptoolmodule.h: don't include gimptooltypes.h here... * libgimptool/gimptoolmodule.c: ...but here. * app/config/gimpconfig-params.c: include "libgimpbase/gimpbase.h" entirely, not single files from it. * app/core/gimp.c * app/core/gimpcontext.c * app/core/gimpcoreconfig.c * app/core/gimpdatafactory.c * app/core/gimpdocuments.c * app/core/gimpdrawable-blend.c * app/core/gimpdrawable-bucket-fill.c * app/core/gimpdrawable-offset.c * app/core/gimpdrawable-transform.c * app/core/gimpdrawable.c * app/core/gimpedit.c * app/core/gimpimage-convert.c * app/core/gimpimage-crop.c * app/core/gimpimage-duplicate.c * app/core/gimpimage-guides.c * app/core/gimpimage-mask.c * app/core/gimpimage-merge.c * app/core/gimpimage-new.c * app/core/gimpimage-projection.c * app/core/gimpimage-qmask.c * app/core/gimpimage-resize.c * app/core/gimpimage-scale.c * app/core/gimpimage.c * app/core/gimpitem.c * app/core/gimpmodules.c * app/core/gimppaintinfo.c * app/core/gimpparasite.c * app/core/gimppreviewcache.c * app/core/gimptoolinfo.c * app/core/gimpunit.c: include "core-types.h" and no other types file. * app/display/gimpdisplay.c * app/display/gimpdisplayshell-callbacks.c * app/display/gimpdisplayshell.c: include "tools/tools-types.h" instead of "libgimptool/gimptooltypes.h", warn about inclusion on "gui/gui-types.h" * app/file/file-open.c * app/file/file-save.c: don't include "libgimptool/gimptooltypes.h". * app/gui/about-dialog.c * app/gui/brush-select.c * app/gui/brushes-commands.c * app/gui/color-select.c * app/gui/data-commands.c * app/gui/device-status-dialog.c * app/gui/dialogs.c * app/gui/gradients-commands.c * app/gui/help-commands.c * app/gui/info-window.c * app/gui/palettes-commands.c * app/gui/patterns-commands.c * app/gui/resize-dialog.c * app/gui/tips-dialog.c * app/gui/tool-options-dialog.c: include "gui-types.h" and no other types file. * app/paint/gimpairbrush.c * app/paint/gimpclone.c * app/paint/gimpconvolve.c * app/paint/gimpdodgeburn.c * app/paint/gimperaser.c * app/paint/gimppaintbrush.c * app/paint/gimppaintcore-stroke.c * app/paint/gimppaintcore.c * app/paint/gimppaintoptions.c * app/paint/gimppencil.c * app/paint/gimpsmudge.c * app/paint/paint.c: include "paint-types.h" and no other types file. * app/pdb/pdb-types.h: don't include "libgimptool/gimptooltypes.h". * app/plug-in/plug-in-progress.c: warn about inclusion of "display/display-types.h" * app/tools/tools-types.h: include "libgimptool/gimptooltypes.h". * app/tools/gimpairbrushtool.c * app/tools/gimpbezierselecttool.c * app/tools/gimpblendtool.c * app/tools/gimpbrightnesscontrasttool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcolorbalancetool.c * app/tools/gimpcolorpickertool.c * app/tools/gimpconvolvetool.c * app/tools/gimpcroptool.c * app/tools/gimpcurvestool.c * app/tools/gimpdodgeburntool.c * app/tools/gimpdrawtool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpellipseselecttool.c * app/tools/gimperasertool.c * app/tools/gimpfliptool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimphistogramtool.c * app/tools/gimphuesaturationtool.c * app/tools/gimpinktool.c * app/tools/gimplevelstool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppaintbrushtool.c * app/tools/gimppainttool.c * app/tools/gimppathtool.c * app/tools/gimppenciltool.c * app/tools/gimpperspectivetool.c * app/tools/gimpposterizetool.c * app/tools/gimprectselecttool.c * app/tools/gimprotatetool.c * app/tools/gimpscaletool.c * app/tools/gimpselectiontool.c * app/tools/gimpsheartool.c * app/tools/gimpsmudgetool.c * app/tools/gimptexttool.c * app/tools/gimpthresholdtool.c * app/tools/gimptoolcontrol.c * app/tools/gimptoolcontrol.h * app/tools/gimptransformtool.c * app/tools/gimpvectortool.c * app/tools/tools.c: include "tools-types.h" and no other types file, warn about inclusion of "gui/gui-types.h". * app/widgets/gimpcolorpanel.c * app/widgets/gimptoolbox-color-area.c: warn about inclusion of "gui/gui-types.h". * app/xcf/xcf-load.c * app/xcf/xcf.c: don't include "libgimptool/gimptooltypes.h". Split tool-safe-mode up in two files, one including libgimpproxy, one libgimp. * plug-ins/tools/Makefile.am * plug-ins/tools/tool-safe-mode-plug-in.[ch]: new files including libgimp/ stuff only. * plug-ins/tools/tool-safe-mode.[ch]: include libgimpproxy/ and libgimptool/ but don't include libgimp/ because of conflicting declarations. Unrelated: * app/tools/gimpclonetool.c: create the clone core so we don't crash. * app/gui/file-open-dialog.c: changed the way we create previews so that only out-of-date previews are created on a click in the preview area. Unconditional creation can still be forced by <Ctrl>+click. Changed the tooltip to document this. |
|
|
Sven Neumann
|
84e1810adc |
app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch]
2002-05-03 Sven Neumann <sven@gimp.org> * app/tools/gimpairbrushtool.[ch] * app/tools/gimpbezierselecttool.[ch] * app/tools/gimpblendtool.[ch] * app/tools/gimpbrightnesscontrasttool.[ch] * app/tools/gimpbucketfilltool[.ch] * app/tools/gimpbycolorselecttool[.ch] * app/tools/gimpclonetool[.ch] * app/tools/gimpcolorbalancetool[.ch] * app/tools/gimpcolorpickertool[.ch] * app/tools/gimpconvolvetool[.ch] * app/tools/gimpcroptool[.ch] * app/tools/gimpcurvestool[.ch] * app/tools/gimpdodgeburntool[.ch] * app/tools/gimpeditselectiontool.c * app/tools/gimpellipseselecttool[.ch] * app/tools/gimperasertool[.ch] * app/tools/gimpfliptool[.ch] * app/tools/gimpfreeselecttool[.ch] * app/tools/gimpfuzzyselecttool[.ch] * app/tools/gimphistogramtool[.ch] * app/tools/gimphuesaturationtool[.ch] * app/tools/gimpinktool[.ch] * app/tools/gimpiscissorstool[.ch] * app/tools/gimplevelstool[.ch] * app/tools/gimpmagnifytool[.ch] * app/tools/gimpmeasuretool[.ch] * app/tools/gimpmovetool[.ch] * app/tools/gimppaintbrushtool[.ch] * app/tools/gimppainttool.c * app/tools/gimppathtool[.ch] * app/tools/gimppenciltool[.ch] * app/tools/gimpperspectivetool[.ch] * app/tools/gimpposterizetool[.ch] * app/tools/gimprectselecttool[.ch] * app/tools/gimprotatetool[.ch] * app/tools/gimpscaletool[.ch] * app/tools/gimpselectiontool.c * app/tools/gimpsheartool[.ch] * app/tools/gimpsmudgetool[.ch] * app/tools/gimptexttool[.ch] * app/tools/gimpthresholdtool[.ch] * app/tools/gimptool.c * app/tools/gimptoolcontrol.h * app/tools/gimptoolmodule[.ch] * app/tools/gimptransformtool.c * app/tools/gimpvectortool[.ch] * app/tools/path_tool.c * app/tools/tool_manager[.ch] * app/tools/tools.c * libgimptool/gimptool.c * libgimptool/gimptoolcontrol.h * libgimptool/gimptoolmodule.h: removed tons of warnings. Do we need to add -Werror to the CFLAGS to avoid such a mess in the future ?! Also had to enforce the GIMP coding style in lots of places :-( * libgimp/gimppixelrgn.c: got sick and tired of debugging plug-ins, so I've added checks for most parameters passed to the GimpPixelRgn functions. This will slow down plug-in execution a little bit but should help to find bugs early. |
|
|
Nate Summers
|
810b983110 |
app/tools/gimptoolcontrol.[ch] resurrected the motion hints and cursor
* app/tools/gimptoolcontrol.[ch]
* libgimptool/gimptool.c: resurrected the motion hints and cursor
changing code.
app/tools/gimpairbrushtool.c
app/tools/gimpbezierselecttool.c
app/tools/gimpblendtool.c
app/tools/gimpbucketfilltool.c
app/tools/gimpbycolorselecttool.c
app/tools/gimpclonetool.c
app/tools/gimpcolorbalancetool.c
app/tools/gimpcolorpickertool.c
app/tools/gimpconvolvetool.c
app/tools/gimpcroptool.c
app/tools/gimpcurvestool.c
app/tools/gimpdodgeburntool.c
app/tools/gimpeditselectiontool.c
app/tools/gimpellipseselecttool.c
app/tools/gimperasertool.c
app/tools/gimpfliptool.c
app/tools/gimpfuzzyselecttool.c
app/tools/gimphistogramtool.c
app/tools/gimphuesaturationtool.c
app/tools/gimpimagemaptool.c
app/tools/gimpinktool.c
app/tools/gimpiscissorstool.c
app/tools/gimplevelstool.c
app/tools/gimpmagnifytool.c
app/tools/gimpmeasuretool.c
app/tools/gimpmovetool.c
app/tools/gimppaintbrushtool.c
app/tools/gimppainttool.c
app/tools/gimppathtool.c
app/tools/gimppenciltool.c
app/tools/gimpperspectivetool.c
app/tools/gimprectselecttool.c
app/tools/gimprotatetool.c
app/tools/gimpscaletool.c
app/tools/gimpselectiontool.c
app/tools/gimpsheartool.c
app/tools/gimpsmudgetool.c
app/tools/gimptexttool.c
app/tools/gimptransformtool.c
app/tools/gimpvectortool.c: set the motion mode; fix a few parameters
* app/tools/gimpinktool.c (gimp_ink_tool_button_press): uncommented
some code I had temporarily commented out and didn't uncomment before
committing
* libgimptool/gimptoolcontrol.h
* app/tools/gimptoolcontrol-displayshell.[ch]: merged with
gimptoolcontrol.[ch]. The distinction was fairly arbitrary.
* plug-ins/tools/gimptoolcontrol.c: added some stubs
* app/tools/Makefile.am
* app/tools/tool_manager.c
* app/display/gimpdisplayshell-callbacks.c: changed accordingly
* libgimp/gimpimage_pdb.c: applied a patch from Pippen to correct
documentation on the undo operations
|
|
|
Nate Summers
|
69ccb4d370 | massive tool plugin changes | |
|
Manish Singh
|
96f78088b0 |
tools/pdbgen/app.pl tools/pdbgen/enumcode-py.pl tools/pdbgen/enumcode.pl
2002-03-17 Manish Singh <yosh@gimp.org>
* tools/pdbgen/app.pl
* tools/pdbgen/enumcode-py.pl
* tools/pdbgen/enumcode.pl
* tools/pdbgen/enumgen.pl: removed enum nick support, best to keep
internal and external names consistent
* app/core/core-enums.h: remove chops from enums. Change TRANS to
TRANSPARENT in GimpBlendMode
* app/core/core-types.h: remove chops and nicks from enums. Change INV
to INVERSE and SUB to SUBTRACT to make things more clear
* app/core/gimpchannel.c
* app/gui/channels-commands.c
* app/gui/vectors-commands.c
* app/tools/gimpbezierselecttool.c
* app/tools/gimpbycolorselecttool.c
* app/tools/gimprectselecttool.c
* app/tools/gimpselectiontool.c
* app/tools/selection_options.c
* app/tools/tools-types.h
* app/widgets/gimpchannellistview.c
* app/widgets/gimpvectorslistview.c: reflect SUB -> SUBTRACT change
* app/core/gimpdrawable-blend.c: reflect TRANS -> TRANSPARENT change
* app/core/gimplayer.c
* app/gui/layers-commands.c: reflect INV -> INVERSE change
* app/paint/paint-types.h: remove nick from PaintApplicationMode
* app/tools/gimperasertool.c: fix tooltip
* app/widgets/gimpenummenu.c: #include "libgimp/gimpintl.h" for
gettext
* libgimp/gimpcompat.h: compatibility enums here, since we removed
the nicks
* tools/pdbgen/enums.pl
* libgimp/gimpenums.h
* plug-ins/script-fu/script-fu-constants.c
* app/core/core-enums.c
* app/pdb/channel_cmds.c
* app/pdb/drawable_cmds.c
* app/pdb/edit_cmds.c
* app/pdb/layer_cmds.c
* app/pdb/misc_tools_cmds.c
* app/pdb/paint_tools_cmds.c
* app/pdb/selection_cmds.c
* app/pdb/selection_tools_cmds.c: regenerated, enum changes
* plug-ins/common/hot.c: GIMP_TRANS_IMAGE_FILL -> GIMP_TRANSPARENT_FILL
* plug-ins/common/warp.c: GIMP_BG_IMAGE_FILL -> GIMP_BACKGROUND_FILL
* plug-ins/script-fu/siod-wrapper.c: compat constant definitions
|
|
|
Michael Natterer
|
5e17408c84 |
Re-enabled the display filters. They work exactly the same way as before
2002-03-14 Michael Natterer <mitch@gimp.org> Re-enabled the display filters. They work exactly the same way as before except for the color_area pseudo-display. More stuff to come... * app/display/Makefile.am: build them again. * app/display/gimpdisplayshell-filter-dialog.[ch] * app/display/gimpdisplayshell-filter.[ch]: changed to the new namespace, work on GimpDisplayShell instead of GimpDisplay. * app/display/gimpdisplayshell-render.c * app/display/gimpdisplayshell.[ch]: changed accordingly. * app/gui/dialogs-constructors.c: enabled the dialog constructor. * app/gui/gui.c: call the init() function. * app/gui/menus.c: enabled the menu entry, but moved it to <Image>/View. Moved "Undo History..." to <Image>/Image. * modules/Makefile.am: build and install the modules. * modules/cdisplay_gamma.c * modules/cdisplay_highcontrast.c: made them compile with minimal changes. Unrelated: * app/undo_history.c: connect to the image's "disconnect", not "destroy" signal. * app/tools/gimpselectiontool.c: mask out the irrelevant parts of the "state" passed to the modifier_key() func, so tool_options button toggling works with other modifiers (e.g. num_lock) pressed. |
|
|
Michael Natterer
|
affc31007e |
changed gimp_image_mask_select_channel() to not take "drawable" and
2002-03-03 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask-select.[ch]: changed gimp_image_mask_select_channel() to not take "drawable" and "sample_merged" parameters (which are silly in some contexts) but simply the offsets of the passed channel. * app/gui/channels-commands.c * app/tools/gimpbezierselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpiscissorstool.c: changed accordingly. * app/tools/gimpdrawtool.[ch]: chaged gimp_draw_tool_draw_lines() and _draw_strokes() to take an additional "use_offsets" parameter like the other drawing functions. * app/path_curves.c * app/tools/gimpvectortool.c: changed accordingly. * app/paint/gimppaintcore.c: removed #if 0'ed code which was identical to other functions. * app/tools/gimpselectiontool.c: use the GimpEditSelectionTool's "arrow_key_func" so it's now possible to keyboad-move the current layer and selection with all selection tool. Needs some more tweaking... * app/tools/gimpiscissorstool.[ch] * app/tools/gimpvectortool.[ch]: derive them from GimpSelectionTool to make the modifier key <-> tool options interaction work. Ported IScissors to the new way the draw_tool works. |
|
|
Michael Natterer
|
967d3e4ef1 |
Removed pointer grabbing from all tools:
2002-02-05 Michael Natterer <mitch@gimp.org> Removed pointer grabbing from all tools: * app/tools/gimptool.[ch]: added "gboolean perfectmouse" which defaults to FALSE but can be set to TRUE in a tool's instance_init function. * app/display/gimpdisplayshell-callbacks.c: look at active_tool->perfectmouse and gimprc.perfectmouse and do the pointer grab/ungrab here. The pointer is now grabbed right before dispatching the button_press to the tool and ungrabbed after the tool's button_release has returned. It is also grabbed *always*, not only if tool->state got ACTIVE by button_press, which makes it all much simpler... * app/tools/gimpbezierselecttool.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcolorpickertool.c * app/tools/gimpcroptool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpfliptool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpinktool.c * app/tools/gimpiscissorstool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimppathtool.c * app/tools/gimprectselecttool.c * app/tools/gimpselectiontool.c * app/tools/gimptexttool.c * app/tools/gimptransformtool.c: removed gdk_pointer_grab()/ungrab() calls all over the place. Also removed inclusion of "display/gimpdisplayshell.h" from most of them. |
|
|
Michael Natterer
|
989d80e79e |
added fields for both the tool's toggled and untoggled GdkCursorType,
2002-02-04 Michael Natterer <mitch@gimp.org> * app/tools/gimptool.[ch]: added fields for both the tool's toggled and untoggled GdkCursorType, GimpToolCursorType and GimpCursorModifier. Added a default implementation of gimp_tool_cursor_update() which uses the new fields. Added gimp_tool_set_cursor() as simple wrapper around the resp. GimpDisplayShell functions so tools don't need to know them. Tool implementations can either set the new fields in their cursor_update() function and chain up or call the new wrapper. * app/tools/gimpbezierselecttool.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcolorpickertool.c * app/tools/gimpconvolvetool.c * app/tools/gimpcroptool.c * app/tools/gimpdodgeburntool.c * app/tools/gimperasertool.c * app/tools/gimpfliptool.c * app/tools/gimpinktool.c * app/tools/gimpiscissorstool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.[ch] * app/tools/gimppathtool.c * app/tools/gimpselectiontool.c * app/tools/gimpsmudgetool.c * app/tools/gimptexttool.c * app/tools/gimptransformtool.c: changed accordingly: - set default values in the tools' instance_init functions. - changed the cursor_update() stuff. - removed inclusion of subclasses in gimppainttool.c - the cursor_update() functions are better than before but still evil. - i probably broke some of them... |
|
|
Michael Natterer
|
f7bbdc3e49 |
s/gimage_mask/gimp_image_mask/g
2001-11-28 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask.[ch]: s/gimage_mask/gimp_image_mask/g * app/floating_sel.c * app/undo.c * app/undo_history.c * app/core/gimpchannel.c * app/core/gimpdrawable-blend.c * app/core/gimpdrawable-transform.c * app/core/gimpdrawable.c * app/core/gimpedit.c * app/core/gimpimage-crop.c * app/core/gimpimage-mask-select.c * app/core/gimpimage-resize.c * app/core/gimpimage-scale.c * app/core/gimpimage.c * app/display/gimpdisplayshell-qmask.c * app/display/gimpdisplayshell-selection.c * app/display/gimpdisplayshell.c * app/gui/channels-commands.c * app/gui/edit-commands.c * app/gui/layers-commands.c * app/gui/select-commands.c * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcroptool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpfliptool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpinktool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimprectselecttool.c * app/tools/gimpselectiontool.c * app/tools/gimptexttool.c * app/tools/gimptransformtool.c * app/widgets/gimpchannellistview.c * app/xcf/xcf-save.c * tools/pdbgen/pdb/edit.pdb * tools/pdbgen/pdb/selection.pdb: changed accordingly. * app/pdb/edit_cmds.c * app/pdb/selection_cmds.c: regenerated. |
|
|
Michael Natterer
|
a08f3ac001 |
use "gimp-item-data" instead of "user_data" as data key when attaching
2001-11-22 Michael Natterer <mitch@gimp.org> * libgimpwidgets/gimpwidgets.[ch]: use "gimp-item-data" instead of "user_data" as data key when attaching values to radio buttons or menu items. (For backward compat, attach "user_data" additionally, but don't use it to _get_data()). Added gimp_radio_group_set_active() which works like gimp_options_menu_set_history() and sets the active item by attached "gimp-item-data" value. * app/gui/brush-select.c * app/gui/file-new-dialog.c * app/gui/info-window.c * app/gui/preferences-dialog.c * app/gui/resolution-calibrate-dialog.c * app/tools/gimpbucketfilltool.c * app/tools/gimpselectiontool.c * app/tools/paint_options.c * app/tools/selection_options.c * app/widgets/gimplayerlistview.c: removed all kinds of "user_data" stuff and evil hacks to find a radio button by the value it represents (simply call gimp_radio_group_set_active()). * app/tools/gimpdrawtool.c: added a g_return_if_fail(). * app/tools/gimpfliptool.c: don't set draw_tool_class->draw to NULL, * app/tools/gimptransformtool.[ch]: fixed some stuff i broke when removing the old "interactive" boolean (there is no non-interactive transform tool any more). Put the info_dialog pointer and the old_trans_info array into the GimpTransformTool instance. Added gimp_transform_tool_info_dialog_connect(). Don't include any subclasses any more. * app/tools/gimpperspectivetool.c * app/tools/gimprotatetool.c * app/tools/gimpscaletool.c * app/tools/gimpsheartool.c: use gimp_transform_tool_info_dialog_connect() to create and connect the info dialogs' action_area. |
|
|
Michael Natterer
|
958071b0c8 |
key press and release events were sent swapped to tools.
2001-11-21 Michael Natterer <mitch@gimp.org> * app/display/gimpdisplayshell-callbacks.c: key press and release events were sent swapped to tools. * app/tools/selection_options.[ch]: added radio buttons for the selection operation (REPLACE, ADD, ...). Partly fixes #51108. * app/tools/gimpselectiontool.[ch]: honor the new tool options stuff. Do evil things in gimp_selection_tool_modifier_key(). * app/tools/gimpbycolorselecttool.[ch]: removed most of the widgets from the by_color_select window because they are all in the selection_options now. * libgimpwidgets/gimpstock.[ch]: added new stock items for the buttons. * themes/Default/Makefile.am * themes/Default/images/Makefile.am * themes/Default/images/stock-button-selection-add.png * themes/Default/images/stock-button-selection-intersect.png * themes/Default/images/stock-button-selection-replace.png * themes/Default/images/stock-button-selection-subtract.png: new stock images. |
|
|
Michael Natterer
|
02fde14c95 |
build display/ before tools/.
2001-11-08 Michael Natterer <mitch@gimp.org> * app/Makefile.am: build display/ before tools/. * app/devices.c: devices_check_change(): added all events which have a GdkDevice pointer. * app/gimpprogress.c: include "display-types.h" instead of "core-types.h". * app/core/Makefile.am * app/core/gimpdrawable-bucket-fill.[ch]: new files: the bucket_fill stuff taken from tools/gimpbucketfilltool.[ch]. * app/core/core-types.h: added "BucketFillMode". * app/core/gimpimage-mask-select.[ch]: cleanup. * app/core/gimpmarshal.list: added more marshallers for GimpTool's new signal signatures. * app/core/gimpmarshal.[ch]: regenerated. * app/display/Makefile.am * app/display/gimpdisplayshell-dnd.[ch] * app/display/gimpdisplayshell-layer-select.[ch]: new files: the canvas drop callbacks from gimpdisplayshell-callbacks.[ch] and the stuff formerly knows as gui/layer-select.[ch]. * app/display/gimpdisplay.h: don't include "gui/gui-types.h". * app/display/gximage.c: include "display-types.h". * app/display/gimpdisplay-foreach.c * app/display/gimpdisplayshell.[ch]: call gdsplay_delete(), don't destroy the shell widget. * app/gui/Makefile.am * app/gui/layer-select.[ch]: removed. * app/gui/gradients-commands.c: fixed "Save as POV" fprintf()s. * app/gui/preferences-dialog.c: removed the layer_select stuff because it is useless with the new preview system. * app/gui/tool-options-dialog.c: send the correct data to the close_callback. * app/gui/tools-commands.c: changed to follow the new gimp_tool_initialize() semantics (see below). Tool & canvas event handling chainsawing: * app/tools/tools-types.h: new struct GimpCoords which contains x, y, pressure, tilt etc. * app/display/gimpdisplayshell-callbacks.[ch]: added utility functions which transparently retreive the current event's GimpCoords or take it from the device directly if the event has none. Pass GimpCoords _in_image_coordinates_ to all tool functions. Most important: don't pass GdkEvents and display coordinates to tools any more. * app/tools/gimptool.[ch]: changed virtual functions to take GimpCoords, time and state separately instead of GdkEvents. * app/tools/gimpbezierselecttool.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.[ch] * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcolorpickertool.c * app/tools/gimpconvolvetool.c * app/tools/gimpcroptool.[ch] * app/tools/gimpcurvestool.c * app/tools/gimpdodgeburntool.c * app/tools/gimpdrawtool.c * app/tools/gimpeditselectiontool.[ch] * app/tools/gimperasertool.c * app/tools/gimpfliptool.c * app/tools/gimpfreeselecttool.[ch] * app/tools/gimpfuzzyselecttool.c * app/tools/gimpinktool.c * app/tools/gimpiscissorstool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimppathtool.[ch] * app/tools/gimprectselecttool.c * app/tools/gimprotatetool.c * app/tools/gimpselectiontool.[ch] * app/tools/gimpsmudgetool.c * app/tools/gimptexttool.c * app/tools/gimptransformtool.[ch] * app/tools/path_tool.[ch] * app/tools/selection_options.c: tons and tons of changes: - changed to use the new virtual function parameters. - removed zillions of gdisplay_untransform_coords(). - get the active drawable's offsets manually in many cases. (questionable, but IMHO ok because it's obvious and not simply a "TRUE" passed to some function) - reordered some functions to be consistent across tools. - some tools had to be changed to work on image coords, not display ones (esp. crop). - fixed strange rotate tool behaviour which should be backported to stable. - some stuff i came across. - indentation and other paranoia. - rounding of coordinated may be broken in some tools. - new bugs guaranteed. * app/tools/tool_manager.[ch]: new semantic of tool_manager_initialize_active() (looked at the places where it was used from and put common code together). Should be a bit better now :) * app/tools/gimpblendtool.c * app/tools/transform_options.c: use the new GTK+ feature that a widget (toggle button) can be a frame's title for this tools' tool options. * app/widgets/widgets-types.h: stuff. * themes/Default/gtkrc: s/GtkDialog/GimpDialog/. * tools/pdbgen/Makefile.am: don't scan tools/gimpbucketfilltool.h any more. * tools/pdbgen/enums.pl: regenerated. * tools/pdbgen/pdb/tools.pdb: changed bucket_fill wrapper. * app/pdb/tools_cmds.c: regenerated. |
|
|
Michael Natterer
|
d162376d47 |
app/display/Makefile.am app/display/gimpdisplay-callbacks.[ch]
2001-11-01 Michael Natterer <mitch@gimp.org> * app/display/Makefile.am * app/display/gimpdisplay-callbacks.[ch] * app/display/gimpdisplay-render.[ch] * app/display/gimpdisplay-scale.[ch] * app/display/gimpdisplay-scroll.[ch]: removed and added as gimpdisplayshell-foo.[ch] because they are all methods of the shell. * app/display/gimpdisplay.[ch] * app/display/gimpdisplayshell.[ch]: moved the "offset" and "size" variables from GimpDisplay to GimpDisplayShell. GimpDisplay should know nothing about screen coordinates. The gdisplay_[un]transform_foo() methods are still part of GimpDisplay but will be moved to GimpDisplayShell as soon as the tools' vitrual functions speak in image coordinates instead of GdkEvents. * app/display/gimpdisplayshell-callbacks.[ch]: prefixed all functions with gimp_display_shell_*. Moved some stuff to a "realize" callback File still has to be renamed. * app/display/gimpdisplay-foreach.[ch]: removed gdisplays_shrink_wrap(). * app/gui/menus.c * app/gui/view-commands.[ch] * app/display/gimpdisplayshell-scale.[ch]: implemented "Zoom to Fit Window" function (#57670). * app/nav_window.c * app/display/gimpdisplay-handlers.c * app/display/gimpdisplayshell-render.[ch] * app/display/gimpdisplayshell-scale.[ch] * app/display/gimpdisplayshell-scroll.[ch] * app/gui/colormap-dialog.c * app/gui/gui.c * app/gui/preferences-dialog.c * app/tools/gimpmagnifytool.c * app/tools/gimpmovetool.c * app/widgets/gimppreview.c: changed according to variable and filename changes. * app/tools/tool_manager.c: tool_manager_select_tool(): send the active tool a "HALT" command before selecting the new one. Fixes stale tool dialogs which were there because some other hack was removed (This is IMHO the right place to shut down the active tool). * app/tools/gimpcroptool.c: don't shrink wrap after cropping but let gimprc.allow_resize_windows decide. * app/tools/gimpselectiontool.c: gimage_mask_value() takes image, not screen coordinates. A good example of how braindead it is to pass GdkEvents to tools :-) Fixes incorrect cursor and oper update of the selection tools. * app/tools/gimptransformtool.c * app/undo.c: removed (#if 0 for now) some strange code which did manual exposing of GimpDisplayShell areas. This was definitely a hack and should not be there given the image emits correct "update" signals. |
|
|
Michael Natterer
|
cbce339039 | fscking broken pipe... | |
|
Michael Natterer
|
99e78c7074 |
General cleanup of the selection tools and their PDB wrappers:
2001-10-22 Michael Natterer <mitch@gimp.org> General cleanup of the selection tools and their PDB wrappers: * app/core/Makefile.am * app/core/gimpimage-contiguous-region.[ch] * app/core/gimpimage-mask-select.[ch]: new files providing a clean, uniform API for the selection functionalities. Changed order of parameters to be consistent, removed code duplication. The region returned by the "by_color" function is not really contiguous but the API is so similar to "by_seed" and it's used in the same context so it's fair enough to put them together. Also, I'm not sure if the two is_pixel_sufficiently_different() I've optimized away were meant to do *exactly* the same. Added a comment there to remember the former difference. * app/core/gimpchannel.[ch] (gimp_channel_feather): removed the "output" channel parameter and made it optionally push an undo (like the other channel operations do). * app/core/gimpimage-mask.c: call gimp_channel_feather() with "push_undo == TRUE", removed some useless comments. * app/tools/gimpbycolorselecttool.[ch] * app/tools/gimpellipseselecttool.[ch] * app/tools/gimpfreeselecttool.[ch] * app/tools/gimpfuzzyselecttool.[ch] * app/tools/gimprectselecttool.[ch]: removed all the actual selection functionality and call the new gimp_image_mask_select_*() and gimp_image_contiguous_region_*() functions instead. * app/tools/gimpbezierselecttool.c * app/tools/gimpiscissorstool.c: use new function gimp_image_mask_select_channel() instead of doing the same manually. * app/tools/gimpbucketfilltool.c: find_contiguous_region() -> gimp_image_contiguous_region_by_seed(). * tools/pdbgen/Makefile.am * tools/pdbgen/groups.pl * tools/pdbgen/pdb/selection_tools.pdb: added new group "Selection Tools" which depends only on "core/" stuff (not on "tools/" any more, brrrr). * tools/pdbgen/pdb/text_tool.pdb: don't include "appenv.h" * tools/pdbgen/pdb/tools.pdb: removed the selection tools. * app/pdb/Makefile.am * app/pdb/selection_tools_cmds.c: new file. * app/pdb/internal_procs.c * app/pdb/text_tool_cmds.c * app/pdb/tools_cmds.c: regenerated. * libgimp/Makefile.am * libgimp/gimp_pdb.h * libgimp/gimpselectiontools_pdb.[ch]: new files. * libgimp/gimptools_pdb.[ch]: regenerated Misc cleanups: * app/app_procs.c: call splash_create() with "no_splash_image" as parameter. * app/display/gimpdisplay-render.c * app/display/gximage.c: don't include "appenv.h". * app/gui/gui.c: call session_restore() only if "restore_session" is TRUE. * app/gui/session.c: don't "if(restore_session)" here and don't include "appenv.h" * app/gui/splash.[ch]: added "gboolean show_image" parameter to splash_create(), don't include "appenv.h" * app/tools/gimppainttool.[ch]: added a "GimpGradient" parameter to gimp_paint_tool_get_color_from_gradient(). * app/tools/gimppaintbrushtool.c: pass the gradient. * app/tools/gimpselectiontool.c * app/tools/gimptransformtool.c * app/tools/tool_manager.c: s/GDisplay/GimpDisplay/. * app/widgets/gimpcontainergridview.[ch]: removed the "white_style" class variable and don't fiddle around with colors and styles... * themes/Default/gtkrc: ...do the same here with a simple rc style. |
|
|
Michael Natterer
|
f235eabbf1 |
app/Makefile.am app/disp_callbacks.[ch] app/gdisplay.[ch]
2001-09-26 Michael Natterer <mitch@gimp.org> * app/Makefile.am * app/disp_callbacks.[ch] * app/gdisplay.[ch] * app/gdisplay_ops.[ch] * app/gximage.[ch] * app/image_render.[ch] * app/interface.[ch] * app/marching_ants.h * app/scale.[ch] * app/scroll.[ch] * app/selection.[ch]: removed. * app/display/Makefile.am * app/display/display-types.h * app/display/gimpdisplay-callbacks.[ch] * app/display/gimpdisplay-marching-ants.h * app/display/gimpdisplay-ops.[ch] * app/display/gimpdisplay-render.[ch] * app/display/gimpdisplay-scale.[ch] * app/display/gimpdisplay-scroll.[ch] * app/display/gimpdisplay-selection.[ch] * app/display/gimpdisplay.[ch] * app/display/gimpdisplayshell.[ch] * app/display/gximage.[ch]: added here. * app/[many files] * app/gui/[many files] * app/tools/* * app/widgets/[many files]: changed accordingly. Still very incomplete separation of the display stuff but it at least compiles. * tools/pdbgen/pdb.pl: * tools/pdbgen/pdb/display.pdb: s/GDisplay/GimpDisplay/, s/"gdisplay.h"/"display/gimpdisplay.h"/. * app/pdb/display_cmds.c: regenerated. |
|
|
Michael Natterer
|
e2daae315b |
an evil temp_hack which lets GimpContext managing the active display
2001-08-14 Michael Natterer <mitch@gimp.org> * app/gdisplay.h: an evil temp_hack which lets GimpContext managing the active display withoug including "gdisplay.h". Will go away as soon ad context properties are registered dynamically. * app/module_db.c: cleaned up the object code in preparation of moving it to core/. * app/path.c: connect to GimpImage's * app/core/gimpobject.[ch]: derive it from GObject, not from GtkObject any more (yeah :-) * app/core/*.c: #include <glib-object.h> instead of <gtk/gtk.h>, removed some remaining GtkObject-isms. (left in a few #include <gtk/gtk.h> where bigger changes are needed to get rid of the UI dependency). * app/core/core-types.h: #include <gdk-pixbuf/gdk-pixbuf.h> here temporarily. * app/core/gimp.c (gimp_create_display): unref the image after creating it's first display. * app/core/gimpbrush.[ch]: disabled the parts of the code which depend on GimpPaintTool. * app/core/gimpbrushgenerated.c * app/core/gimpbrushpipe.c: changed accordingly. * app/core/gimpcontext.[ch]: evil hack (see above) to manage the active display without including "gdisplay.h" * app/core/gimpimage-mask.[ch]: pass a context to gimage_mask_stroke() and get the current tool's PDB string from there. * app/core/gimpedit.c: changed accordingly. * app/core/gimpimage.c: use gimp_image_update() instead of gdisplays_update_full(). * app/gui/color-area.c * app/gui/colormap-dialog.c * app/gui/dialogs-constructors.c * app/gui/edit-commands.c * app/gui/image-commands.c * app/gui/toolbox.c: changed accordingly (don't use Gtk methods on GObjects). * app/gui/menus.c: fix some const warnings by explicit casting. * app/tools/*.[ch]: ported all tools to GObject, some minor cleanup while i was on it. * app/widgets/gimpdialogfactory.[ch]: ported to GObject. * app/widgets/gimplayerlistview.h: added FOO_GET_CLASS() macro. * tools/pdbgen/app.pl: added a "widgets_eek" hack like "tools_eek" which inserts #include "widgets/widgets-types.h" before ordinary includes. * tools/pdbgen/pdb/brush_select.pdb * tools/pdbgen/pdb/edit.pdb * app/pdb/brush_select_cmds.c * app/pdb/edit_cmds.c: changed according to the stuff above. |
|
|
Michael Natterer
|
0cbbef4025 |
app/Makefile.am removed. Stuff now lives in app_procs.[ch] and in
2001-05-13 Michael Natterer <mitch@gimp.org> * app/Makefile.am * app/cursorutil.[ch]: removed. Stuff now lives in app_procs.[ch] and in widgets/gimpcursor.[ch] * app/appenv.h: added the "gimp_busy" boolean. * app/app_procs.[ch]: added the "busy" stuff here. * app/gui/gui.[ch]: "busy" stuff for the gui. * app/widgets/Makefile.am * app/widgets/gimpcursor.[ch]: exports only one function: gimp_cursor_new() which returns a GdkCursor which has to be destroyed. * app/apptypes.h * app/appenums.h: removed the cursor types. * app/widgets/widgets-types.h: added here. * app/tools/gimpeditselectiontool.[ch]: added gtkutil_compress_motion() here (will go to some utils file in widgets/). * app/tools/tools-types.h: #include "widgets/widgets-types.h" * app/dialog_handler.c * app/disp_callbacks.c * app/gdisplay.[ch] * app/nav_window.c * app/scroll.c * app/xcf.c * app/core/gimpimage-convert.c * app/core/gimpimage-duplicate.c * app/core/gimpimage.c * app/gui/file-open-dialog.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpcroptool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimptransformtool.c * tools/pdbgen/pdb/image.pdb * app/pdb/image_cmds.c: use the new cursor and "busy" functions. * app/gdisplay.h * app/core/gimpbrush.c: added some ugly cross-includes. * app/context_manager.c * app/gdisplay_ops.c * app/gimprc.c * app/core/gimpdrawable-offset.c * app/gui/file-save-dialog.c * app/gui/gradient-editor.c * app/gui/preferences-dialog.c * app/tools/gimpbezierselecttool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcolorpickertool.c * app/tools/gimperasertool.c * app/tools/gimpfliptool.c * app/tools/gimpinktool.c * app/tools/gimpiscissorstool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimprectselecttool.c * app/tools/gimprotatetool.c * app/tools/gimpselectiontool.c: removed inclusion of "cursorutil.h" |
|
|
Michael Natterer
|
d1022c34b6 |
app/Makefile.am removed.
2001-05-10 Michael Natterer <mitch@gimp.org> * app/Makefile.am * app/asupsample.[ch]: removed. * app/core/Makefile.am * app/core/core-types.h * app/tools/Makefile.am * app/tools/tools-types.h: new files. * app/tools/gimptoolinfo.[ch]: removed. * app/core/gimptoolinfo.[ch]: added here. * libgimp/Makefile.am * libgimp/gimp.h * libgimp/gimpadaptivesupersample.[ch] * libgimp/gimpbilinear.[ch]: removed here... * libgimpcolor/Makefile.am * libgimpcolor/gimpcolortypes.h * libgimpcolor/gimpadaptivesupersample.[ch] * libgimpcolor/gimpbilinear.[ch]: ..and added here. * tools/pdbgen/app.pl * tools/pdbgen/pdb/paths.pdb * app/*.c: changed tons of #include's |
|
|
Michael Natterer
|
8985b107c3 |
configure.in added new directory app/core/ for the core object system.
2001-05-09 Michael Natterer <mitch@gimp.org> * configure.in * app/Makefile.am: added new directory app/core/ for the core object system. * app/gimage_mask.[ch] * app/gimpbrush-header.h * app/gimpbrush.[ch] * app/gimpbrushgenerated.[ch] * app/gimpbrushpipe.[ch] * app/gimpchannel.[ch] * app/gimpcontainer.[ch] * app/gimpcontext.[ch] * app/gimpdata.[ch] * app/gimpdatafactory.[ch] * app/gimpdatalist.h * app/gimpdrawable-desaturate.[ch] * app/gimpdrawable-equalize.[ch] * app/gimpdrawable-invert.[ch] * app/gimpdrawable-offset.[ch] * app/gimpdrawable-preview.[ch] * app/gimpdrawable.[ch] * app/gimpgradient.[ch] * app/gimpimage-convert.[ch] * app/gimpimage-duplicate.[ch] * app/gimpimage-undo.[ch] * app/gimpimage.[ch] * app/gimplayer.[ch] * app/gimplayermask.[ch] * app/gimplist.[ch] * app/gimpmarshal.[ch] * app/gimpobject.[ch] * app/gimppalette-import.[ch] * app/gimppalette.[ch] * app/gimppattern-header.h * app/gimppattern.[ch] * app/gimpundo.[ch] * app/gimpundostack.[ch] * app/gimpviewable.[ch]: removed these files... * app/core/*: ...and added them here. * app/*.c * app/gui/*.c * app/pdb/*.c * app/tools/*.c * app/widgets/*.c * plug-ins/common/gbr.c * plug-ins/common/gih.c * plug-ins/common/pat.c * po/POTFILES.in * tools/pdbgen/Makefile.am * tools/pdbgen/enums.pl * tools/pdbgen/pdb.pl * tools/pdbgen/pdb/*.pdb: changed accordingly. |
|
|
Michael Natterer
|
5362220ba1 |
app/tools/Makefile.am new files ported by Dave Neary <dneary@eircom.net>.
2001-03-02 Michael Natterer <mitch@gimp.org> * app/tools/Makefile.am * app/tools/gimpselectiontool.[ch]: new files ported by Dave Neary <dneary@eircom.net>. Changed them a bit to inherit from GimpDrawTool and added implementations of "modifier_key" and "oper_update" because they are shared by 4 of the old selection tools. |