Commit Graph

52 Commits

Author SHA1 Message Date
Massimo Valentini d3e68fc995 plug-ins: don't crash loading a transparent indexed png
with no text chunk, in that case 'i' == tile_height and

*** glibc detected *** ...2.0/plug-ins/file-png:
  double free or corruption (out): 0x00000000011af590 ***
2012-07-09 18:04:08 +02:00
Simon Budig a13765e2a7 remove obsolete workaround for gegl 2012-05-03 01:16:21 +02:00
Simon Budig ab1bf6fcee clean up png plugin some more. 2012-05-02 17:51:22 +02:00
Simon Budig 87abc72832 file-png: use gegl iterators for some of the code 2012-05-02 17:51:21 +02:00
Simon Budig 7f45819202 ==== remove obsolete warning ==== 2012-05-02 17:51:21 +02:00
Simon Budig 641848ea0b Fix the palette handling in gimp_drawable_get_format() 2012-05-02 17:51:21 +02:00
Simon Budig 1549dd00ba file-png: implement PNG indexed saving/loading 2012-05-02 17:51:20 +02:00
Simon Budig 89113fed51 code formatting fixes, some simplifications 2012-05-02 17:51:18 +02:00
Simon Budig 64ad69e331 first shot at GEGL-based png-save 2012-05-02 17:51:18 +02:00
Simon Budig 5edf1b1972 first shot at PNG loading with GEGL
Doesn't work yet for 16bit PNGs, there is a weird crash in libgimp
but I didn't do anything...

This closely follows the old pixel region based code, which might
be suboptimal for gegl, but has the advantage of keeping metadata intact.

Indexed currently is disabled, needs resurrecting.
2012-05-02 17:51:17 +02:00
Massimo Valentini 257224ff99 Bug 674024: Store in .png does not compress
The slider did not always show the values effectively used
2012-04-14 18:39:49 +02:00
Ville Sokk f07b9606d8 Bug 658610 - Warn when importing PNG images with an offse
Added a dialog about offsets to the PNG loader
2012-02-12 20:49:52 +01:00
Mukund Sivaraman e78ea68f69 file-png: Display a readable string when error message is unavailable 2011-12-06 20:48:09 +05:30
Mukund Sivaraman e410fe09e7 file-png: Mark string for translation 2011-12-06 20:47:37 +05:30
Mukund Sivaraman f40453be3c file-png: Remove redundant assignment 2011-10-11 10:22:24 +05:30
Mukund Sivaraman e0298effdf file-png: Move comment to correct function 2011-10-11 10:22:00 +05:30
Mukund Sivaraman 5769acd3db file-png: Add comments about the struct checks 2011-09-27 19:22:50 +05:30
Mukund Sivaraman ff2b9ee727 file-png: Return correct type of error value 2011-09-21 17:16:54 +05:30
Mukund Sivaraman 1ac6c7b85c file-png: Check that PNG structs are created properly
If there's a version mismatch between compiled version (header) and
installed shared libpng library, structs are not created and NULL is
returned.
2011-09-21 17:08:56 +05:30
Mukund Sivaraman 5b999ab3f9 file-png: Indent some code 2011-05-06 19:33:46 +05:30
Mukund Sivaraman ae654a7aae file-png: Update comment for png_set_IHDR() 2011-05-05 20:47:53 +05:30
Mukund Sivaraman fbbeb8d629 file-png: Call png_set_*() functions after png_set_IHDR() 2011-05-05 20:36:45 +05:30
Mukund Sivaraman dbecc7b705 file-png: Move setting the comment text after IHDR is set 2011-05-05 20:15:02 +05:30
Mukund Sivaraman 4fa2bbabf9 file-png: Specify the interlace type explicitly 2011-05-05 18:53:11 +05:30
Mukund Sivaraman 5b5d88a2f1 file-png: Get num_colors properly before passing it on 2011-04-26 15:18:27 +05:30
Mukund Sivaraman 92684a25e9 file-png: Don't access inside PNG structs directly (contd.) 2011-04-26 08:06:27 +05:30
Mukund Sivaraman a1c7606d51 file-png: Conditionally declare text_length 2011-04-25 20:15:39 +05:30
Mukund Sivaraman f610aa4375 file-png: Don't access inside PNG structs directly 2011-04-25 20:15:39 +05:30
Mikael Magnusson 8ff66342b8 plug-ins: set progress to 1.0 when done 2011-04-10 19:28:43 +02:00
Michael Natterer 8c4d99f883 Bug 645456 - Inconsistent window (role) naming scheme
Applied patch from Christoph Kappel which adds a "gimp-" prefix to all
plug-in dialog window roles.
2011-04-08 20:31:34 +02:00
Michael Natterer bb6436cb44 libgimp: deprecate and rename the global pararasite functions
just as it was done for items and images. Remove the "parasite" PDB
group completely.
2011-03-08 14:31:04 +01:00
Michael Natterer 87646e9ace libgimp: deprecate and rename the image parasite functions
in exactly the way the drawable functios were turned into item ones.
2011-03-08 13:19:21 +01:00
Omari Stephens ed872c7c6e Bug 599065 - PNG output: omit unwanted chunks (sRGB)
If the image has neither a gamma set nor a color profile set, then we
should leave the image untagged. We should not tag as sRGB by default
because it is too arbitrary.
2011-02-02 08:34:39 +01:00
Michael Natterer bbd7ec6b5c plug-ins: port from gimp_image_add_foo() to gimp_image_insert_foo()
I'm sure some plug-ins need to add their items *not* at the toplevel,
but since making plug-ins really tree-aware is a lot more work than
just fixing insert positions, I went for passing -1 as parent in
almost all cases. And because of laziness...
2010-09-06 11:40:46 +02:00
Sven Neumann ff221e679c Bug 624275 - Image saved from google docs generates a 'gimp-image-set-resolution' error message
Only set the image resolution if the resolution in the PNG file
is greater than zero.
2010-07-13 22:20:15 +02:00
Michael Natterer d2406fd4c3 plug-ins: move the UI file to datadir/ui/plug-ins/plug-in-file-png.ui 2010-01-12 22:02:51 +01:00
Sven Neumann 9317bb4548 plug-ins: fix error reporting and a compiler warning 2010-01-12 21:12:40 +01:00
Martin Nordholts 7c32f5442a plug-ins: Check for errors when loading file-png.ui
Check for errors when loading file-png.ui. Still continue execution
though even if an error occurs, because the user can still export.
2010-01-09 20:03:58 +01:00
Martin Nordholts 0abf5cc4f0 Use Glade + GtkBuilder for file-png.c save_dialog()
To give us experience with Glade + GtkBuilder, use it for the save
dialog in the PNG plug-in. The layout is as good as
identical. Mnemonics still works and strings are still translated.
2010-01-08 21:16:10 +01:00
Michael Natterer 018e8b0d29 Build with GSEAL_ENABLE and #undef it where accessors are missing 2009-10-17 20:31:57 +02:00
Martin Nordholts 19fe919dce plug-ins: Port file plug-ins to new export API 2009-07-21 16:03:58 +02:00
Massimo Valentini 65c21b6bc3 Bug 567466 – PNG comment not found if more than 1 tEXt chunks
Fix an oversight: only the first tEXt chunk of a PNG was considered,
though repeatedly, when looking for the comment.
2009-07-16 22:24:59 +02:00
Michael Natterer e805cb0cf4 Use gtk_dialog_get_content_area() instead of dialog->vbox 2009-07-15 18:57:12 +02:00
Michael Natterer 4ea1437646 plug-ins/common/*.c plug-ins/color-rotate/color-rotate.c
2009-01-19  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/*.c
	* plug-ins/color-rotate/color-rotate.c
	* plug-ins/file-bmp/bmp.c
	* plug-ins/file-faxg3/faxg3.c
	* plug-ins/file-fits/fits.c
	* plug-ins/file-fli/fli-gimp.c
	* plug-ins/file-ico/ico.c
	* plug-ins/file-jpeg/jpeg.c
	* plug-ins/file-psd/psd-save.c
	* plug-ins/file-psd/psd.c
	* plug-ins/file-sgi/sgi.c
	* plug-ins/file-uri/uri.c
	* plug-ins/file-xjt/xjt.c
	* plug-ins/flame/flame.c
	* plug-ins/fractal-explorer/fractal-explorer.c
	* plug-ins/gfig/gfig.c
	* plug-ins/gimpressionist/gimp.c
	* plug-ins/gradient-flare/gradient-flare.c
	* plug-ins/help-browser/help-browser.c
	* plug-ins/ifs-compose/ifs-compose.c
	* plug-ins/imagemap/imap_main.c
	* plug-ins/lighting/lighting-main.c
	* plug-ins/map-object/map-object-main.c
	* plug-ins/maze/maze.c
	* plug-ins/metadata/metadata.c
	* plug-ins/pagecurl/pagecurl.c
	* plug-ins/print/print.c
	* plug-ins/pygimp/gimpfu.py
	* plug-ins/script-fu/script-fu-script.c
	* plug-ins/script-fu/script-fu.c
	* plug-ins/selection-to-path/selection-to-path.c
	* plug-ins/twain/twain.c
	* plug-ins/win-snap/winsnap.c: document the "run-mode" parameter
	as we document enums for core procedures.


svn path=/trunk/; revision=27922
2009-01-19 20:11:36 +00:00
Michael Natterer d9b5207aa2 Change licence to GPLv3 (and to LGPLv3 for libgimp).
2009-01-17  Michael Natterer  <mitch@gimp.org>

	* all files with a GPL header and all COPYING files:

	Change licence to GPLv3 (and to LGPLv3 for libgimp).

	Cleaned up some copyright headers and regenerated the parsers in
	the ImageMap plugin.


svn path=/trunk/; revision=27913
2009-01-17 22:28:01 +00:00
Sven Neumann 91189b62b2 reverted last change, it was bogus.
2008-12-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-png.c: reverted last change, it was 
bogus.


svn path=/trunk/; revision=27808
2008-12-17 19:33:30 +00:00
Sven Neumann a6f377dd02 use a tile cache to optimize pixel access.
2008-12-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-png.c (load_image) (save_image): use a 
tile
	cache to optimize pixel access.


svn path=/trunk/; revision=27805
2008-12-17 19:23:25 +00:00
Sven Neumann edabd739d4 plug-ins/common/file-pnm.c plug-ins/common/file-ps.c for the most common
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-pnm.c
	* plug-ins/common/file-ps.c
	* plug-ins/common/file-psp.c: for the most common errors, pass 
the
	error message with the return values instead of calling
	gimp_message().


svn path=/trunk/; revision=26639
2008-08-18 06:53:21 +00:00
Sven Neumann 592d59765e plug-ins/common/file-mng.c for the most common errors, pass the error
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-mng.c
	* plug-ins/common/file-pcx.c: for the most common errors,
	pass the error message with the return values instead of calling
	gimp_message().

	* plug-ins/common/file-gif-save.c
	* plug-ins/common/file-pdf.c
	* plug-ins/common/file-png.c: minor cleanup.


svn path=/trunk/; revision=26638
2008-08-18 06:31:03 +00:00
Sven Neumann ad828a0301 plug-ins/common/file-gif-load.c for the most common errors, pass the error
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-gif-load.c
	* plug-ins/common/file-gif-save.c: for the most common errors,
	pass the error message with the return values instead of calling
	gimp_message().

	* plug-ins/common/file-png.c: unmarked a string for translation.
	This error condition can't possibly happen.

	* plug-ins/common/file-svg.c: also return an error message when
	the thumbnail can't be loaded.


svn path=/trunk/; revision=26636
2008-08-17 21:30:34 +00:00