Wed Apr 15 01:58:12 EDT 1998 Matthew Wilson <msw@gimp.org>
* app/gdisplay.c: made a change to gdisplays_update_area to
update _all_ gdisplays that point at the gimage ID. This
(should) fix the paint on the second layer of a second view bug.
--Matt
Tue Apr 14 18:01:50 EDT 1998 Matthew Wilson <msw@gimp.org>
* app/gdisplay.c: Set active_tool->drawable to NULL when destroying
the gdisplay that the active tool points to.
* app/giamge.c: Fixed spacing...
--Matt
* gimp_tips.txt: applied gimp-quinet-980414-0; adds new tips
* plug-ins/pagecurl/pagecurl.c: applied gimp-quinet-980414-1;
defines M_PI
* app/app_procs.c: applied gimp-quinet-980414-2; adds more
information to the startup screen
* app/gradient.c: applied gradient-041398-seth; fixes the
behavior that the gradient editor would become insensitive
forever if the color selection dialog were close
* app/regex.c
* plugins/script-fu/regex.c: partially applied
gimp-jbuhler-980412-0; adds braces to nested if/else
--Sven
so cancelling the dialog should work correctly. There might be a problem,
because now named_edit_cut() and named_edit_copy() always return TRUE.
Before they returned FALSE when there was nothing to copy (tiles==NULL).
However I had no problems at all when testing my code....
--Sven
setting the paste functions insensitive.
When pasting from the named buffer, a call to gdisplays_flush() was missing.
I originally intended to fix the bug that canceling the cut-named-function
doesn't work. But it appears that there's no way to check if the
Cancel-button was hit in the query_string_box?!
--Sven
Mon Apr 13 00:41:50 EDT 1998 Matthew Wilson <msw@gimp.org>
* app/command.c: Duh. We have a message_box. Why not use it for
the prefs code.
--Matt "reinvent the wheel" Wilson
Mon Apr 13 00:27:45 EDP 1998 Matthew Wilson <msw@gimp.org>
* app/gdisplay.c: Set the current tool's gdisplay pointer to NULL
when destroying a gdisplay
* app/interface.c: Use "clicked" as the signal to handle for menu
based tools. This lets us pop by_color_select back up.
--Matt
Removed the systemwide palettes directory from the palettes searchpath.
I still think we should overwork the gradients and palettes functions to
distinct between files that can be changed and those that are not writeable.
Probably for 1.1 ??
--Sven
* configure.in: I guess it didn't end... an attempt to try to recognize all
types of tiff configs
* app/gdisplay_ops.c: resize on zoom fix for naught window positioning from
Kevin Cozens <kcozens@interlog.com>
* app/errors.c: gdk_exit needs to be prototyped
-Yosh
* configure.in: more fixes... when will it all end...
* plug-ins/xd/xd.c: compile with >= 0.15 now
* app/transform.[ch]: applied gimp-alt-980412, fixes control point selection
for transforms
-Yosh
* app/gdisplay.c: reverted cosmetic fix below, broke zoomed updates
* configure.in: changes to xdelta and jpeg checks
* updated bmp plugin
* portability patch for polar
* minor bugfix to vpropagate
* fix for memory problem in xwd
-Yosh
* app/app_procs.c: fixed up idle handler for file open (look like testgtk
idle demo)
* app/colomaps.c: fixup for visual test and use of gdk_color_alloc for some
fixed colors (from Owen Taylor)
* app/errors.h
* app/errors.c
* app/main.c
* libgimp/gimp.c: redid the signal handlers so we only get a debug prompt on
SIGSEGV, SIGBUS, and SIGFPE.
* applied gimp-jbuhler-980408-0 and gimp-joke-980409-0 (warning fixups)
* applied gimp-monnaux-980409-0 for configurable plugin path for multiarch
setups
-Yosh
Fri Apr 10 00:17:23 EDT 1998 Matthew Wilson <msw@gimp.org>
* app/commands.c: Fixed (hopefully) the preferences code. Added
a warning to restart GIMP for those changes that require restarts.
--Matt
Thu Apr 9 02:53:14 EST 1998 Matthew Wilson <msw@gimp.org>
* app/app_procs.c: Added a little wrapper when loading files from
command line that loads the files after gtk_main starts. This
fixes the segfault from the tips dialog when you load images on
the command line. Cudos to Owen for the fix.
--Matt "owen scares me with his GTK+ knowledge" Wilson
* configure.in: redid libjpeg check to make sure old versions aren't used.
Also #undef PACKAGE and VERSION since some jconfig.h's define it
* updated included regex.[ch] to the one in GNU grep
* plug-ins/script-fu/interp_regex.c: we don't need to kludge around OSF1
anymore, since we use our own regex stuff
-Yosh
random() and add -lucb on systems that need it. Fix for xdelta.h check. Find
xemacs as well as emacs. Properly define settings for print plugin.
app/Makefile.am: ditch -DNDEBUG, since nothing uses it
flame: properly handle random() and friends
pnm: workaround for systems with old sprintfs
print, sgi: fold back in portability fixes
threshold_alpha: properly get params in non-interactive mode
bmp: updated and merged in
-Yosh
* app/bezier_select.c: Destroy the tool when changing displays.
* app/command.c: initialize pointers to drawables when selecting
tools
* app/disp_callbacks.c: initialize pointers to drawables on first
click of a gdisplay
* app/gimage.c: removed extra tool destruction
* app/tools.c: make a fallback case when starting tools so that
you'll always have an active tool.
--Matt
added it twice, once under <Image>->Layers and additionally under
<Image>->Image->Alpha
Now it is possible to work on a single-layer image without opening the
Layers-dialog for adding an alpha channel.
--Sven
Thu Apr 2 04:06:50 EST 1998 Matthew Wilson <msw@gimp.org>
* app/disp_callbacks.c: Always ungrab the pointer on button release.
This is a quick and dirty hack to try to nuke the pointer grab
bug.
Thu Apr 2 01:49:34 EST 1998 Matthew Wilson <msw@gimp.org>
* app/transform_core.c: added a change to make a note of the
current drawable in the button_release. This prevents the tool
from being restarted when the transform_core makes a floating
selection.
* app/tools.c: Initialize the current drawable to NULL if
there is gdisp == NULL.
--Matt
* app/brightness_contrast.c
* app/by_color_select.c
* app/color_balance.c
* app/color_picker.c
* app/curves.c
* app/histogram_tool.c
* app/hue_saturation.c
* app/levels.c
* app/posterize.c
* app/threshold.c
* app/transform_core.c: modified to call the cancel callback
instead of the ok callback when freed. modified to save the
last used drawable so that we might be able to check later
and restart the tool if need be.
* app/disp_callbacks.c
* app/gimage.c: modified tool restart/destruction code
* app/tools.c
* app/tools.h: added tools_initialize, made changes to
be able save the last used drawable in the tool.
--Matt
I will hopefully finish my changes to the dialog tonight and will upload a
new version of my patch. Could you (the core developers) please make up your
mind whether to include it in 1.0 or not...
The Blend-Tool dialog now changes the repeat_mode_menu to insensitive when
the Gradient-Type is one of the Shapeburst-types.
--Sven
Wed Apr 01 04:07:29 EST 1998 Matthew Wilson <msw@gimp.org>
* app/disp_callbacks.c: Only destroy the current tool if you change
gdisplays and the tool caches image data.
--Matt "flood the commits-list" Wilson
Wed Apr 01 03:40:15 EST 1998 Matthew Wilson <msw@gimp.org>
* app/disp_callbacks.c: If the current gdisp->ID does not match
the ID of the gdisp_ptr in the active_tool, restart it.
--Matt "I need sleep" Wilson
Tue Mar 31 03:10:12 EST 1998 Matthew Wilson <msw@gimp.org>
* app/iscissors.c: Set tool->preserve to TRUE in tools_new_iscissors.
--Matt "forgets files when committing" Wilson
Tue Mar 31 02:21:15 EST 1998 Matthew Wilson <msw@gimp.org>
* app/gimage.c
* app/tools.c
* app/tools.h: Added a field in the Tools struct, preserve.
During gimage_dirty, if this flag is not set the tool will be
reset. This is good for tools that keep a copy of the image
in cache for local manipulation like transform_core.
* app/bezier_select.c
* app/blend.c
* app/brightness_contrast.c
* app/bucket_fill.c
* app/color_balance.c
* app/color_picker.c
* app/crop.c
* app/curves.c
* app/ellipse_select.c
* app/free_select.c
* app/histogram_tool.c
* app/hue_saturation.c
* app/levels.c
* app/move.c
* app/paint_core.c
* app/posterize.c
* app/rect_select.c
* app/text_tool.c
* app/transform_core.c: Set the preserve flag to the correct
values in the new functions and wrapped calls to functions that
dirty the gimage to prevent tool restarts.
* app/disp_callbacks.c
* app/menus.c: Removed Nether's tool patch.
--phew. Matt
* app/brush_select.c
* app/iscissors.c: get rid of unused variable warnings
* app/fileops.c: refresh the filesel better
* app/plug_in.c: make sure everything gets initialized to something in the
plug-in struct
-Yosh
This fixes the crashes when closing an image with the by-color-select-dialog
associated to it still open and pressing "Reset" or clicking into the preview.
The checks produce some warnings like
** WARNING **: invalid class type (unknown)' in cast to impDrawable'
when failing, but I consider this less evil than a crash.
There is still a problem: Sometimes the by-color-select-dialog is closed
when the image is closed and can't be opened anymore. Anyone?
--Sven
Fri Mar 27 13:41:55 EST 1998 Matthew Wilson <msw@gimp.org>
* app/floating_sel.c: Always update the drawable when converting
a floating selection to a layer
--Matt
Fri Mar 26 03:13:15 EST 1998 Matthew Wilson <msw@gimp.org>
* app/paint_core.c: Offset brush buffer when painting on edges
of the canvas.
* app/text_tool.c: Set window to auto_shrink = FALSE
-Matt
Fri Mar 26 01:30:45 EST 1998 Matthew Wilson <msw@gimp.org>
* app/iscissors.c
* app/bezier_select.c: Change to select the bezier tool properly
when converting from iscissors to bezier
-Matt
* app/iscissors.c: This version works much better.
outstanding bugs <VERY IMPORTANT>:
1. the edgemap does not seem to be constructed quite right
(construct_edge_map) -- uncomment #define
ISCISSORS_STILL_DOES_NOT_WORK and take a look at the edgemap -- it
will be saved to the file "dump"
2. sigsegvs if the layer offset isn't 0,0. dunno why.
3. convert to bezier still does not work! Any tools experts wanna
help me with it? (it converts to bezier fine, it just doesn't set
the active tool to bezier currectly.)
* app/iscissors.c: fixes the display artifact where the preview
outline of the selected area would not appear or would appear in
the wrong place or have the wrong shape
* iscissors.c: This should hopefully fix most of the UMRs
(uninitialized memory reads) found with Purify. No noticable
change in iscissors's behavior, unfortunately.
* app/app_procs.c app/brush_select.c app/brushes.c
app/brushes.h app/convert.c app/gradient.c app/gradient.h
app/palette.c app/palette.h app/pattern_select.c app/patterns.c
app/patterns.h: Fixed up --no-data so that the various *_init()
routines always get called, and so that when in interactive mode
the data can be loaded by the user even when started with --no-data.
Fixes the blend bug too...
yeah, sven scooped me... but i think this is still a needed patch...
-adrian
started with the --no-data option. This is fixed now. grad_get_color_at()
now returns a totally transparent black when no gradient is present.
Additionally the gradient editor now behaves better when the window is
resized. The resize code is still an ugly hack though.
--Sven
1998-03-25 Federico Mena Quintero <federico@nuclecu.unam.mx>
* app/asupsample.c (adaptive_supersample_area): Removed Sopwith's
"speed optimizations", as they introduced bugs (exposed by using a
high threshold value for supersampling). They weren't much of a
speed improvement, anyway (memcpy on very small regions, etc.).
Also, assuming that all-bytes-zero is a floating-point 0 value is
not portable.
Wed Mar 25 16:22:00 EST 1998 Matthew Wilson <msw@gimp.org>
* app/app_procs.c: now prints messages when starting up --no-splash
* app/gimprc.c: now prints messages when starting up --no-splash
* app/plug-in.c: does not print messages when starting up with
splash screen
* app/fileops.c: refresh the open/save as dialogs upon open
* applied gimp-quinet-980323-0, fixing more M_PI madness
* applied gimp-quinet-980323-1 which fixes redundant inline checks
* plug-ins/gfig/gfig.c: changed stipple to type unsigned char to quell warnings
-Yosh
* configure.in: corrected test for libXmu for some systems; added test for
difftime
* app/main.c: use glib ATEXIT macro
* app/text_tool.c: applied gimp-stric-980321-0 (text preview refresh)
* plug-ins/script-fu/script-fu-console.c: don't need to init gtkpreview stuff,
since we don't use them
* plug-ins/script-fu/*: many portability fixes
* plug-ins/pnm/pnm.c: sprintf portability patch
* plug-ins now #define RAND_MAX if needed
* plug-ins/sparkle/sparkle.c: applied gimp-joke-980322-1
-Yosh
* app/gimage_mask.c
* app/paint_core.c: applied patch from Ben Jackson to fix fractional pixel
errors and reverted the old fix.
* app/paint_funcs.h: changed the #defines for ERASE_MODE and REPLACE_MODE to
correctly match layer_modes[]
-Yosh
Mon Mar 16 21:52:46 CST 1998 Larry Ewing <lewing@gimp.org>
* app/convert.c (indexed_ok_callback): added gimage_ID to the
dialog struct to check if the gimage was still around.
* app/commands.c: fixed border/grow/shrink to check for valid
gimage. (Once again object if you don't like this method).
Mon Mar 16 17:05:54 CST 1998 Larry Ewing <lewing@gimp.org>
* app/commands.c: changed select_feather_cmd_callback to pass the
gimage->ID rather than the gimage to prevent a fatal error. If
you have objections to this speak now.
Mon Mar 16 17:50:56 EST 1998 Adrian Likins <adrian@gimp.org>
* plugins/illusion/illusion.c:
* plugins/papertile/papertile.c:
* plugins/fractaltrace/fractaltrace.c:
* plugins/flame/flame.c: Changed MAIN(); to MAIN()
*gimprc_user: added a commented out (install-colormap)
option
*app/install.c: comsetic update to show info about .gimp/scripts
*plugins/sparkle/sparckle.c:
*plugins/despeckle/despeckle.c: made a local MIN/MAX instead
of redefing the normal one (causes problems on some compilers)
-adrian
Mon Mar 16 05:12:00 CST 1998 Larry Ewing <lewing@gimp.org>
* app/move.c:
* app/gdisplay.c:
* app/gimage.c: Reworked the guide drawing and picking code to
remove all known guide artifacts.
Sun Mar 15 20:39:12 CST 1998 Larry Ewing <lewing@gimp.org>
* app/undo.c (undo_pop_layer_displace): removed what seemed to be
an extra call to drawable_update on the layer, and added a call to
update the layer->mask.
Sun Mar 15 14:50:21 CST 1998 Larry Ewing <lewing@gimp.org>
* app/fileops.c (file_save_as_callback): fixed file Save As
cancel callback to use gtk_signal_connect_object.
Sun Mar 15 02:06:18 CST 1998 Larry Ewing <lewing@gimp.org>
* app/layers_dialog.c: pass layer_ID instead of layer_widget to
rename funtion to prevent dereferencing freed mem. Fixes layer
rename bug.
Sun Mar 15 06:15:37 1998 Tim Janik <timj@gimp.org>
* plug-ins/exchange/exchange.c (doDialog): also destroy the main dialog
if the "Cancel" button is clicked.
* plug-ins/flame/flame.c: use gtk_quit_add_destroy instead of
gtk_quit_add (,gtk_widget_destroy,), i should have really known
better since i wrote gtk_quit_add_destroy() exclusively for the gimp ;)
* app/tips_dialog.c (tips_dialog_create): likewise.
* app/indexed_palette.c (indexed_palette_create): likewise.
* app/fileops.c (file_open_callback): likewise.
* app/fileops.c (file_save_as_callback): likewise.
Sun Mar 15 03:54:58 1998 Tim Janik <timj@gimp.org>
* plug-ins/AlienMap/AlienMap.c: show/hide about dialog, don't affect
the main dialog.
* app/iscissors.c: new, improved, still buggy iscissors!
* app/fileops.c: correctly hide the file selector
* app/transform_core.c: a better fix for the display artifacts
* added aa plugin back in
-Yosh
* updated to use libtool 1.1
* app/transform_core.c: fixed display artifacts for the transform tools, sorta.
* plug-ins/pcx/pcx.c: updated pcx plug-in
and some admistrivia
-Yosh
Now registry and encoding can be choosen in the text tool and
two new pdb-functions are available to access this functionality.
Changed i26-gunya2.scm to make it follow the naming-convention.
--Sven
Fri Mar 13 12:53:22 1998 Tim Janik <timj@gimp.org>
* app/layers_dialog.c: proper destruct at the end of gtk_main().
(layer_widget_delete): unreference the layer widget's list item.
(layers_dialog_free): instead of destroying the menu, sink it since
it is still floating because we didn't attach it to some other widget.
(layers_dialog_free): sink the preview, destroy doesn't work since it's
still floating. wonder what the preview is created for if it is never
used?.
* app/channels_dialog.c (channel_widget_delete): unreference the channel
widget's list item.
* app/channels_dialog.c (channels_dialog_free): sink the menu.
* app/channels_dialog.c (channels_dialog_free): sink the preview.
* app/indexed_palette.c (indexed_palette_create): update the image list
even on initial creation. fixed the option menu warning.
* plug-ins/script-fu/script-fu-console.c (script_fu_browse_callback):
properly destroy the browser when gtk_main() quits.
* plug-ins/dbbrowser/dbbrowser_utils.c (gimp_db_browser): pass a widget
pointer back to our caller, for enabling proper destruction.
* plug-ins/script-fu/script-fu-console.c (script_fu_console_interface):
only destroy the dialog on exit if it is still existing.
fixed buffer overrun in convert.c correctly; the previous "fix" forced
quantization when it wasn't necessary in some cases (and made Adam
very mad). --sg
1998-03-11 Larry Ewing <lewing@discord.isc.tamu.edu>
* app/undo.c
* app/gimage.h
* app/gimage.c: added a simple ref count to the guides so that
undo does not free the too early...
* app/app_procs.c: fix for (install-colormap) and splash screen
using gtk_preview_reset()
* configure.in: on some platforms libXmu doesn't require libSM and
libICE. configure should know this now.
* app/gradient.c: corrected WM_CLASS typo
* plug-ins/gfli/gfli.c: fix for load handler magic
* plug-ins/gtm/gtm.c: don't use naughty gccisms.
* plug-ins/gqbist
* plug-ins/maze: updated from registry
-Yosh
Tue Mar 3 01:02:30 1998 Larry Ewing <lewing@discord.isc.tamu.edu>
* app/scale.c: Fixed a long standing bug in the scale factor
computation so that the scale labels all agree.
1998-02-26 Federico Mena Quintero <federico@nuclecu.unam.mx>
* app/app_procs.c (make_initialization_status_window): Push/pop
correct visuals for drawing area creation.
(splash_logo_load): Use a correct gc.
Sun Feb 22 22:32:56 CST 1998 Francisco Bustamante <pancho@nuclecu.unam.mx>
* pattern_select.c (pattern_select_new): Shrinking no longer
allowed to avoid SIGSEGV
Sun Feb 22 22:07:10 CST 1998 Francisco Bustamante <pancho@nuclecu.unam.mx>
* brush_select.c (brush_select_new): Changed call to gtk_window_set_policy
to avoid shrinking of the dialog as it caused a SIGSEGV when shrinked to
a very small size.
* gimp_splash.ppm: added the splash-screen image drawn
by Jens Lauterbacher to the distribution
* app/appenv.h
* app/app_procs.c
* app/main.c: added the splash-image to the startup-window;
new command-line options: --no-splash, --no-splash-image
* ps_menurc: changed to reflect changes to the
menu-structure
*plug-ins/ edge.c
added a check so it woudlnt segfault when
passed a non-existend drawable
threshold_alpha added a non-interactive mode
*app/brightness_contrast.c
app/color_balance.c
app/colormaps.c
app/curves.c
app/hue_saturation.c
app/posterize.c
app/threshold.c
-added a check so it wouldnt except
a indexed drawable. This was previosly possible via the pdb.
-adrian
Fri Jan 30 13:47:57 1998 Federico Mena <federico@bananoid.nuclecu.unam.mx>
* app/gradient.c: Applied patch from Wolfgang Hofer
<hof@ws6310.gud.siemens.at> to let the user load the segment
endpoint color from the current foreground color. It also makes
the preview un-resizable, which is not a complete fix for the
preview resizing bug.
* updated refract and warp plugins
* changed the INSTALL file to reflect the fact that gtk is a separate package
* app/text_tool.c: small patch for indexed images and antialiased toggle
-Yosh
* Fixed carve-it.scm and circuit.scm (circuit broke due
to a plugin update, carve-it broke due to theadd-layer stuff)
* Added a close button to the color picker info window
* changed index_palette.c a bit...now if you click with
MB11, it changes the current active color, clicking with MB3
opens the color in the color selector for editing
* Made some of the <Image>/Color/* menus sensitive to the image
type (gdisplay.c)
-adrian
CVS:
* app/indexed_palette.c: fix for wrong color selected in indexed
palette dialog
* app/xcf.c: don't crash on bad input (0 byte files)
* app/plug_in.h
* app/plug_in.c: fixes Gimp's most obscure bug. Failed plugin
queries are handle correctly now
* app/commands.c: added marching ants speed to preferences
* plug-ins/tiff/tiff.c: correction for inversion for MINISWHITE
images without alpha
* plug-ins/pcx/pcx.c: updated to new version
* app/paint_funcs.h: changed OPAQUE and TRANSPARENT to
OPAQUE_OPACITY and TRANSPARENT_OPACITY to avoid possible
conflicts. All affects .c files changed.
-Yosh
* ltconfig
* ltmain.sh: downgraded to libtool 1.0f at Jay's suggestion
* app/gimage.c: Fix for the "merge to alpha" bug from Nathan
Summers
* app/text_tool.c: Fix for the font spec bug from Nathan
Summers
* plug-ins/maze/maze.c
* plug-ins/rotate/rotate.c: updated from registry
* plug-ins/blur/blur.c
* plug-ins/randomize/randomize.c
* plug-ins/vpropagate/vpropagate.c
* plug-ins/warp/warp.c: more portability fixes for DEC OSF1
-Yosh
* INSTALL: updated to properly reflect installation procedure
* app/text_tool.c: Fixed bad string in tool description
* libgimp/gimppixelrgn.c: tiles aren't marked dirty in
gimp_pixel_rgn_get_pixel
* plug-ins/edge/edge.c
* plug-ins/edge/emboss.c
* plug-ins/edge/laplace.c
* plug-ins/edge/sobel.c: DEC OSF1 cannont handle reference to
array element with a negative arugment with an unsigned int
(gimp-joke-980108-0)
* plug-ins/sinus/sinus_logo.h: got rid of really long string
* plug-ins/refract/Makefile.am
* plug-ins/refract/refmain.c: fixed megawidget reference
* plug-ins/xpm/xpm.c: made our own case-insenstive strcmp
for checking for transperancy
-Yosh
for more complete functionality.
I actually posted this patch Nov 4, 1997, but it seemed to get lost in
the CVS confusion, so here it is again. The original patch applied
cleanly, so it should be ok.
EDT 1998 Matthew Wilson