2004-08-31 Michael Natterer <mitch@gimp.org>
* app/paint/gimppaintoptions.[ch]: added "GimpPaintInfo *paint_info"
member and construct property. Changed gimp_paint_options_new()
to take only a GimpPaintInfo parameter.
* app/core/gimpitem.c (gimp_item_stroke)
* app/core/gimppaintinfo.c (gimp_paint_info_new): changed accordingly.
* app/core/gimpchannel.c (gimp_channel_stroke)
* app/vectors/gimpvectors.c (gimp_vectors_stroke): use
paint_options->paint_info->paint_type directly instead of casting
to GimpToolOptions and using
tool_options->tool_info->paint_info->paint_type (eek). Fixes crash
when stroking via the PDB because newly created GimpToolOptions
instances have no "tool_info" pointer yet.
* tools/pdbgen/pdb/paint_tools.pdb: changed all paint PDB wrappers
accordingly.
* app/pdb/paint_tools_cmds.c: regenerated.
2004-08-31 Michael Natterer <mitch@gimp.org>
* app/config/gimpconfig.c (gimp_config_iface_duplicate): set
construct_param->foo, not construct_param*s*->foo, so we don't set
the first construct param again and crash.
2004-08-31 Sven Neumann <sven@gimp.org>
* libgimp/gimpuitypes.h
* libgimpwidgets/gimpwidgetstypes.h: moved the GimpDrawablePreview
typedef to the header file that it belongs to.
* libgimp/gimpdrawablepreview.[ch]: minor include cleanups and
gtk-doc fixes.
2004-08-31 Sven Neumann <sven@gimp.org>
* libgimp/Makefile.am
* libgimp/libgimp-docs.sgml
* libgimp/libgimp-sections.txt
* libgimp/libgimp.types
* libgimp/tmpl/gimpdrawablepreview.sgml: updated for
GimpDrawablePreview
* libgimpwidgets/Makefile.am
* libgimpwidgets/libgimpwidgets-include.c: removed this file, it
isn't needed since libgimpwidgets doesn't need to be linked
against libgimp.
* libgimpwidgets/libgimpwidgets-docs.sgml
* libgimpwidgets/libgimpwidgets-sections.txt
* libgimpwidgets/libgimpwidgets.types
* libgimpwidgets/tmpl/gimppreview.sgml: updated for GimpPreview.
2004-08-31 Sven Neumann <sven@gimp.org>
* plug-ins/common/gauss.c (gauss_dialog): update the preview when
the blur radius is being changed. gimp_coordinates_new() seems to
be broken though; there shouldn't be two signal connections needed
here.
2004-08-31 Sven Neumann <sven@gimp.org>
* libgimp/gimpdrawablepreview.[ch]
* libgimpwidgets/gimppreview.[ch]: minor code cleanup, fixes to
gtk-doc comments and to the handling of object properties.
* libgimpwidgets/gimppreview.c
* libgimpwidgets/gimppreview.h: added a GimpPreview widget, abstract
base for a GimpDrawablePreview.
* libgimpwidgets/Makefile.am
* libgimpwidgets/gimpwidgets.h
* libgimpwidgets/gimpwidgetstypes.h: modified accordingly.
* libgimp/gimpdrawablepreview.c
* libgimp/gimpdrawablepreview.h: added a GimpDrawablePreview widget
to ease the use of previews by plug-ins.
* libgimp/Makefile.am
* libgimp/gimpui.h: Changed accordingly.
* plug-ins/common/despeckle.c
* plug-ins/common/gauss.c
* plug-ins/common/neon.c
* plug-ins/common/sobel.c
* plug-ins/common/softglow.c
* plug-ins/common/spread.c
* plug-ins/common/unsharp.c: use a GimpDrawablePreview with these plug-ins.
2004-08-30 Michael Natterer <mitch@gimp.org>
* app/plug-in/plug-in-progress.[ch]: added boolean return values
to plug_in_progress_install(), uninstall() and cancel(). Added
checks to make sure the installed progress_callback exists, has
the correct signature and was installed by this plug-in.
* tools/pdbgen/pdb/progress.pdb: use the return values to let the
PDB wrappers succeed/fail.
* app/pdb/progress_cmds.c: regenerated.
2004-08-30 Sven Neumann <sven@gimp.org>
* plug-ins/common/colortoalpha.c
* plug-ins/common/compose.c
* plug-ins/common/decompose.c
* plug-ins/common/film.c
* plug-ins/fits/fits.c: always use the progress API, not doing it
in non-interactive mode has always been wrong.
2004-08-30 Michael Natterer <mitch@gimp.org>
* libgimp/libgimp-sections.txt
* libgimp/tmpl/gimpplugin.sgml
* libgimp/tmpl/gimpprogress.sgml: moved remaining progress stuff
from "Plug-In" to "Progress".
2004-08-30 Sven Neumann <sven@gimp.org>
* libgimp/gimpbrushmenu.c (gimp_brush_select_preview_draw): fixed
drawing of brushes that extend beyond the preview.
2004-08-30 Sven Neumann <sven@gimp.org>
* app/tools/gimpvectortool.[ch] (gimp_vector_tool_status_set):
avoid excessive use of strdup() and strcmp(). The strings are all
constant anyway.
2004-08-30 Michael Natterer <mitch@gimp.org>
Brought the PDB progress into a working state. Fixes bug #6010,
addressed bugs #97266 and #135185 and unfortunately reopens bug
#150194 (will fix that later).
* libgimpbase/gimpbaseenums.h: added enum GimpProgressCommand.
* app/core/gimppdbprogress.c
* libgimp/gimpprogress.c: use the enum instead of integer
constants for the different progress commands. Cleanup.
* app/plug-in/plug-in-progress.c
* app/plug-in/plug-in-run.c
* app/plug-in/plug-in.c: switch bach to real refcouting for
plug_in->progress (reopens bug #150194) and enabled the PDB
progress code.
* plug-ins/script-fu/script-fu-scripts.c: cleaned up the
progress stuff and the script-fu interface a bit.
* plug-ins/pygimp/gimpenums.py
* plug-ins/script-fu/script-fu-constants.c
* tools/pdbgen/enums.pl: regenerated.
2004-08-29 Manish Singh <yosh@gimp.org>
* app/plug-in/plug-in.c (plug_in_open): set can_recurse on the
recv_message watch, so we don't block on recursive calls to the
handler. plug_in_recv_message needs some refcounting help now
though.
* app/composite/gimp-composite-x86.h
* app/composite/gimp-composite-sse.c
* app/composite/gimp-composite-sse2.c: Fixed a bunch of
warnings due to bad type casting.
* app/composite/gimp-composite-mmx.c
* app/composite/gimp-composite-sse.c
* app/composite/gimp-composite-x86.h
* app/composite/gimp-composite-sse2.c:
The last changes to fix the the clobber registers bug #147013.
Commented out some dead code to be reviewed later.
2004-08-29 Michael Natterer <mitch@gimp.org>
Added an API to allow plug-ins to embed the progress for the
actions they trigger into their own GUI (attention: half-done and
broken code ahead...)
* app/core/Makefile.am
* app/core/core-types.h
* app/core/gimppdbprogress.[ch]: new object implementing dispatching
progress calls to a temporary PDB procedure in a plug-in.
* app/Makefile.am: force to link gimppdbprogress.o, bah!
* app/plug-in/plug-in-progress.[ch]: added API to install,
uninstall and cancel a PDB progress for this plug-in, but disabled
the implementation because it doesn't work yet.
* tools/pdbgen/pdb/progress.pdb: added pdb wrappers for the new
install, uninstall and cancel functions.
* libgimp/Makefile.am
* libgimp/gimp.h
* libgimp/gimpprogress.[ch]: added an API around the PDB progress
stuff.
* app/pdb/internal_procs.c
* app/pdb/progress_cmds.c
* libgimp/gimpprogress_pdb.[ch]: regenerated.
* plug-ins/script-fu/script-fu-scripts.c: use the new API to show
the progress in the script-fu dialog.
2004-08-29 Sven Neumann <sven@gimp.org>
* app/config/gimpconfigwriter.c: don't emit critical warnings
about a messed up state of GimpConfigWriter if the writer is
disabled because of a write error that occured earlier.
* app/composite/gimp-composite-sse.c
* app/composite/gimp-composite-sse2.c: More updates to accomodate
the clobber registers. Additional progress against bug #147013.
* app/composite/gimp-composite-sse.h: Fixed a bug where the wrong
manifest constant definition caused sse2 instructions to never be
compiled.
2004-08-28 Sven Neumann <sven@gimp.org>
* plug-ins/common/vpropagate.c (run): fixed confusion about which
mode to use when being run with last values (bug #151308).
2004-08-28 Simon Budig <simon@gimp.org>
* plug-ins/common/plugindetails.c: workaround to avoid a warning
by gcc about the use of "%c" in the format string.
2004-08-28 Sven Neumann <sven@gimp.org>
* libgimpwidgets/gimpwidgets.[ch]: applied a patch from Joao
S. O. Bueno which adds an API that allows to make the scale widget
of a GimpScaleEntry behave logarithmic. Fixes bug #149420.
* app/widgets/gimpbrusheditor.c: use the new functionality for the
radius control.
2004-08-28 Sven Neumann <sven@gimp.org>
* plug-ins/common/compose.c (compose_dialog): applied patch from
Markus Triska that improves which layers are choosen by
default (bug #148172).
2004-08-28 Sven Neumann <sven@gimp.org>
* app/core/gimpimage-contiguous-region.c
(find_contiguous_region_helper): applied a patch from Eric Cheung
that changes the function to use a GQueue to implement recursion
instead of recursive function calls. Fixes bug #151124.
* plug-ins/common/noisify.c (noisify_dialog): left-align the
preview.
2004-08-28 Sven Neumann <sven@gimp.org>
* app/widgets/gimphelp-ids.h
* app/widgets/gimptoolbox.c (toolbox_create_image_area): added a
help-id for the image area.
2004-08-27 Michael Natterer <mitch@gimp.org>
Moved the gimp_progress_init() and gimp_progress_update() PDB
functions to their own group because they don't belong to the
"Plug-In" namespace and will soon get more functions.
* tools/pdbgen/pdb/plug_in.pdb: removed the progress stuff...
* tools/pdbgen/pdb/progress.pdb: ...and added it here.
* tools/pdbgen/Makefile.am
* tools/pdbgen/groups.pl
* app/pdb/Makefile.am
* libgimp/Makefile.am: changed accordingly.
* libgimp/gimpprogress_pdb.[ch]: new generated files.
* app/pdb/internal_procs.c
* app/pdb/plug_in_cmds.c
* libgimp/gimp_pdb.h
* libgimp/gimpplugin_pdb.[ch]: regenerated.
2004-08-27 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpcontainereditor.c
(gimp_container_editor_construct): call
gimp_container_editor_select_item() manually at construction time
so views show the initially selected object's state correctly
(e.g. the brush spacing). Fixes bug #151227.
* app/widgets/gimpnavigationpreview.c
* app/widgets/gimpnavigationpreview.h: renamed these files to ...
* app/widgets/gimpnavigationview.c
* app/widgets/gimpnavigationview.h: to these.
And renamed the GimpNavigationPreview type to GimpNavigationView.
Hopefully, this is the last change in file names for the Preview->View
renaming process.
* app/display/gimpnavigationeditor.c
* app/widgets/Makefile.am
* app/widgets/widgets-types.h: Changed accordingly.
2004-08-26 Sven Neumann <sven@gimp.org>
* Makefile.am
* fortunes.xsl: added simple XSL transformation to generate
fortunes for wiki.gimp.org from gimp-tips.xml.in.
2004-08-26 Michael Natterer <mitch@gimp.org>
* app/core/gimpitem.c (gimp_item_stroke): implement the whole
paint_options fiddling here instead of in each subclass and pass
either GimpStrokeOptions or GimpPaintOptions (instead of
GimpStrokeOptions or GimpPaintInfo) to GimpItem::stroke().
Also copied code (that needs to be abstracted to a utility
function) from the tool_manager which makes sure we really use the
global brush, pattern etc. if these options are checked in prefs.
Fixes bug #150716.
* app/core/gimpchannel.c (gimp_channel_stroke)
* app/vectors/gimpvectors.c (gimp_vectors_stroke): removed the
duplicated code mentioned above and simply use the paint_options
passed.
Michael Natterer