Commit Graph

17025 Commits

Author SHA1 Message Date
Sven Neumann 74b29fe9c9 pass error messages with the return values instead of calling g_message().
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-xjt/xjt.c: pass error messages with the return
	values instead of calling g_message().


svn path=/trunk/; revision=26675
2008-08-20 13:01:57 +00:00
Sven Neumann 6f3a122953 plug-ins/file-sgi/sgi.c pass error messages with the return values instead
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-sgi/sgi.c
	* plug-ins/file-sgi/sgi-lib.[ch]: pass error messages with the
	return values instead of calling g_message().


svn path=/trunk/; revision=26674
2008-08-20 12:49:41 +00:00
Michael Natterer 4c356fe42b make gimp_perspective_clone_get_matrix() static and add
2008-08-20  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpperspectiveclone.[ch]: make
	gimp_perspective_clone_get_matrix() static and add
	gimp_perspective_clone_set_transform().

	* app/tools/gimpperspectiveclonetool.c
	(gimp_perspective_clone_tool_mode_notify): use above set_transform()
	API instead of poking into the object.

	(gimp_perspective_clone_tool_constructor): call
	gimp_perspective_clone_tool_mode_notify() to set up things instead
	of duplicating code.


svn path=/trunk/; revision=26673
2008-08-20 09:49:40 +00:00
Michael Natterer e650b579a7 formatting.
2008-08-20  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpperspectiveclonetool.[ch]: formatting.


svn path=/trunk/; revision=26672
2008-08-20 08:57:01 +00:00
Sven Neumann 5e347ed24b plug-ins/file-psd/psd.c plug-ins/file-psd/psd-load.[ch]
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-psd/psd.c
	* plug-ins/file-psd/psd-load.[ch]
	* plug-ins/file-psd/psd-save.c 
	* plug-ins/file-psd/psd-thumb-load.[ch]: pass error messages 
with
	the return values instead of calling g_message().


svn path=/trunk/; revision=26671
2008-08-20 07:36:25 +00:00
Sven Neumann 5084939673 plug-ins/file-jpeg/jpeg.[ch] plug-ins/file-jpeg/jpeg-load.[ch] pass error
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-jpeg/jpeg.[ch]
	* plug-ins/file-jpeg/jpeg-load.[ch]
	* plug-ins/file-jpeg/jpeg-save.[ch]: pass error messages with 
the
	return values instead of calling g_message().


svn path=/trunk/; revision=26670
2008-08-20 07:07:56 +00:00
Sven Neumann cdf2726bc9 flush the image when done to cause the actions to be updated (in
2008-08-20  Sven Neumann  <sven@gimp.org>

	* app/file/file-save.c (file_save): flush the image when done to
	cause the actions to be updated (in particular File->Revert).


svn path=/trunk/; revision=26669
2008-08-20 06:30:59 +00:00
Sven Neumann 39571e1656 create GHashTable with destroy notifiers.
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-ico/ico-save.c: create GHashTable with destroy
	notifiers.


svn path=/trunk/; revision=26668
2008-08-20 06:24:45 +00:00
Sven Neumann 3f26d82b62 plug-ins/file-faxg3/faxg3.c plug-ins/file-ico/ico.c
2008-08-20  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-faxg3/faxg3.c
	* plug-ins/file-ico/ico.c
	* plug-ins/file-ico/ico-load.[ch]
	* plug-ins/file-ico/ico-save.[ch]: pass error messages with the
	return values instead of calling g_message().


svn path=/trunk/; revision=26667
2008-08-20 06:15:35 +00:00
Sven Neumann 0b804f4d50 find guides outside the image as well. This complements the change that we
2008-08-19  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-guides.c (gimp_image_find_guide): find 
guides
	outside the image as well. This complements the change that we
	also draw guides outside the image now.


svn path=/trunk/; revision=26665
2008-08-19 17:48:33 +00:00
Michael Natterer 8ed8670d01 formatting.
2008-08-19  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpgegltool.c (gimp_gegl_tool_dialog): formatting.


svn path=/trunk/; revision=26664
2008-08-19 15:42:31 +00:00
Michael Natterer 128da64d0d Fix filename.
svn path=/trunk/; revision=26662
2008-08-19 08:25:27 +00:00
Michael Natterer 960b30cd9e app/plug-in/gimpplugin.[ch] (struct GimpPlugIn) move the error_handler
2008-08-19  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimpplugin.[ch] (struct GimpPlugIn)
	* app/plug-in/gimppluginprocframe.[ch] (struct GimpPlugInProcFrame):
	move the error_handler from the plug-in to the proc-frame.

	* app/plug-in/gimppluginprocframe.c
	* app/plug-in/gimpplugin-message.c: changed accordingly.


svn path=/trunk/; revision=26661
2008-08-19 08:24:48 +00:00
Sven Neumann 61d870cdd3 libgimpbase/gimpbase.def added new symbols.
2008-08-19  Sven Neumann  <sven@gimp.org>

	* libgimpbase/gimpbase.def
	* libgimp/gimp.def: added new symbols.


svn path=/trunk/; revision=26658
2008-08-19 06:33:48 +00:00
Sven Neumann 6e23a26307 plug-ins/file-bmp/bmp.[ch] plug-ins/file-bmp/bmp-read.c for most errors,
2008-08-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-bmp/bmp.[ch]
	* plug-ins/file-bmp/bmp-read.c
	* plug-ins/file-bmp/bmp-write.c: for most errors, pass the error
	message with the return values instead of calling g_message().


svn path=/trunk/; revision=26657
2008-08-19 06:27:32 +00:00
Sven Neumann 369d991fd2 Complements the fix for bug #344818:
2008-08-19  Sven Neumann  <sven@gimp.org>

	Complements the fix for bug #344818:

	* libgimpbase/gimpbaseenums.[ch]: added new enum 
GimpPDBErrorHandler.

	* tools/pdbgen/enums.pl: regenerated.

	* app/plug-in/gimpplugin.[ch]: added error_handler to 
GimpPlugIn.

	* app/plug-in/gimpplugin-message.c 
(gimp_plug_in_handle_proc_run):
	only display an error message for a failed procedure call if the
	plug-in's error-handler is set to 
GIMP_PDB_ERROR_HANDLER_INTERNAL.
	
	* tools/pdbgen/pdb/plug_in.pdb: added PDB getter and setter for
	the plug-in's error-handler.

	* app/pdb/plug-in-cmds.c
	* app/pdb/internal-procs.c
	* libgimp/gimpenums.c.tail
	* libgimp/gimpplugin_pdb.[ch]: regenerated.

	* plug-ins/common/file-compressor.c
	* plug-ins/file-uri/uri.c: set the error-handler to
	GIMP_PDB_ERROR_HANDLER_PLUGIN as these plug-ins are forwarding 
the
	error with their return values.


svn path=/trunk/; revision=26656
2008-08-18 22:54:26 +00:00
Sven Neumann 8b0384a70a pass error messages with the return values instead of calling g_message().
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-uri/uri.c: pass error messages with the return
	values instead of calling g_message().

	* plug-ins/file-uri/uri-backend-libcurl.c
	* plug-ins/file-uri/uri-backend-gnomevfs.c
	* plug-ins/file-uri/uri-backend-gvfs.c
	* plug-ins/file-uri/uri-backend-wget.c: set errors in the 
	G_FILE_ERROR domain and other minor cleanups.


svn path=/trunk/; revision=26655
2008-08-18 21:18:01 +00:00
Sven Neumann cc60f022b1 open the temporary file before forking. This allows us to return an error
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-compressor.c: open the temporary file
	before forking. This allows us to return an error message if the
	file can't be opened. Also changed the code to not use 
g_message()
	from the child process.


svn path=/trunk/; revision=26653
2008-08-18 20:47:19 +00:00
Sven Neumann 7c57332c6c pass some error message with the return values instead of calling
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-compressor.c: pass some error message 
with
	the return values instead of calling g_message().


svn path=/trunk/; revision=26652
2008-08-18 19:51:52 +00:00
Sven Neumann a1cbd58195 plug-ins/common/file-gbr.c plug-ins/common/file-gih.c
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-gbr.c
	* plug-ins/common/file-gih.c
	* plug-ins/common/file-pat.c
	* plug-ins/common/file-pix.c
	* plug-ins/common/file-sunras.c: for the most common errors, 
pass
	the error message with the return values instead of calling
	g_message().


svn path=/trunk/; revision=26650
2008-08-18 19:35:55 +00:00
Michael Natterer 7caea1c8e8 renamed... ...to this.
2008-08-18  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/compressor.c: renamed...
	* plug-ins/common/file-compressor.c: ...to this.

	* plug-ins/common/plugin-defs.pl: changed accordingly.

	* plug-ins/common/Makefile.am: regenerated.


svn path=/trunk/; revision=26648
2008-08-18 19:27:14 +00:00
Sven Neumann a458135b1a plug-ins/common/file-xbm.c plug-ins/common/file-xpm.c for the most common
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-xbm.c
	* plug-ins/common/file-xpm.c
	* plug-ins/common/file-xwd.c: for the most common errors, pass 
the
	error message with the return values instead of calling 
g_message().


svn path=/trunk/; revision=26646
2008-08-18 19:08:54 +00:00
Sven Neumann baabae4d0d pass error message with the return values instead of calling g_message().
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-wmf.c: pass error message with the return
	values instead of calling g_message().


svn path=/trunk/; revision=26642
2008-08-18 13:07:28 +00:00
Sven Neumann e7f4446b7b it's g_message(), not gimp_message()
svn path=/trunk/; revision=26641
2008-08-18 10:08:20 +00:00
Sven Neumann fc059e310d plug-ins/common/file-raw.c plug-ins/common/file-tga.c
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-raw.c
	* plug-ins/common/file-tga.c
	* plug-ins/common/file-tiff-load.c
	* plug-ins/common/file-tiff-save.c: pass error messages with the
	return values instead of calling gimp_message().


svn path=/trunk/; revision=26640
2008-08-18 10:02:20 +00:00
Sven Neumann edabd739d4 plug-ins/common/file-pnm.c plug-ins/common/file-ps.c for the most common
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-pnm.c
	* plug-ins/common/file-ps.c
	* plug-ins/common/file-psp.c: for the most common errors, pass 
the
	error message with the return values instead of calling
	gimp_message().


svn path=/trunk/; revision=26639
2008-08-18 06:53:21 +00:00
Sven Neumann 592d59765e plug-ins/common/file-mng.c for the most common errors, pass the error
2008-08-18  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-mng.c
	* plug-ins/common/file-pcx.c: for the most common errors,
	pass the error message with the return values instead of calling
	gimp_message().

	* plug-ins/common/file-gif-save.c
	* plug-ins/common/file-pdf.c
	* plug-ins/common/file-png.c: minor cleanup.


svn path=/trunk/; revision=26638
2008-08-18 06:31:03 +00:00
Sven Neumann d5da6ce87b in case of an error, pass the error message with the return values.
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-pdf.c: in case of an error, pass the 
error
	message with the return values.


svn path=/trunk/; revision=26637
2008-08-17 21:39:44 +00:00
Sven Neumann ad828a0301 plug-ins/common/file-gif-load.c for the most common errors, pass the error
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-gif-load.c
	* plug-ins/common/file-gif-save.c: for the most common errors,
	pass the error message with the return values instead of calling
	gimp_message().

	* plug-ins/common/file-png.c: unmarked a string for translation.
	This error condition can't possibly happen.

	* plug-ins/common/file-svg.c: also return an error message when
	the thumbnail can't be loaded.


svn path=/trunk/; revision=26636
2008-08-17 21:30:34 +00:00
Sven Neumann cb21ecf5a2 for the most common errors, pass the error message with the return values
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-dicom.c: for the most common errors, pass
	the error message with the return values instead of calling
	gimp_message().


svn path=/trunk/; revision=26634
2008-08-17 21:04:02 +00:00
Sven Neumann c60a4ba597 in case of an error, pass the error message with the return values.
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-csource.c (save_image): in case of an
	error, pass the error message with the return values.


svn path=/trunk/; revision=26633
2008-08-17 20:56:01 +00:00
Sven Neumann e73fc40cf4 don't hardcode the tile size, use gimp.tile_width() instead.
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/pygimp/plug-ins/whirlpinch.py: don't hardcode the 
tile
	size, use gimp.tile_width() instead.


svn path=/trunk/; revision=26632
2008-08-17 20:37:31 +00:00
Sven Neumann 00f704f82f formatting.
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/pygimp/plug-ins/whirlpinch.py: formatting.


svn path=/trunk/; revision=26631
2008-08-17 20:21:29 +00:00
Sven Neumann 1834dcc8a9 formatting
svn path=/trunk/; revision=26627
2008-08-17 18:29:21 +00:00
Sven Neumann 2c348c7a71 plug-ins/common/file-desktop-link.c
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/file-desktop-link.c

	* plug-ins/common/file-svg.c: changed to pass error messages 
with
	the return values instead of calling g_message().


svn path=/trunk/; revision=26626
2008-08-17 18:28:55 +00:00
Sven Neumann 4a2063872d unmarked string for translation. Script-Fu doesn't support i18n outside
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/frosty-logo.scm
	(apply-frosty-logo-effect): unmarked string for translation.
	Script-Fu doesn't support i18n outside the register call.


svn path=/trunk/; revision=26624
2008-08-17 15:01:39 +00:00
Sven Neumann 3db928cfc7 plug-ins/script-fu/scripts/glowing-logo.scm changed the "Alpha to Logo"
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/glowing-logo.scm
	* plug-ins/script-fu/scripts/neon-logo.scm: changed the "Alpha 
to
	Logo" parts of these scripts so that the user can specify the
	effect size directly instead of as some multiple of the size.


svn path=/trunk/; revision=26623
2008-08-17 14:57:21 +00:00
Sven Neumann b801bc39ad dropped the "Alpha to Logo" part of the "Starscape logo script. It had a
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/starscape-logo.scm: dropped the
	"Alpha to Logo" part of the "Starscape logo script. It had a
	similar problem as the Starburst script (see bug #486779).


svn path=/trunk/; revision=26622
2008-08-17 14:54:53 +00:00
Sven Neumann 97f281a9c3 plug-ins/script-fu/scripts/Makefile.am dropped the "Starburst" logo
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/Makefile.am
	* plug-ins/script-fu/scripts/starburst-logo.scm: dropped the
	"Starburst" logo script. Fixes bug #486779.


svn path=/trunk/; revision=26621
2008-08-17 14:42:11 +00:00
Sven Neumann a2cd4b73ec Next step towards fixing bug #344818:
2008-08-17  Sven Neumann  <sven@gimp.org>

	Next step towards fixing bug #344818:

	* app/pdb/gimpprocedure.c (gimp_procedure_execute): if the error
	has not already been set, construct one from the error message
	that is optionally passed with the return values.

	* plug-ins/common/file-png.c: changed to pass an error message
	with the return values instead of calling g_message() in case of
	an error.


svn path=/trunk/; revision=26620
2008-08-17 12:13:46 +00:00
Sven Neumann 04539e92ed renamed gimp_plug_in_proc_frame_get_return_vals() to
2008-08-17  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginprocframe.[ch]: renamed
	gimp_plug_in_proc_frame_get_return_vals() to
	gimp_plug_in_proc_frame_get_return_values().

	* app/plug-in/gimppluginmanager-call.c: changed accordingly.

svn path=/trunk/; revision=26619
2008-08-17 12:08:52 +00:00
Sven Neumann 3fa2cbe022 changed to use g_set_error().
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-psd/psd-util.c (psd_set_error): changed to use
	g_set_error().


svn path=/trunk/; revision=26618
2008-08-17 11:14:13 +00:00
Sven Neumann 1277bb4415 changed to use g_error_new_literal().
2008-08-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-psd/psd-util.c (psd_set_error): changed to use
	g_error_new_literal().


svn path=/trunk/; revision=26617
2008-08-17 11:04:04 +00:00
Sven Neumann 51d56e3a43 introduced a utility function to reduce code duplication.
2008-08-17  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimpplugin-progress.c
	(gimp_plug_in_progress_cancel_callback): introduced a utility
	function to reduce code duplication.

	* app/pdb/gimppdb.c (gimp_pdb_execute_procedure_by_name): 
changed
	to use g_error_new_literal().


svn path=/trunk/; revision=26616
2008-08-17 11:00:41 +00:00
Martin Nordholts 42c315a782 Fix typo in the only word in my most recent ChangeLog entry :(
svn path=/trunk/; revision=26615
2008-08-17 10:51:21 +00:00
Martin Nordholts a07760dea5 Simpliy.
2008-08-17  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_size_allocate): Simpliy.

svn path=/trunk/; revision=26614
2008-08-17 10:48:49 +00:00
Martin Nordholts a4a05e8c59 If the image ends up below or to the right of the viewport top and left
2008-08-17  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_size_allocate): If the image ends up
	below or to the right of the viewport top and left edges, and the
	image is not centered on a given axis, align the top left image
	edge with the top left viewport edge. This is basically the best
	we can do without an API for start and end of a window resize
	cycle using the mouse.

svn path=/trunk/; revision=26613
2008-08-17 07:38:25 +00:00
Martin Nordholts 9311a413fa Don't apply the centering logic on zoom_on_resize.
2008-08-17  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_size_allocate): Don't apply the
	centering logic on zoom_on_resize.

svn path=/trunk/; revision=26612
2008-08-17 07:29:48 +00:00
Martin Nordholts 384df24b80 When applying the centering logic we need to know the size of the new
2008-08-17  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.[ch]
	(gimp_display_shell_configure_event): When applying the centering
	logic we need to know the size of the new canvas, so instead of
	having it here, only make sure that this logic is run on the next
	canvas size-allocate.

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_size_allocate): If the size-allocate
	comes from a top level window resize, apply centering logic.

svn path=/trunk/; revision=26611
2008-08-17 07:21:41 +00:00
Martin Nordholts 7902305706 Oops, correct parameter order.
2008-08-16  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_scroll_center_image_on_next_size_allocate):
	Oops, correct parameter order.

svn path=/trunk/; revision=26609
2008-08-16 19:18:31 +00:00