Commit Graph

52 Commits

Author SHA1 Message Date
Téo Mazars 54f83a5ba2 plug-ins: don't check biClrUsed if bpp > 8 (in bug 697431) 2014-01-30 20:35:45 +01:00
Michael Natterer 03df8c6af4 plug-ins: pass the format's name again in calls to gimp_export_image()
and clean up the formatting of the call and the lines around it. Now
we can check the various (disabled) export options for regressions
again by changing a single line in gimp_export_image().
2013-11-10 00:18:48 +01:00
Nils Philippsen 4664c1f479 file-bmp: don't close foreign FD in ReadImage() 2013-11-08 14:02:03 +01:00
Nils Philippsen 6467fbf65d file-bmp: don't leak file pointer when erroring out 2013-11-07 12:20:34 +01:00
Téo Mazars 56f065321c Bug 674391 - Indexed colours not exported when save a .bmp
It's about importing in fact.

Parse BITMAPV4HEADER / BITMAPV5HEADER and use GIMP's BMP
implementation instead of using gdk_pixbuf.

Also, remove an old hack about 32bits bmp v3 + alpha. The alpha
channel is already ignored in that case.
2013-08-03 19:46:39 +02:00
Michael Natterer ec786816bb */Makefile.am: merge INCLUDES into AM_CPPFLAGS
automake-1.13 finally warns about this anachronism.
2013-06-05 20:48:37 +02:00
Kevin Cozens cc20c8d7f6 Fixed several typos. Minor whitespace changes. 2012-12-14 17:43:10 -05:00
Michael Natterer 67dda14e77 plug-ins: cleanup in the recently GEGL-ported plug-ins
Mostly formatting consistency paranoia.
2012-11-27 20:58:05 +01:00
Mukund Sivaraman 610aac1dac file-bmp: Don't use alpha channel with BI_RGB compression type
Don't use alpha channel with BI_RGB compression type in
BITMAPINFOHEADER images (bug #573090, bug #674398).
2012-10-08 09:12:25 +05:30
Mukund Sivaraman a19bbee5cb file-bmp: Reject compression type BI_ALPHABITFIELDS as unsupported
These were erroneously parsed before. Now we reject them.  It is
trivial to implement support for them, but we can't test it unless
someone comes up with a sample BMP file.  They don't seem to be
available in the wild.
2012-10-08 09:09:04 +05:30
Mukund Sivaraman 9818c4706a file-bmp: Change order of bytes (and the masks correspondingly) to please Firefox 2012-10-08 08:03:57 +05:30
Michael Natterer 244b3766bd plug-ins: port file-bmp to GEGL 2012-09-21 19:19:03 +02:00
Mukund Sivaraman 800f967930 file-bmp: Fix order of data in RGBA_8888 images
See #678250, #678252, etc. for example bug reports.

This fix should be sufficient in fixing BMP output, but it looks
like some apps like Firefox have broken BMP loaders which do not
care for the masks. We would have to change the masks for them.
2012-09-21 20:11:31 +05:30
Mukund Sivaraman b100b14111 file-bmp: All 16 and 32-bpp files need the masks to be written
See #678250, #678252, etc. for example bug reports.
2012-09-21 20:09:51 +05:30
Øyvind Kolås d1ced11415 plug-ins: add GEGL_CFLAGS to many Makefile.am's 2012-05-02 17:46:08 +02:00
Massimo Valentini a0e6941db1 Bug 669188: saving a monochrome bitmap picture ...
The colormap was being written within the DIB header.
It must follow both the mask and color space info.
2012-02-02 11:49:41 -05:00
Michael Natterer 9a4abedb98 plug-ins: fix indentation b0rk from previous commit 2012-01-31 21:28:12 +01:00
Kevin Cozens 2871093626 Bug 669074 - Corrected typo, spotted by David Allen, in BMP file signature. 2012-01-31 14:53:18 -05:00
Mukund Sivaraman 5c67d250ca file-bmp: Unmark string from translation 2011-12-06 21:18:56 +05:30
Michael Natterer dcb4c6e34a plug-ins: use gtk_box_new() 2011-09-30 12:18:24 +02:00
Martin Nordholts 7fea63a283 Bug 653757 - Bitmap export in Gimp 2.6.11 vs Bitmap Export in Gimp 2.7.3
Make writing BITMAPV5HEADER color space information optional since
there are compatibility problems with writing color space
information. Unity 3D and BlitzMax have been reported to not support
such BMP images.
2011-08-26 23:49:41 +02:00
Martin Nordholts bb02019aa0 plug-ins: Remember BMP options across invocations
There is no reason to not do that, especially since we soon will make
color space information in the BMP file optional.
2011-08-12 18:47:21 +02:00
Martin Nordholts 698d9ea28e plug-ins: bmp-write.c: encoded -> use_run_length_encoding 2011-08-12 18:47:21 +02:00
Mukund Sivaraman f93398b4cf file-bmp: Fix typo in comment 2011-05-08 23:33:17 +05:30
Mukund Sivaraman b3a4a00d29 file-bmp: Use BITMAPV5HEADER structure (bug #649741) 2011-05-08 22:57:39 +05:30
Mukund Sivaraman a713175375 file-bmp: Rewrite code 2011-05-08 22:10:20 +05:30
Mukund Sivaraman 4978f370fe file-bmp: Rewrite code 2011-05-08 21:22:31 +05:30
Michael Natterer 5c7660c6cc plug-ins: don't #include <libgimp/gimppixbuf.h> in bmp-read.c 2011-04-28 19:58:51 +02:00
Mikael Magnusson 8ff66342b8 plug-ins: set progress to 1.0 when done 2011-04-10 19:28:43 +02:00
Michael Natterer 8c4d99f883 Bug 645456 - Inconsistent window (role) naming scheme
Applied patch from Christoph Kappel which adds a "gimp-" prefix to all
plug-in dialog window roles.
2011-04-08 20:31:34 +02:00
Michael Natterer 38fd77f5e9 plug-ins: some more s/gtk_container_add/gtk_box_pack_start/ 2011-03-05 10:59:56 +01:00
Michael Natterer 97a73ea83f app: use gtk_box_pack_start() to pack a dialog's toplevel container
instead of gtk_container_add()'s because otherwise the widget will not
expand in GTK+ 3.x
2011-03-04 10:44:58 +01:00
Nelson A. de Oliveira 7666e5cf36 Fix memory and descriptor leaks 2010-11-12 21:56:17 +01:00
Michael Natterer bbd7ec6b5c plug-ins: port from gimp_image_add_foo() to gimp_image_insert_foo()
I'm sure some plug-ins need to add their items *not* at the toplevel,
but since making plug-ins really tree-aware is a lot more work than
just fixing insert positions, I went for passing -1 as parent in
almost all cases. And because of laziness...
2010-09-06 11:40:46 +02:00
Michael Schumacher e77dd90fc0 Bug 574018 - Add a manifest to executables
Created a resource file for plug-ins and a rule to link it to them.
The application icon file is smaller than the default one, there's no
point in doubling the size of a plug-in executable just for an icon.

If no problems turn up, this will close the bug.
2010-09-01 08:24:45 +02:00
Massimo Valentini ca43054f08 Bug 623290 - Save As... does not save Windows Bitmap as default in dialog
Connect to "toggled" signal of radio buttons.
2010-07-07 20:29:06 +02:00
Massimo Valentini bc02c2f51e Bug 599233 - Dialog of "Save as BMP" ignores changes which are not made with a mouse
Connect to GtkButton::clicked instead of GtkButton::pressed.
2010-03-11 08:42:19 +01:00
Nils Philippsen 16e6a37687 Ensure valid bit depths when reading BMP files. 2009-11-16 18:16:38 +01:00
Nils Philippsen f63ba36dd9 Use more defensive coding in plausibility check.
Use an equivalent division instead of multiplying values and checking if
they are more than G_MAXINT32, because divisions cannot overflow.
2009-11-16 17:30:43 +01:00
Nils Philippsen 43d57c6663 Make plausibility check easier to understand.
Explicitly check that Bitmap_Head.biHeight is not G_MININT32
instead of relying on ABS(G_MININT32) being negative.
2009-11-16 17:30:43 +01:00
Simon Budig e3afc99b2f Harden the BMP plugin against integer overflows.
Issues discovered by Stefan Cornelius, Secunia Research, advisory SA37232
and CVE identifier CVE-2009-1570. Fixes bug #600484.
2009-11-10 00:08:59 +01:00
Massimo Valentini 61db48ac74 Bug 586851 – Transparent BMP files fail to load
If everything else fails, use gdk_pixbuf_new_from_file().
2009-07-22 18:17:00 +02:00
Martin Nordholts 19fe919dce plug-ins: Port file plug-ins to new export API 2009-07-21 16:03:58 +02:00
Michael Natterer e805cb0cf4 Use gtk_dialog_get_content_area() instead of dialog->vbox 2009-07-15 18:57:12 +02:00
Michael Schumacher eed061efbb Adding Microsoft Windows executables to the .gitignore files
All binaries have been added individually.
Old binaries are supposed to show up as untracked.
2009-06-19 00:14:17 +02:00
Martin Nordholts 4d7a6b10d1 Added .gitignore files generated with git svn create-ignore.
svn path=/trunk/; revision=27972
2009-01-31 11:37:44 +00:00
Michael Natterer 4ea1437646 plug-ins/common/*.c plug-ins/color-rotate/color-rotate.c
2009-01-19  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/*.c
	* plug-ins/color-rotate/color-rotate.c
	* plug-ins/file-bmp/bmp.c
	* plug-ins/file-faxg3/faxg3.c
	* plug-ins/file-fits/fits.c
	* plug-ins/file-fli/fli-gimp.c
	* plug-ins/file-ico/ico.c
	* plug-ins/file-jpeg/jpeg.c
	* plug-ins/file-psd/psd-save.c
	* plug-ins/file-psd/psd.c
	* plug-ins/file-sgi/sgi.c
	* plug-ins/file-uri/uri.c
	* plug-ins/file-xjt/xjt.c
	* plug-ins/flame/flame.c
	* plug-ins/fractal-explorer/fractal-explorer.c
	* plug-ins/gfig/gfig.c
	* plug-ins/gimpressionist/gimp.c
	* plug-ins/gradient-flare/gradient-flare.c
	* plug-ins/help-browser/help-browser.c
	* plug-ins/ifs-compose/ifs-compose.c
	* plug-ins/imagemap/imap_main.c
	* plug-ins/lighting/lighting-main.c
	* plug-ins/map-object/map-object-main.c
	* plug-ins/maze/maze.c
	* plug-ins/metadata/metadata.c
	* plug-ins/pagecurl/pagecurl.c
	* plug-ins/print/print.c
	* plug-ins/pygimp/gimpfu.py
	* plug-ins/script-fu/script-fu-script.c
	* plug-ins/script-fu/script-fu.c
	* plug-ins/selection-to-path/selection-to-path.c
	* plug-ins/twain/twain.c
	* plug-ins/win-snap/winsnap.c: document the "run-mode" parameter
	as we document enums for core procedures.


svn path=/trunk/; revision=27922
2009-01-19 20:11:36 +00:00
Michael Natterer d9b5207aa2 Change licence to GPLv3 (and to LGPLv3 for libgimp).
2009-01-17  Michael Natterer  <mitch@gimp.org>

	* all files with a GPL header and all COPYING files:

	Change licence to GPLv3 (and to LGPLv3 for libgimp).

	Cleaned up some copyright headers and regenerated the parsers in
	the ImageMap plugin.


svn path=/trunk/; revision=27913
2009-01-17 22:28:01 +00:00
Sven Neumann cc7222d8e4 added missing include.
2008-11-04  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplay-foreach.c: added missing include.

	* app/actions/debug-commands.c
	* plug-ins/common/lcms.c
	* plug-ins/common/mail.c
	* plug-ins/file-bmp/bmp-write.c
	* plug-ins/file-fits/fits.c
	* plug-ins/file-jpeg/jpeg.c
	* plug-ins/file-uri/uri.c
	* plug-ins/help/gimphelpdomain.c
	* plug-ins/ifs-compose/ifs-compose.c
	* plug-ins/print/print.c: fixed use of g_message() with literal
	strings.


svn path=/trunk/; revision=27551
2008-11-04 14:05:24 +00:00
Sven Neumann 6e23a26307 plug-ins/file-bmp/bmp.[ch] plug-ins/file-bmp/bmp-read.c for most errors,
2008-08-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/file-bmp/bmp.[ch]
	* plug-ins/file-bmp/bmp-read.c
	* plug-ins/file-bmp/bmp-write.c: for most errors, pass the error
	message with the return values instead of calling g_message().


svn path=/trunk/; revision=26657
2008-08-19 06:27:32 +00:00