Commit Graph

27685 Commits

Author SHA1 Message Date
Michael Natterer 39c7405954 app: disconnect from the dialog factory in dispose() instead of finalize() 2010-06-24 18:38:18 +02:00
Michael Natterer a83b3250e4 app: set non-NULL names on the default image and the default grid 2010-06-24 18:38:18 +02:00
Michael Natterer 67590c04d1 app: unref tool options and presets in dispose() instead of finalize() 2010-06-24 18:38:18 +02:00
Michael Natterer bfbdf1cfb8 app: unref the paint options in dispose() instead of finalize() 2010-06-24 18:38:18 +02:00
Michael Natterer 5db9d31498 app: drop all object references in dispose() insatead of finalize() 2010-06-24 18:38:18 +02:00
Michael Natterer 06bf098fa9 app: run dispose on the tool infos before unrefing their container
because they contain reference cycles with the tool options
2010-06-24 18:38:18 +02:00
Michael Natterer cf98aed702 app: run dispose on the paint infos before unrefing their container
because they contain reference cycles with the paint options
2010-06-24 18:38:17 +02:00
Michael Natterer a5b6544b6e app: unref options->tool_info in dispose() instead of finalize() 2010-06-24 18:38:17 +02:00
Michael Natterer 69e7e411f8 app: unref options->paint_info in dispose() instead of finalize() 2010-06-24 18:38:17 +02:00
Michael Natterer c47edb5016 app: improve the g_warning() about undestroyed dialogs 2010-06-24 18:38:17 +02:00
Michael Natterer e7b16c8634 app: run dispose manually on the dialog factory before unrefing it
Because some of the dialogs the factory creates add a reference to
it, creating a cycle; so simply unrefing it doesn't do anything.
2010-06-24 18:38:17 +02:00
Michael Natterer 403908829a app: add comment about why we can't use GimpContainerView API in init() 2010-06-24 18:38:17 +02:00
Michael Natterer 3c565a1736 app: unref context, dialog_factory and ui_manager in GObject::dispose()
The were not unrefed at all before
2010-06-24 18:38:16 +02:00
Michael Natterer ad83462570 app: unref the filtered container in GObject::dispose()
It was simply never destroyed at all before.
2010-06-24 18:38:16 +02:00
Michael Natterer c9bde335f0 app: don't additionally ref the standard data objects
Instead, set their statically remembered pointer as a weak pointer so
it's nullified automatically if they are ever finalized. Doesn't
actually get rid of them upon exit yet, this is just a preparation.
2010-06-24 18:38:16 +02:00
Barak Itkin 5da440f1a5 Update Hebrew translation. 2010-06-24 14:40:50 +03:00
Nelson A. de Oliveira c4588f1209 Bug 575911 - Add 'Rule of fifths' crop guide overlay
Implement a rule of fifths guideline for GIMP. See
http://markhancock.blogspot.com/2006/03/address-basic-composition.html
for more info.
2010-06-24 08:37:09 +02:00
Michael Natterer b43be361ff app: add a forgotten g_object_unref()
so all dockables are destroyed when a dock is destroyed.
2010-06-23 22:50:45 +02:00
Michael Natterer bbd4038e98 app: make sure all tool options widgets are properly destroyed
...and with them all references their widgets keep (which are a lot).

Take ownership of the widget after creating it, so it can be reliably
unrefed upon exit.
2010-06-23 22:48:53 +02:00
Michael Natterer e44d81bd4b app: add a debug facility that keeps track of allocated GimpObjects 2010-06-23 22:32:14 +02:00
Martin Nordholts f6781d15c4 Bug 565459 - newly opened images are put into the background
When we are going to open new image windows, unset the transient
window. We don't need it since we will use gdk_window_raise() to
keep the dialog on top. And if we don't do it, then the dialog
will pull the image window it was invoked from on top of all the
new opened image windows, and we don't want that to happen.

Patch heavily inspiried by hack from Massimo Valentini.

Also add a manual test case for the fix. (I don't think there is GTK+
API to automate it).
2010-06-23 20:17:44 +02:00
Martin Nordholts 2431740492 app: Explain gdk_window_raise() in file-open-dialog.c 2010-06-23 19:58:01 +02:00
SimaMoto,RyōTa 66bd26b208 Bug 618143 - Clarify labels in 'Size' tab in GIMPressionist
The "Size" and "Sizes" labels in the GIMPressionist plugin can be more
descriptive, change them to "Size variants" and "Size depends on"
respectively.
2010-06-23 18:45:37 +02:00
Martin Nordholts e54a93f649 devel-docs: Update development schedule
Update development schedule. A bunch of things had to be postponed,
and I adjusted some time estimates.

New ETA: 2010-12-29.
2010-06-23 18:23:16 +02:00
Michael Natterer ea050b267e app: don't leak all cached GtkTreeIters in container views
This is evil: the hash table of "insert_data" is created on demand
when GimpContainerView API is used, using a value_free_func that is
set in the interface_init functions of its implementors. Therefore, no
GimpContainerView API must be called from any init() function, because
the interface_init() function of a subclass that sets the right
value_free_func might not have been called yet, leaving the
insert_data hash table without memory management.

Call GimpContainerView API from GObject::constructed() instead, which
runs after everything is set up correctly.
2010-06-23 00:20:21 +02:00
Michael Natterer a60463cd8e app: free one more list returned by gtk_container_get_children() 2010-06-23 00:19:44 +02:00
Michael Natterer 46e1410213 app: free the list returned by gtk_container_get_children() 2010-06-22 23:06:35 +02:00
Michael Natterer 865a1f4896 app: free the string returned by gimp_dock_window_get_description() 2010-06-22 23:06:35 +02:00
Michael Natterer 94e757df51 app: don't leak options->language; add finalize() to free it 2010-06-22 23:06:35 +02:00
Michael Natterer cf1cc6dc6f app: private->shells might be a list with one element upon destroy; free it 2010-06-22 23:06:35 +02:00
Michael Natterer 5df1d477b7 app: free shell->zoom_focus_pointer_queue in destroy() 2010-06-22 23:06:35 +02:00
Michael Natterer 09ebdcb06b app: don't leak each transformed brush mask 2010-06-22 23:06:35 +02:00
Martin Nordholts 2b050c78cd devel-docs: Remove release commit from release-howto.txt 2010-06-22 21:37:00 +02:00
Michael Natterer 2a984ef51f Bug 612618 - Font selection remains visible
Connect to "grab-notify" and "grab-broken-event" and close the popup
when the grab is lost.
2010-06-22 20:09:52 +02:00
Martin Nordholts ff1da59f33 Bug 574018 - Add a manifest to executables
Patch from Jernej Simončič.
2010-06-22 19:35:16 +02:00
Kevin Cozens 75941beaca Added SIOD compatability routines string-downcase and string-upcase. 2010-06-21 23:56:40 -04:00
Martin Nordholts f0e90007f7 app/tests: Remove gimp_ui_synthesize_plus_key_event() crack
Make gimp_ui_synthesize_plus_key_event() generic and implement it with
gdk_test_simulate_key(). We can't use gtk_test_widget_send_key()
because its input window logic doesn't seem to work very well.
2010-06-21 21:19:15 +02:00
Martin Nordholts 8b344fa6ad app: Test for existance of git-version.h.tmp before comparing
Test for existance of git-version.h.tmp before comparing. Otherwise
cmp will complain when building tarballs.
2010-06-21 21:19:15 +02:00
Michael Natterer ae0ae9fcb8 app: pass all construct params to g_object_new() 2010-06-21 21:08:13 +02:00
Michael Natterer d04051bcad Bug 622234 - gimp.desktop: image/x-psd in MimeTypes twice
Fix the typo: the second x-psd should be x-psp
2010-06-20 23:53:43 +02:00
Michael Natterer ac6ee07184 app: the tests should succeed, so should a normal gimp session
Don't divide by zero in gimp_session_info_class_apply_position_accuracy()
when klass->position_accuracy is 0, which happens on each exit in a normal
session.
2010-06-20 23:26:45 +02:00
Martin Nordholts df731fecda Make 'make distcheck' pass
Add missing CLEANFILES, make distcheck passes now.
2010-06-20 20:30:24 +02:00
Martin Nordholts ce33255588 app/tests: Also add error margin to 'gimpsessioninfo-book.c'
Also add error margin to 'gimpsessioninfo-book.c' and update reference
files. This makes 'make distcheck' pass, and it passes more reliably.
2010-06-20 20:30:24 +02:00
Sven Neumann 9275404452 Bug 622196 - Unportable test(1) construct in configure script
Use of '==' as comparison operator is a bashism.
2010-06-20 18:37:53 +02:00
Michael Natterer ba3d530c9b tests: fix the directory variables in TESTS_ENVIRONMENT
Apparently, $(abs_top_srcdir) and $(abs_top_builddir) aren't set as
shell variables any longer. Instead, use @abs_top_srcdir@ and
@abs_top_builddir@ so they get substituted at configure time.
2010-06-20 12:25:32 +02:00
Martin Nordholts 49d951d49e app: Introduce error margin in sessionrc in test cases
Introduce a few pixels of error margin in sessionrc, otherwise the
tests are too fragile, widgets have a tendency to change size a bit
and window managers have a tendency to move windows a bit.

Still needs more work, should probably do the same on book positions
too...
2010-06-19 23:55:35 +02:00
Martin Nordholts 4e78fc7279 Also distribute dockrc-expected 2010-06-19 23:55:35 +02:00
Martin Nordholts 53596f708d m4macros: Delete gtk-doc.m4, gtkdocize gives us a symlink 2010-06-19 23:55:35 +02:00
Martin Nordholts d1202096e6 app: Include git commit hash in verbose version output
Note:
* Passes make distcheck
* The git commit hash is shipped with tarballs
* Build handles if git-version.h is removed from a tarball
2010-06-19 23:55:35 +02:00
Michael Natterer 22864d1b88 NEWS: even more 2010-06-19 15:18:52 +02:00