2002-06-20 Michael Natterer <mitch@gimp.org>
Fixed color picking (reported by jimmac on #gimp):
* app/core/gimpimage-pick-color.c: set the returned color's alpha
value to opaque if the drawable we pick from has no aplha.
* app/tools/gimpcolorpickertool.c: ignore all values returned by
gimp_image_pick_color() if it returns FALSE (which happens if we
want to pick outside the drawable).
2002-06-19 Michael Natterer <mitch@gimp.org>
Fix for #85202:
Updating the active tool's modifier state on GTK_ENTER_NOTIFY and
GTK_LEAVE_NOTIFY was a bad idea because this only works with
focus-follows-mouse. Instead, update it during the whole time the
canvas can receive key events, namely from FOCUS_IN until
FOCUS_OUT. As an ugly side condition, click-to-focus leads to
GDK_BUTTON_PRESS arriving before GDK_FOCUS_CHANGE(in).
* app/display/gimpdisplayshell-callbacks.[ch]: removed the
separate focus_in and focus_out callbacks and handle them in
gimp_display_shell_canvas_tool_events(). Moved tool state updating
from the ENTER/LEAVE code to FOCUS_CHANGE. Added an ugly static
variable "button_press_before_focus" and take care of the side
condition mentioned above.
* app/display/gimpdisplayshell.c: changed accordingly.
2002-06-17 Sven Neumann <sven@gimp.org>
Obviously I disagree with Tim about the symbol_name parameter in
g_scanner_unexp_token(). As it seems it's not supposed to be used
to tell the user about the expected symbol (see bug #81850):
* gimpconfig.[ch] (gimp_config_deserialize_return): removed the
symbol_name parameter.
* app/config/gimpconfig-deserialize.c
* app/core/gimpcontainer.c
* app/core/gimpdocumentlist.c
* app/core/gimpparasitelist.c: changed the callers accordingly.
* app/core/gimpunits.c (gimp_unitrc_load): pass NULL as symbol_name
to g_scanner_unexp_token().
2002-06-17 Sven Neumann <sven@gimp.org>
* plug-ins/script-fu/script-fu-server.c (read_from_client): merged
fix for bug #85573 from stable branch. We should port this stuff
to use GIOChannels.
2002-06-17 Michael Natterer <mitch@gimp.org>
Separated tool_options creation from tool registration so we
don't implicitly create widgets before gui_init():
* libgimptool/gimptooltypes.h: removed GimpToolOptionsNewFunc
typedef here...
* app/core/core-types.h: ...and added it here.
* libgimpproxy/gimpproxytypes.h: regenerated.
* app/core/gimptoolinfo.[ch]: added a GimpToolOptionsNewFunc
pointer to remember the constructor. Fixed the finalize() method
(bug was never noticed because we leaked all tool infos)
* app/tools/tool_manager.[ch]: moved tool_options creation to the
new function tool_manager_restore(). Unref the tool infos after
adding them to their container. Added "brush" and "gradient" to
the context properties which are defined for tool contexts.
* app/app_procs.c: call tool_manager_restore() after gui_init().
* app/gui/gui.c: removed the hack introduced recently and call
render_setup() in gui_init() again, not in gui_themes_init().
Use the correct contexts now that they are properly initialized
at the time of tool_options creation:
* app/tools/gimpblendtool.c: use tool_info->context, not
gimp_get_user_context() to get/set the tool's gradient.
* app/paint/gimppaintcore.[ch] (gimp_paint_core_start): added a
GimpPaintOptions paramater and get the brush to use from
paint_options->context (instead of gimp_get_current_context()).
* app/paint/gimppaintcore-stroke.c
* app/tools/gimppainttool.c: changed accordingly.
* app/tools/paint_options.c: added a brush preview to the paint
options.
2002-06-16 Michael Natterer <mitch@gimp.org>
* app/tools/gimpblendtool.c: set the witdh of the gradient preview
to 96 instead of 128 pixels so it is not the widest tool options
item with the "small" theme.
2002-06-16 Michael Natterer <mitch@gimp.org>
* libgimpwidgets/gimpstock.[ch]: register the new "invert" and
"layer to imagesize" PNGs as stock icons.
* app/gui/menus.c: use them here.
* themes/Default/images/Makefile.am: fixed indentation.
2002-06-13 Sven Neumann <sven@gimp.org>
* configure.in
* app/plug-in/plug-in.c (plug_in_init_shm): allocate shared memory
segments with permissions 0600 instead of making them accessible
by everyone.
2002-06-12 Sven Neumann <sven@gimp.org>
* app/paint/gimppaintcore.[ch]: applied a patch from Henning
Makholm <henning@makholm.net> that vastly improves drawing of thin
lines. See bug #69773 for a detailed description.
2002-06-12 Sven Neumann <sven@gimp.org>
* app/widgets/gimppreview.c (gimp_preview_size_allocate): center
the preview's allocation.
* app/tools/gimpblendtool.c (blend_options_new): use a button for
the gradient so it's more obvious that it can be pressed.
2002-06-12 Michael Natterer <mitch@gimp.org>
* app/core/gimpdata.[ch]: added a boolean "internal" which
indicates that the data object is an automatically created
internal object. Changed the code to refuse saving to deleting
internal objects.
* app/core/Makefile.am
* app/core/gimp-gradients.[ch]: new files implementing internal
gradients (FG -> BG in RGB and HSV and FG -> transparent).
* app/core/gimp.c: call gimp_gradients_init().
* app/core/gimpdatafactory.c (gimp_data_factory_data_free): don't
free internal objects so they stay there on "Refresh".
* app/core/gimpdatalist.c: sort internal objects to the beginning
of the list.
* app/widgets/gimpdataeditor.c: refuse to change the name of
internal objects.
* app/widgets/gimpdatafactoryview.c: set the "Delete" button
insensitive for internal objects.
* app/widgets/gimpgradienteditor.c: refuse to edit internal
gradients, just display them so color picking works.
* app/gui/brushes-commands.c
* app/gui/gradients-commands.c
* app/gui/palettes-commands.c
* app/gui/patterns-commands.c: set the "Delete" menu item
insensitive for internal objects.
* app/gui/gui.c: need to call render_setup() earlier because of
you-dont-want-to-know-why. Will change it back once the previews
have their own render buffers.
* app/tools/gimpblendtool.c: Replaced the "Type" menu by a preview
showing the active gradient. Clicking the preview pops up the
gradient selection. Renamed the "Gradient" menu to "Shape". Removed
"blend_mode" from the BlendOptions struct because we always use
"custom" mode now.
2002-06-11 Sven Neumann <sven@gimp.org>
* plug-ins/helpbrowser/helpbrowser.c: implemented anchor handling.
Load remote URLs by calling the webbrowser plug-in.
Maurits Rijk