mirror of https://github.com/GNOME/gimp.git
16 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Sven Neumann
|
41237259c9 |
In all files, changed the standard copyright notice to say "GIMP - The GNU
2006-12-09 Sven Neumann <sven@gimp.org>
* In all files, changed the standard copyright notice to say
"GIMP - The GNU Image Manipulation Program".
|
|
|
Michael Natterer
|
1ee6516d52 |
Applied modified patch from Martin Nordholts which adds a "Rounded
2006-10-18 Michael Natterer <mitch@gimp.org> Applied modified patch from Martin Nordholts which adds a "Rounded Corners" option to the rectangle select tool. Fixes bug #86279. * app/core/gimpchannel-combine.[ch]: added gimp_channel_combine_ellipse_rect(). Use it from gimp_channel_combine_ellipse(). * app/core/gimpchannel-select.[ch]: added gimp_channel_select_round_rect() * app/tools/gimprectangleselectoptions.[ch]: added properties "round-corners" and "corner-radius" and GUI for the new propeties. * app/tools/gimprectangleselecttool.h: added macro GIMP_RECT_SELECT_TOOL_GET_OPTIONS(). * app/tools/gimprectangleselecttool.c (gimp_rect_select_tool_draw): draw round corners if enabled. (gimp_rect_select_tool_real_select): use gimp_channel_select_round_rect() if enabled. * app/tools/gimpselectionoptions.[ch]: added "antialias_toggle" to the GimpSelectionOptions struct so the rect select options can set its sensitivity. Unrelated: * app/tools/gimpellipseselecttool.c (gimp_ellipse_select_tool_draw): use 360 * 64 instead of 23040. |
|
|
William Skaggs
|
1d03a22c3f |
Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/core/gimpchannel-select.[ch]: add push_undo arguments to several gimp_channel_select_foo functions. * app/actions/vectors-commands.c * app/core/gimpchannel-select.c * app/core/gimpchannel-select.h * app/pdb/paths_cmds.c * app/pdb/selection_tools_cmds.c * app/pdb/vectors_cmds.c * app/tools/gimpellipseselecttool.c * app/tools/gimpfreeselecttool.c * app/tools/gimprectangleselecttool.c * app/tools/gimpvectortool.c * tools/pdbgen/pdb/paths.pdb * tools/pdbgen/pdb/selection_tools.pdb * tools/pdbgen/pdb/vectors.pdb: add push_undo argument to function calls where needed. |
|
|
Michael Natterer
|
9dabd23e2d |
Applied (modified and enhanced) patch from Chris Moller which allows tools
2006-08-05 Michael Natterer <mitch@gimp.org> Applied (modified and enhanced) patch from Chris Moller which allows tools to distinguish similar colors not only by composite, but also by R, G, B, H, S and V. Fixes bug #348291. * app/core/core-enums.[ch]: added new enum GimpSelectCriterion which can be one of { COMPOSITE, R, G, B, H, S, V }. * app/core/gimpimage-contiguous-region.[ch]: added select_criterion params and create the region based on difference by the selected criterion. * app/core/gimpchannel-select.[ch] * app/core/gimpdrawable-bucket-fill.[ch]: take criterion params and pass them through to the contiguous region functions. * app/tools/gimpbucketfilloptions.[ch] * app/tools/gimpselectionoptions.[ch]: added criterion properties and GUI to select it. * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpfuzzyselecttool.c: pass the selected criterion to the resp. core functions. * app/widgets/gimpdrawabletreeview.c * app/widgets/gimpselectioneditor.c * app/display/gimpdisplayshell-dnd.c * tools/pdbgen/pdb/edit.pdb * tools/pdbgen/pdb/selection_tools.pdb: changed accordingly (simply pass GIMP_SELECT_CRITERION_COMPOSITE in most cases). * app/pdb/edit_cmds.c * app/pdb/selection_tools_cmds.c: regenerated. |
|
|
Michael Natterer
|
49238237dc |
ref new tiles before unrefing the old ones.
2004-03-16 Michael Natterer <mitch@gimp.org> * app/core/gimpdrawable.c (gimp_drawable_set_tiles): ref new tiles before unrefing the old ones. * app/core/gimpimage-undo-push.c: keep undo memsize exact by adjusting undo->size when the stored data changes. * app/core/gimpchannel.[ch] (gimp_channel_new_from_alpha) * app/core/gimpchannel-select.[ch] (gimp_channel_select_alpha): replaced "layer" parameter by "drawable". * app/gui/layers-commands.c * tools/pdbgen/pdb/selection.pdb: changed accordingly. * app/pdb/selection_cmds.c: regenerated. * app/core/gimpchannel.c * app/core/gimplayer.c * app/core/gimplayermask.[ch] * app/core/gimpselection.c: remdom cleanup & code review. |
|
|
Michael Natterer
|
da2bd8b91a |
added GimpScanConvert typedef.
2003-10-09 Michael Natterer <mitch@gimp.org> * app/core/core-types.h: added GimpScanConvert typedef. * app/core/gimpscanconvert.h: removed it here. * app/core/gimpchannel-select.[ch]: factored out new function gimp_channel_select_scan_convert(). (gimp_channel_select_polygon) (gimp_channel_select_vectors): use it. (gimp_channel_select_alpha): when called on a layer without alpha, don't fail but fake the effect of a fully opaque alpha channel. * app/tools/gimpiscissorstool.c: some cleanup. (iscissors_convert): fixed my latest cleanup (don't cast the tool to a GimpGrawable ;). Don't ignore options->antialias. |
|
|
Michael Natterer
|
f0372cad0f |
Treat changes to the selection like changes to any other drawable:
2003-10-06 Michael Natterer <mitch@gimp.org> Treat changes to the selection like changes to any other drawable: * app/core/gimpchannel.c * app/core/gimpchannel-combine.c: call gimp_drawable_update() after changing the channel. * app/core/gimpimage.[ch]: added struct GimpImageFlushAccumulator with one member "gboolean mask_changed". Connect to "update" of the selection and set accum.mask_changed to TRUE in the callback. Added default implementation for GimpImage::flush() and emit "mask_changed" there. Unrelated: * app/core/gimpimage.h: removed GimpGuide struct... * app/core/gimpimage-guides.h: ...and added it here. * app/core/gimpimage-undo-push.c (undo_pop_mask) (undo_pop_channel_mod): don't distinguish between selection and non-selection channels and just call gimp_drawable_update(). * app/core/gimpundo.h * app/core/gimpimage-undo.c: removed "gboolean mask_changed" from the GimpUndoAccumulator struct since we don't have to care about that signal explicitly any more. * app/display/gimpdisplay-foreach.[ch]: removed gimp_displays_flush(). * tools/pdbgen/pdb/display.pdb (displays_flush_invoker): call gimp_image_flush() on all images so the flush accumulator is honored. This generalization enables the removal of more special purpose code which was needed to treat the selection different: * app/core/gimpimage-mask-select.[ch]: removed... * app/core/gimpchannel-select.[ch]: ...and added under a new name because it's not selection specific any more. * app/core/gimpimage-mask.[ch]: removed... * app/core/gimpselection.[ch]: ...added the two remaining functions here. Removed all calls to gimp_image_mask_changed(). * app/core/Makefile.am * app/core/gimp-edit.c * app/core/gimpdrawable-transform.c * app/core/gimpimage-scale.c * app/core/gimpimage-snap.c * app/display/gimpdisplayshell.c * app/gui/channels-commands.c * app/gui/layers-commands.c * app/gui/select-commands.c * app/gui/vectors-commands.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpellipseselecttool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpiscissorstool.c * app/tools/gimprectselecttool.c * app/tools/gimptransformtool.c * app/widgets/gimpchanneltreeview.c * app/widgets/gimpselectioneditor.c * app/widgets/gimpvectorstreeview.c * app/xcf/xcf-save.c * tools/pdbgen/pdb/paths.pdb * tools/pdbgen/pdb/selection.pdb * tools/pdbgen/pdb/selection_tools.pdb: changed accordingly. * app/core/gimpdrawable-bucket-fill.c * app/core/gimpimage-colormap.c * app/core/gimplayer-floating-sel.c * app/core/gimplayer.c * app/gui/image-menu.c * app/paint/gimppaintcore.c * app/tools/gimpcroptool.c * app/tools/gimpinkoptions.c * app/tools/gimpvectortool.c: removed useless and/or obsolete #includes. * app/pdb/display_cmds.c * app/pdb/paths_cmds.c * app/pdb/selection_cmds.c * app/pdb/selection_tools_cmds.c: regenerated. |
|
|
Michael Natterer
|
1c04c3f601 |
removed the _clear() wrapper.
2003-09-03 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask-select.[ch]: removed the _clear() wrapper. * app/core/gimpimage-mask.[ch]: changed accordingly. Added "const gchar *undo desc" parameter to gimp_image_mask_select_vectors(). * app/core/gimpimage-qmask.c * app/gui/vectors-commands.c * app/text/gimptext-compat.c * app/tools/gimpbucketfilltool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimprectselecttool.c * app/widgets/gimpvectorstreeview.c * tools/pdbgen/pdb/paths.pdb * tools/pdbgen/pdb/selection.pdb: changed accordingly. Also replaced some wrappers which still exist. * tools/pdbgen/pdb/paths.pdb: stroke using gimp_item_stroke(). * app/pdb/paths_cmds.c * app/pdb/selection_cmds.c: regenerated. |
|
|
Michael Natterer
|
a319c455d9 |
app/widgets/Makefile.am new file defining the available help topics. Work
2003-08-21 Michael Natterer <mitch@gimp.org> * app/widgets/Makefile.am * app/widgets/gimphelp-ids.h: new file defining the available help topics. Work in progress and totally unusable for matching to the help system. Stay tuned... * app/gui/about-dialog.c * app/gui/brushes-menu.c * app/gui/buffers-menu.c * app/gui/channels-commands.[ch] * app/gui/channels-menu.c * app/gui/edit-commands.c * app/gui/file-commands.c * app/gui/file-new-dialog.c * app/gui/file-open-dialog.c * app/gui/file-save-dialog.c * app/gui/gradients-commands.c * app/gui/gradients-menu.c * app/gui/image-menu.c * app/gui/layers-commands.[ch] * app/gui/layers-menu.c * app/gui/module-browser.c * app/gui/offset-dialog.c * app/gui/palettes-menu.c * app/gui/patterns-menu.c * app/gui/resize-dialog.c * app/gui/select-commands.c * app/gui/templates-menu.c * app/gui/tips-dialog.c * app/gui/toolbox-menu.c * app/gui/vectors-commands.[ch] * app/gui/vectors-menu.c: replaced literal HTML file paths by help IDs from gimphelp-ids.h. Renamed some menu callbacks to be consistent with similar ones. This is just an intermediate commit and not finished. While browsing all the menus, I noticed that our "x to selection" functions are not consistent at all. They should all offer the REPLACE,ADD,SUBTRACT,INTERSECT options: * app/core/gimpchannel.[ch]: added new function gimp_channel_new_from_alpha(). Removed gimp_channel_layer_alpha() and gimp_channel_layer_mask(). * app/core/gimpimage-mask.[ch]: added gimp_image_mask_select_alpha() and gimp_image_mask_select_component() which offer the full set of operation, feather and feather_radius parameters as the other selection functions. * app/core/gimpimage-mask-select.[ch]: removed gimp_image_mask_layer_alpha() and gimp_image_mask_layer_mask(). * app/gui/channels-commands.c (channels_channel_to_selection): use gimp_image_mask_select_component() instead of implementing it here. * app/gui/image-menu.c * app/gui/layers-commands.[ch]: offer the full choice of REPLACE,ADD,SUBTRACT,INTERSECT with "Alpha to Selection" and "Mask to Selection". * tools/pdbgen/pdb/selection.pdb: changed accordingly. * app/pdb/selection_cmds.c: regenerated. |
|
|
Michael Natterer
|
7a6a8d9dbb |
Moved the undo step implementations to the core and pass around lots of
2003-02-14 Michael Natterer <mitch@gimp.org> Moved the undo step implementations to the core and pass around lots of "const gchar *undo_desc". Fixes bug #104367. * app/Makefile.am * app/undo.[ch]: removed... * app/core/Makefile.am * app/core/gimpimage-undo-push.[ch]: ...and added here. * app/paint/Makefile.am * app/tools/Makefile.am * app/paint/gimppaintcore-undo.[ch] * app/tools/gimptransformtool-undo.[ch]: new files for the paint and transform undos. * app/core/gimppaintinfo.[ch]: added a blurb. * app/paint/gimpairbrush.c * app/paint/gimpclone.c * app/paint/gimpconvolve.c * app/paint/gimpdodgeburn.c * app/paint/gimperaser.c * app/paint/gimppaintbrush.c * app/paint/gimppaintcore.c * app/paint/gimppencil.c * app/paint/gimpsmudge.c * app/paint/paint-types.h * app/paint/paint.c: pass the blurb when registering the core. * app/core/gimpdrawable.[ch] * app/core/gimpimage.[ch] * app/core/gimpimage-mask-select.[ch] * app/core/gimpimage-mask.[ch] * app/core/gimpimagemap.[ch] * app/core/gimplayer-floating-sel.[ch]: added "undo_desc" parameters to all undo pushing helper functions. * app/undo_history.c * app/core/gimpchannel.c * app/core/gimpdrawable-blend.c * app/core/gimpdrawable-bucket-fill.c * app/core/gimpdrawable-desaturate.c * app/core/gimpdrawable-equalize.c * app/core/gimpdrawable-invert.c * app/core/gimpdrawable-offset.c * app/core/gimpdrawable-transform.c * app/core/gimpedit.c * app/core/gimpimage-convert.c * app/core/gimpimage-crop.c * app/core/gimpimage-guides.c * app/core/gimpimage-merge.c * app/core/gimpimage-qmask.c * app/core/gimpimage-resize.c * app/core/gimpimage-scale.c * app/core/gimpimage-undo.c * app/core/gimpitem.c * app/core/gimplayer.c * app/core/gimplayermask.c * app/display/gimpdisplayshell-dnd.c * app/file/file-open.c * app/file/file-save.c * app/gui/channels-commands.c * app/gui/file-commands.c * app/gui/file-open-dialog.c * app/gui/image-commands.c * app/gui/layers-commands.c * app/gui/paths-dialog.c * app/gui/select-commands.c * app/gui/vectors-commands.c * app/text/gimptext-compat.c * app/tools/gimpbezierselecttool.c * app/tools/gimpbucketfilltool.c * app/tools/gimpeditselectiontool.c * app/tools/gimpfreeselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpimagemaptool.c * app/tools/gimpinktool.c * app/tools/gimpiscissorstool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimprectselecttool.c * app/tools/gimptexttool.c * app/tools/gimptransformtool.c * app/widgets/gimpchannellistview.c * app/widgets/gimpdrawablelistview.c * app/widgets/gimpselectioneditor.c * tools/pdbgen/pdb/color.pdb * tools/pdbgen/pdb/drawable.pdb * tools/pdbgen/pdb/guides.pdb * tools/pdbgen/pdb/layer.pdb * tools/pdbgen/pdb/selection.pdb * tools/pdbgen/pdb/selection_tools.pdb: changed accordingly: pass "undo_desc" strings, changed includes or simply removed inclusion of "undo.h". Some random cleanups. * tools/pdbgen/pdb/guides.pdb: cleaned up a lot. Fixed gimp_image_find_next_guide() to not return guides with position < 0 (and made it shorter and readable). * app/pdb/color_cmds.c * app/pdb/drawable_cmds.c * app/pdb/guides_cmds.c * app/pdb/layer_cmds.c * app/pdb/selection_cmds.c * app/pdb/selection_tools_cmds.c: regenerated. |
|
|
Sven Neumann
|
d68b730a82 |
app/core/core-enums.h more enum cleanup (ChannelOps this time).
2002-03-18 Sven Neumann <sven@gimp.org> * app/core/core-enums.h * app/core/core-types.h: more enum cleanup (ChannelOps this time). * app/core/gimpchannel.[ch] * app/core/gimpimage-mask-select.[ch] * app/gui/channels-commands.c * app/gui/vectors-commands.c * app/tools/gimpbezierselecttool.c * app/tools/tools-types.h * app/widgets/gimpchannellistview.[ch] * tools/pdbgen/pdb/channel.pdb * tools/pdbgen/pdb/selection.pdb * tools/pdbgen/pdb/selection_tools.pdb: changed accordingly. * app/pdb/channel_cmds.c * app/pdb/selection_cmds.c * app/pdb/selection_tools_cmds.c * libgimp/gimpenums.h * plug-ins/script-fu/script-fu-constants.c * tools/pdbgen/enums.pl: regenerated. |
|
|
Michael Natterer
|
affc31007e |
changed gimp_image_mask_select_channel() to not take "drawable" and
2002-03-03 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask-select.[ch]: changed gimp_image_mask_select_channel() to not take "drawable" and "sample_merged" parameters (which are silly in some contexts) but simply the offsets of the passed channel. * app/gui/channels-commands.c * app/tools/gimpbezierselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/gimpiscissorstool.c: changed accordingly. * app/tools/gimpdrawtool.[ch]: chaged gimp_draw_tool_draw_lines() and _draw_strokes() to take an additional "use_offsets" parameter like the other drawing functions. * app/path_curves.c * app/tools/gimpvectortool.c: changed accordingly. * app/paint/gimppaintcore.c: removed #if 0'ed code which was identical to other functions. * app/tools/gimpselectiontool.c: use the GimpEditSelectionTool's "arrow_key_func" so it's now possible to keyboad-move the current layer and selection with all selection tool. Needs some more tweaking... * app/tools/gimpiscissorstool.[ch] * app/tools/gimpvectortool.[ch]: derive them from GimpSelectionTool to make the modifier key <-> tool options interaction work. Ported IScissors to the new way the draw_tool works. |
|
|
Michael Natterer
|
52d07c9646 |
implemented gimp_image_mask_select_vectors() as simple wrapper around
2002-02-26 Michael Natterer <mitch@gimp.org> * app/core/gimpimage-mask-select.[ch]: implemented gimp_image_mask_select_vectors() as simple wrapper around gimp_image_mask_select_polygon(). * app/gui/vectors-commands.c: call it from the "to selection" callbacks. * app/gui/channels-commands.c: use gimp_image_mask_select_channel() instead of doing the same manually. * app/paint/gimppencil.c: register as "GimpPencil", not "GimpPencilCore". * app/widgets/Makefile.am * app/widgets/widgets-types.h * app/widgets/gimpvectorslistview.[ch]: new GimpItemListView subclass featuring a "To Selection" and "Stroke" button. * app/widgets/gimpitemlistview.c: create GimpVectorsListViews. |
|
|
Michael Natterer
|
ceed8eae4e |
removed #if 0'ed old display update hackery. Don't flush the displays here
2002-02-10 Michael Natterer <mitch@gimp.org> * app/undo.c: removed #if 0'ed old display update hackery. Don't flush the displays here at all and include nothing from "display/". * app/undo_history.c * app/gui/edit-commands.c: call gdisplays_flush() if undo_pop() or undo_redo() return TRUE. * app/core/gimpimage-contiguous-region.[ch]: allow a contiguous transparent region to be selected/filled (#71058). * app/core/gimpdrawable-bucket-fill.[ch] * app/core/gimpimage-mask-select.[ch]: take a boolean fill_transparent/select_transparent parameter and pass it to the contiguous region funcion. * app/display/gimpdisplayshell-dnd.c: pass fill_transparent == FALSE to bucket_fill_full because we fill the whole drawable anyway here. * app/tools/gimpbucketfilltool.c * app/tools/gimpbycolorselecttool.c * app/tools/gimpfuzzyselecttool.c * app/tools/selection_options.[ch]: added toggle buttons to the tool options and pass the value to the fill and select core functions. * tools/pdbgen/pdb/misc_tools.pdb * tools/pdbgen/pdb/selection_tools.pdb: hardcode "select_transparent" to FALSE to get the old behaviour. Should export the new feature to plug-ins however. * app/pdb/misc_tools_cmds.c * app/pdb/selection_tools_cmds.c: regenerated. |
|
|
Michael Natterer
|
02fde14c95 |
build display/ before tools/.
2001-11-08 Michael Natterer <mitch@gimp.org> * app/Makefile.am: build display/ before tools/. * app/devices.c: devices_check_change(): added all events which have a GdkDevice pointer. * app/gimpprogress.c: include "display-types.h" instead of "core-types.h". * app/core/Makefile.am * app/core/gimpdrawable-bucket-fill.[ch]: new files: the bucket_fill stuff taken from tools/gimpbucketfilltool.[ch]. * app/core/core-types.h: added "BucketFillMode". * app/core/gimpimage-mask-select.[ch]: cleanup. * app/core/gimpmarshal.list: added more marshallers for GimpTool's new signal signatures. * app/core/gimpmarshal.[ch]: regenerated. * app/display/Makefile.am * app/display/gimpdisplayshell-dnd.[ch] * app/display/gimpdisplayshell-layer-select.[ch]: new files: the canvas drop callbacks from gimpdisplayshell-callbacks.[ch] and the stuff formerly knows as gui/layer-select.[ch]. * app/display/gimpdisplay.h: don't include "gui/gui-types.h". * app/display/gximage.c: include "display-types.h". * app/display/gimpdisplay-foreach.c * app/display/gimpdisplayshell.[ch]: call gdsplay_delete(), don't destroy the shell widget. * app/gui/Makefile.am * app/gui/layer-select.[ch]: removed. * app/gui/gradients-commands.c: fixed "Save as POV" fprintf()s. * app/gui/preferences-dialog.c: removed the layer_select stuff because it is useless with the new preview system. * app/gui/tool-options-dialog.c: send the correct data to the close_callback. * app/gui/tools-commands.c: changed to follow the new gimp_tool_initialize() semantics (see below). Tool & canvas event handling chainsawing: * app/tools/tools-types.h: new struct GimpCoords which contains x, y, pressure, tilt etc. * app/display/gimpdisplayshell-callbacks.[ch]: added utility functions which transparently retreive the current event's GimpCoords or take it from the device directly if the event has none. Pass GimpCoords _in_image_coordinates_ to all tool functions. Most important: don't pass GdkEvents and display coordinates to tools any more. * app/tools/gimptool.[ch]: changed virtual functions to take GimpCoords, time and state separately instead of GdkEvents. * app/tools/gimpbezierselecttool.c * app/tools/gimpblendtool.c * app/tools/gimpbucketfilltool.[ch] * app/tools/gimpbycolorselecttool.c * app/tools/gimpclonetool.c * app/tools/gimpcolorpickertool.c * app/tools/gimpconvolvetool.c * app/tools/gimpcroptool.[ch] * app/tools/gimpcurvestool.c * app/tools/gimpdodgeburntool.c * app/tools/gimpdrawtool.c * app/tools/gimpeditselectiontool.[ch] * app/tools/gimperasertool.c * app/tools/gimpfliptool.c * app/tools/gimpfreeselecttool.[ch] * app/tools/gimpfuzzyselecttool.c * app/tools/gimpinktool.c * app/tools/gimpiscissorstool.c * app/tools/gimpmagnifytool.c * app/tools/gimpmeasuretool.c * app/tools/gimpmovetool.c * app/tools/gimppainttool.c * app/tools/gimppathtool.[ch] * app/tools/gimprectselecttool.c * app/tools/gimprotatetool.c * app/tools/gimpselectiontool.[ch] * app/tools/gimpsmudgetool.c * app/tools/gimptexttool.c * app/tools/gimptransformtool.[ch] * app/tools/path_tool.[ch] * app/tools/selection_options.c: tons and tons of changes: - changed to use the new virtual function parameters. - removed zillions of gdisplay_untransform_coords(). - get the active drawable's offsets manually in many cases. (questionable, but IMHO ok because it's obvious and not simply a "TRUE" passed to some function) - reordered some functions to be consistent across tools. - some tools had to be changed to work on image coords, not display ones (esp. crop). - fixed strange rotate tool behaviour which should be backported to stable. - some stuff i came across. - indentation and other paranoia. - rounding of coordinated may be broken in some tools. - new bugs guaranteed. * app/tools/tool_manager.[ch]: new semantic of tool_manager_initialize_active() (looked at the places where it was used from and put common code together). Should be a bit better now :) * app/tools/gimpblendtool.c * app/tools/transform_options.c: use the new GTK+ feature that a widget (toggle button) can be a frame's title for this tools' tool options. * app/widgets/widgets-types.h: stuff. * themes/Default/gtkrc: s/GtkDialog/GimpDialog/. * tools/pdbgen/Makefile.am: don't scan tools/gimpbucketfilltool.h any more. * tools/pdbgen/enums.pl: regenerated. * tools/pdbgen/pdb/tools.pdb: changed bucket_fill wrapper. * app/pdb/tools_cmds.c: regenerated. |
|
|
Michael Natterer
|
99e78c7074 |
General cleanup of the selection tools and their PDB wrappers:
2001-10-22 Michael Natterer <mitch@gimp.org> General cleanup of the selection tools and their PDB wrappers: * app/core/Makefile.am * app/core/gimpimage-contiguous-region.[ch] * app/core/gimpimage-mask-select.[ch]: new files providing a clean, uniform API for the selection functionalities. Changed order of parameters to be consistent, removed code duplication. The region returned by the "by_color" function is not really contiguous but the API is so similar to "by_seed" and it's used in the same context so it's fair enough to put them together. Also, I'm not sure if the two is_pixel_sufficiently_different() I've optimized away were meant to do *exactly* the same. Added a comment there to remember the former difference. * app/core/gimpchannel.[ch] (gimp_channel_feather): removed the "output" channel parameter and made it optionally push an undo (like the other channel operations do). * app/core/gimpimage-mask.c: call gimp_channel_feather() with "push_undo == TRUE", removed some useless comments. * app/tools/gimpbycolorselecttool.[ch] * app/tools/gimpellipseselecttool.[ch] * app/tools/gimpfreeselecttool.[ch] * app/tools/gimpfuzzyselecttool.[ch] * app/tools/gimprectselecttool.[ch]: removed all the actual selection functionality and call the new gimp_image_mask_select_*() and gimp_image_contiguous_region_*() functions instead. * app/tools/gimpbezierselecttool.c * app/tools/gimpiscissorstool.c: use new function gimp_image_mask_select_channel() instead of doing the same manually. * app/tools/gimpbucketfilltool.c: find_contiguous_region() -> gimp_image_contiguous_region_by_seed(). * tools/pdbgen/Makefile.am * tools/pdbgen/groups.pl * tools/pdbgen/pdb/selection_tools.pdb: added new group "Selection Tools" which depends only on "core/" stuff (not on "tools/" any more, brrrr). * tools/pdbgen/pdb/text_tool.pdb: don't include "appenv.h" * tools/pdbgen/pdb/tools.pdb: removed the selection tools. * app/pdb/Makefile.am * app/pdb/selection_tools_cmds.c: new file. * app/pdb/internal_procs.c * app/pdb/text_tool_cmds.c * app/pdb/tools_cmds.c: regenerated. * libgimp/Makefile.am * libgimp/gimp_pdb.h * libgimp/gimpselectiontools_pdb.[ch]: new files. * libgimp/gimptools_pdb.[ch]: regenerated Misc cleanups: * app/app_procs.c: call splash_create() with "no_splash_image" as parameter. * app/display/gimpdisplay-render.c * app/display/gximage.c: don't include "appenv.h". * app/gui/gui.c: call session_restore() only if "restore_session" is TRUE. * app/gui/session.c: don't "if(restore_session)" here and don't include "appenv.h" * app/gui/splash.[ch]: added "gboolean show_image" parameter to splash_create(), don't include "appenv.h" * app/tools/gimppainttool.[ch]: added a "GimpGradient" parameter to gimp_paint_tool_get_color_from_gradient(). * app/tools/gimppaintbrushtool.c: pass the gradient. * app/tools/gimpselectiontool.c * app/tools/gimptransformtool.c * app/tools/tool_manager.c: s/GDisplay/GimpDisplay/. * app/widgets/gimpcontainergridview.[ch]: removed the "white_style" class variable and don't fiddle around with colors and styles... * themes/Default/gtkrc: ...do the same here with a simple rc style. |