59f4396c7b
app: use the toggle_behavior modifier instead of GDK_CONTROL_MASK
...
to switch between dragging a guide or a sample point from a ruler.
2011-10-06 21:10:18 +02:00
da2410148c
Revert "app: initalize rectangle tool respecting size constrants"
...
This reverts commit ef7060251c
2011-10-06 20:16:26 +03:00
970782cfef
Revert "app: prevent executing rectangle tool on the creating click"
...
This reverts commit 5a99bf4f47
2011-10-06 20:16:26 +03:00
c8cde40952
Revert "app: handle motion right just created size fixed rects"
...
This reverts commit c8fa2c99e8
2011-10-06 20:16:26 +03:00
3ad505b124
Revert "app: rect tool changes made for suppressed execute need to be applied"
...
This reverts commit eff20af915
2011-10-06 20:16:25 +03:00
e55ceea11a
app: handle MOD2 in GimpTool's generic modifier code
...
because we "know" that it's used on the Mac and unfortunately there
is no other way of knowing but simply knowing it...
2011-10-06 16:43:23 +02:00
f4141d6942
app: add a utility function that returns the "constrain" modifier
2011-10-06 16:42:42 +02:00
c0610697cb
app: remove widget parameter from gimp_modifiers_to_channel_op()
...
and simply use the default keymap.
2011-10-06 16:33:05 +02:00
10a9c660f8
app: add utility functions which return modifier masks
...
Simply get the masks from the default display's keymap, since
the widget makes absolutely no difference here.
2011-10-06 16:33:05 +02:00
c9e7186a35
app: Conditionally assign show_menu
2011-10-06 19:45:32 +05:30
d6d2a0bbd1
app (gimprc): Delete dead assignment
2011-10-06 19:23:06 +05:30
29e7d032a3
app (file-save-dialog): Remove dead code and variables
2011-10-06 09:01:51 +05:30
ad3633110a
app: Remove duplicate assignment
2011-10-06 08:37:41 +05:30
3699475be9
app (xcf): Remove duplicate assignment
2011-10-06 08:35:00 +05:30
990a4bd271
app: don't forget to move the start handle in GimpBlendTool
...
because the tool moves both handles when Alt is pressed.
2011-10-05 23:40:44 +02:00
e8250320d5
app: use gdk_event_triggers_context_menu() for the image menu
...
and clean up button event handling a bit.
2011-10-05 20:04:42 +02:00
c18c21f651
app: treat Meta_L and Meta_R as tool-relevant modifiers
...
for the Mac, they are still unhandled by tools though.
2011-10-05 19:44:24 +02:00
4b3d3fe431
app: port the channels and paths dialog to portable selection modifiers
...
instead of hardcoding SHIFT and CONTROL.
2011-10-05 19:26:54 +02:00
f22d6b9d3b
app: use the portable EXTEND_SELECTION modifier instead of SHIFT
2011-10-05 19:26:54 +02:00
ad27b30525
app: get the "add" and "subtract" modifiers from the new portable API
...
instead of hardcoding SHIFT and CONTROL. Also replace virtual modifiers
before showing them as tooltips.
2011-10-05 19:26:54 +02:00
16d4d6fa94
app: replace virtual modifiers before displaying them as GimpEditor tooltip
2011-10-05 19:26:53 +02:00
9e44a199e5
app: use gimp_modifiers_to_channel_op()
...
instead of replicating its logic in a non-portable way.
2011-10-05 19:26:53 +02:00
fdf103ce08
app: add more modifier utility functions to gimpwidgets-utils.[ch]
...
- gimp_modifiers_to_channel_op() translates a modifier state to REPLACE,
ADD, SUBTRACT or INTERSECT.
- gimp_replace_virtual_modifiers() uses gdk_keymap_add_virtual_modifiers()
to replace the physical bits in a modifier state to their virtual
counterparts (and not just adds the virtual ones like the GDK
function).
2011-10-05 19:26:53 +02:00
f45cccbc82
app: make gimp_get_mod_string() a bit nicer
2011-10-05 18:47:37 +02:00
3982ddc39b
app: implement gimp_get_mod_string() using gtk_accelerator_get_label()
...
so it can handle all modifiers (also Mac ones).
Remove gimp_get_mod_name_shift,control,alt().
2011-10-05 01:30:59 +02:00
1459f5bb61
app: unparent GimpDockBook's menu button in dispose() not finalize()
...
because unparenting requires a fully functional object that can
be used as signal parameter. I have no clue why this doesn't
trigger criticals on X11.
2011-10-04 23:54:42 +02:00
29a6c71f00
app: don't use GNU-only options when generating git-version.h
2011-10-04 23:36:21 +02:00
1c730f94ac
app (paint-funcs): Delete dead assignment and move variable
2011-10-04 14:55:41 +05:30
0a3c8c5c86
app (siox): Delete redundant total initializer
2011-10-04 14:44:56 +05:30
f9cebd40a7
app (tool-preset-editor): Delete dead code and variables
2011-10-04 14:37:36 +05:30
9a39d84e96
app: Remove dead assignment
2011-10-03 19:13:22 +05:30
f33dcf2df2
app: Don't care about return value of g_string_append()
2011-10-03 19:06:37 +05:30
01daf311b4
app: Remove redundant assignments
2011-10-03 13:29:02 +05:30
9dd857d996
app: Remove dead assignments (and variable)
2011-10-03 13:11:09 +05:30
0ccaaf8216
app: Remove dead assignments (and variable)
2011-10-03 13:05:58 +05:30
16ca43e4c8
Revert "app: Add /gimptilebackendtilemanager/basic_write unit test"
...
This reverts commit e4d6726bde
2011-10-02 18:41:11 +02:00
e4d6726bde
app: Add /gimptilebackendtilemanager/basic_write unit test
...
Rename the 'basic_usage' test to 'basic_read' and add 'basic_write'
test. Implement GimpTileBackendTileManagerPrivate enough to make them
pass.
Note that these tests currently do not work with GIMP's "effective
tile size" optimization.
2011-10-02 18:25:08 +02:00
f1d4dde36a
libgimpwidgets: add gdk_event_triggers_context_menu() to gimp3migration.[ch]
...
and remove gimp_button_event_triggers_context_menu() again. Update
all callers to use the new function.
2011-10-02 16:23:59 +02:00
e79f90d3b6
app: Fix assignment (may be confused as compound assignment)
2011-10-02 19:15:08 +05:30
7d083ce457
app: Don't overload head_size with different meanings
...
The code in file_procedure_find() tries to lazy-open the image file, so
it's not opened if unnecessary. To keep track of whether the image was
opened or not, it overrides head_size to keep track of this. head_size
is also assigned the return value of fread() in the loop. The patch
separates this by introducing another variable.
I think it's best to move the file opening code outside the while loop,
as it's most likely bound to be opened anyway, and the penalty is not
too bad.
2011-10-02 18:42:16 +05:30
2c175b068d
libgimpwidgets: add gtk_paned_new() to gimp3migration.[ch]
...
and use it all over the place.
2011-10-02 14:36:42 +02:00
19b9bfd189
libgimpwidgets: add gtk_scale_new() to gimp3migration.[ch]
...
and use it all over the place. Also change some GtkObject* variables
to GtkAdjustment*.
2011-10-02 14:36:41 +02:00
16817c666f
libgimpwidgets: add gtk_scrollbar_new() to gimp3migration.[ch]
...
and use it all over the place.
2011-10-02 14:36:41 +02:00
eff20af915
app: rect tool changes made for suppressed execute need to be applied
2011-10-01 17:07:51 +03:00
c8fa2c99e8
app: handle motion right just created size fixed rects
2011-10-01 15:03:16 +03:00
5a99bf4f47
app: prevent executing rectangle tool on the creating click
2011-10-01 15:03:16 +03:00
ef7060251c
app: initalize rectangle tool respecting size constrants
2011-10-01 12:38:04 +03:00
f342b50483
libgimpwidgets: add gtk_button_box_new() to gimp3migration.[ch]
...
and use it all over the place.
2011-09-30 15:44:33 +02:00
cb242a484e
app: Add basic GimpTileBackendTileManager unit test
...
Add a super basic GimpTileBackendTileManager unit test and implement
GimpTileBackendTileManager enough to make it pass. Still a lot of work
left to do, this was just to get things up and running.
2011-09-30 12:00:40 +02:00
06a16afa7d
app: Add GimpTileBackendTileManagerPrivate
...
Also do some minor cleanup.
2011-09-30 12:00:40 +02:00
3e336199b9
app: use gtk_box_new()
2011-09-30 11:29:11 +02:00
2b2ecd1af1
app/tests: Remove static Gimp *gimp
...
Say no to evilness.
2011-09-30 07:56:47 +02:00
cd2a1a92fc
app: Add configurable path for tool presets in preferences
2011-09-29 20:29:49 +03:00
d34bbaec2d
app: #undef G_DISABLE_DEPRECATED where GStaticMutex is used
...
because it's deprecated in GLib 2.30.
2011-09-28 23:27:49 +02:00
0f03ed9e05
Bug 616416: hidden layer groups appear again after an image change
...
Introduced two virtual functions to a GimpViewable
'set_expanded' and 'get_expanded'
and a PROP_GROUP_ITEM_FLAGS to load/save the expanded state
of layer_groups and use them.
2011-09-25 21:57:20 +02:00
a67bb11cf5
Revert "Bug 616416: hidden layer groups appear again after an image change"
...
This reverts commit 359c9c22d9
2011-09-25 21:49:36 +02:00
359c9c22d9
Bug 616416: hidden layer groups appear again after an image change
2011-09-25 21:38:50 +02:00
e071bfa3b6
Bug 656716 - Have a procedure to get a layer from its name
...
Add gimp_image_get_[layer|channel|vectors]_by_name().
2011-09-24 16:35:59 +02:00
624e99041b
app: remove unused variable in gimp_image_map_tool_initialize()
2011-09-24 16:20:50 +02:00
c3c40fd45f
Bug 545910 - crash when selecting a font after a search
...
Add an explicit search entry, so the treeview's automatic search
popup doesn't break our grab and closes the dialog in the middle
of setting up the serach popup.
2011-09-24 10:58:48 +02:00
69f55d0fb0
Bug 152259 - Revert button in GimpDataEditor is not implemented
...
Hide the button instead of only setting it insensitive.
2011-09-24 00:55:37 +02:00
fdb69d20d5
Revert accidental usage of gtk_box
2011-09-24 00:44:14 +02:00
4e3c308931
Bug 658902 - Show different icon for visible layer group members of...
...
Set the "eye" renderer to inconsistent state if the item is visible,
but not effectively viewable because one of its parents is invisible.
2011-09-23 23:45:10 +02:00
d995fefb7c
app: add gimp_item_is_visible()
...
which returns TRUE if an item is effectively visible (it is visible
and all its parents are visible).
2011-09-23 23:43:42 +02:00
0e1d07d129
Bug 659446 - Missing plural handling for...
...
Use ngettext() instead of simply _().
2011-09-23 23:09:26 +02:00
944f6a529d
Bug 656512 - Moving a floating selection - objects disappear
...
Fix typo in gimp_drawable_fs_update(): use the drawable's x and y
offsets to calculate the intersection with the fs' update area, and
not the y offset for both axes.
2011-09-23 22:34:25 +02:00
578e6402b8
app: don't detach the floating selection if it's not attached
...
Fix the commit two down in the log: a layer can be a floating
selection even if it's not attached to anything (when it is on the
undo stack). Don't detach it if it is not the underlying drawable's
current fs.
2011-09-23 22:24:23 +02:00
208fedd7ea
app: don't add GimpLayer's source node to two different parents
...
When the layer is a floating selection, its source node is being
hijacked by the underlying drawable to be composited on top of it.
This can happen before the layer's own layer node is being created; in
this case we must not add the source node to the layer node. Detaching
the floating selection in any way will fix up things later.
2011-09-23 21:58:00 +02:00
e8f64664c9
app: properly detach floating selection in dispose()
...
We crash when closing an image that has a floating selection and the
GEGL projection is being used. Detach the floating selection when
either the FS or the drawable it's attached to are disposed. This fix
only makes it crash later, but makes sense as separate commit.
2011-09-23 19:55:24 +02:00
5c8ded8960
app: let the drawable keep around a pointer to its floating selection
...
Instead of getting the floating selection from the image. Change
gimp_drawable_has_floating_sel() to get_floating_sel() and remove the
"floating_sel" parameter from gimp_drawable_deatch_floating_sel().
This cleanup is one more step towards sanitizing floating selections,
and makes the crash fix in the next commit much much simpler.
2011-09-23 19:31:50 +02:00
281c4cebb2
Bug 659804: wrong tooltips in the Align tool options
2011-09-22 18:13:10 +02:00
b300e389d2
Bug 659052: stroke path with a pattern always uses the Pine pattern
2011-09-20 14:01:35 +02:00
439e8b0bf1
app/text: nuke gimpfont-utils.[ch]
...
gimp_font_util_pango_font_description_to_string() isn't needed any
longer as this was fixed long ago in pango itself (and we require a much
higher version anyway). See Pango bug #166540 (at GNOME Bugzilla).
2011-09-19 15:44:26 +02:00
d92cd2f6c8
Add gimp_button_event_triggers_context_menu() and use it
...
instead of checking for event->button == 3, so context menus
work correctly on the Mac. Didn't change the image menu yet
because thet requires some more refactoring.
2011-09-19 00:47:23 +02:00
f8a2644b13
app: sanitize event->button checking in GimpNavigationView
...
Use if() instead of switch() with one case:, and ignore
double and triple clicks.
2011-09-18 19:49:05 +02:00
9199432eda
Bug 659376: wrong behavior of the channel visibility button
2011-09-18 15:46:19 +02:00
7656e2bda1
app: make gimp_window_key_press_event() do the right thing on a Mac
...
which is look at the right modifier when checking if a key event
can invoke an accelerator. Also get the mnemonic modifier from
GTK instead of hardcoding it, and don't check for it if mnemonics
are disabled, which is the right thing to do on all platforms.
2011-09-17 23:26:58 +02:00
6b0e77eafe
app: adapt ige-mac-menu.c to the change to META as primary modifier
2011-09-16 23:24:49 +02:00
ed00cff9d3
app: don't use image_window->menubar if it's NULL
2011-09-16 23:24:49 +02:00
3066a8228a
app: use <primary> instead of <control> in accelerator strings
...
but generically change it back to <control> for GTK+ < 2.24.7.
This enables using the Command modifier on OSX,
2011-09-16 22:59:58 +02:00
8424aafc05
Bug 659084 - git-version.h can't be generated from shallow repositories
...
Pass --always to git describe so git-version.h can be generated also
from shallow (--depth 1) repositories. Cause found by Kenny Stuart.
2011-09-15 20:47:34 +02:00
9cfa0a5dde
app: use a smaller icon for the image tabs' close button
...
Also make sure the visibility of the icon doesn't depend on
GTK+ settings by packing it manually.
2011-09-15 09:04:38 +02:00
d32fa80d1d
app: Move smooth to painttool and clean up the rest
2011-09-14 20:44:45 +03:00
fea6d2e5b1
app: Add pixel_regions_free()
2011-09-14 17:34:52 +02:00
27feccc4a4
Do not access transform tool handles if NULL or stales
...
For example starting GIMP and pressing
Ctrl-N Enter Shift-T (or Shift-R or Shift-P)
showed warnings on the console, and with window manager's
focus mode set to 'click' it was also possible to crash GIMP.
2011-09-13 18:12:35 +02:00
83e3e58ebc
app: Remove PixelRegionIterator::dirty_tiles
...
It is always 1 and only used in a boolean expression.
The member was introduced and used in
bc0451b4b4fd586862fce4b031932a
2011-09-13 07:07:19 +02:00
6080c11161
Revert "Bug #658816 - Add a spellchecker to the comment editor"
...
This reverts commit 978c96bbc6
2011-09-13 00:33:33 +05:30
978c96bbc6
Bug #658816 - Add a spellchecker to the comment editor
...
This is an initial version and can be improved. Something is better
than nothing. :)
2011-09-12 19:36:35 +05:30
159ee0381d
app: Complete the reversal of last patch
2011-09-11 22:48:02 +03:00
79dfee2c9e
Revert "app: Remove obsolete way of keeping track of last painted dab"
...
This reverts commit 1b62a7bff3
2011-09-11 22:47:55 +03:00
8beec385ee
app: silence a warning in ink tool
2011-09-11 21:56:33 +03:00
8f11e8743d
app: Don't mark coord done untill its actually been painted
2011-09-11 21:56:33 +03:00
c360c53873
app: Fix ink tool smooth handling
2011-09-11 16:20:47 +03:00
1b62a7bff3
app: Remove obsolete way of keeping track of last painted dab
2011-09-11 13:23:05 +03:00
9711995d88
app: remove duplicate call to coord smooth
...
Interpolation function is taking care of
the smooth now. This caused bugs with
spacing while using smooth.
2011-09-11 13:23:05 +03:00
2528f656b5
app: remove call to possibly buggy and un-needed scale clamp
...
It's likely that the removed call and function were causing
random drawing artefacts, but as this was once in a blue
moon bug, I have just a guess to go by however, testing
revealed no regressions, so pushing.
2011-09-10 21:47:52 +03:00
8b8e67ffe2
Bug 656129: Warnings: render_image_tile_fault: assertion `tile[4]...
2011-09-08 18:37:28 +02:00
50acd95e9d
app: Use pixel_region_has_alpha()
...
For increased readability.
2011-09-07 16:01:24 +02:00
9f1187f6a5
app: Prefix TileManager functions
...
read_pixel_data() -> tile_manager_read_pixel_data()
write_pixel_data() -> tile_manager_write_pixel_data()
read_pixel_data_1() -> tile_manager_read_pixel_data_1()
write_pixel_data_1() -> tile_manager_write_pixel_data_1()
for consistency.
2011-09-07 12:08:43 +02:00
e4204e453a
app: Move language specific code into language.[ch]
2011-09-06 23:12:36 +05:30
Michael Natterer