2000-05-01 Michael Natterer <mitch@gimp.org>
* libgimp/gimpsignal.[ch]
* libgimp/gimpui.c: don't panic, this is not another signal handling
change but only a namespace cleanup to make the html documentation
better. Also added documentation for gimp_ui_init().
2000-05-01 Michael Natterer <mitch@gimp.org>
* libgimp/libgimp-decl.txt
* libgimp/libgimp-sections.txt
* libgimp/tmpl/gimp.sgml
* libgimp/tmpl/gimpsignal.sgml
* libgimp/tmpl/gimpui.sgml
* libgimp/tmpl/libgimp-unused.sgml: updated.
2000-05-01 Michael Natterer <mitch@gimp.org>
* app/main.c
* libgimp/gimp.c: again... _do_ use gimp_signal_private() but
force it to behave like signal(). While on Linux it seems to
be ok to use both signal() and sigaction() (because signal() is
built on top of sigaction()), doing the same on other systems
is totally broken code. Thanks to Garry for pointing out this
portability issue.
* app/errors.c: s/vprintf/g_strdup_vprintf/
* libgimp/gimpsignal.[ch]: code formating paranoia.
2000-04-30 Michael Natterer <mitch@gimp.org>
* plug-ins/common/[a-g]*.c: use gimp_ui_init(). Minor cleanups like
reordering includes consistently and removing trailing commas from
enums and param defs.
2000-04-30 Michael Natterer <mitch@gimp.org>
* gimprc.in
* app/gimprc.[ch]: replaced "color-cube" by "min-colors".
* app/app_procs.c: read unitrc/gimprc before displaying the splash.
* app/colormaps.c: set min_colors and install_cmap before
initializing GdkRGB.
* app/gimprc.[ch]
* app/gimpunit.c: don't call the splash's progress_update function.
* app/plug_in.c: pass min_colors instead of color_cube to plugins.
* app/preferences_dialog.c: widget for min_colors.
* libgimp/gimp.[ch]: s/color_cube/min_colors/ but left
gimp_color_cube() there for source level compatibility.
* libgimp/gimpprotocol.[ch]: changed the GPConfig message
accordinly and increased the gimp protocol version number because
the change breaks binary compatibility. Also actually pass the
use_xshm variable over the wire (was only in the GPConfig struct
before).
Was it the right thing to do to increase the version number??
* libgimp/gimpui.c (gimp_ui_init): use the same code as the app
for initializing GdkRGB. Never explicitly activate Gdk's SHM
usage (only switch it off).
* app/main.c
* libgimp/gimp.c: reverted the handling of all signals except
SIGCHLD back to plain old signal() because those signals are
fatal anyway and sigaction() as used by gimp_signal_*() made
debugging (stacktrace) impossible.
* plug-ins/AlienMap/AlienMap.c
* plug-ins/AlienMap2/AlienMap2.c
* plug-ins/FractalExplorer/Dialogs.c
* plug-ins/bmp/bmp.c
* plug-ins/borderaverage/borderaverage.c
* plug-ins/dbbrowser/dbbrowser.c
* plug-ins/faxg3/faxg3.c
* plug-ins/fits/fits.c
* plug-ins/flame/flame.c
* plug-ins/fp/fp.c
* plug-ins/fp/fp_gtk.c
* plug-ins/gdyntext/Makefile.am
* plug-ins/gdyntext/gdyntext_ui.c
* plug-ins/gfig/gfig.c
* plug-ins/gflare/gflare.c
* plug-ins/gfli/gfli.c
* plug-ins/gimpressionist/gimpressionist.c
* plug-ins/helpbrowser/helpbrowser.c
* plug-ins/ifscompose/ifscompose.c
* plug-ins/imagemap/Makefile.am
* plug-ins/imagemap/imap_main.c
* plug-ins/maze/maze_face.c
* plug-ins/mosaic/mosaic.c
* plug-ins/pagecurl/pagecurl.c
* plug-ins/print/print.c
* plug-ins/rcm/rcm_dialog.c
* plug-ins/script-fu/script-fu-console.c
* plug-ins/script-fu/script-fu-scripts.c
* plug-ins/script-fu/script-fu-server.c
* plug-ins/sel2path/Makefile.am
* plug-ins/sel2path/sel2path.c
* plug-ins/sgi/sgi.c
* plug-ins/sinus/sinus.c
* plug-ins/struc/struc.c
* plug-ins/webbrowser/webbrowser.c
* plug-ins/winsnap/winsnap.c
* plug-ins/xjt/xjt.c: use gimp_ui_init().
* plug-ins/Lighting/lighting_ui.c
* plug-ins/MapObject/mapobject_ui.c: only switch Gdk SHM usage off,
never on. Don't use gimp_ui_init() here because of libgck.
2000-04-30 Garry R. Osgood <gosgood@idt.net>
* app/main.c
* libgimp/gimpsignal.c [Documentation only]
Patches arising from Tim Mooney to fix#2742
which should (hopefully) die at this point.
removes on_sig_chld() from app/main() which
offers no meaningful functionality in light
of SA_NOCHLDSTOP.
* app/paint_funcs.c: Correctly initialize the max arrays in
thin_region. Fixes bug #8351
* app/scale.c: return from the channel_scale function if we
tried to zoom in/out too far. This prevents some
unnecessary display redraws.
2000-04-26 Michael Natterer <mitch@gimp.org>
* app/color_select.c
* app/colormaps.[ch]
* app/context_manager.c: removed unused global variables
[foreground|background]_pixel and [old|new]_color_pixel.
Initialize the colormap and visual stuff with GdkRGB instead of
GtkPreview functions (which are deprecated).
* app/[62 files]: removed #include's (started with colormaps.h and
couldn't stop). Also ordered them consistently and did some small
unrelated cleanups.
Removed variuos <stdlib.h> et.al. but checked the files carefully
before doing so. If I was too radical and you get warnings on your
platform, please flame me or just put them back :)
2000-04-26 Michael Natterer <mitch@gimp.org>
* app/gdisplay.[ch]
* app/gdisplay_ops.c: made the warning_dialog a per-display
variable. The old behaviour of having only one global variable
can easily result in loss of work and should IMHO be considered
a bug.
2000-04-26 Michael Natterer <mitch@gimp.org>
* app/xcf.c (xcf_load_image_props): when reading PROP_UNIT, check
it's value against the number of built-in units, not against the
number of defined units.
2000-04-26 Michael Natterer <mitch@gimp.org>
* app/free_select.c: fill empty "default" with a "break" (#9431).
* libgimp/gimpenv.c: g_path_is_absolute wants a parameter (#9400).
2000-04-23 Tor Lillqvist <tml@iki.fi>
* libgimp/gimpui.def: Add gimp_ui_init.
* libgimp/makefile.{cygwin,msc} (gimpui_OBJECTS): Add gimpui.
* app/makefile.{cygwin,msc}
* plug-ins/makefile.{cygwin,msc}: New installation directory.
* app/datafiles.c (is_script): Must not g_free() value returned by
g_getenv().
* plug-ins/gdyntext/font_selection.c: Don't include gdkx.h with
GTk+ 1.3.
2000-04-22 Garry R. Osgood <gosgood@idt.net>
* app/bezier_select.c
Closes the most recent bezier segfault report;
about plotting anchor points on- and off-image.
unable to cite because bugs.gnome.org is not
well. Andrew Thomas handled the only other
buglet I'm aware of at this time.
Sat Apr 22 14:01:06 BST 2000 <alt@gimp.org>
* app/bezier_select.c
Fixed problem pointed out by Garry R. Osgood (manipulating
control points where curve is closed). Thanks
again Garry for pointing it out.
* libgimp/Makefile.am: gimpsignal.[ch] needs to go into libgimp,
since it is used in gimp.c
* libgimp/gimpsignal.c: use g_error instead of gimp_fatal_error
* plug-ins/common/png.c: typo fix for Nick's previous commit
-Yosh
2000-04-21 Garry R. Osgood <gosgood@idt.net>
* app/main.c
* libgimp/Makefile.am
* libgimp/gimp.c
* libgimp/gimpsignal.c (New )
* libgimp/gimpsignal.h (New )
Patch by Austin Donnelly <austin@gimp.org> to
address #2742. (I took the liberty of moving it to
libgimp for general consumption, & fixed a typo)
Thanks due to Tim Mooney
<mooney@dogbert.cc.ndsu.nodak.edu> for testing
this on various flavors of OSF/1 boxes where
#2742 seemed especially common.
* plug-ins/common/bumpmap.c: correctly initialize the bumpmap
offsets
* plug-ins/common/png.c: (load_image) if the PNG cannot be loaded,
return -1 instead of some uninitialized integer
--Sven
2000-04-20 Michael Natterer <mitch@gimp.org>
* gimprc.in
* app/gimprc.c: default to restore_session == TRUE so first time
users really see the automatically opened dialogs.
* app/session.[ch]: also open "Tool Options" if no sessionrc
exists. Moved the harcoded initial positions away from the top and
left edges of the screen to avoid dialogs which appear underneath
panels. Also arranged the four default dialogs non-overlapping.
2000-04-20 Michael Natterer <mitch@gimp.org>
* app/fuzzy_select.c
* app/selection_options.h
* app/tool_options.c: moved the "Threshold" scale from the fuzzy
select options to the selection options structure, so none of the
selection tools needs it's own tools options structure.
* app/bucket_fill.c: moved "Threshold" after "Sample Merged" as in
the fuzzy select options.
2000-04-20 Michael Natterer <mitch@gimp.org>
* libgimp/gimpfileselection.[ch]: using the GimpPixmap here was a
bad idea because showing/hiding the pixmap widgets is no solution
(somebody may call gtk_widget_show_all() and we suddenly see both
pixmaps, eek).
Reverted it to use GtkPixmap and gtk_pixmap_set().
2000-04-19 Michael Natterer <mitch@gimp.org>
* app/bucket_fill.c
* app/by_color_select.c
* app/fuzzy_select.c
* app/preferences_dialog.c: made the "default_threshold" gimprc
variable work as advertized:
- initialize the thresholds with it.
- use it for "Reset".
- added a widget to the "Tool Options" preferences page.
- noticed that the "Reset" button of "By Color Select" doesn't
behave like all the other "Reset" buttons and changed it to
reset the ui, not the selection.
(There is now a "None" button and because it was so trivial, I
couldn't resist to add "All" and "Invert" buttons, too)
* libgimp/Makefile.am
* libgimp/gimpui.c: new file.
* libgimp/gimpui.h: new function gimp_ui_init() which will be
called by all plugins which have a ui (not only by those with a
preview because plugins should always follow gimp's colormap
installation policy).
Could someone please check if the FIXME stuff in the function
is the right thing to do (TM). Does GdkRGB allocate the correct
colors for the widgets in all cases or do we have to find another
way to ensure this across processes (gtk instances)?
2000-04-19 Michael Natterer <mitch@gimp.org>
* plug-ins/gdnytext/*: fixed all files to include the i18n stuff
correctly and don't mess up Gimp's locale setup. Fixes#7878.
2000-04-18 Michael Natterer <mitch@gimp.org>
* app/user_install.c: Creating the user's gimp directory may take
some time on NFS, so users may be tempted to press the "Continue"
button again.
Inform the user that this step may take some time and set the
"Continue" and "Cancel" buttons insensitive until finished.
2000-04-17 Michael Natterer <mitch@gimp.org>
* plug-ins/helpbrowser/helpbrowser.c (open_browser_dialog):
install gimp's colormap to avoid flickering on 8 bit displays.
2000-04-16 Michael Natterer <mitch@gimp.org>
* app/gdisplay_ops.c (gdisplay_shrink_wrap): block all canvas
events while resizing the display so the standard canvas "expose"
and "configure" handlers are not called.
This optimization is valid because shrink_wrap's caller has to do
a full recalculation and expose of the gdisplay anyway.
For the same reason, I removed the calls to gdisplay_expose_full()
and bounds_checking() from shrink_wrap.
This should also fix the double exposes Austin reported some time
ago. I hope it does not re-break yesterday's fix :)
* app/gdisplay_ops.[ch]: removed unused function
gdisplay_resize_image().
* app/scale.c (resize_display): do a full expose if one of the
"resize_display" or "redisplay" parameters is TRUE.
2000-04-15 Michael Natterer <mitch@gimp.org>
* app/gdisplay_ops.c (gdisplay_shrink_wrap): after resizing the
display, check if the window manager placed it offscreen and
center it in that case.
2000-04-15 Michael Natterer <mitch@gimp.org>
* app/disp_callbacks.c: s/0/FALSE/
* app/gdisplay_ops.c (gdisplay_shrink_wrap): removed all the
gtk_drawing_area_size(), show/hide and gtk_main_iteration() stuff
and don't touch the drawing area at all.
Instead, use brute force on gdisp->shell:
1. gtk_widget_size_allocate(gdisp->shell)
2. gdk_window_resize(gdisp->shell->window)
(tested with Sawmill, Enlightenment and twm)
* plug-ins/common/gif.c: use GIMP_HAVE_PARASITES instead of
_PARASITES_H, which wasn't defined anymore. Makes comment
parasites work with GIFs again.
* app/measure.c: pressing ALT anywhere outside the handles allows
to move the measure lines.
--Sven
* docs/quick_reference.tar.gz: updated the tool icons and added
new ones. Removed the dvi and ps files from the tarball. Added
a TODO which describes what needs to be done to update the
quick_reference for gimp-1.2. Any volunteers?
--Sven
2000-04-11 Tor Lillqvist <tml@iki.fi>
* libgimp/gimpenv.c (gimp_path_get_user_writable_dir): The stat()
function in the Win32 C runtime doesn't like if directory names
have an extra G_DIR_SEPARATOR suffixed. Remove such before calling
stat(). Those extra (back)slashes are added by for instance
gimp_path_parse(). Document that feature of gimp_path_parse().
* libgimp/gimputils.c (gimp_strescape): Correct documentation for
gimp_strescape(). The semantics of the exceptions parameter was
documented backwards. Clarify what the function does.
* plug-ins/gfig/gfig.c (plug_in_parse_gfig_path)
* plug-ins/FractalExplorer/FractalExplorer.c
(plug_in_parse_fractalexplorer_path)
* plug-ins/gflare/gflare.c (plug_in_parse_gflare_path,
gflare_save): Use painstakingly correct platform-specific
directory and search path separators, and escaped with
gimp_strescape when displayed as part of a gimprc entry.
* app/gimphelp.c: No debug messages on Win32, thanks.
2000-04-11 Michael Natterer <mitch@gimp.org>
* app/plug_in.c: if attaching to the newly created shared memory
segment fails, destroy it before forgetting it's ID. Closes#6299.
2000-04-11 Tor Lillqvist <tml@iki.fi>
* README: Warn about the ads in the messages from the
egroups-hosted Win32 lists ;-)
* gimprc.win32: Use correct path separators. Document help-browser
diffferently on Win32.
* plug-ins/webbrowser/webbrowser.c: Implement on Win32.
* plug-ins/makefile.cygwin
* plug-ins/makefile.msc: Add it.
2000-04-10 Tor Lillqvist <tml@iki.fi>
* README: Correct the info about Win32 mailing lists.
* gimprc.win32: Add perfect-mouse setting.
* libgimp/gimp.h
* app/main.c: Guard against redefinition of _stdcall.
* libgimp/gimpmath.h: Define macros ISNAN and ISINF. On Win32 use
_isnan() and _fpclass() from <float.h>, on other platforms use
isnan() and isinf(). We really should test for isnan and isinf in the
configure script.
* tools/pdbgen/pdb/gimage.pdb
* app/gimage_cmds.c: Include gimpmath.h, use above macros instead
of using the nonportable isnan and isinf.
* app/gdisplay_ops.c: Do use the old gtk_widget_hide/show hack on
Win32.
* libgimp/makefile.cygwin
* libgimp/makefile.msc
* app/makefile.cygwin
* app/makefile.msc
* plug-ins/makefile.cygwin
* plug-ins/makefile.msc: Updates.
* plug-ins/gfig/gfig.c (plug_in_parse_gfig_path): Simplify warning
message on Win32. We could use G_DIR_SEPARATOR in the sample
gimprc line, but then we would have to call g_strescape to quote
it, argh. Win32 users use prebuilt versions with a correct gimprc
file anyway.
(create_file_selection): Use g_get_tmp_dir().
(gfig_update_stat_labels): Guard against possibly NULL value from
g_get_home_dir().
* libgimp/gimpexport.c: implemented the changes Nick Lamb
suggested: If the background layer has no alpha channel,
suggest "Flatten" instead of "Merge Visible Layers".
* app/fileops.c: In the MRU list and the doc_index always store
the absolute path to images, so you can open files from the
command-line and gimp will find them later if started from another
dir. Added tooltips that show the full path.
* app/menus.c: fixed a memleak (list entries were not freed on
removal from the MRU list).
* app/main.c
* app/user_install.[ch]: renamed functions and variables to match
the new filename.
--Sven
2000-04-06 Michael Natterer <mitch@gimp.org>
* app/commands.c
* app/layers_dialog.c
* app/resize.[ch]: behave like a widget:
removed resize_widget_free() and call
gtk_widget_destroy(resize->resize_shell) instead.
* app/interface.c: s/0/FALSE/
* app/color_area.c
* libgimp/gimpchainbutton.c: show the correct background also for
engine driven themes. The chainbutton's lines still don't draw
with the pixmap theme, which is probably a bug of the theme's
draw_polygon method.
* app/gimage_cmds.c
* tools/pdbgen/pdb/gimage.pdb: (gimp_image_set_resolution) guard
against NaN and infinity. There are pics out there using these
values and it seems that NaN > GIMP_MIN_RESOLUTION. Fixes#8476.
--Sven
* app/app_procs.c: if we cannot load the font we'd like to use,
use the gtk+ default font. Fixes bug #8359.
* app/about_dialog.c
* app/install.c: properly ref/unref fonts
* app/text_tool.[ch]: code cleanup (do not rely on TRUE being 1)
* app/tips_dialog.c: code cleanup and less resizing
--Sven
2000-04-05 Michael Natterer <mitch@gimp.org>
* app/layers_dialog.c: oops, yesterday's "cleanups" contained an
unreverted hack I've tried which caused a SEGV with floating
selections. Fixed now.
2000-04-03 Michael Natterer <mitch@gimp.org>
* app/color_panel.[ch]
* app/color_picker.c
* app/qmask.c: removed the public function color_panel_free() and
fake a real widget's behaviour by connecting to the panel widget's
"destroy" signal.
* app/channels_dialog.c
* app/layers_dialog.c: cleaned up and sync'ed the code where
possible (without changing the logic).
2000-04-03 Michael Natterer <mitch@gimp.org>
* app/channels_dialog.c
* app/layers_dialog.c: when dropping layers/channels around in the
stack, Gtk sometimes continues searching a drag destination
_after_ the drop callback has been called (which is probably a
bug), causing a SEGV because the callback changed the GtkList
containing the layer/channel widgets.
The safe way is to reorder the stack in an idle function which
should also be robust against any future Gdk/X dnd protocol
change.
For the same reason, I added an idle function which lets the
active layer/channel widget grab the focus because in some dnd
cases the row holding the focus was not the active one (which is
otherwise impossible with GTK_SELECTION_BROWSE).
This commit should fix the remaining problems with layer/channel
dnd as well as all cases where the highlighted layer was not the
active one. Please report if it still doesn't work for you.
2000-04-03 Michael Natterer <mitch@gimp.org>
* app/gimpdnd.[ch]
* app/channels_dialog.c
* app/layers_dialog.c: removed the GdkGC parameter from
gimp_dnd_set_drawable_preview_icon() since it's no longer used.
* app/gimpimage.c: dirty the view correctly after applying the
layer mask. Don't gdisplays_flush() because it's the job of the
caller.
* app/layers_dialog.c: when applying a layer mask, flush either
the display or just the layer_widget, depending on the previous
visibility state of the mask. Cleanups.
* plug-ins/print/gimp_color_window.c
* plug-ins/print/gimp_main_window.c: including config.h re-enables
i18n.
german translation. Hopefully the translation is now good enough
that it won't ihave to change much anymore, since the new
"Gimp kurz und gut" reference for 1.2 will go into print soon...
--Sven
2000-04-02 Garry R. Osgood <gosgood@idt.net>
* gimp/app/colormap_dialog.i.c
As Mr. Lamb, report originator noted, an easy
fix. in ipal_set_image() line 688
Reorganized the initialization of the
indexed palette object so as not to run afoul
of gasserts() inhabiting ipal_draw() and client
routines. These entailed initialing ipal->col_index,
ipal->dnd_col_index prior to call to ipal_draw()
* app/bezier_select.c
Curves/Path tool
Fixed propblem with deleting points. You can now delete the first
and last point on any open curve (as well as mid-points).
Also fixed some problems where some points would leave the markers
on screen after they had been deleted.
Note you have always been able to delete whole curves by pressing
the "shift" key when over a point to be deleted in "remove mode".
2000-04-02 Michael Natterer <mitch@gimp.org>
* app/interface.c: completely overworked the widget packing of the
display shell. This was necessary because the table insisted on
giving the vertical scrollbar more allocation than it needed when
first displaying an image which is smaller than the minimal
statusbar width. Replaced the tables with packing boxes.
See the comments I've added to create_display_shell() if you
really want to see the ugly details.
Also, to get rid of the 2-pixel spacing which appears at the
bottom of the display whenever the statusarea is hidden,
gdisp->statusarea is now the eventbox, not the hbox it contains.
* pixmaps/navbutton.xpm: made it 2x2 pixels larger.
2000-04-01 Garry R. Osgood <gosgood@idt.net>
* gimp/app/bezier_select.c
No fooling, #6903 was not that hard to close;
in bezier_edit_point_on_curve(),when point
deletion reduces a curve below the minimum
with which the implementation can cope (2
anchors, four controls) we put it out of its
misery with an invocation of delete_whole_curve().
2000-04-01 Michael Natterer <mitch@gimp.org>
* app/disp_callbacks.c: when dropping a drawable, do the
undo_push_group_start() before creating the new layer, otherwise
the undo system will show obscure misbehaviour (the undo group is
pushed correctly but no undo will be possible until an other undo
is pushed).
2000-04-01 Michael Natterer <mitch@gimp.org>
Backported the UI changes of the 3.1.x gimp-print plugin to the
stable 3.0.x version.
Put the printer definitions to a separate file and added the 3.1.x
access functions. This way the new dialog files can be used with
minimal changes.
Bumped version number to 3.0.10.
* po-plug-ins/POTFILES.in
* plug-ins/print/Makefile.am
* plug-ins/print/print_gimp.h
* plug-ins/print/gimp_color_window.c
* plug-ins/print/gimp_main_window.c: new files containing the
dialog code.
* plug-ins/print/print-printers.c: new file containing the printer
definitions.
* plug-ins/print/print-util.c: added printer list access functions.
* plug-ins/print/print.[ch]: removed the dialog stuff and use the
list access functions.
2000-04-01 Michael Natterer <mitch@gimp.org>
* plug-ins/flame/Makefile.am
* plug-ins/flame/megawidget.[ch]: removed
* plug-ins/flame/flame.c: general ui cleanup, added some sanity
checks when opening a flame file, indentation.
* app/paint_funcs.c: Fixed the off by one error that was the cause
of bug #4980. Fixed a bug that caused images to have their
centers shifted slightly when resizing. Removed a couple of
unused variables.
2000-03-31 Michael Natterer <mitch@gimp.org>
* app/gimpdnd.[ch]: minor cleanups.
* libgimp/gimpwidgets.c: don't set a border width for the
radio_group's vbox if no frame around it was requested.
* plug-ins/common/sample_colorize.c: add a separator between
image and sample.
* plug-ins/common/iwarp.c: use the libgimp ui functions, removed
callbacks, a global s/gfloat/gdouble/, replaced the booleans
toggling the transform mode with a single variable containing an
enum value, indentation.
Fri Mar 31 14:10:02 BST 2000 Adam D. Moss <adam@gimp.org>
* plug-ins/common/gifload.c: Mildly more useful
comments/messages concerning frame disposals.
2000-03-29 Michael Natterer <mitch@gimp.org>
* app/bezier_select.h
* app/bezier_selectP.h
* app/by_color_select.[ch]
* app/ellipse_select.[ch]
* app/free_select.[ch]
* app/move.[ch]
* app/rect_select.[ch]: kindof selection tools code review:
- use SelectOps instead of int.
- removed some unused prototyped and callbacks.
- don't show the SELECTION_MOVE_MASK cursor if there is no
selection and don't try to move the mask in that case.
- re(?)-enabled moving the selection mask even if there is a
floating selection.
- usual bunch of cleanups.
2000-03-27 Michael Natterer <mitch@gimp.org>
* app/transform_core.c: the button_press and cursor_update
functions were still doing checks on the active layer instead of
the active drawable.
Fixing this automatically made the layers mask transformable.
2000-03-26 Garry R. Osgood <gosgood@idt.net>
* gimp/app/bezier_select.c
in bezier_add_point(), when a BEZIER_MOVE type
point is being added to a path with at least
one extant segment, the point is re-typed
to a BEZIER_ANCHOR (which is old behavior)
and designated as the current anchor
(which is new behaviour). With this change,
motion events move the (second) control point
and indicia are properly updated. This closes
#6225.
2000-03-26 Michael Natterer <mitch@gimp.org>
* app/gimage_mask.[ch] (gimage_mask_extract): add an "add_alpha"
parameter to allow selected regions to be extracted without having
an alpha channel added.
* app/global_edit.c: pass add_alpha = TRUE.
* app/transform_core.[ch]: made the transform core work on
non-layer drawables even if no selection is present. Fixes#7485
and #7555.
- transform_core_cut(): extract the mask without alpha if
operating on a non-layer without having a selection.
- transform_core_paste(): return a boolean indicating success
instead of a layer and handle channels correctly.
- transform_core_do(): if the "floating_tiles" passed to the
function are from an un-floated non-layer, treat the whole
non-layer as alpha channel and never enter the loop which
transforms the (not present) color channels.
Also clip the result to ensure that the channel never grows
larger then the image.
* app/tools_cmds.c
* tools/pdbgen/pdb/tools.pdb: transform_core_paste() returns a
gboolean now.
2000-03-25 Michael Natterer <mitch@gimp.org>
* app/cursorutil.[ch]: new global variable "gimp_busy" which gets
set/unset whenever busy cursors are added/removed.
* app/info_dialog.c: register the info dialogs with the dialog
handler.
* app/fuzzy_select.[ch]: cleanups.
Here starts the ugly workaround which simulates something like
locking. If it works, it will close lots of bugs, if not, it's
easy to remove again.
So far, I didn't find strange side effects but Gimp is told to be
a complex program :-) Please test this.
* app/context_manager.c: don't allow tool changes if gimp_busy
is TRUE.
* app/disp_callbacks.c: don't allow mouse and key events in the
display_canvas if gimp_busy is TRUE.
(except if the current tool is FUZZY_SELECT and it is ACTIVE,
which is very ugly)
Also block other stuff like dropping colors/patterns etc.
* app/gdisplay_ops.c: don't close any display while Gimp is
busy. This is not really what we want but at least it prevents
crashes.
2000-03-24 Michael Natterer <mitch@gimp.org>
* Makefile.am
* gimp1_0_splash.ppm: added
* gimp1_1_splash.ppm: removed
* gimp_splash.ppm: the image formerly known as gimp1_1_splash.ppm
* app/app_procs.c: load gimp_splash.ppm
The idea if shearing the data_dir between Gimp versions has
vanished, so this seems like the right thing to do (TM).
Keep the 1.0 splash around for sentimental reasons but don't
install it anymore.
* plug-ins/common/autocrop.c: indentation paranoia.
2000-03-24 Michael Natterer <mitch@gimp.org>
* app/plug_in.c (plug_in_proc_def_remove): pass FALSE to
plug_in_proc_def_destroy() so the proc_def structure gets actually
freed.
* configure.in: more sanity checking for the gtkxmhtml test. Also
changed datadir to include the gimp version too. So right now
only the development headers conflict between versions in the same
prefix.
* gimptool.in
* gimptool.1: added and documented configure variable query options
(bindir, sbindir, sysconfdir, etc.)
* tips/Makefile.am: add gimp_tips.uk.txt
-Yosh
* app/fileops.c
* app/gdisplay.[ch]: when reverting an image, reconnect all
affected views to the reverted version. This fixes one of the
bugs Tigert pointed out at GUADEC.
* app/gimage_mask.[ch]
* app/flip_tool.c: cleanups
--Sven & Mitch
2000-03-11 Tor Lillqvist <tml@iki.fi>
* plug-ins/twain/*.c: Use GLib's memory functions instead of
malloc and free.
* plug-ins/winsnap/winsnap.c: Add delay functionality.
* app/gimpdrawable.c: gimp_drawable_get_color_at() now silently
returns NULL again if the coordinates are out of range. A lot of
code using this function relies on this feature and correctly
checks the return value. No need to emit critical warnings here.
The GTK_CHECK_TYPE macro test for obj != NULL, no need to do this
check twice. Removed lots of unnecessary calls to g_return_if_fail().
* app/color_picker.c: with the old behaviour of
gimp_drawable_get_color_at() the code is a bit simpler.
* app/fuzzy_select.c: fuzzy_select relied on drawable_offsets()
returning off_x = off_y = 0 if drawable == NULL. Decided to change
this here, fixes bug #7077.
* app/gimpimage.[ch]: Even though we made bad experiences with the
changes in gimpdrawable.c, I have introduced similar argument checks
here.
* app/image_map.c: indentation
--Sven
* app/menus.c: applied and heavily modified a patch from Daniel Egger.
There's not any more the need to declare menu branches unless we
want to create empty submenus (to be filled in by plug-ins). Removes
a bunch of messages from the catalogs.
We do not longer put a seperator after submenus if the menu contains
nothing but submenus.
--Sven
2000-03-08 Tor Lillqvist <tml@iki.fi>
* app/cursorutil.c (gtkutil_compress_motion)
* app/edit_selection.c (process_event_queue_keys): Guard against
gdk_event_get returning NULL (which can happen at least on Win32).
* libgimp/gimp.def: Add a couple of new entry points.
* plug-ins/makefile.{cygwin,msc}: Update according to the source
file changes. Fix some typos in the .msc file.
Fixes by Hans Breuer:
* app/resize.c: Add some more includes.
* libgimp/gimpenv.c
* plug-ins/gflare/gflare.c: Win32 header lossage fixup.
Wed Mar 8 12:40:53 GMT 2000 Adam D. Moss <adam@gimp.org>
* plug-ins/common/xbm.c: Type of written array should
be unsigned, as that's the type of data we're initializing
it with. Cast back to signed for passing to XCreateBitmapFromData()
etc.
2000-03-07 Michael Natterer <mitch@gimp.org>
* app/disp_callbacks.C: show GIMP_BAD_CURSOR if we have no layers.
Moved the closing bracket out of the GTK_HAVE_SIX_VALUATORS ifdefs
(just to force emacs to do correct indentation).
2000-03-07 Michael Natterer <mitch@gimp.org>
* app/by_color_select.c: immediate cursor_update feedback on
modifier events.
* libgimp/gimpwidgets.c: one more s/private_tip/help_data/
2000-03-04 Michael Natterer <mitch@gimp.org>
* Makefile.am
* cursors/selection_move.xbm
* cursors/selection_move_mask.xbm
* app/cursorutil.[ch]: new cursor for moving the selection
mask. Looks imho nicer than the ugly GDK_DIAMOND_CROSS.
* app/move.c
* app/rect_select.c: use the new cursor.
* app/paint_core.c: check for the statusbar's context_id in the
cursor_update function. Fixes gdk_criticals with the line preview
(which doesn't need a mouse click). Minor cleanups.
* app/tool_options.c: put the paint_pressure options in a
GtkHWrapBox instead of a GtkHBox. Makes the size of the dialog a
bit less locale-dependent.
* plug-ins/common/xbm.c: use accessor functions instead of using
the parasite's fields directly.
2000-03-03 Michael Natterer <mitch@gimp.org>
* app/crop.c: s/"Only"/"only"/
* app/iscissors.c: one more cursor_update fix. This time I don't
claim that it's _really_ correct.
* app/tool_options.c: don't add a separator after
opacity/paint_mode if a paint pressure options box follows.
* cursors/bad.xbm
* cursors/bad_mask.xbm: made it FAT (no need to use thin lines
which show as much as possible of the image below because the
cursor indicates that no operation is possible).
* libgimp/gimpprotocol.[ch]: s/int/gboolean/ where appopriate,
indentation paranoia.
_gp_*_read(): free the already allocated parts of the message if
reading a subsequent part fails. These cleanups will probably occur
shortly before the process crashes, but at least they make the
search for real leaks easier.
* plug-ins/common/uniteditor.c: some more tooltips.
* plug-ins/common/xbm.c: store the image comment in the
"gimp-comment" parasite and the hot spot in the new "hot-spot"
parasite. Added ui for entering the hot spot.
* docs/parasites.txt: documented the new "hot-spot" parasite.
2000-03-03 Michael Natterer <mitch@gimp.org>
* libgimp/gimpprotocol.c (_gp_proc_return_destroy): fixed a
memleak: free the message's name before freeing the message itself.
2000-03-03 Michael Natterer <mitch@gimp.org>
* app/iscissors.c: this time cursor_update feedback is _really_
correct: for closed curves, show the "point" cursor if a mouse
click will modify the curve and the "bad" cursor if a mouse click
will do nothing. Seems it was not too hard to understand how it
works...
* plug-ins/common/uniteditor.c: for consistency, did a
s/"Delete","Undelete"/"Don't Save","Save"/.
Thu Mar 2 21:45:17 GMT 2000 Andy Thomas <alt@gimp.org>
* gimp/app/nav_window.c
The "follow display" nav window is now hidden when the
last window is closed.
2000-03-02 Michael Natterer <mitch@gimp.org>
* app/iscissors.c: Iscissors was using rect_select_cursor_update
which is totally wrong since the oper_update_func tool method was
introduced (in fact it didn't even give correct feedback before).
Added oper_update_func, modifier_key_func, cursor_update_func for
Iscissors which give correct cursor_update feedback now. The only
remaining inconsistency occurs when a curve is closed: There's no
way to find out if the mouse is over a control point/line or
outside (without touching the Iscissors engine, which I didn't
want to do because I don't understand how it works ;-).
2000-03-02 Michael Natterer <mitch@gimp.org>
* app/rect_select.[ch]: added a modifier_key_func which gives
immediate cursor_update feedback on modifier key events.
* app/ellipse_select.c
* app/free_select.c
* app/fuzzy_select.c
* app/rect_selectP.h: call the new function.
Added current_[x|y] fields to the tools' structures which get
updated from the "motion" functions. They have to appear in the
same order in all structures because the modifier_key_func treats
them all as rectangular selection tools.
This is ugly and cries for a object hierarchy of tools.
2000-03-01 Michael Natterer <mitch@gimp.org>
* app/gimpdrawable.c: gimp_drawable_get_color_at(): put the check
below back but only require a non-indexed drawable if the drawable
doesn't have an image.
(The function may call gimp_image_get_color() with gimage == NULL
for RGB and GRAY colors because we don't need a colormap to
transform them to RGB space).
This was the obscure special case (TM).
2000-03-01 Michael Natterer <mitch@gimp.org>
* app/gimpdrawable.c: gimp_drawable_get_color_at(): don't
g_return_val_if_fail(!indexed, NULL) because the function seems to
work fine for all kinds of drawables. Fixes#6756. Or is this
check needed for some obscure special case?
2000-03-01 Michael Natterer <mitch@gimp.org>
* cursors/selection.xbm
* cursors/selection_subtract.xbm: made the selection rectangles
look the same (avoids flickering on Ctrl/Shift).
* cursors/selection_intersect.xbm
* cursors/selection_intersect_mask.xbm: the symbol for
intersection is "n", not "u".
2000-03-01 Michael Natterer <mitch@gimp.org>
* Makefile.am
* cursors/*: a proper naming scheme for all cursor files. Added
zoom_in and zoom_out cursors.
* app/bezier_select.c
* app/by_color_select.c
* app/cursorutil.[ch]
* app/rect_select.c
* app/scale.[ch]: changed according to the new cursor names. Some
minor fixes.
* app/magnify.[ch]: made the zoom_in/zoom_out toggle a proper
tool_toggle and show cursors for the two modes.
* plug-ins/print/print-util.c: patch from Robert Kravitz which
fixes printing layers with alpha.
2000-03-01 Michael Natterer <mitch@gimp.org>
* app/gdisplay.c: set <Image>/File/Revert... insensitive if the
image has no filename.
* plug-ins/common/uniteditor.c: minor fix.
2000-03-01 Michael Natterer <mitch@gimp.org>
* C/dialogs/layers/Makefile.am
* C/dialogs/layers/index.html
* C/dialogs/layers/apply_mask.html: removed.
* C/layers/Makefile.am
* C/layers/index.html
* C/layers/apply_mask.html
* C/layers/delete_mask.html: new files.
* app/gimpcontextpreview.c: return without warning if popup_timeout
is already set. Suppresses warning that occured on double-click.
* app/layers_dialog.[ch]
* app/menus.c: added "Delete Mask" menu entry and removed dialog
asking if mask is to applied or discarded on "Apply Mask".
* app/tools.c: Magnify is not a transform tool
--Sven
2000-02-29 Michael Natterer <mitch@gimp.org>
* plug-ins/common/.cvsignore
* plug-ins/common/Makefile.am
* plug-ins/common/plugin-defs.pl
* po-plug-ins/POTFILES.in
* help/C/filters/Makefile.am
* help/C/filters/index.html
* plug-ins/common/uniteditor.c
* help/C/filters/uniteditor.html: new plugin.
After one year of announcing it, I finally hacked the GIMP unit
editor. Have fun with lightyears, parsec, ... :-)
Mon Feb 28 19:11:39 GMT 2000 Adam D. Moss <adam@gimp.org>
* app/cursorutil.c app/cursorutil.h:
added gtkutil_compress_motion() utility function to seek and
destroy outstanding pointer motion events from the gdk event queue
for a given widget.
* app/edit_selection.c:305: Use gtkutil_compress_motion() to
do a more thorough job of tracking motion (something recently
started interleaving our motion events with others, largely
nullifying the effectiveness of GDK_POINTER_MOTION_HINT_MASK).
* app/edit_selection.c:704: Yikes, the key-press snooping code
was turning part of the event queue back-to-front with each
compressed key-press. (Still looks a bit bogus overall; looks
as though it could transplant a whole chunk of the start of
the event queue right onto the end. I'll probably disable it
unless someone points out that I'm a doofus.)
2000-02-27 Garry R. Osgood <gosgood@idt.net>
* gimp/app/by_color_select.c
* gimp/app/color_picker.c
* gimp/app/gimpdrawable.c
* gimp/app/image_map.c
* gimp/app/paint_core.c
Inadvertent logic error in g_return_val_if_fail()
style sanity checks implemented in
gimp_drawable_get_color_at() gave rise to
segment violation reported in #6624;
error admitted out-of-bounds x&y that
do not map to tiles. Closes#6624.
GTK-critical warnings which result from
this new sanity check require that
gimp_drawable_get_color_at() clients
perform initial culling of out-of-bounds
x & y coordinates.
2000-02-28 Michael Natterer <mitch@gimp.org>
* libgimp/gimpfileselection.c
* libgimp/gimpunitmenu.c: behave like other dialogs (close) when
pressing "OK" or "Cancel".
* libgimp/stdplugins-intl.h
* plug-ins/script-fu/script-fu-intl.h: bind the "gimp-libgimp"
textdomain also if HAVE_LC_MESSAGES is undefined.
* plug-ins/print/print-ps.c
* plug-ins/print/print.c: applied a patch from Robert L Kravitz
<rlk@alum.mit.edu> which adds a "Center" button, activates all
text entries and corrects the rounding behaviour. And a minor fix
for the PS driver.
* plug-ins/dbbrowser/Makefile.am
* plug-ins/dbbrowser/dbbrowser.h: removed.
* plug-ins/dbbrowser/dbbrowser.c
* plug-ins/dbbrowser/dbbrowser_utils.c
* plug-ins/dbbrowser/dbbrowser_utils.h
* plug-ins/common/plugindetails.c: ui and code cleanup.
libgimp ui stuff and a proper include structure for the dbbrowser.
* plug-ins/script-fu/script-fu-console.c: include
"plug-ins/dbbrowser/dbbrowser_utils.h".
Sat Feb 26 23:58:27 GMT 2000 Andy Thomas <alt@gimp.org>
* gimp/app/nav_window.c
Now takes note of the users set preview size when close to the
edge of the screen.
If the user selected < MAX size of preview the popup would appear
in the incorrect location of the screen. This is a slight change
to the checkin of Sat Feb 19 13:53:34 CET 2000 by
Sven Neumann <sven@gimp.org>
2000-02-26 Garry R. Osgood <gosgood@idt.net>
* app/commands.c
* app/gimpimage.c
* app/layer.c
* app/layer.h
* app/resize.c
* app/resize.h
Aliasing artifacts that changed relative positions
of layers under scaling, giving rise to #5271, are
minimized by a new layer.c function,
layer_scale_by_factors(). Closes#5271. See
http://idt.net/~gosgood/gimp-patch/patch07.html for
further detail. See also usage documentation for
layer_scale() and layer_scale_by_factors() in
layer.c.
Provided logic for the Scale Image dialog box to
pre-check an image's layers for the possibility that
a particular scaling, s: 0 < s < 1, reduces a layer
dimension to zero. Should this case prevail, a
boolean dialog box warns the user of the
possibility. The user may (1) Cancel, returning
focus to Scale Image and the possibility of
corrective adjustment, or (2) OK the scaling. The
layers that will vanish upon the new scaling are
culled from the GimpImage::layers list first.
2000-02-24 Michael Natterer <mitch@gimp.org>
* plug-ins/print/print.c: use the ui constructors from libgimp,
put the widgets into frames, removed callbacks wich are not used
any more. Makes the dialog smaller but is not perfect yet.
Re-applied Sven's patch which initializes the "File" printer.
* app/fileops_cmds.c
* tools/pdbgen/pdb/fileops.pdb: don't add an already registered
load|save handler twice to the list. This fixes the problem
that extension were listed twice if a load|save plugin changed.
* app/plug_in.[ch]: code cleanup, indentation
* app/xcf.[ch]: same here, include copyright headers
* plug-ins/common/wmf.c: properly cancel the load if the user
pressed Cancel in the dialog (fixes bug #6500)
--Sven
2000-02-24 Michael Natterer <mitch@gimp.org>
* app/paths_dialog.c: we were also leaking all path preview
pixmaps ever created. Always remember that GdkPixmaps are not
created "floating" but with a real refcount of 1. Minor cleanups.
2000-02-24 Michael Natterer <mitch@gimp.org>
* app/gimpbrush.[ch]
* app/gimpbrushgenerated.[ch]
* app/gimpbrushlist.[ch]
* app/gimpbrushlistP.h
* app/gimpbrushpipe.[ch]
* app/gimpbrushpipeP.h: did a brushes code-review: indentation,
removed some includes, didn't find a bug :-)
* app/gradient.c
* app/palette.c: we were leaking all gradient and palette preview
pixmaps as well as all lists of palette colors on each refresh.
* libgimp/gimpenv.c: updated documentation.
Michael Natterer