dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't free the old filename pointer till we're all done, since we might be 

* app/gimpimage.c: don't free the old filename pointer till we're
all done, since we might be passed our own filename as a param
and reference it after freeing. The code didn't heed it's own
warning ;) (TigerT, this should fix that filename corruption bug)

-Yosh
This commit is contained in:
Manish Singh 1999-10-25 23:51:56 +00:00
parent f48c866846
commit f697f6cfab
9 changed files with 63 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
Mon Oct 25 16:49:19 PDT 1999 Manish Singh <yosh@gimp.org>
* app/gimpimage.c: don't free the old filename pointer till we're
all done, since we might be passed our own filename as a param
and reference it after freeing. The code didn't heed it's own
warning ;) (TigerT, this should fix that filename corruption bug)
1999-10-25 Tor Lillqvist <tml@iki.fi>
* app/cursorutil.h: Uncomment the inclusion of gdkcursor.h that

11
app/core/gimpimage-guides.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/core/gimpimage-merge.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/core/gimpimage-projection.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/core/gimpimage-resize.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/core/gimpimage-scale.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/core/gimpimage.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/core/gimpprojection-construct.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}

11
app/gimpimage.c
View File

@ -318,7 +318,8 @@ void
gimp_image_set_filename (GimpImage *gimage,
gchar *filename)
{
gchar *new_filename;
gchar *new_filename, *old_filename;
gboolean free_old;
/*
* WARNING: this function will free the current filename even if you are
@ -327,9 +328,8 @@ gimp_image_set_filename (GimpImage *gimage,
*/
new_filename = g_strdup (filename);
if (gimage->has_filename)
g_free (gimage->filename);
old_filename = gimage->filename;
free_old = gimage->has_filename;
if (filename && filename[0])
{
@ -342,6 +342,9 @@ gimp_image_set_filename (GimpImage *gimage,
gimage->has_filename = FALSE;
}
if (free_old)
g_free (old_filename);
gtk_signal_emit (GTK_OBJECT (gimage), gimp_image_signals[RENAME]);
}