dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

app: fix leaks when freeing the list of accum_buffers in gimpsmudge.c

This commit is contained in:
Michael Natterer 2017-07-15 18:36:53 +02:00
parent be6ccc491c
commit f3561549bb
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/paint/gimpsmudge.c
View File

@ -97,8 +97,8 @@ gimp_smudge_class_init (GimpSmudgeClass *klass)
paint_core_class->paint = gimp_smudge_paint; paint_core_class->paint = gimp_smudge_paint;
brush_core_class->handles_changing_brush = TRUE; brush_core_class->handles_changing_brush = TRUE;
brush_core_class->handles_transforming_brush = TRUE; brush_core_class->handles_transforming_brush = TRUE;
brush_core_class->handles_dynamic_transforming_brush = TRUE; brush_core_class->handles_dynamic_transforming_brush = TRUE;
} }
@ -120,8 +120,10 @@ gimp_smudge_finalize (GObject *object)
{ {
if (iter->data) if (iter->data)
g_object_unref (iter->data); g_object_unref (iter->data);
smudge->accum_buffers = NULL;
} }
g_list_free (smudge->accum_buffers);
smudge->accum_buffers = NULL;
} }
G_OBJECT_CLASS (parent_class)->finalize (object); G_OBJECT_CLASS (parent_class)->finalize (object);
@ -158,9 +160,12 @@ gimp_smudge_paint (GimpPaintCore *paint_core,
{ {
if (iter->data) if (iter->data)
g_object_unref (iter->data); g_object_unref (iter->data);
smudge->accum_buffers = NULL;
} }
g_list_free (smudge->accum_buffers);
smudge->accum_buffers = NULL;
} }
smudge->initialized = FALSE; smudge->initialized = FALSE;
break; break;
@ -260,6 +265,7 @@ gimp_smudge_start (GimpPaintCore *paint_core,
paint_buffer_y - y, paint_buffer_y - y,
0, 0)); 0, 0));
} }
smudge->accum_buffers = g_list_reverse (smudge->accum_buffers); smudge->accum_buffers = g_list_reverse (smudge->accum_buffers);
return TRUE; return TRUE;
@ -355,6 +361,7 @@ gimp_smudge_motion (GimpPaintCore *paint_core,
*/ */
accum_buffer = g_list_nth_data (smudge->accum_buffers, i); accum_buffer = g_list_nth_data (smudge->accum_buffers, i);
gimp_gegl_smudge_blend (accum_buffer, gimp_gegl_smudge_blend (accum_buffer,
GEGL_RECTANGLE (paint_buffer_x - x, GEGL_RECTANGLE (paint_buffer_x - x,
paint_buffer_y - y, paint_buffer_y - y,
@ -411,6 +418,7 @@ gimp_smudge_accumulator_coords (GimpPaintCore *paint_core,
GeglBuffer *accum_buffer; GeglBuffer *accum_buffer;
accum_buffer = g_list_nth_data (smudge->accum_buffers, stroke); accum_buffer = g_list_nth_data (smudge->accum_buffers, stroke);
*x = (gint) coords->x - gegl_buffer_get_width (accum_buffer) / 2; *x = (gint) coords->x - gegl_buffer_get_width (accum_buffer) / 2;
*y = (gint) coords->y - gegl_buffer_get_height (accum_buffer) / 2; *y = (gint) coords->y - gegl_buffer_get_height (accum_buffer) / 2;
} }