Fixed off by 1 error that was emitting Critical warnings.

This commit is contained in:
Seth Burgess 2003-01-31 02:15:52 +00:00
parent 5ad96758e9
commit e717e0731c
2 changed files with 15 additions and 5 deletions

View File

@ -1,3 +1,8 @@
2003-01-30 Seth Burgess <sjburges@gimp.org>
* plug-ins/common/laplace.c: fixed off-by-1 error that caused
gimp_pixel_rgn_get_row() critical warnings (but managed to work).
2003-01-30 Pablo Saratxaga <pablo@mandrakesoft.com>
* configure.in: Added Vietnamese (vi) to ALL_LINGUAS

View File

@ -19,6 +19,11 @@
/* This plugin by thorsten@arch.usyd.edu.au */
/* Based on S&P's Gauss and Laplace filters */
/* updated 1/30/03: <sjburges@gimp.org>
* fixed an off-by-1 error that was causing an attempt to read a
* get_pixel_by_row at the -1'th row
*/
/* updated 11/04/97:
Use 8-pixel neighbourhood to create outline,
use min-max operation for local gradient,
@ -147,13 +152,13 @@ laplace_prepare_row (GimpPixelRgn *pixel_rgn,
{
gint b;
if (y == 0)
gimp_pixel_rgn_get_row (pixel_rgn, data, x, (y + 1), w);
if (y < 0)
gimp_pixel_rgn_get_row (pixel_rgn, data, x, (y + 1), w);
else if (y == pixel_rgn->h)
gimp_pixel_rgn_get_row (pixel_rgn, data, x, (y - 1), w);
gimp_pixel_rgn_get_row (pixel_rgn, data, x, (y - 1), w);
else
gimp_pixel_rgn_get_row (pixel_rgn, data, x, y, w);
gimp_pixel_rgn_get_row (pixel_rgn, data, x, y, w);
/* Fill in edge pixels */
for (b = 0; b < pixel_rgn->bpp; b++)
{