app: Always return values in non-void functions.

This commit is contained in:
Michael Henning 2014-06-29 22:35:34 -04:00
parent 6fb9d1a3b0
commit db4f67048d
3 changed files with 12 additions and 12 deletions

View File

@ -92,9 +92,9 @@ gimp_drawable_merge_filter (GimpDrawable *drawable,
GeglRectangle rect;
gboolean success = TRUE;
g_return_if_fail (GIMP_IS_DRAWABLE (drawable));
g_return_if_fail (GIMP_IS_FILTER (filter));
g_return_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress));
g_return_val_if_fail (GIMP_IS_DRAWABLE (drawable), FALSE);
g_return_val_if_fail (GIMP_IS_FILTER (filter), FALSE);
g_return_val_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress), FALSE);
if (gimp_item_mask_intersect (GIMP_ITEM (drawable),
&rect.x, &rect.y,

View File

@ -404,8 +404,8 @@ gimp_image_map_commit (GimpImageMap *image_map,
{
gboolean success = TRUE;
g_return_if_fail (GIMP_IS_IMAGE_MAP (image_map));
g_return_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress));
g_return_val_if_fail (GIMP_IS_IMAGE_MAP (image_map), FALSE);
g_return_val_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress), FALSE);
if (gimp_image_map_is_filtering (image_map))
{

View File

@ -79,13 +79,13 @@ gimp_gegl_apply_cached_operation (GeglBuffer *src_buffer,
gdouble value;
gboolean cancel = FALSE;
g_return_if_fail (src_buffer == NULL || GEGL_IS_BUFFER (src_buffer));
g_return_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress));
g_return_if_fail (GEGL_IS_NODE (operation));
g_return_if_fail (GEGL_IS_BUFFER (dest_buffer));
g_return_if_fail (cache == NULL || GEGL_IS_BUFFER (cache));
g_return_if_fail (valid_rects == NULL || cache != NULL);
g_return_if_fail (valid_rects == NULL || n_valid_rects != 0);
g_return_val_if_fail (src_buffer == NULL || GEGL_IS_BUFFER (src_buffer), FALSE);
g_return_val_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress), FALSE);
g_return_val_if_fail (GEGL_IS_NODE (operation), FALSE);
g_return_val_if_fail (GEGL_IS_BUFFER (dest_buffer), FALSE);
g_return_val_if_fail (cache == NULL || GEGL_IS_BUFFER (cache), FALSE);
g_return_val_if_fail (valid_rects == NULL || cache != NULL, FALSE);
g_return_val_if_fail (valid_rects == NULL || n_valid_rects != 0, FALSE);
if (dest_rect)
{