From d62615293d3f7b38c98593a64b78872497d943ac Mon Sep 17 00:00:00 2001 From: Jehan Date: Wed, 9 Sep 2015 01:11:32 +0200 Subject: [PATCH] configure: add warning for forgotten return value on non-void functions. Adding -Wreturn-type for general case, but also -Wsystem-headers to warn of g_return_if_fail() on non-void, since these are macros from system headers directory, and -Wreturn-type would not warn for these. --- configure.ac | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index e2335c6846..3ed4e05e24 100644 --- a/configure.ac +++ b/configure.ac @@ -434,6 +434,14 @@ CFLAGS="$CFLAGS $extra_warnings" GIMP_DETECT_CFLAGS(extra_warnings, '-fdiagnostics-show-option') CFLAGS="$CFLAGS $extra_warnings" +GIMP_DETECT_CFLAGS(extra_warnings, '-Wreturn-type') +CFLAGS="$CFLAGS $extra_warnings" + +# -Wreturn-type warns on forgotten return on non-void functions, +# but not of g_return_if_fail() on non-void functions. +# -Wsystem-headers is needed for that. +GIMP_DETECT_CFLAGS(extra_warnings, '-Wsystem-headers') +CFLAGS="$CFLAGS $extra_warnings" # Extra optimization flags for super performance GIMP_DETECT_CFLAGS(extra_warnings, '--omg-optimized')