app: require a text in gimp_gegl_progress_connect()

and simplify and fix the progress callback.
This commit is contained in:
Michael Natterer 2016-05-11 22:50:33 +02:00
parent 4f0521c7cf
commit cea4ea6cff
1 changed files with 16 additions and 24 deletions

View File

@ -76,31 +76,23 @@ static void
gimp_gegl_progress_callback (GObject *object,
gdouble value,
GimpProgress *progress)
{
const gchar *text;
text = g_object_get_data (object, "gimp-progress-text");
if (text)
{
if (value == 0.0)
{
const gchar *text = g_object_get_data (object, "gimp-progress-text");
if (gimp_progress_is_active (progress))
gimp_progress_set_text (progress, "%s", text);
else
gimp_progress_start (progress, FALSE, "%s", text);
return;
}
else if (value == 1.0)
else
{
gimp_progress_end (progress);
return;
}
}
gimp_progress_set_value (progress, value);
if (value == 1.0)
gimp_progress_end (progress);
}
}
void
@ -110,12 +102,12 @@ gimp_gegl_progress_connect (GeglNode *node,
{
g_return_if_fail (GEGL_IS_NODE (node));
g_return_if_fail (GIMP_IS_PROGRESS (progress));
g_return_if_fail (text != NULL);
g_signal_connect (node, "progress",
G_CALLBACK (gimp_gegl_progress_callback),
progress);
if (text)
g_object_set_data_full (G_OBJECT (node),
"gimp-progress-text", g_strdup (text),
(GDestroyNotify) g_free);