dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Changed the Ok and Cancel buttons in the histogram dialog to a simple Close, 

because that's what they were actually doing.


--Sven
This commit is contained in:
Sven Neumann 1998-04-13 21:59:28 +00:00
parent eeb017e163
commit c5d9a5e9b8
4 changed files with 36 additions and 75 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
Mon Apr 13 23:48:31 MEST 1998 Sven Neumann <sven@gimp.org>
* app/histogram_tool.c: changed the Ok and Cancel buttons in the
histogram dialog to a simple Close, because that's what they were
actually doing
Mon Apr 13 13:09:32 EDT 1998 Matthew Wilson <msw@gimp.org>
* app/commands.c: Fixed prefs to save stingy memory

35
app/histogram_tool.c
View File

@ -71,8 +71,7 @@ static void histogram_tool_cursor_update (Tool *, GdkEventMotion *, gpointer)
static void histogram_tool_control (Tool *, int, gpointer);
static HistogramToolDialog * histogram_tool_new_dialog (void);
static void histogram_tool_ok_callback (GtkWidget *, gpointer);
static void histogram_tool_cancel_callback (GtkWidget *, gpointer);
static void histogram_tool_close_callback (GtkWidget *, gpointer);
static gint histogram_tool_delete_callback (GtkWidget *, GdkEvent *, gpointer);
static void histogram_tool_value_callback (GtkWidget *, gpointer);
static void histogram_tool_red_callback (GtkWidget *, gpointer);
@ -331,7 +330,7 @@ histogram_tool_control (Tool *tool,
break;
case HALT :
if (histogram_tool_dialog)
histogram_tool_cancel_callback (NULL, (gpointer) histogram_tool_dialog);
histogram_tool_close_callback (NULL, (gpointer) histogram_tool_dialog);
break;
}
}
@ -374,7 +373,7 @@ tools_free_histogram_tool (Tool *tool)
/* Close the histogram dialog */
if (histogram_tool_dialog)
histogram_tool_cancel_callback (NULL, (gpointer) histogram_tool_dialog);
histogram_tool_close_callback (NULL, (gpointer) histogram_tool_dialog);
g_free (hist);
}
@ -415,15 +414,14 @@ histogram_tool_initialize (void *gdisp_ptr)
}
/****************************/
/* Select by Color dialog */
/****************************/
/***************************/
/* Histogram Tool dialog */
/***************************/
/* the action area structure */
static ActionAreaItem action_items[] =
{
{ "OK", histogram_tool_ok_callback, NULL, NULL },
{ "Cancel", histogram_tool_cancel_callback, NULL, NULL }
{ "Close", histogram_tool_close_callback, NULL, NULL }
};
static MenuItem color_option_items[] =
@ -526,8 +524,7 @@ histogram_tool_new_dialog ()
/* The action area */
action_items[0].user_data = htd;
action_items[1].user_data = htd;
build_action_area (GTK_DIALOG (htd->shell), action_items, 2, 0);
build_action_area (GTK_DIALOG (htd->shell), action_items, 1, 0);
gtk_widget_show (table);
gtk_widget_show (vbox);
@ -537,13 +534,12 @@ histogram_tool_new_dialog ()
}
static void
histogram_tool_ok_callback (GtkWidget *widget,
histogram_tool_close_callback (GtkWidget *widget,
gpointer client_data)
{
HistogramToolDialog *htd;
htd = (HistogramToolDialog *) client_data;
if (GTK_WIDGET_VISIBLE (htd->shell))
gtk_widget_hide (htd->shell);
}
@ -553,22 +549,11 @@ histogram_tool_delete_callback (GtkWidget *widget,
GdkEvent *event,
gpointer client_data)
{
histogram_tool_cancel_callback (widget, client_data);
histogram_tool_close_callback (widget, client_data);
return TRUE;
}
static void
histogram_tool_cancel_callback (GtkWidget *widget,
gpointer client_data)
{
HistogramToolDialog *htd;
htd = (HistogramToolDialog *) client_data;
if (GTK_WIDGET_VISIBLE (htd->shell))
gtk_widget_hide (htd->shell);
}
static void
histogram_tool_value_callback (GtkWidget *w,
gpointer client_data)

35
app/tools/gimphistogramtool.c
View File

@ -71,8 +71,7 @@ static void histogram_tool_cursor_update (Tool *, GdkEventMotion *, gpointer)
static void histogram_tool_control (Tool *, int, gpointer);
static HistogramToolDialog * histogram_tool_new_dialog (void);
static void histogram_tool_ok_callback (GtkWidget *, gpointer);
static void histogram_tool_cancel_callback (GtkWidget *, gpointer);
static void histogram_tool_close_callback (GtkWidget *, gpointer);
static gint histogram_tool_delete_callback (GtkWidget *, GdkEvent *, gpointer);
static void histogram_tool_value_callback (GtkWidget *, gpointer);
static void histogram_tool_red_callback (GtkWidget *, gpointer);
@ -331,7 +330,7 @@ histogram_tool_control (Tool *tool,
break;
case HALT :
if (histogram_tool_dialog)
histogram_tool_cancel_callback (NULL, (gpointer) histogram_tool_dialog);
histogram_tool_close_callback (NULL, (gpointer) histogram_tool_dialog);
break;
}
}
@ -374,7 +373,7 @@ tools_free_histogram_tool (Tool *tool)
/* Close the histogram dialog */
if (histogram_tool_dialog)
histogram_tool_cancel_callback (NULL, (gpointer) histogram_tool_dialog);
histogram_tool_close_callback (NULL, (gpointer) histogram_tool_dialog);
g_free (hist);
}
@ -415,15 +414,14 @@ histogram_tool_initialize (void *gdisp_ptr)
}
/****************************/
/* Select by Color dialog */
/****************************/
/***************************/
/* Histogram Tool dialog */
/***************************/
/* the action area structure */
static ActionAreaItem action_items[] =
{
{ "OK", histogram_tool_ok_callback, NULL, NULL },
{ "Cancel", histogram_tool_cancel_callback, NULL, NULL }
{ "Close", histogram_tool_close_callback, NULL, NULL }
};
static MenuItem color_option_items[] =
@ -526,8 +524,7 @@ histogram_tool_new_dialog ()
/* The action area */
action_items[0].user_data = htd;
action_items[1].user_data = htd;
build_action_area (GTK_DIALOG (htd->shell), action_items, 2, 0);
build_action_area (GTK_DIALOG (htd->shell), action_items, 1, 0);
gtk_widget_show (table);
gtk_widget_show (vbox);
@ -537,13 +534,12 @@ histogram_tool_new_dialog ()
}
static void
histogram_tool_ok_callback (GtkWidget *widget,
histogram_tool_close_callback (GtkWidget *widget,
gpointer client_data)
{
HistogramToolDialog *htd;
htd = (HistogramToolDialog *) client_data;
if (GTK_WIDGET_VISIBLE (htd->shell))
gtk_widget_hide (htd->shell);
}
@ -553,22 +549,11 @@ histogram_tool_delete_callback (GtkWidget *widget,
GdkEvent *event,
gpointer client_data)
{
histogram_tool_cancel_callback (widget, client_data);
histogram_tool_close_callback (widget, client_data);
return TRUE;
}
static void
histogram_tool_cancel_callback (GtkWidget *widget,
gpointer client_data)
{
HistogramToolDialog *htd;
htd = (HistogramToolDialog *) client_data;
if (GTK_WIDGET_VISIBLE (htd->shell))
gtk_widget_hide (htd->shell);
}
static void
histogram_tool_value_callback (GtkWidget *w,
gpointer client_data)

35
app/tools/histogram_tool.c
View File

@ -71,8 +71,7 @@ static void histogram_tool_cursor_update (Tool *, GdkEventMotion *, gpointer)
static void histogram_tool_control (Tool *, int, gpointer);
static HistogramToolDialog * histogram_tool_new_dialog (void);
static void histogram_tool_ok_callback (GtkWidget *, gpointer);
static void histogram_tool_cancel_callback (GtkWidget *, gpointer);
static void histogram_tool_close_callback (GtkWidget *, gpointer);
static gint histogram_tool_delete_callback (GtkWidget *, GdkEvent *, gpointer);
static void histogram_tool_value_callback (GtkWidget *, gpointer);
static void histogram_tool_red_callback (GtkWidget *, gpointer);
@ -331,7 +330,7 @@ histogram_tool_control (Tool *tool,
break;
case HALT :
if (histogram_tool_dialog)
histogram_tool_cancel_callback (NULL, (gpointer) histogram_tool_dialog);
histogram_tool_close_callback (NULL, (gpointer) histogram_tool_dialog);
break;
}
}
@ -374,7 +373,7 @@ tools_free_histogram_tool (Tool *tool)
/* Close the histogram dialog */
if (histogram_tool_dialog)
histogram_tool_cancel_callback (NULL, (gpointer) histogram_tool_dialog);
histogram_tool_close_callback (NULL, (gpointer) histogram_tool_dialog);
g_free (hist);
}
@ -415,15 +414,14 @@ histogram_tool_initialize (void *gdisp_ptr)
}
/****************************/
/* Select by Color dialog */
/****************************/
/***************************/
/* Histogram Tool dialog */
/***************************/
/* the action area structure */
static ActionAreaItem action_items[] =
{
{ "OK", histogram_tool_ok_callback, NULL, NULL },
{ "Cancel", histogram_tool_cancel_callback, NULL, NULL }
{ "Close", histogram_tool_close_callback, NULL, NULL }
};
static MenuItem color_option_items[] =
@ -526,8 +524,7 @@ histogram_tool_new_dialog ()
/* The action area */
action_items[0].user_data = htd;
action_items[1].user_data = htd;
build_action_area (GTK_DIALOG (htd->shell), action_items, 2, 0);
build_action_area (GTK_DIALOG (htd->shell), action_items, 1, 0);
gtk_widget_show (table);
gtk_widget_show (vbox);
@ -537,13 +534,12 @@ histogram_tool_new_dialog ()
}
static void
histogram_tool_ok_callback (GtkWidget *widget,
histogram_tool_close_callback (GtkWidget *widget,
gpointer client_data)
{
HistogramToolDialog *htd;
htd = (HistogramToolDialog *) client_data;
if (GTK_WIDGET_VISIBLE (htd->shell))
gtk_widget_hide (htd->shell);
}
@ -553,22 +549,11 @@ histogram_tool_delete_callback (GtkWidget *widget,
GdkEvent *event,
gpointer client_data)
{
histogram_tool_cancel_callback (widget, client_data);
histogram_tool_close_callback (widget, client_data);
return TRUE;
}
static void
histogram_tool_cancel_callback (GtkWidget *widget,
gpointer client_data)
{
HistogramToolDialog *htd;
htd = (HistogramToolDialog *) client_data;
if (GTK_WIDGET_VISIBLE (htd->shell))
gtk_widget_hide (htd->shell);
}
static void
histogram_tool_value_callback (GtkWidget *w,
gpointer client_data)