dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added TODO on how to improve the code by changing the way the rectangle is 

2008-03-08  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c: Added TODO on how to improve the
	code by changing the way the rectangle is represented internally.

svn path=/trunk/; revision=25062
This commit is contained in:
Martin Nordholts 2008-03-08 13:14:32 +00:00 committed by Martin Nordholts
parent 236ea53050
commit beab79680f
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2008-03-08 Martin Nordholts <martinn@svn.gnome.org>
* app/tools/gimprectangletool.c: Added TODO on how to improve the
code by changing the way the rectangle is represented internally.
2008-03-07 Sven Neumann <sven@gimp.org>
* etc/controllerrc: changed default mouse-wheel bindings to act on

6
app/tools/gimprectangletool.c
View File

@ -139,6 +139,12 @@ struct _GimpRectangleToolPrivate
* rectangle), but that will be the case if we always calculate the
* integer coordinates based on rounded values of the gdouble
* coordinates even if the gdouble width remains constant.
*
* TODO: Change the internal double-representation of the rectangle
* to x,y width,height instead of x1,y1 x2,y2. That way we don't
* need to keep a separate representation of the integer version of
* the rectangle; rounding width an height will yield consistant
* results and not depend on position of the rectangle.
*/
gint x1_int, y1_int;
gint width_int, height_int;