dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use sizeof() instead of hardcoding the buffer size. 

2006-09-01  Sven Neumann  <sven@gimp.org>

	* app/core/gimpgradient-load.c (gimp_gradient_load): use sizeof()
	instead of hardcoding the buffer size.
This commit is contained in:
Sven Neumann 2006-09-01 08:34:08 +00:00 committed by Sven Neumann
parent a057b8d38e
commit b43b5be15c
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2006-09-01 Sven Neumann <sven@gimp.org>
* app/core/gimpgradient-load.c (gimp_gradient_load): use sizeof()
instead of hardcoding the buffer size.
2006-09-01 Michael Natterer <mitch@gimp.org>
Extended the GIMP Gradient file format to contain the endpoint

14
app/core/gimpgradient-load.c
View File

@ -62,7 +62,7 @@ gimp_gradient_load (const gchar *filename,
return NULL;
}
fgets (line, 1024, file);
fgets (line, sizeof (line), file);
if (strcmp (line, "GIMP Gradient\n") != 0)
{
g_set_error (error, GIMP_DATA_ERROR, GIMP_DATA_ERROR_READ,
@ -77,7 +77,7 @@ gimp_gradient_load (const gchar *filename,
"mime-type", "application/x-gimp-gradient",
NULL);
fgets (line, 1024, file);
fgets (line, sizeof (line), file);
if (! strncmp (line, "Name: ", strlen ("Name: ")))
{
gchar *utf8;
@ -87,7 +87,7 @@ gimp_gradient_load (const gchar *filename,
gimp_filename_to_utf8 (filename));
gimp_object_take_name (GIMP_OBJECT (gradient), g_strstrip (utf8));
fgets (line, 1024, file);
fgets (line, sizeof (line), file);
}
else /* old gradient format */
{
@ -113,9 +113,11 @@ gimp_gradient_load (const gchar *filename,
for (i = 0; i < num_segments; i++)
{
GimpGradientSegment *seg;
gint type, color;
gint left_color_type, right_color_type;
gchar *end;
gint color;
gint type;
gint left_color_type;
gint right_color_type;
seg = gimp_gradient_segment_new ();
@ -126,7 +128,7 @@ gimp_gradient_load (const gchar *filename,
else
gradient->segments = seg;
fgets (line, 1024, file);
fgets (line, sizeof (line), file);
seg->left = g_ascii_strtod (line, &end);
if (end && errno != ERANGE)