Remove a call to channel_set_opacity() at a point where channel always is

* tools/pdbgen/pdb/channel.pdb: Remove a call to
 	channel_set_opacity() at a point where channel always is NULL,
 	causing a crash. The next statement calls channel_new() (passing
 	the opacity), and assigns its return value to channel, so there
 	shouldn't be any need to call channel_set_opacity()?

	* app/channel_cmds.c: Corresponding change in generated file.

	* plug-ins/makefile.{cygwin,msc}: Add the new curve_bend and
 	sample_colorize plug-ins.
This commit is contained in:
Tor Lillqvist 1999-07-28 23:47:45 +00:00
parent 87f0717086
commit 871ca6d6ee
5 changed files with 19 additions and 8 deletions

View File

@ -1,3 +1,16 @@
Thu Jul 29 02:42:17 1999 Tor Lillqvist <tml@iki.fi>
* tools/pdbgen/pdb/channel.pdb: Remove a call to
channel_set_opacity() at a point where channel always is NULL,
causing a crash. The next statement calls channel_new() (passing
the opacity), and assigns its return value to channel, so there
shouldn't be any need to call channel_set_opacity()?
* app/channel_cmds.c: Corresponding change in generated file.
* plug-ins/makefile.{cygwin,msc}: Add the new curve_bend and
sample_colorize plug-ins.
Wed Jul 28 16:17:29 PDT 1999 Manish Singh <yosh@gimp.org>
* tools/pdbgen/pdbgen.pl: eval "defined $_" -> eval "defined scalar $_"

View File

@ -96,7 +96,6 @@ channel_new_invoker (Argument *args)
if (success)
{
channel_set_opacity (channel, opacity);
channel = channel_new (gimage, width, height, name, opacity, color);
success = channel != NULL;
}

View File

@ -22,11 +22,11 @@ FROMPLUGINSDIR=YES # Used to bypass other parts below
# the one used with Microsoft's nmake, which has silly limits.
# The COMMON* ones are in the common subdirectory
COMMON1 = CEL CML_explorer align_layers animationplay animoptimize apply_lens autocrop autostretch_hsv blinds blur bumpmap c_astretch checkerboard colorify compose convmatrix csource cubism
COMMON1 = CEL CML_explorer align_layers animationplay animoptimize apply_lens autocrop autostretch_hsv blinds blur bumpmap c_astretch checkerboard colorify compose convmatrix csource cubism curve_bend
COMMON2 = decompose deinterlace depthmerge despeckle destripe diffraction displace edge emboss engrave exchange film flarefx fractaltrace
COMMON3 = gauss_iir gauss_rle gbr gee gicon gif gifload glasstile gqbist gradmap grid gtm guillotine gz header hot hrz illusion iwarp jigsaw jpeg laplace lic
COMMON4 = mapcolor max_rgb mblur newsprint nlfilt noisify normalize nova oilify palette papertile pat pcx pix pixelize plasma plugindetails png pnm polar ps psd randomize ripple rotate rotators
COMMON5 = scatter_hsv semiflatten sharpen shift smooth_palette snoise sobel sparkle spread sunras tga threshold_alpha tiff tile tileit tiler video vinvert vpropagate waves whirlpinch wind wmf xbm xwd zealouscrop
COMMON5 = sample_colorize scatter_hsv semiflatten sharpen shift smooth_palette snoise sobel sparkle spread sunras tga threshold_alpha tiff tile tileit tiler video vinvert vpropagate waves whirlpinch wind wmf xbm xwd zealouscrop
# These have own subdirectories each
SEPARATE = AlienMap FractalExplorer Lighting MapObject bmp borderaverage dbbrowser faxg3 fits flame fp gfig gfli ifscompose maze mosaic pagecurl print rcm sel2path sgi sinus struc unsharp
@ -36,7 +36,7 @@ SEPARATE = AlienMap FractalExplorer Lighting MapObject bmp borderaverage dbbrows
# ../unofficial-plug-ins directory, go there, and do "make -f
# makefile.cygwin unofficial".
UNOFFICIAL = Anamorphose RGB_Displace ccanalyze curve_bend fuse gimp_ace gimpressionist guash user_filter twain winsnap
UNOFFICIAL = Anamorphose RGB_Displace ccanalyze fuse gimp_ace gimpressionist guash user_filter twain winsnap
# The main target

View File

@ -21,11 +21,11 @@ FROMPLUGINSDIR=YES # Used to bypass other parts below
# List plug-ins. We must use several lists to work around nmake's limits
# The COMMON* ones are in the common subdirectory
COMMON1 = CEL CML_explorer align_layers animationplay animoptimize apply_lens autocrop autostretch_hsv blinds blur bumpmap c_astretch checkerboard colorify compose convmatrix csource cubism
COMMON1 = CEL CML_explorer align_layers animationplay animoptimize apply_lens autocrop autostretch_hsv blinds blur bumpmap c_astretch checkerboard colorify compose convmatrix csource cubism curve_bend
COMMON2 = decompose deinterlace depthmerge despeckle destripe diffraction displace edge emboss engrave exchange film flarefx fractaltrace
COMMON3 = gauss_iir gauss_rle gbr gee gicon gif gifload glasstile gqbist gradmap grid gtm guillotine gz header hot hrz illusion iwarp jigsaw jpeg laplace lic
COMMON4 = mapcolor max_rgb mblur newsprint nlfilt noisify normalize nova oilify palette papertile pat pcx pix pixelize plasma plugindetails png pnm polar ps psd randomize ripple rotate rotators
COMMON5 = scatter_hsv semiflatten sharpen shift smooth_palette snoise sobel sparkle spread sunras tga threshold_alpha tiff tile tileit tiler video vinvert vpropagate waves whirlpinch wind wmf xbm xwd zealouscrop
COMMON5 = sample_colorize scatter_hsv semiflatten sharpen shift smooth_palette snoise sobel sparkle spread sunras tga threshold_alpha tiff tile tileit tiler video vinvert vpropagate waves whirlpinch wind wmf xbm xwd zealouscrop
# These have own subdirectories each
SEPARATE = AlienMap FractalExplorer Lighting MapObject bmp borderaverage dbbrowser faxg3 fits flame fp gfig gfli ifscompose maze mosaic pagecurl print rcm sel2path sgi sinus struc unsharp
@ -35,7 +35,7 @@ SEPARATE = AlienMap FractalExplorer Lighting MapObject bmp borderaverage dbbrows
# ..\unofficial-plug-ins directory, go there, and do "nmake -f
# makefile.msc unofficial".
UNOFFICIAL = Anamorphose RGB_Displace ccanalyze curve_bend fuse gimp_ace gimpressionist guash user_filter twain winsnap
UNOFFICIAL = Anamorphose RGB_Displace ccanalyze fuse gimp_ace gimpressionist guash user_filter twain winsnap
# The main target

View File

@ -144,7 +144,6 @@ HELP
%invoke = (
code => <<'CODE'
{
channel_set_opacity (channel, opacity);
channel = channel_new (gimage, width, height, name, opacity, color);
success = channel != NULL;
}