dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

app: always use libunwind for symbol names in GimpBacktrace Linux backend 

In the GimpBacktrace Linux backend, always use libunwind, when
available, to find symbol names, even if dladdr() or libbacktrace
had already found one.  libunwind provides more descriptive names
in certain cases, and, in particular, full symbol names for C++
lambdas.

Note that, in some cases, this can result in a discrepancy between
the reported symbol name, and the corresponding source location.
This commit is contained in:
Ell 2018-10-11 03:31:57 -04:00
parent 85b16b9eaa
commit 72fc01742b
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/core/gimpbacktrace-linux.c
View File

@ -665,7 +665,16 @@ gimp_backtrace_get_address_info (guintptr address,
#endif /* HAVE_LIBBACKTRACE */
#ifdef HAVE_LIBUNWIND
/* we use libunwind to get the symbol name, when available, even if dladdr() or
* libbacktrace already found one, since it provides more descriptive names in
* some cases, and, in particular, full symbol names for C++ lambdas.
*
* note that, in some cases, this can result in a discrepancy between the
* symbol name, and the corresponding source location.
*/
#if 0
if (! info->symbol_name[0])
#endif
{
unw_context_t context = {};
unw_cursor_t cursor;