Bug 554646 – Opening Help crashes GIMP with lqr-plugin installed

2008-10-02  Michael Natterer  <mitch@gimp.org>

	Bug 554646 – Opening Help crashes GIMP with lqr-plugin installed

	* app/widgets/gimphelp.c (gimp_help_get_help_domains): need to
	assign (*foo)[i] and not *foo[i] of a gchar** returned via return
	value location.


svn path=/trunk/; revision=27113
This commit is contained in:
Michael Natterer 2008-10-02 17:16:14 +00:00 committed by Michael Natterer
parent 184fe0a30b
commit 68acc6598c
2 changed files with 12 additions and 4 deletions

View File

@ -1,3 +1,11 @@
2008-10-02 Michael Natterer <mitch@gimp.org>
Bug 554646 Opening Help crashes GIMP with lqr-plugin installed
* app/widgets/gimphelp.c (gimp_help_get_help_domains): need to
assign (*foo)[i] and not *foo[i] of a gchar** returned via return
value location.
2008-10-02 Michael Natterer <mitch@gimp.org>
* app/plug-in/gimppluginprocframe.c: keep a reference to the

View File

@ -503,13 +503,13 @@ gimp_help_get_help_domains (Gimp *gimp,
*domain_names = g_new0 (gchar *, n_domains + 1);
*domain_uris = g_new0 (gchar *, n_domains + 1);
*domain_names[0] = g_strdup ("http://www.gimp.org/help");
*domain_uris[0] = gimp_help_get_default_domain_uri (gimp);
(*domain_names)[0] = g_strdup ("http://www.gimp.org/help");
(*domain_uris)[0] = gimp_help_get_default_domain_uri (gimp);
for (i = 0; i < n_domains; i++)
{
*domain_names[i + 1] = plug_in_domains[i];
*domain_uris[i + 1] = plug_in_uris[i];
(*domain_names)[i + 1] = plug_in_domains[i];
(*domain_uris)[i + 1] = plug_in_uris[i];
}
g_free (plug_in_domains);