reverted my last change. (gimp_histogram_editor_item_visible): fix the

2004-07-09  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphistogrameditor.c
	(gimp_histogram_editor_menu_update): reverted my last change.
	(gimp_histogram_editor_item_visible): fix the problem here instead.
This commit is contained in:
Sven Neumann 2004-07-08 22:45:36 +00:00 committed by Sven Neumann
parent 788ae2fd5f
commit 458ea9a50e
2 changed files with 34 additions and 25 deletions

View File

@ -1,3 +1,9 @@
2004-07-09 Sven Neumann <sven@gimp.org>
* app/widgets/gimphistogrameditor.c
(gimp_histogram_editor_menu_update): reverted my last change.
(gimp_histogram_editor_item_visible): fix the problem here instead.
2004-07-08 Michael Natterer <mitch@gimp.org>
* libgimpwidgets/gimpdialog.c: removed "role" property because

View File

@ -414,43 +414,46 @@ gimp_histogram_editor_item_visible (GtkTreeModel *model,
GtkTreeIter *iter,
gpointer data)
{
GimpHistogramEditor *editor = GIMP_HISTOGRAM_EDITOR (data);
GimpHistogramChannel channel;
GimpHistogramEditor *editor = GIMP_HISTOGRAM_EDITOR (data);
gtk_tree_model_get (model, iter,
GIMP_INT_STORE_VALUE, &channel,
-1);
switch (channel)
if (editor->drawable)
{
case GIMP_HISTOGRAM_VALUE:
return TRUE;
GimpHistogramChannel channel;
case GIMP_HISTOGRAM_RED:
case GIMP_HISTOGRAM_GREEN:
case GIMP_HISTOGRAM_BLUE:
case GIMP_HISTOGRAM_RGB:
return editor->drawable && gimp_drawable_is_rgb (editor->drawable);
gtk_tree_model_get (model, iter,
GIMP_INT_STORE_VALUE, &channel,
-1);
case GIMP_HISTOGRAM_ALPHA:
return editor->drawable && gimp_drawable_has_alpha (editor->drawable);
switch (channel)
{
case GIMP_HISTOGRAM_VALUE:
return TRUE;
case GIMP_HISTOGRAM_RED:
case GIMP_HISTOGRAM_GREEN:
case GIMP_HISTOGRAM_BLUE:
case GIMP_HISTOGRAM_RGB:
return gimp_drawable_is_rgb (editor->drawable);
case GIMP_HISTOGRAM_ALPHA:
return gimp_drawable_has_alpha (editor->drawable);
}
return FALSE;
}
else
{
/* allow all channels, the menu is insensitive anyway */
return TRUE;
}
return FALSE;
}
static void
gimp_histogram_editor_menu_update (GimpHistogramEditor *editor)
{
GimpHistogramView *view = GIMP_HISTOGRAM_BOX (editor->box)->view;
GtkTreeModel *model;
model = gtk_combo_box_get_model (GTK_COMBO_BOX (editor->menu));
GtkTreeModel *model = gtk_combo_box_get_model (GTK_COMBO_BOX (editor->menu));
gtk_tree_model_filter_refilter (GTK_TREE_MODEL_FILTER (model));
gimp_int_combo_box_set_active (GIMP_INT_COMBO_BOX (editor->menu),
gimp_histogram_view_get_channel (view));
}
static void