dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

app: Don't grab the pointer when doing scrolling 

By doing `gimp_display_shell_pointer_grab()`, we actually prevent events
from a tablet coming through. There doesn't seem to be a reason to use
it and it's not regressing in functionality either, so let's just remove
it.

Fixes: https://gitlab.gnome.org/GNOME/gimp/-/issues/8016
This commit is contained in:
Niels De Graef 2023-05-24 12:30:00 +02:00 committed by Jehan
parent ebe63c215f
commit 413cf9ad85
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/display/gimpdisplayshell-tool-events.c
View File

@ -1685,10 +1685,6 @@ gimp_display_shell_start_scrolling (GimpDisplayShell *shell,
mod_action = GIMP_MODIFIER_ACTION_ZOOMING; mod_action = GIMP_MODIFIER_ACTION_ZOOMING;
} }
gimp_display_shell_pointer_grab (shell, event,
GDK_POINTER_MOTION_MASK |
GDK_BUTTON_RELEASE_MASK);
shell->scroll_start_x = x; shell->scroll_start_x = x;
shell->scroll_start_y = y; shell->scroll_start_y = y;
shell->scroll_last_x = x; shell->scroll_last_x = x;
@ -1799,12 +1795,6 @@ gimp_display_shell_stop_scrolling (GimpDisplayShell *shell,
shell->scroll_last_x = 0; shell->scroll_last_x = 0;
shell->scroll_last_y = 0; shell->scroll_last_y = 0;
shell->rotate_drag_angle = 0.0; shell->rotate_drag_angle = 0.0;
/* We may have ungrabbed the pointer when space was released while
* mouse was down, to be able to catch a GDK_BUTTON_RELEASE event.
*/
if (shell->grab_pointer)
gimp_display_shell_pointer_ungrab (shell, event);
} }
static void static void