From 413cf9ad854139a7504c7a966578acca86f48a87 Mon Sep 17 00:00:00 2001 From: Niels De Graef Date: Wed, 24 May 2023 12:30:00 +0200 Subject: [PATCH] app: Don't grab the pointer when doing scrolling By doing `gimp_display_shell_pointer_grab()`, we actually prevent events from a tablet coming through. There doesn't seem to be a reason to use it and it's not regressing in functionality either, so let's just remove it. Fixes: https://gitlab.gnome.org/GNOME/gimp/-/issues/8016 --- app/display/gimpdisplayshell-tool-events.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/display/gimpdisplayshell-tool-events.c b/app/display/gimpdisplayshell-tool-events.c index b0f4a47d20..05b1402a18 100644 --- a/app/display/gimpdisplayshell-tool-events.c +++ b/app/display/gimpdisplayshell-tool-events.c @@ -1685,10 +1685,6 @@ gimp_display_shell_start_scrolling (GimpDisplayShell *shell, mod_action = GIMP_MODIFIER_ACTION_ZOOMING; } - gimp_display_shell_pointer_grab (shell, event, - GDK_POINTER_MOTION_MASK | - GDK_BUTTON_RELEASE_MASK); - shell->scroll_start_x = x; shell->scroll_start_y = y; shell->scroll_last_x = x; @@ -1799,12 +1795,6 @@ gimp_display_shell_stop_scrolling (GimpDisplayShell *shell, shell->scroll_last_x = 0; shell->scroll_last_y = 0; shell->rotate_drag_angle = 0.0; - - /* We may have ungrabbed the pointer when space was released while - * mouse was down, to be able to catch a GDK_BUTTON_RELEASE event. - */ - if (shell->grab_pointer) - gimp_display_shell_pointer_ungrab (shell, event); } static void