From 2ead56096d9813f710f4fb545e1b70502affe53b Mon Sep 17 00:00:00 2001 From: Michael Natterer Date: Sun, 14 Jul 2019 21:34:27 +0200 Subject: [PATCH] plug-ins, pdb: remove the softglow plug-in and add a PDB compat procedure Not for 2.10 because the GEGL op's result looks different. I have no clue how softglow is supposed to look at all, but the removed plug-in did things that can't possibly be done with physical light in a darkroom, so chances are the GEGL op is more correct. --- app/pdb/internal-procs.c | 2 +- app/pdb/plug-in-compat-cmds.c | 102 +++++ pdb/groups/plug_in_compat.pdb | 64 +++ plug-ins/common/.gitignore | 2 - plug-ins/common/Makefile.am | 19 - plug-ins/common/gimprc.common | 1 - plug-ins/common/plugin-defs.pl | 1 - plug-ins/common/softglow.c | 723 --------------------------------- po-plug-ins/POTFILES.in | 1 - 9 files changed, 167 insertions(+), 748 deletions(-) delete mode 100644 plug-ins/common/softglow.c diff --git a/app/pdb/internal-procs.c b/app/pdb/internal-procs.c index 4a4674c786..3cbfb383e1 100644 --- a/app/pdb/internal-procs.c +++ b/app/pdb/internal-procs.c @@ -28,7 +28,7 @@ #include "internal-procs.h" -/* 740 procedures registered total */ +/* 741 procedures registered total */ void internal_procs_init (GimpPDB *pdb) diff --git a/app/pdb/plug-in-compat-cmds.c b/app/pdb/plug-in-compat-cmds.c index 2ba137e6cb..5c12fdda07 100644 --- a/app/pdb/plug-in-compat-cmds.c +++ b/app/pdb/plug-in-compat-cmds.c @@ -3809,6 +3809,54 @@ plug_in_sobel_invoker (GimpProcedure *procedure, error ? *error : NULL); } +static GimpValueArray * +plug_in_softglow_invoker (GimpProcedure *procedure, + Gimp *gimp, + GimpContext *context, + GimpProgress *progress, + const GimpValueArray *args, + GError **error) +{ + gboolean success = TRUE; + GimpDrawable *drawable; + gdouble glow_radius; + gdouble brightness; + gdouble sharpness; + + drawable = gimp_value_get_drawable (gimp_value_array_index (args, 2), gimp); + glow_radius = g_value_get_double (gimp_value_array_index (args, 3)); + brightness = g_value_get_double (gimp_value_array_index (args, 4)); + sharpness = g_value_get_double (gimp_value_array_index (args, 5)); + + if (success) + { + if (gimp_pdb_item_is_attached (GIMP_ITEM (drawable), NULL, + GIMP_PDB_ITEM_CONTENT, error) && + gimp_pdb_item_is_not_group (GIMP_ITEM (drawable), error)) + { + GeglNode *node = + gegl_node_new_child (NULL, + "operation", "gegl:softglow", + "glow-radius", glow_radius, + "brightness", brightness, + "sharpness", sharpness, + NULL); + + node = wrap_in_gamma_cast (node, drawable); + + gimp_drawable_apply_operation (drawable, progress, + C_("undo-type", "Softglow"), + node); + g_object_unref (node); + } + else + success = FALSE; + } + + return gimp_procedure_get_return_values (procedure, success, + error ? *error : NULL); +} + static GimpValueArray * plug_in_solid_noise_invoker (GimpProcedure *procedure, Gimp *gimp, @@ -8211,6 +8259,60 @@ register_plug_in_compat_procs (GimpPDB *pdb) gimp_pdb_register_procedure (pdb, procedure); g_object_unref (procedure); + /* + * gimp-plug-in-softglow + */ + procedure = gimp_procedure_new (plug_in_softglow_invoker); + gimp_object_set_static_name (GIMP_OBJECT (procedure), + "plug-in-softglow"); + gimp_procedure_set_static_strings (procedure, + "plug-in-softglow", + "Simulate glow by making highlights intense and fuzzy", + "Gives an image a softglow effect by intensifying the highlights in the image. This is done by screening a modified version of the drawable with itself. The modified version is desaturated and then a sigmoidal transfer function is applied to force the distribution of intensities into very small and very large only. This desaturated version is then blurred to give it a fuzzy 'vaseline-on-the-lens' effect. The glow radius parameter controls the sharpness of the glow effect. The brightness parameter controls the degree of intensification applied to image highlights. The sharpness parameter controls how defined or alternatively, diffuse, the glow effect should be.", + "Compatibility procedure. Please see 'gegl:softglow' for credits.", + "Compatibility procedure. Please see 'gegl:softglow' for credits.", + "2019", + NULL); + gimp_procedure_add_argument (procedure, + g_param_spec_enum ("run-mode", + "run mode", + "The run mode", + GIMP_TYPE_RUN_MODE, + GIMP_RUN_INTERACTIVE, + GIMP_PARAM_READWRITE)); + gimp_procedure_add_argument (procedure, + gimp_param_spec_image_id ("image", + "image", + "Input image (unused)", + pdb->gimp, FALSE, + GIMP_PARAM_READWRITE)); + gimp_procedure_add_argument (procedure, + gimp_param_spec_drawable_id ("drawable", + "drawable", + "Input drawable", + pdb->gimp, FALSE, + GIMP_PARAM_READWRITE)); + gimp_procedure_add_argument (procedure, + g_param_spec_double ("glow-radius", + "glow radius", + "Glow radius in pixels", + 0, G_MAXDOUBLE, 0, + GIMP_PARAM_READWRITE)); + gimp_procedure_add_argument (procedure, + g_param_spec_double ("brightness", + "brightness", + "Glow brightness", + 0.0, 1.0, 0.0, + GIMP_PARAM_READWRITE)); + gimp_procedure_add_argument (procedure, + g_param_spec_double ("sharpness", + "sharpness", + "Glow sharpness", + 0.0, 1.0, 0.0, + GIMP_PARAM_READWRITE)); + gimp_pdb_register_procedure (pdb, procedure); + g_object_unref (procedure); + /* * gimp-plug-in-solid-noise */ diff --git a/pdb/groups/plug_in_compat.pdb b/pdb/groups/plug_in_compat.pdb index cbca2f7470..fcd7c4e3d3 100644 --- a/pdb/groups/plug_in_compat.pdb +++ b/pdb/groups/plug_in_compat.pdb @@ -3981,6 +3981,69 @@ CODE ); } +sub plug_in_softglow { + $blurb = 'Simulate glow by making highlights intense and fuzzy'; + + $help = <<'HELP'; +Gives an image a softglow effect by intensifying the highlights in the +image. This is done by screening a modified version of the drawable +with itself. The modified version is desaturated and then a sigmoidal +transfer function is applied to force the distribution of intensities +into very small and very large only. This desaturated version is then +blurred to give it a fuzzy 'vaseline-on-the-lens' effect. The glow +radius parameter controls the sharpness of the glow effect. The +brightness parameter controls the degree of intensification applied to +image highlights. The sharpness parameter controls how defined or +alternatively, diffuse, the glow effect should be. +HELP + + &std_pdb_compat('gegl:softglow'); + $date = '2019'; + + @inargs = ( + { name => 'run_mode', type => 'enum GimpRunMode', dead => 1, + desc => 'The run mode' }, + { name => 'image', type => 'image', dead => 1, + desc => 'Input image (unused)' }, + { name => 'drawable', type => 'drawable', + desc => 'Input drawable' }, + { name => 'glow_radius', type => '0 <= float', + desc => 'Glow radius in pixels' }, + { name => 'brightness', type => '0.0 <= float <= 1.0', + desc => 'Glow brightness' }, + { name => 'sharpness', type => '0.0 <= float <= 1.0', + desc => 'Glow sharpness' } + ); + + %invoke = ( + code => <<'CODE' +{ + if (gimp_pdb_item_is_attached (GIMP_ITEM (drawable), NULL, + GIMP_PDB_ITEM_CONTENT, error) && + gimp_pdb_item_is_not_group (GIMP_ITEM (drawable), error)) + { + GeglNode *node = + gegl_node_new_child (NULL, + "operation", "gegl:softglow", + "glow-radius", glow_radius, + "brightness", brightness, + "sharpness", sharpness, + NULL); + + node = wrap_in_gamma_cast (node, drawable); + + gimp_drawable_apply_operation (drawable, progress, + C_("undo-type", "Softglow"), + node); + g_object_unref (node); + } + else + success = FALSE; +} +CODE + ); +} + sub plug_in_solid_noise { $blurb = 'Create a random cloud-like texture'; @@ -5107,6 +5170,7 @@ CODE plug_in_shift plug_in_sinus plug_in_sobel + plug_in_softglow plug_in_solid_noise plug_in_spread plug_in_threshold_alpha diff --git a/plug-ins/common/.gitignore b/plug-ins/common/.gitignore index 216a3faa82..e8fbb1a877 100644 --- a/plug-ins/common/.gitignore +++ b/plug-ins/common/.gitignore @@ -150,8 +150,6 @@ /sharpen.exe /smooth-palette /smooth-palette.exe -/softglow -/softglow.exe /sparkle /sparkle.exe /sphere-designer diff --git a/plug-ins/common/Makefile.am b/plug-ins/common/Makefile.am index b4cf6f7fa0..9e478a14b1 100644 --- a/plug-ins/common/Makefile.am +++ b/plug-ins/common/Makefile.am @@ -120,7 +120,6 @@ qbist_libexecdir = $(gimpplugindir)/plug-ins/qbist sample_colorize_libexecdir = $(gimpplugindir)/plug-ins/sample-colorize sharpen_libexecdir = $(gimpplugindir)/plug-ins/sharpen smooth_palette_libexecdir = $(gimpplugindir)/plug-ins/smooth-palette -softglow_libexecdir = $(gimpplugindir)/plug-ins/softglow sparkle_libexecdir = $(gimpplugindir)/plug-ins/sparkle sphere_designer_libexecdir = $(gimpplugindir)/plug-ins/sphere-designer tile_libexecdir = $(gimpplugindir)/plug-ins/tile @@ -207,7 +206,6 @@ qbist_libexec_PROGRAMS = qbist sample_colorize_libexec_PROGRAMS = sample-colorize sharpen_libexec_PROGRAMS = sharpen smooth_palette_libexec_PROGRAMS = smooth-palette -softglow_libexec_PROGRAMS = softglow sparkle_libexec_PROGRAMS = sparkle sphere_designer_libexec_PROGRAMS = sphere-designer tile_libexec_PROGRAMS = tile @@ -1573,23 +1571,6 @@ smooth_palette_LDADD = \ $(INTLLIBS) \ $(smooth_palette_RC) -softglow_SOURCES = \ - softglow.c - -softglow_LDADD = \ - $(libgimpui) \ - $(libgimpwidgets) \ - $(libgimpmodule) \ - $(libgimp) \ - $(libgimpmath) \ - $(libgimpconfig) \ - $(libgimpcolor) \ - $(libgimpbase) \ - $(GTK_LIBS) \ - $(RT_LIBS) \ - $(INTLLIBS) \ - $(softglow_RC) - sparkle_SOURCES = \ sparkle.c diff --git a/plug-ins/common/gimprc.common b/plug-ins/common/gimprc.common index d0f056754e..08f017ec4c 100644 --- a/plug-ins/common/gimprc.common +++ b/plug-ins/common/gimprc.common @@ -72,7 +72,6 @@ qbist_RC = qbist.rc.o sample_colorize_RC = sample-colorize.rc.o sharpen_RC = sharpen.rc.o smooth_palette_RC = smooth-palette.rc.o -softglow_RC = softglow.rc.o sparkle_RC = sparkle.rc.o sphere_designer_RC = sphere-designer.rc.o tile_RC = tile.rc.o diff --git a/plug-ins/common/plugin-defs.pl b/plug-ins/common/plugin-defs.pl index 1bc05b0986..3bc5dbfdf5 100644 --- a/plug-ins/common/plugin-defs.pl +++ b/plug-ins/common/plugin-defs.pl @@ -74,7 +74,6 @@ 'sample-colorize' => { ui => 1, gegl => 1 }, 'sharpen' => { ui => 1 }, 'smooth-palette' => { ui => 1, gegl => 1 }, - 'softglow' => { ui => 1 }, 'sparkle' => { ui => 1, gegl => 1 }, 'sphere-designer' => { ui => 1, gegl => 1 }, 'tile' => { ui => 1, gegl => 1 }, diff --git a/plug-ins/common/softglow.c b/plug-ins/common/softglow.c deleted file mode 100644 index b01d5a8bd4..0000000000 --- a/plug-ins/common/softglow.c +++ /dev/null @@ -1,723 +0,0 @@ -/* GIMP - The GNU Image Manipulation Program - * Copyright (C) 1995 Spencer Kimball and Peter Mattis - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ - -/* Softglow filter for GIMP for BIPS - * -Spencer Kimball - * - * This filter screens a desaturated, sigmoidally transferred - * and gaussian blurred version of the drawable over itself - * to create a "softglow" photographic effect. - */ - -#include "config.h" - -#include - -#include -#include - -#include "libgimp/stdplugins-intl.h" - - -/* Some useful macros */ - -#define PLUG_IN_PROC "plug-in-softglow" -#define PLUG_IN_BINARY "softglow" -#define PLUG_IN_ROLE "gimp-softglow" -#define TILE_CACHE_SIZE 48 -#define SIGMOIDAL_BASE 2 -#define SIGMOIDAL_RANGE 20 - -#define INT_MULT(a,b,t) ((t) = (a) * (b) + 0x80, ((((t) >> 8) + (t)) >> 8)) - -typedef struct -{ - gdouble glow_radius; - gdouble brightness; - gdouble sharpness; -} SoftglowVals; - - -/* - * Function prototypes. - */ - -static void query (void); -static void run (const gchar *name, - gint nparams, - const GimpParam *param, - gint *nreturn_vals, - GimpParam **return_vals); - -static void softglow (GimpDrawable *drawable, - GimpPreview *preview); -static gboolean softglow_dialog (GimpDrawable *drawable); - -/* - * Gaussian blur helper functions - */ -static void find_constants (gdouble n_p[], - gdouble n_m[], - gdouble d_p[], - gdouble d_m[], - gdouble bd_p[], - gdouble bd_m[], - gdouble std_dev); -static void transfer_pixels (gdouble *src1, - gdouble *src2, - guchar *dest, - gint jump, - gint width); - -/***** Local vars *****/ - -const GimpPlugInInfo PLUG_IN_INFO = -{ - NULL, /* init */ - NULL, /* quit */ - query, /* query */ - run, /* run */ -}; - -static SoftglowVals svals = -{ - 10.0, /* glow_radius */ - 0.75, /* brightness */ - 0.85, /* sharpness */ -}; - - -/***** Functions *****/ - -MAIN () - -static void -query (void) -{ - static const GimpParamDef args[] = - { - { GIMP_PDB_INT32, "run-mode", "The run mode { RUN-INTERACTIVE (0), RUN-NONINTERACTIVE (1) }" }, - { GIMP_PDB_IMAGE, "image", "Input image (unused)" }, - { GIMP_PDB_DRAWABLE, "drawable", "Input drawable" }, - { GIMP_PDB_FLOAT, "glow-radius", "Glow radius (radius in pixels)" }, - { GIMP_PDB_FLOAT, "brightness", "Glow brightness (0.0 - 1.0)" }, - { GIMP_PDB_FLOAT, "sharpness", "Glow sharpness (0.0 - 1.0)" } - }; - - gchar *help_string = - "Gives an image a softglow effect by intensifying the highlights in the " - "image. This is done by screening a modified version of the drawable " - "with itself. The modified version is desaturated and then a sigmoidal " - "transfer function is applied to force the distribution of intensities " - "into very small and very large only. This desaturated version is then " - "blurred to give it a fuzzy 'vaseline-on-the-lens' effect. The glow " - "radius parameter controls the sharpness of the glow effect. The " - "brightness parameter controls the degree of intensification applied " - "to image highlights. The sharpness parameter controls how defined or " - "alternatively, diffuse, the glow effect should be."; - - gimp_install_procedure (PLUG_IN_PROC, - N_("Simulate glow by making highlights intense and fuzzy"), - help_string, - "Spencer Kimball", - "Bit Specialists, Inc.", - "2001", - N_("_Softglow (legacy)..."), - "RGB*, GRAY*", - GIMP_PLUGIN, - G_N_ELEMENTS (args), 0, - args, NULL); - - gimp_plugin_menu_register (PLUG_IN_PROC, "/Filters/Artistic"); -} - -static void -run (const gchar *name, - gint nparams, - const GimpParam *param, - gint *nreturn_vals, - GimpParam **return_vals) -{ - static GimpParam values[2]; - GimpRunMode run_mode; - GimpDrawable *drawable; - GimpPDBStatusType status = GIMP_PDB_SUCCESS; - - run_mode = param[0].data.d_int32; - - /* Get the specified drawable */ - drawable = gimp_drawable_get (param[2].data.d_drawable); - - /* set the tile cache size */ - gimp_tile_cache_ntiles (TILE_CACHE_SIZE); - - *nreturn_vals = 1; - *return_vals = values; - - values[0].type = GIMP_PDB_STATUS; - values[0].data.d_status = status; - - INIT_I18N(); - - switch (run_mode) - { - case GIMP_RUN_INTERACTIVE: - /* Possibly retrieve data */ - gimp_get_data (PLUG_IN_PROC, &svals); - - /* First acquire information with a dialog */ - if (! softglow_dialog (drawable)) - return; - break; - - case GIMP_RUN_NONINTERACTIVE: - svals.glow_radius = param[3].data.d_float; - svals.brightness = param[4].data.d_float; - svals.sharpness = param[5].data.d_float; - break; - - case GIMP_RUN_WITH_LAST_VALS: - /* Possibly retrieve data */ - gimp_get_data (PLUG_IN_PROC, &svals); - break; - - default: - break; - } - - if (status == GIMP_PDB_SUCCESS) - { - /* Make sure that the drawable is RGB or GRAY color */ - if (gimp_drawable_is_rgb (drawable->drawable_id) || - gimp_drawable_is_gray (drawable->drawable_id)) - { - gimp_progress_init ("Softglow"); - - softglow (drawable, NULL); - - if (run_mode != GIMP_RUN_NONINTERACTIVE) - gimp_displays_flush (); - - /* Store data */ - if (run_mode == GIMP_RUN_INTERACTIVE) - gimp_set_data (PLUG_IN_PROC, &svals, sizeof (SoftglowVals)); - } - else - { - status = GIMP_PDB_EXECUTION_ERROR; - *nreturn_vals = 2; - values[1].type = GIMP_PDB_STRING; - values[1].data.d_string = _("Cannot operate on indexed color images."); - } - } - - values[0].data.d_status = status; - - gimp_drawable_detach (drawable); -} - -static void -softglow (GimpDrawable *drawable, - GimpPreview *preview) -{ - GimpPixelRgn src_rgn, dest_rgn; - GimpPixelRgn *pr; - gint width, height; - gint bytes; - gboolean has_alpha; - guchar *dest; - guchar *src, *sp_p, *sp_m; - gdouble n_p[5], n_m[5]; - gdouble d_p[5], d_m[5]; - gdouble bd_p[5], bd_m[5]; - gdouble *val_p, *val_m, *vp, *vm; - gint x1, y1; - gint i, j; - gint row, col, b; - gint terms; - gint progress, max_progress; - gint initial_p[4]; - gint initial_m[4]; - gint tmp; - gdouble radius; - gdouble std_dev; - gdouble val; - - if (preview) - { - gimp_preview_get_position (preview, &x1, &y1); - gimp_preview_get_size (preview, &width, &height); - } - else if (! gimp_drawable_mask_intersect (drawable->drawable_id, - &x1, &y1, &width, &height)) - return; - - bytes = drawable->bpp; - has_alpha = gimp_drawable_has_alpha (drawable->drawable_id); - - val_p = g_new (gdouble, MAX (width, height)); - val_m = g_new (gdouble, MAX (width, height)); - - dest = g_new0 (guchar, width * height); - - progress = 0; - max_progress = width * height * 3; - - /* Initialize the pixel regions. */ - gimp_pixel_rgn_init (&src_rgn, drawable, x1, y1, width, height, FALSE, FALSE); - - for (pr = gimp_pixel_rgns_register (1, &src_rgn); - pr != NULL; - pr = gimp_pixel_rgns_process (pr)) - { - guchar *src_ptr = src_rgn.data; - guchar *dest_ptr = dest + (src_rgn.y - y1) * width + (src_rgn.x - x1); - - for (row = 0; row < src_rgn.h; row++) - { - for (col = 0; col < src_rgn.w; col++) - { - /* desaturate */ - if (bytes > 2) - { - GimpRGB rgb; - GimpHSL hsl; - - gimp_rgb_set_uchar (&rgb, - src_ptr[col * bytes + 0], - src_ptr[col * bytes + 1], - src_ptr[col * bytes + 2]); - gimp_rgb_to_hsl (&rgb, &hsl); - dest_ptr[col] = ROUND (hsl.l * 255.0); - } - else - { - dest_ptr[col] = (guchar) src_ptr[col * bytes]; - } - - /* compute sigmoidal transfer */ - val = dest_ptr[col] / 255.0; - val = 255.0 / (1 + exp (-(SIGMOIDAL_BASE + (svals.sharpness * SIGMOIDAL_RANGE)) * (val - 0.5))); - val = val * svals.brightness; - dest_ptr[col] = (guchar) CLAMP (val, 0, 255); - } - - src_ptr += src_rgn.rowstride; - dest_ptr += width; - } - - if (!preview) - { - progress += src_rgn.w * src_rgn.h; - gimp_progress_update ((gdouble) progress / (gdouble) max_progress); - } - } - - /* Calculate the standard deviations */ - radius = fabs (svals.glow_radius) + 1.0; - std_dev = sqrt (-(radius * radius) / (2 * log (1.0 / 255.0))); - - /* derive the constants for calculating the gaussian from the std dev */ - find_constants (n_p, n_m, d_p, d_m, bd_p, bd_m, std_dev); - - /* First the vertical pass */ - for (col = 0; col < width; col++) - { - memset (val_p, 0, height * sizeof (gdouble)); - memset (val_m, 0, height * sizeof (gdouble)); - - src = dest + col; - sp_p = src; - sp_m = src + width * (height - 1); - vp = val_p; - vm = val_m + (height - 1); - - /* Set up the first vals */ - initial_p[0] = sp_p[0]; - initial_m[0] = sp_m[0]; - - for (row = 0; row < height; row++) - { - gdouble *vpptr, *vmptr; - - terms = (row < 4) ? row : 4; - - vpptr = vp; vmptr = vm; - for (i = 0; i <= terms; i++) - { - *vpptr += n_p[i] * sp_p[-i * width] - d_p[i] * vp[-i]; - *vmptr += n_m[i] * sp_m[i * width] - d_m[i] * vm[i]; - } - for (j = i; j <= 4; j++) - { - *vpptr += (n_p[j] - bd_p[j]) * initial_p[0]; - *vmptr += (n_m[j] - bd_m[j]) * initial_m[0]; - } - - sp_p += width; - sp_m -= width; - vp ++; - vm --; - } - - transfer_pixels (val_p, val_m, dest + col, width, height); - - if (!preview) - { - progress += height; - if ((col % 5) == 0) - gimp_progress_update ((gdouble) progress / (gdouble) max_progress); - } - } - - for (row = 0; row < height; row++) - { - memset (val_p, 0, width * sizeof (gdouble)); - memset (val_m, 0, width * sizeof (gdouble)); - - src = dest + row * width; - - sp_p = src; - sp_m = src + width - 1; - vp = val_p; - vm = val_m + width - 1; - - /* Set up the first vals */ - initial_p[0] = sp_p[0]; - initial_m[0] = sp_m[0]; - - for (col = 0; col < width; col++) - { - gdouble *vpptr, *vmptr; - - terms = (col < 4) ? col : 4; - - vpptr = vp; vmptr = vm; - - for (i = 0; i <= terms; i++) - { - *vpptr += n_p[i] * sp_p[-i] - d_p[i] * vp[-i]; - *vmptr += n_m[i] * sp_m[i] - d_m[i] * vm[i]; - } - - for (j = i; j <= 4; j++) - { - *vpptr += (n_p[j] - bd_p[j]) * initial_p[0]; - *vmptr += (n_m[j] - bd_m[j]) * initial_m[0]; - } - - sp_p ++; - sp_m --; - vp ++; - vm --; - } - - transfer_pixels (val_p, val_m, dest + row * width, 1, width); - - if (!preview) - { - progress += width; - if ((row % 5) == 0) - gimp_progress_update ((gdouble) progress / (gdouble) max_progress); - } - } - - /* Initialize the pixel regions. */ - gimp_pixel_rgn_init (&src_rgn, drawable, x1, y1, width, height, FALSE, FALSE); - gimp_pixel_rgn_init (&dest_rgn, drawable, - x1, y1, width, height, (preview == NULL), TRUE); - - for (pr = gimp_pixel_rgns_register (2, &src_rgn, &dest_rgn); - pr != NULL; - pr = gimp_pixel_rgns_process (pr)) - { - guchar *src_ptr = src_rgn.data; - guchar *dest_ptr = dest_rgn.data; - guchar *blur_ptr = dest + (src_rgn.y - y1) * width + (src_rgn.x - x1); - - for (row = 0; row < src_rgn.h; row++) - { - for (col = 0; col < src_rgn.w; col++) - { - /* screen op */ - for (b = 0; b < (has_alpha ? (bytes - 1) : bytes); b++) - dest_ptr[col * bytes + b] = - 255 - INT_MULT((255 - src_ptr[col * bytes + b]), - (255 - blur_ptr[col]), tmp); - if (has_alpha) - dest_ptr[col * bytes + b] = src_ptr[col * bytes + b]; - } - - src_ptr += src_rgn.rowstride; - dest_ptr += dest_rgn.rowstride; - blur_ptr += width; - } - - if (preview) - { - gimp_drawable_preview_draw_region (GIMP_DRAWABLE_PREVIEW (preview), - &dest_rgn); - } - else - { - progress += src_rgn.w * src_rgn.h; - gimp_progress_update ((gdouble) progress / (gdouble) max_progress); - } - } - - if (! preview) - { - gimp_progress_update (1.0); - /* merge the shadow, update the drawable */ - gimp_drawable_flush (drawable); - gimp_drawable_merge_shadow (drawable->drawable_id, TRUE); - gimp_drawable_update (drawable->drawable_id, - x1, y1, width, height); - } - - /* free up buffers */ - g_free (val_p); - g_free (val_m); - g_free (dest); -} - -/* - * Gaussian blur helper functions - */ - -static void -transfer_pixels (gdouble *src1, - gdouble *src2, - guchar *dest, - gint jump, - gint width) -{ - gint i; - gdouble sum; - - for (i = 0; i < width; i++) - { - sum = src1[i] + src2[i]; - - sum = CLAMP0255 (sum); - - *dest = (guchar) sum; - dest += jump; - } -} - -static void -find_constants (gdouble n_p[], - gdouble n_m[], - gdouble d_p[], - gdouble d_m[], - gdouble bd_p[], - gdouble bd_m[], - gdouble std_dev) -{ - gint i; - gdouble constants [8]; - gdouble div; - - /* The constants used in the implementation of a casual sequence - * using a 4th order approximation of the gaussian operator - */ - - div = sqrt(2 * G_PI) * std_dev; - - constants [0] = -1.783 / std_dev; - constants [1] = -1.723 / std_dev; - constants [2] = 0.6318 / std_dev; - constants [3] = 1.997 / std_dev; - constants [4] = 1.6803 / div; - constants [5] = 3.735 / div; - constants [6] = -0.6803 / div; - constants [7] = -0.2598 / div; - - n_p [0] = constants[4] + constants[6]; - n_p [1] = exp (constants[1]) * - (constants[7] * sin (constants[3]) - - (constants[6] + 2 * constants[4]) * cos (constants[3])) + - exp (constants[0]) * - (constants[5] * sin (constants[2]) - - (2 * constants[6] + constants[4]) * cos (constants[2])); - n_p [2] = 2 * exp (constants[0] + constants[1]) * - ((constants[4] + constants[6]) * cos (constants[3]) * cos (constants[2]) - - constants[5] * cos (constants[3]) * sin (constants[2]) - - constants[7] * cos (constants[2]) * sin (constants[3])) + - constants[6] * exp (2 * constants[0]) + - constants[4] * exp (2 * constants[1]); - n_p [3] = exp (constants[1] + 2 * constants[0]) * - (constants[7] * sin (constants[3]) - constants[6] * cos (constants[3])) + - exp (constants[0] + 2 * constants[1]) * - (constants[5] * sin (constants[2]) - constants[4] * cos (constants[2])); - n_p [4] = 0.0; - - d_p [0] = 0.0; - d_p [1] = -2 * exp (constants[1]) * cos (constants[3]) - - 2 * exp (constants[0]) * cos (constants[2]); - d_p [2] = 4 * cos (constants[3]) * cos (constants[2]) * exp (constants[0] + constants[1]) + - exp (2 * constants[1]) + exp (2 * constants[0]); - d_p [3] = -2 * cos (constants[2]) * exp (constants[0] + 2 * constants[1]) - - 2 * cos (constants[3]) * exp (constants[1] + 2 * constants[0]); - d_p [4] = exp (2 * constants[0] + 2 * constants[1]); - -#ifndef ORIGINAL_READABLE_CODE - memcpy(d_m, d_p, 5 * sizeof(gdouble)); -#else - for (i = 0; i <= 4; i++) - d_m [i] = d_p [i]; -#endif - - n_m[0] = 0.0; - for (i = 1; i <= 4; i++) - n_m [i] = n_p[i] - d_p[i] * n_p[0]; - - { - gdouble sum_n_p, sum_n_m, sum_d; - gdouble a, b; - - sum_n_p = 0.0; - sum_n_m = 0.0; - sum_d = 0.0; - - for (i = 0; i <= 4; i++) - { - sum_n_p += n_p[i]; - sum_n_m += n_m[i]; - sum_d += d_p[i]; - } - -#ifndef ORIGINAL_READABLE_CODE - sum_d++; - a = sum_n_p / sum_d; - b = sum_n_m / sum_d; -#else - a = sum_n_p / (1 + sum_d); - b = sum_n_m / (1 + sum_d); -#endif - - for (i = 0; i <= 4; i++) - { - bd_p[i] = d_p[i] * a; - bd_m[i] = d_m[i] * b; - } - } -} - -/*******************************************************/ -/* Dialog */ -/*******************************************************/ - -static gboolean -softglow_dialog (GimpDrawable *drawable) -{ - GtkWidget *dialog; - GtkWidget *main_vbox; - GtkWidget *preview; - GtkWidget *grid; - GtkAdjustment *scale_data; - gboolean run; - - gimp_ui_init (PLUG_IN_BINARY, FALSE); - - dialog = gimp_dialog_new (_("Softglow"), PLUG_IN_ROLE, - NULL, 0, - gimp_standard_help_func, PLUG_IN_PROC, - - _("_Cancel"), GTK_RESPONSE_CANCEL, - _("_OK"), GTK_RESPONSE_OK, - - NULL); - - gimp_dialog_set_alternative_button_order (GTK_DIALOG (dialog), - GTK_RESPONSE_OK, - GTK_RESPONSE_CANCEL, - -1); - - gimp_window_set_transient (GTK_WINDOW (dialog)); - - main_vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 12); - gtk_container_set_border_width (GTK_CONTAINER (main_vbox), 12); - gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), - main_vbox, TRUE, TRUE, 0); - gtk_widget_show (main_vbox); - - preview = gimp_drawable_preview_new_from_drawable_id (drawable->drawable_id); - gtk_box_pack_start (GTK_BOX (main_vbox), preview, TRUE, TRUE, 0); - gtk_widget_show (preview); - - g_signal_connect_swapped (preview, "invalidated", - G_CALLBACK (softglow), - drawable); - - grid = gtk_grid_new (); - gtk_grid_set_row_spacing (GTK_GRID (grid), 6); - gtk_grid_set_column_spacing (GTK_GRID (grid), 6); - gtk_box_pack_start (GTK_BOX (main_vbox), grid, FALSE, FALSE, 0); - gtk_widget_show (grid); - - /* Label, scale, entry for svals.amount */ - scale_data = gimp_scale_entry_new (GTK_GRID (grid), 0, 0, - _("_Glow radius:"), 100, 5, - svals.glow_radius, 1.0, 50.0, 1, 5.0, 2, - TRUE, 0, 0, - NULL, NULL); - - g_signal_connect (scale_data, "value-changed", - G_CALLBACK (gimp_double_adjustment_update), - &svals.glow_radius); - g_signal_connect_swapped (scale_data, "value-changed", - G_CALLBACK (gimp_preview_invalidate), - preview); - - /* Label, scale, entry for svals.amount */ - scale_data = gimp_scale_entry_new (GTK_GRID (grid), 0, 1, - _("_Brightness:"), 100, 5, - svals.brightness, 0.0, 1.0, 0.01, 0.1, 2, - TRUE, 0, 0, - NULL, NULL); - - g_signal_connect (scale_data, "value-changed", - G_CALLBACK (gimp_double_adjustment_update), - &svals.brightness); - g_signal_connect_swapped (scale_data, "value-changed", - G_CALLBACK (gimp_preview_invalidate), - preview); - - /* Label, scale, entry for svals.amount */ - scale_data = gimp_scale_entry_new (GTK_GRID (grid), 0, 2, - _("_Sharpness:"), 100, 5, - svals.sharpness, 0.0, 1.0, 0.01, 0.1, 2, - TRUE, 0, 0, - NULL, NULL); - - g_signal_connect (scale_data, "value-changed", - G_CALLBACK (gimp_double_adjustment_update), - &svals.sharpness); - g_signal_connect_swapped (scale_data, "value-changed", - G_CALLBACK (gimp_preview_invalidate), - preview); - - gtk_widget_show (dialog); - - run = (gimp_dialog_run (GIMP_DIALOG (dialog)) == GTK_RESPONSE_OK); - - gtk_widget_destroy (dialog); - - return run; -} diff --git a/po-plug-ins/POTFILES.in b/po-plug-ins/POTFILES.in index 3d3b2e9843..9f130c8017 100644 --- a/po-plug-ins/POTFILES.in +++ b/po-plug-ins/POTFILES.in @@ -78,7 +78,6 @@ plug-ins/common/qbist.c plug-ins/common/sample-colorize.c plug-ins/common/sharpen.c plug-ins/common/smooth-palette.c -plug-ins/common/softglow.c plug-ins/common/sparkle.c plug-ins/common/sphere-designer.c plug-ins/common/tile.c