dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

initialize length to appease cppcheck 

The code was technically correct previously: It wrote the uninitialized
length only as a placeholder to overwrite it later on. Yet it's better
to not confuse tools (or people) analysing the code. Besides that having
0 for the length in the file while the payload is being written may aid
debugging e.g. crashes in that code later on.
This commit is contained in:
Nils Philippsen 2013-11-28 17:43:14 +01:00
parent 99937ddfce
commit 2e6af22686
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/xcf/xcf-save.c
View File

@ -1011,7 +1011,7 @@ xcf_save_prop (XcfInfo *info,
if (gimp_parasite_list_persistent_length (list) > 0) if (gimp_parasite_list_persistent_length (list) > 0)
{ {
guint32 base, length; guint32 base, length = 0;
long pos; long pos;
xcf_write_prop_type_check_error (info, prop_type); xcf_write_prop_type_check_error (info, prop_type);
@ -1056,7 +1056,7 @@ xcf_save_prop (XcfInfo *info,
case PROP_PATHS: case PROP_PATHS:
{ {
guint32 base, length; guint32 base, length = 0;
glong pos; glong pos;
xcf_write_prop_type_check_error (info, prop_type); xcf_write_prop_type_check_error (info, prop_type);
@ -1122,7 +1122,7 @@ xcf_save_prop (XcfInfo *info,
case PROP_VECTORS: case PROP_VECTORS:
{ {
guint32 base, length; guint32 base, length = 0;
glong pos; glong pos;
xcf_write_prop_type_check_error (info, prop_type); xcf_write_prop_type_check_error (info, prop_type);