diff --git a/ChangeLog b/ChangeLog index 8c2caf413f..63455e61aa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2007-08-13 Sven Neumann + + * app/base/gimphistogram.c (gimp_histogram_get_std_dev): corrected + caluclation for the histogram in RGB mode (bug #466189). + 2007-08-13 Sven Neumann * libgimpwidgets/gimpnumberpairentry.c: use italic font if not in diff --git a/app/base/gimphistogram.c b/app/base/gimphistogram.c index f24f64570f..ca7e792256 100644 --- a/app/base/gimphistogram.c +++ b/app/base/gimphistogram.c @@ -469,7 +469,22 @@ gimp_histogram_get_std_dev (GimpHistogram *histogram, count = 1.0; for (i = start; i <= end; i++) - dev += gimp_histogram_get_value (histogram, channel, i) * SQR (i - mean); + { + gdouble value; + + if (channel == GIMP_HISTOGRAM_RGB) + { + value = (HISTOGRAM_VALUE (GIMP_HISTOGRAM_RED, i) + + HISTOGRAM_VALUE (GIMP_HISTOGRAM_GREEN, i) + + HISTOGRAM_VALUE (GIMP_HISTOGRAM_BLUE, i)); + } + else + { + value = gimp_histogram_get_value (histogram, channel, i); + } + + dev += value * SQR (i - mean); + } return sqrt (dev / count); }