dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libgimp: Fix checks when writing GdkPixbuf over the wire 

* We need to check if `icon_bytes` is NULL, not `icon_data`
* We should not set `icon_bytes` if `gdk_pixbuf_save_to_buffer` fails
This commit is contained in:
Niels De Graef 2023-05-25 23:19:58 +02:00
parent c9700680fe
commit 275f7d5f4c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libgimp/gimpprocedure.c
View File

@ -335,10 +335,10 @@ gimp_procedure_install_icon (GimpProcedure *procedure)
if (pixbuf)
{
gdk_pixbuf_save_to_buffer (pixbuf,
(gchar **) &icon_data, &icon_data_length,
"png", NULL, NULL);
icon_bytes = g_bytes_new_take (icon_data, icon_data_length);
if (gdk_pixbuf_save_to_buffer (pixbuf,
(gchar **) &icon_data, &icon_data_length,
"png", NULL, NULL))
icon_bytes = g_bytes_new_take (icon_data, icon_data_length);
}
}
break;
@ -357,7 +357,7 @@ gimp_procedure_install_icon (GimpProcedure *procedure)
break;
}
if (icon_data)
if (icon_bytes)
_gimp_pdb_set_proc_icon (gimp_procedure_get_name (procedure),
icon_type, icon_bytes);
}