From 23711e13d393cec207bcb676dc50c0564b0818fa Mon Sep 17 00:00:00 2001 From: Simon Budig Date: Wed, 17 Mar 2004 16:12:21 +0000 Subject: [PATCH] app/gui/channels-commands.c app/gui/layers-commands.c Make sure that 2004-03-17 Simon Budig * app/gui/channels-commands.c * app/gui/layers-commands.c * app/gui/vectors-commands.c: Make sure that non-dialog creation of layer/channels/vectors properly updates the image. Also clear the new channel unconditionally. Change the name of the newly created item to not include the "Copy". It isn't a copy. * app/widgets/gimpitemtreeview.c: Don't try to assemble translated strings. * app/widgets/gimpchanneltreeview.c * app/widgets/gimplayertreeview.c * app/widgets/gimpvectorstreeview.c: properly overwrite the tooltip for the "New" button. Sorry, some real string changes ahere, but they were necessary. --- ChangeLog | 21 +++++++++++++++++++++ app/actions/channels-commands.c | 10 +++++----- app/actions/layers-commands.c | 3 ++- app/actions/vectors-commands.c | 3 ++- app/gui/channels-commands.c | 10 +++++----- app/gui/layers-commands.c | 3 ++- app/gui/vectors-commands.c | 3 ++- app/widgets/gimpchanneltreeview.c | 2 +- app/widgets/gimpitemtreeview.c | 7 ++----- app/widgets/gimplayertreeview.c | 2 +- app/widgets/gimpvectorstreeview.c | 2 +- 11 files changed, 44 insertions(+), 22 deletions(-) diff --git a/ChangeLog b/ChangeLog index 28608449db..0fc2a9b858 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,24 @@ +2004-03-17 Simon Budig + + * app/gui/channels-commands.c + * app/gui/layers-commands.c + * app/gui/vectors-commands.c: Make sure that non-dialog creation + of layer/channels/vectors properly updates the image. Also + clear the new channel unconditionally. + + Change the name of the newly created item to not include the "Copy". + It isn't a copy. + + * app/widgets/gimpitemtreeview.c: Don't try to assemble translated + strings. + + * app/widgets/gimpchanneltreeview.c + * app/widgets/gimplayertreeview.c + * app/widgets/gimpvectorstreeview.c: properly overwrite the + tooltip for the "New" button. + + Sorry, some real string changes ahere, but they were necessary. + 2004-03-17 Michael Natterer * app/core/gimpdrawable-transform.c diff --git a/app/actions/channels-commands.c b/app/actions/channels-commands.c index 6262a07889..1c1bd97b7f 100644 --- a/app/actions/channels-commands.c +++ b/app/actions/channels-commands.c @@ -319,15 +319,15 @@ channels_new_channel_query (GimpImage *gimage, new_channel = gimp_channel_new (gimage, width, height, - _("Empty Channel Copy"), + _("Empty Channel"), &color); - if (template) - gimp_drawable_fill_by_type (GIMP_DRAWABLE (new_channel), - gimp_get_user_context (gimage->gimp), - GIMP_TRANSPARENT_FILL); + gimp_drawable_fill_by_type (GIMP_DRAWABLE (new_channel), + gimp_get_user_context (gimage->gimp), + GIMP_TRANSPARENT_FILL); gimp_image_add_channel (gimage, new_channel, -1); + gimp_image_flush (gimage); gimp_image_undo_group_end (gimage); return; diff --git a/app/actions/layers-commands.c b/app/actions/layers-commands.c index 51572d4149..65027d9c85 100644 --- a/app/actions/layers-commands.c +++ b/app/actions/layers-commands.c @@ -720,7 +720,7 @@ layers_new_layer_query (GimpImage *gimage, width, height, gimp_image_base_type_with_alpha (gimage), - _("Empty Layer Copy"), + _("Empty Layer"), opacity, mode); @@ -733,6 +733,7 @@ layers_new_layer_query (GimpImage *gimage, } gimp_image_add_layer (gimage, new_layer, -1); + gimp_image_flush (gimage); gimp_image_undo_group_end (gimage); return; diff --git a/app/actions/vectors-commands.c b/app/actions/vectors-commands.c index 037ae668c6..eb2ce13b2e 100644 --- a/app/actions/vectors-commands.c +++ b/app/actions/vectors-commands.c @@ -441,9 +441,10 @@ vectors_new_vectors_query (GimpImage *gimage, { GimpVectors *new_vectors; - new_vectors = gimp_vectors_new (gimage, _("Empty Vectors Copy")); + new_vectors = gimp_vectors_new (gimage, _("Empty Path")); gimp_image_add_vectors (gimage, new_vectors, -1); + gimp_display_flush (gimage); return; } diff --git a/app/gui/channels-commands.c b/app/gui/channels-commands.c index 6262a07889..1c1bd97b7f 100644 --- a/app/gui/channels-commands.c +++ b/app/gui/channels-commands.c @@ -319,15 +319,15 @@ channels_new_channel_query (GimpImage *gimage, new_channel = gimp_channel_new (gimage, width, height, - _("Empty Channel Copy"), + _("Empty Channel"), &color); - if (template) - gimp_drawable_fill_by_type (GIMP_DRAWABLE (new_channel), - gimp_get_user_context (gimage->gimp), - GIMP_TRANSPARENT_FILL); + gimp_drawable_fill_by_type (GIMP_DRAWABLE (new_channel), + gimp_get_user_context (gimage->gimp), + GIMP_TRANSPARENT_FILL); gimp_image_add_channel (gimage, new_channel, -1); + gimp_image_flush (gimage); gimp_image_undo_group_end (gimage); return; diff --git a/app/gui/layers-commands.c b/app/gui/layers-commands.c index 51572d4149..65027d9c85 100644 --- a/app/gui/layers-commands.c +++ b/app/gui/layers-commands.c @@ -720,7 +720,7 @@ layers_new_layer_query (GimpImage *gimage, width, height, gimp_image_base_type_with_alpha (gimage), - _("Empty Layer Copy"), + _("Empty Layer"), opacity, mode); @@ -733,6 +733,7 @@ layers_new_layer_query (GimpImage *gimage, } gimp_image_add_layer (gimage, new_layer, -1); + gimp_image_flush (gimage); gimp_image_undo_group_end (gimage); return; diff --git a/app/gui/vectors-commands.c b/app/gui/vectors-commands.c index 037ae668c6..eb2ce13b2e 100644 --- a/app/gui/vectors-commands.c +++ b/app/gui/vectors-commands.c @@ -441,9 +441,10 @@ vectors_new_vectors_query (GimpImage *gimage, { GimpVectors *new_vectors; - new_vectors = gimp_vectors_new (gimage, _("Empty Vectors Copy")); + new_vectors = gimp_vectors_new (gimage, _("Empty Path")); gimp_image_add_vectors (gimage, new_vectors, -1); + gimp_display_flush (gimage); return; } diff --git a/app/widgets/gimpchanneltreeview.c b/app/widgets/gimpchanneltreeview.c index 2c0a865626..366b7875f8 100644 --- a/app/widgets/gimpchanneltreeview.c +++ b/app/widgets/gimpchanneltreeview.c @@ -118,7 +118,7 @@ gimp_channel_tree_view_class_init (GimpChannelTreeViewClass *klass) item_view_class->edit_desc = _("Edit Channel Attributes"); item_view_class->edit_help_id = GIMP_HELP_CHANNEL_EDIT; - item_view_class->new_desc = _("New Channel"); + item_view_class->new_desc = _("New Channel\n%s New Channel Dialog"); item_view_class->new_help_id = GIMP_HELP_CHANNEL_NEW; item_view_class->duplicate_desc = _("Duplicate Channel"); item_view_class->duplicate_help_id = GIMP_HELP_CHANNEL_DUPLICATE; diff --git a/app/widgets/gimpitemtreeview.c b/app/widgets/gimpitemtreeview.c index 099ce3cd03..616e0f5798 100644 --- a/app/widgets/gimpitemtreeview.c +++ b/app/widgets/gimpitemtreeview.c @@ -344,11 +344,8 @@ gimp_item_tree_view_init (GimpItemTreeView *view, NULL, view); - str = g_strdup_printf (_("%s\n" - "%s %s Dialog"), - view_class->new_desc, - gimp_get_mod_name_shift (), - view_class->new_desc); + str = g_strdup_printf (view_class->new_desc, + gimp_get_mod_name_shift ()); view->new_button = gimp_editor_add_button (editor, diff --git a/app/widgets/gimplayertreeview.c b/app/widgets/gimplayertreeview.c index 798753e656..50726272d6 100644 --- a/app/widgets/gimplayertreeview.c +++ b/app/widgets/gimplayertreeview.c @@ -204,7 +204,7 @@ gimp_layer_tree_view_class_init (GimpLayerTreeViewClass *klass) item_view_class->edit_desc = _("Edit Layer Attributes"); item_view_class->edit_help_id = GIMP_HELP_LAYER_EDIT; - item_view_class->new_desc = _("New Layer"); + item_view_class->new_desc = _("New Layer\n%s New Layer Dialog"); item_view_class->new_help_id = GIMP_HELP_LAYER_NEW; item_view_class->duplicate_desc = _("Duplicate Layer"); item_view_class->duplicate_help_id = GIMP_HELP_LAYER_DUPLICATE; diff --git a/app/widgets/gimpvectorstreeview.c b/app/widgets/gimpvectorstreeview.c index 6b4c0846b3..23a1d8cb77 100644 --- a/app/widgets/gimpvectorstreeview.c +++ b/app/widgets/gimpvectorstreeview.c @@ -128,7 +128,7 @@ gimp_vectors_tree_view_class_init (GimpVectorsTreeViewClass *klass) item_view_class->edit_desc = _("Edit Path Attributes"); item_view_class->edit_help_id = GIMP_HELP_PATH_EDIT; - item_view_class->new_desc = _("New Path"); + item_view_class->new_desc = _("New Path\n%s New Path Dialog"); item_view_class->new_help_id = GIMP_HELP_PATH_NEW; item_view_class->duplicate_desc = _("Duplicate Path"); item_view_class->duplicate_help_id = GIMP_HELP_PATH_DUPLICATE;