dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

This should hopefully fix most of the UMRs (uninitialized memory reads) 

* iscissors.c: This should hopefully fix most of the UMRs
(uninitialized memory reads) found with Purify.  No noticable
change in iscissors's behavior, unfortunately.
This commit is contained in:
Nate Summers 1998-03-26 19:03:10 +00:00
parent 380deeb2d8
commit 0b9cf33499
4 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
Thu Mar 26 12:00:47 MST 1998 Nathan Summers <rock@gimp.org>
* iscissors.c: This should hopefully fix most of the UMRs
(uninitialized memory reads) found with Purify. No noticable
change in iscissors's behavior, unfortunately.
Thu Mar 26 13:03:18 EST 1998 Adrian Likins <adrian@gimp.org> Thu Mar 26 13:03:18 EST 1998 Adrian Likins <adrian@gimp.org>
* app/app_procs.c app/brush_select.c app/brushes.c * app/app_procs.c app/brush_select.c app/brushes.c

9
app/iscissors.c
View File

@ -458,6 +458,7 @@ tools_new_iscissors ()
tool->arrow_keys_func = standard_arrow_keys_func; tool->arrow_keys_func = standard_arrow_keys_func;
tool->cursor_update_func = rect_select_cursor_update; tool->cursor_update_func = rect_select_cursor_update;
tool->control_func = iscissors_control; tool->control_func = iscissors_control;
tool->auto_snap_to = 0;
last_tool = tool; last_tool = tool;
@ -1889,7 +1890,13 @@ calculate_edge_map (GImage *gimage,
destPR.data = conv1 + MAX_CHANNELS * (CONV_WIDTH * offy + offx); destPR.data = conv1 + MAX_CHANNELS * (CONV_WIDTH * offy + offx);
destPR.rowstride = CONV_WIDTH * MAX_CHANNELS; destPR.rowstride = CONV_WIDTH * MAX_CHANNELS;
destPR.tiles = NULL; destPR.tiles = NULL;
destPR.bytes = 1;
destPR.x = x1;
destPR.y = y1;
destPR.w = w;
destPR.h = h;
destPR.dirty = 1;
for (pr =pixel_regions_register (2, &srcPR, &destPR); pr != NULL; pr = pixel_regions_process (pr)) for (pr =pixel_regions_register (2, &srcPR, &destPR); pr != NULL; pr = pixel_regions_process (pr))
gaussian_deriv (&srcPR, &destPR, HORIZONTAL, std_dev); gaussian_deriv (&srcPR, &destPR, HORIZONTAL, std_dev);

9
app/tools/gimpiscissorstool.c
View File

@ -458,6 +458,7 @@ tools_new_iscissors ()
tool->arrow_keys_func = standard_arrow_keys_func; tool->arrow_keys_func = standard_arrow_keys_func;
tool->cursor_update_func = rect_select_cursor_update; tool->cursor_update_func = rect_select_cursor_update;
tool->control_func = iscissors_control; tool->control_func = iscissors_control;
tool->auto_snap_to = 0;
last_tool = tool; last_tool = tool;
@ -1889,7 +1890,13 @@ calculate_edge_map (GImage *gimage,
destPR.data = conv1 + MAX_CHANNELS * (CONV_WIDTH * offy + offx); destPR.data = conv1 + MAX_CHANNELS * (CONV_WIDTH * offy + offx);
destPR.rowstride = CONV_WIDTH * MAX_CHANNELS; destPR.rowstride = CONV_WIDTH * MAX_CHANNELS;
destPR.tiles = NULL; destPR.tiles = NULL;
destPR.bytes = 1;
destPR.x = x1;
destPR.y = y1;
destPR.w = w;
destPR.h = h;
destPR.dirty = 1;
for (pr =pixel_regions_register (2, &srcPR, &destPR); pr != NULL; pr = pixel_regions_process (pr)) for (pr =pixel_regions_register (2, &srcPR, &destPR); pr != NULL; pr = pixel_regions_process (pr))
gaussian_deriv (&srcPR, &destPR, HORIZONTAL, std_dev); gaussian_deriv (&srcPR, &destPR, HORIZONTAL, std_dev);

9
app/tools/iscissors.c
View File

@ -458,6 +458,7 @@ tools_new_iscissors ()
tool->arrow_keys_func = standard_arrow_keys_func; tool->arrow_keys_func = standard_arrow_keys_func;
tool->cursor_update_func = rect_select_cursor_update; tool->cursor_update_func = rect_select_cursor_update;
tool->control_func = iscissors_control; tool->control_func = iscissors_control;
tool->auto_snap_to = 0;
last_tool = tool; last_tool = tool;
@ -1889,7 +1890,13 @@ calculate_edge_map (GImage *gimage,
destPR.data = conv1 + MAX_CHANNELS * (CONV_WIDTH * offy + offx); destPR.data = conv1 + MAX_CHANNELS * (CONV_WIDTH * offy + offx);
destPR.rowstride = CONV_WIDTH * MAX_CHANNELS; destPR.rowstride = CONV_WIDTH * MAX_CHANNELS;
destPR.tiles = NULL; destPR.tiles = NULL;
destPR.bytes = 1;
destPR.x = x1;
destPR.y = y1;
destPR.w = w;
destPR.h = h;
destPR.dirty = 1;
for (pr =pixel_regions_register (2, &srcPR, &destPR); pr != NULL; pr = pixel_regions_process (pr)) for (pr =pixel_regions_register (2, &srcPR, &destPR); pr != NULL; pr = pixel_regions_process (pr))
gaussian_deriv (&srcPR, &destPR, HORIZONTAL, std_dev); gaussian_deriv (&srcPR, &destPR, HORIZONTAL, std_dev);