dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

document the purpose of the extra struct fields. 

2008-07-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/help/gimphelpitem.h: document the purpose of the 
extra
	struct fields.

	* plug-ins/help-browser/dialog.c: limit the depth of the index 
to 4.


svn path=/trunk/; revision=26056
This commit is contained in:
Sven Neumann 2008-07-04 17:27:02 +00:00 committed by Sven Neumann
parent adfc3bd6f7
commit 075e22d2fb
3 changed files with 24 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
2008-07-04 Sven Neumann <sven@gimp.org>
* plug-ins/help/gimphelpitem.h: document the purpose of the extra
struct fields.
* plug-ins/help-browser/dialog.c: limit the depth of the index to 4.
2008-07-04 Sven Neumann <sven@gimp.org>
* app/core/gimpgrid.c: changed default grid to a 10x10 grid of

24
plug-ins/help-browser/dialog.c
View File

@ -62,7 +62,10 @@
#endif
#define GIMP_HELP_BROWSER_DIALOG_DATA "gimp-help-browser-dialog"
#define GIMP_HELP_BROWSER_DIALOG_DATA "gimp-help-browser-dialog"
#define GIMP_HELP_BROWSER_INDEX_MAX_DEPTH 4
typedef struct
{
@ -343,7 +346,6 @@ browser_dialog_make_index_foreach (const gchar *help_id,
GimpHelpItem *item,
GimpHelpLocale *locale)
{
#if 0
g_printerr ("%s: processing %s (parent %s)\n",
G_STRFUNC,
@ -374,7 +376,9 @@ browser_dialog_make_index_foreach (const gchar *help_id,
parent = g_hash_table_lookup (locale->help_id_mapping, item->parent);
if (parent)
parent->children = g_list_prepend (parent->children, item);
{
parent->children = g_list_prepend (parent->children, item);
}
}
else
{
@ -386,8 +390,8 @@ static gint
help_item_compare (gconstpointer a,
gconstpointer b)
{
GimpHelpItem *item_a = (GimpHelpItem *) a;
GimpHelpItem *item_b = (GimpHelpItem *) b;
const GimpHelpItem *item_a = a;
const GimpHelpItem *item_b = b;
if (item_a->index > item_b->index)
return 1;
@ -402,7 +406,8 @@ add_child (GtkTreeStore *store,
GimpHelpDomain *domain,
GimpHelpLocale *locale,
GtkTreeIter *parent,
GimpHelpItem *item)
GimpHelpItem *item,
gint depth)
{
GtkTreeIter iter;
GList *list;
@ -424,13 +429,16 @@ add_child (GtkTreeStore *store,
uri,
gtk_tree_iter_copy (&iter));
if (depth + 1 == GIMP_HELP_BROWSER_INDEX_MAX_DEPTH)
return;
item->children = g_list_sort (item->children, help_item_compare);
for (list = item->children; list; list = g_list_next (list))
{
GimpHelpItem *item = list->data;
add_child (store, domain, locale, &iter, item);
add_child (store, domain, locale, &iter, item, depth + 1);
}
}
@ -470,7 +478,7 @@ browser_dialog_make_index (GimpHelpDomain *domain,
{
GimpHelpItem *item = list->data;
add_child (store, domain, locale, NULL, item);
add_child (store, domain, locale, NULL, item, 0);
}
gtk_tree_view_set_model (GTK_TREE_VIEW (tree_view), GTK_TREE_MODEL (store));

2
plug-ins/help/gimphelpitem.h
View File

@ -31,7 +31,7 @@ struct _GimpHelpItem
gchar *title;
gchar *parent;
/* eek */
/* extra fields used by the help-browser */
GList *children;
gint index;
};