dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug 765492: Memory leak in gimp_brush_cache_add 

g_free the lru 'unit' when removed from the cache

and keep track of the list length and last item
while looking for a duplicate already present in
the cache.
This commit is contained in:
Massimo Valentini 2016-04-24 19:41:22 +02:00
parent 19738412ce
commit 022439e463
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/core/gimpbrushcache.c
View File

@ -258,6 +258,8 @@ gimp_brush_cache_add (GimpBrushCache *cache,
{
GList *iter;
GimpBrushCacheUnit *unit;
GList *last = NULL;
gint length = 0;
g_return_if_fail (GIMP_IS_BRUSH_CACHE (cache));
g_return_if_fail (data != NULL);
@ -268,15 +270,18 @@ gimp_brush_cache_add (GimpBrushCache *cache,
if (data == unit->data)
return;
length++;
last = iter;
}
if (g_list_length (cache->cached_units) > MAX_CACHED_DATA &&
(iter = g_list_last (cache->cached_units)))
if (length > MAX_CACHED_DATA)
{
unit = iter->data;
unit = last->data;
cache->data_destroy (unit->data);
cache->cached_units = g_list_delete_link (cache->cached_units, iter);
cache->cached_units = g_list_delete_link (cache->cached_units, last);
g_free (unit);
}
unit = g_new0 (GimpBrushCacheUnit, 1);