dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gimp/plug-ins/file-raw/file-darktable.c

500 lines
17 KiB
C
Raw Normal View History

plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
/* GIMP - The GNU Image Manipulation Program
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
*
* file-darktable.c -- raw file format plug-in that uses darktable
* Copyright (C) 2012 Simon Budig <simon@gimp.org>
* Copyright (C) 2016 Tobias Ellinghaus <me@houz.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "config.h"
#include <stdlib.h>
#include <errno.h>
#include <glib/gstdio.h>
#include <libgimp/gimp.h>
#include "libgimp/stdplugins-intl.h"
plug-ins: rename file-raw/file-formats.h to file-raw/file-raw-formats.h
2017-07-31 00:35:20 +08:00
#include "file-raw-formats.h"
plug-ins: add some MacOS support to find RawTherapee. Hopefully it works, since that's untested (I have no MacOS access). This is mostly code from file-darktable.c, made generic and factorized into file-raw-utils.[ch]. At least it still builds and work fine on Linux. I used the CFBundleIdentifier from `tools/osx/Info.plist.in` in RawTherapee code. I didn't add a Win32 registry key base though, since I couldn't find any relevant data for this in RawTherapee code.
2017-07-29 07:15:28 +08:00
#include "file-raw-utils.h"
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
app, pdb, libgimp: make the raw image importer configurable Add "import-raw-plug-in" to gimprc, and a new procedure gimp_register_file_handler_raw(). On startup, remove all load procedures that are marked as "handles raw" but are not implemented by the configured plug-in. Add the list of available plug-ins to prefs -> import/export. Register all file-darktable procedures as handling raw.
2017-05-05 02:35:53 +08:00
#define LOAD_THUMB_PROC "file-darktable-load-thumb"
plug-ins: add some MacOS support to find RawTherapee. Hopefully it works, since that's untested (I have no MacOS access). This is mostly code from file-darktable.c, made generic and factorized into file-raw-utils.[ch]. At least it still builds and work fine on Linux. I used the CFBundleIdentifier from `tools/osx/Info.plist.in` in RawTherapee code. I didn't add a Win32 registry key base though, since I couldn't find any relevant data for this in RawTherapee code.
2017-07-29 07:15:28 +08:00
#define REGISTRY_KEY_BASE "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\App Paths\\darktable"
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
plug-ins: move conditional gimp_install_procedure() of file-darktable... ... to init(). Otherwise presence of darktable is not checked at every startup.
2017-06-28 04:45:31 +08:00
static void init (void);
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
static void query (void);
static void run (const gchar *name,
gint nparams,
const GimpParam *param,
gint *nreturn_vals,
GimpParam **return_vals);
static gint32 load_image (const gchar *filename,
GimpRunMode run_mode,
GError **error);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
static gint32 load_thumbnail_image (const gchar *filename,
gint thumb_size,
gint *width,
gint *height,
GError **error);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
const GimpPlugInInfo PLUG_IN_INFO =
{
plug-ins: move conditional gimp_install_procedure() of file-darktable... ... to init(). Otherwise presence of darktable is not checked at every startup.
2017-06-28 04:45:31 +08:00
init, /* init_proc */
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
NULL, /* quit_proc */
query, /* query proc */
run, /* run_proc */
};
MAIN ()
static void
plug-ins: move conditional gimp_install_procedure() of file-darktable... ... to init(). Otherwise presence of darktable is not checked at every startup.
2017-06-28 04:45:31 +08:00
init (void)
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
{
static const GimpParamDef load_args[] =
{
{ GIMP_PDB_INT32, "run-mode", "The run mode { RUN-INTERACTIVE (0), RUN-NONINTERACTIVE (1) }" },
{ GIMP_PDB_STRING, "filename", "The name of the file to load." },
{ GIMP_PDB_STRING, "raw-filename", "The name entered" },
};
static const GimpParamDef load_return_vals[] =
{
{ GIMP_PDB_IMAGE, "image", "Output image" }
};
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
static const GimpParamDef thumb_args[] =
{
{ GIMP_PDB_STRING, "filename", "The name of the file to load" },
{ GIMP_PDB_INT32, "thumb-size", "Preferred thumbnail size" }
};
static const GimpParamDef thumb_return_vals[] =
{
{ GIMP_PDB_IMAGE, "image", "Thumbnail image" },
{ GIMP_PDB_INT32, "image-width", "Width of full-sized image" },
{ GIMP_PDB_INT32, "image-height", "Height of full-sized image" }
};
plug-ins: use the right magic for Canon CR2 files and some general code cleanup.
2016-04-25 05:30:25 +08:00
/* check if darktable is installed
*/
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
gboolean search_path = FALSE;
plug-ins: add some MacOS support to find RawTherapee. Hopefully it works, since that's untested (I have no MacOS access). This is mostly code from file-darktable.c, made generic and factorized into file-raw-utils.[ch]. At least it still builds and work fine on Linux. I used the CFBundleIdentifier from `tools/osx/Info.plist.in` in RawTherapee code. I didn't add a Win32 registry key base though, since I couldn't find any relevant data for this in RawTherapee code.
2017-07-29 07:15:28 +08:00
gchar *exec_path = file_raw_get_executable_path ("darktable", NULL,
"DARKTABLE_EXECUTABLE",
"org.darktable",
REGISTRY_KEY_BASE,
&search_path);
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
gchar *argv[] = { exec_path, "--version", NULL };
plug-ins: use the right magic for Canon CR2 files and some general code cleanup.
2016-04-25 05:30:25 +08:00
gchar *darktable_stdout = NULL;
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
gchar *darktable_stderr = NULL;
plug-ins: use the right magic for Canon CR2 files and some general code cleanup.
2016-04-25 05:30:25 +08:00
gboolean have_darktable = FALSE;
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
GError *error = NULL;
plug-ins: use the right magic for Canon CR2 files and some general code cleanup.
2016-04-25 05:30:25 +08:00
gint i;
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
/* allow the user to have some insight into why darktable may fail. */
gboolean debug_prints = g_getenv ("DARKTABLE_DEBUG") != NULL;
if (debug_prints)
printf ("[%s] trying to call '%s'\n", __FILE__, exec_path);
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
if (g_spawn_sync (NULL,
argv,
NULL,
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
(search_path ? G_SPAWN_SEARCH_PATH : 0),
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
NULL,
NULL,
&darktable_stdout,
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
&darktable_stderr,
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
NULL,
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
&error))
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
{
plug-ins: use the right magic for Canon CR2 files and some general code cleanup.
2016-04-25 05:30:25 +08:00
gint major, minor, patch;
if (sscanf (darktable_stdout,
"this is darktable %d.%d.%d",
&major, &minor, &patch) == 3)
{
if (((major == 1 && minor >= 7) || major >= 2))
{
if (g_strstr_len (darktable_stdout, -1,
"Lua support enabled"))
{
have_darktable = TRUE;
}
}
}
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
}
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
else if (debug_prints)
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
printf ("[%s] g_spawn_sync failed\n", __FILE__);
plug-ins: Only enable darktable loading when it's installed For now we only check if darktable is in PATH, of the right version and supporting the featuers we need (i.e., Lua scripting). We still want to have a way to manually specify the path to the darktable installation in preferences I guess.
2016-04-21 17:40:45 +08:00
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
if (debug_prints)
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
{
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
if (error)
printf ("[%s] error: %s\n", __FILE__, error->message);
if (darktable_stdout && *darktable_stdout)
printf ("[%s] stdout:\n%s\n", __FILE__, darktable_stdout);
if (darktable_stderr && *darktable_stderr)
printf ("[%s] stderr:\n%s\n", __FILE__, darktable_stderr);
printf ("[%s] have_darktable: %d\n", __FILE__, have_darktable);
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
}
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
if (error)
g_error_free (error);
plug-ins: Use Windows registry to find darktable There are now (up to) three steps to locate an installed darktable used to load raw files: 1. The environment variable DARKTABLE_EXECUTABLE. It should point to the main darktable executable without any file extension. So on Windows leave the ".exe" away! 2. If the environment variable isn't set there is a platform dependent part. On OSX it uses Kris' code to look for installed app bundles, on Windows it checks for the registry key written by darktable's installer. 3. Last but not least we fall back to crossing our fingers and hoping that darktable is in PATH.
2017-07-05 06:50:54 +08:00
g_free (darktable_stdout);
g_free (darktable_stderr);
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
g_free (exec_path);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
if (! have_darktable)
return;
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
gimp_install_procedure (LOAD_THUMB_PROC,
"Load thumbnail from a raw image via darktable",
"This plug-in loads a thumbnail from a raw image by calling darktable-cli.",
"Tobias Ellinghaus",
"Tobias Ellinghaus",
"2016",
NULL,
NULL,
GIMP_PLUGIN,
G_N_ELEMENTS (thumb_args),
G_N_ELEMENTS (thumb_return_vals),
thumb_args, thumb_return_vals);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
for (i = 0; i < G_N_ELEMENTS (file_formats); i++)
{
const FileFormat *format = &file_formats[i];
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
gchar *load_proc;
gchar *load_blurb;
gchar *load_help;
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
load_proc = g_strdup_printf (format->load_proc_format, "darktable");
load_blurb = g_strdup_printf (format->load_blurb_format, "darktable");
load_help = g_strdup_printf (format->load_help_format, "darktable");
gimp_install_procedure (load_proc,
load_blurb,
load_help,
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
"Tobias Ellinghaus",
"Tobias Ellinghaus",
"2016",
format->file_type,
NULL,
GIMP_PLUGIN,
G_N_ELEMENTS (load_args),
G_N_ELEMENTS (load_return_vals),
load_args, load_return_vals);
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
gimp_register_file_handler_mime (load_proc,
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
format->mime_type);
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
gimp_register_file_handler_raw (load_proc);
gimp_register_magic_load_handler (load_proc,
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
format->extensions,
"",
format->magic);
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
gimp_register_thumbnail_loader (load_proc, LOAD_THUMB_PROC);
g_free (load_proc);
g_free (load_blurb);
g_free (load_help);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
}
}
plug-ins: move conditional gimp_install_procedure() of file-darktable... ... to init(). Otherwise presence of darktable is not checked at every startup.
2017-06-28 04:45:31 +08:00
static void
query (void)
{
/* query() is run only the first time for efficiency. Yet this plugin
* is dependent on the presence of darktable which may be installed
* or uninstalled between GIMP startups. Therefore we should move the
* usual gimp_install_procedure() to init() so that the check is done
* at every startup instead.
*/
}
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
static void
run (const gchar *name,
gint nparams,
const GimpParam *param,
gint *nreturn_vals,
GimpParam **return_vals)
{
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
static GimpParam values[6];
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
GimpPDBStatusType status = GIMP_PDB_SUCCESS;
GimpRunMode run_mode;
gint image_ID;
GError *error = NULL;
gint i;
INIT_I18N ();
run_mode = param[0].data.d_int32;
*nreturn_vals = 1;
*return_vals = values;
values[0].type = GIMP_PDB_STATUS;
values[0].data.d_status = GIMP_PDB_EXECUTION_ERROR;
/* check if the format passed is actually supported & load */
for (i = 0; i < G_N_ELEMENTS (file_formats); i++)
{
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
const FileFormat *format = &file_formats[i];
gchar *load_proc = NULL;
if (format->load_proc_format)
load_proc = g_strdup_printf (format->load_proc_format, "darktable");
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
plug-ins: replace file-raw/file-formats.h's "darktable" strings by "%s" and assemble the actual strings dynamically, substituting "draktable".
2017-07-25 02:41:41 +08:00
if (load_proc && ! strcmp (name, load_proc))
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
{
image_ID = load_image (param[1].data.d_string, run_mode, &error);
if (image_ID != -1)
{
*nreturn_vals = 2;
values[1].type = GIMP_PDB_IMAGE;
values[1].data.d_image = image_ID;
}
else
{
status = GIMP_PDB_EXECUTION_ERROR;
}
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
break;
}
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
else if (! strcmp (name, LOAD_THUMB_PROC))
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
{
gint width = 0;
gint height = 0;
image_ID = load_thumbnail_image (param[0].data.d_string,
param[1].data.d_int32,
&width,
&height,
&error);
if (image_ID != -1)
{
*nreturn_vals = 6;
values[1].type = GIMP_PDB_IMAGE;
values[1].data.d_image = image_ID;
values[2].type = GIMP_PDB_INT32;
values[2].data.d_int32 = width;
values[3].type = GIMP_PDB_INT32;
values[3].data.d_int32 = height;
values[4].type = GIMP_PDB_INT32;
values[4].data.d_int32 = GIMP_RGB_IMAGE;
values[5].type = GIMP_PDB_INT32;
values[5].data.d_int32 = 1; /* num_layers */
}
else
{
status = GIMP_PDB_EXECUTION_ERROR;
}
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
break;
}
}
if (i == G_N_ELEMENTS (file_formats))
status = GIMP_PDB_CALLING_ERROR;
if (status != GIMP_PDB_SUCCESS && error)
{
*nreturn_vals = 2;
values[1].type = GIMP_PDB_STRING;
values[1].data.d_string = error->message;
}
values[0].data.d_status = status;
}
static gint32
load_image (const gchar *filename,
GimpRunMode run_mode,
GError **error)
{
darktable: Add more shell escaping for Windows Apparently Lua chokes when it sees c:\darktable\... as a path to a script, thinking the '\d' was an escape sequence. Thus we have to add an extra layer of escaping. Houdini like. Who came up with the brilliant idea to use '\' as a separator anyway? So much pain just to be different?
2017-09-04 18:56:34 +08:00
gint32 image_ID = -1;
GFile *lua_file = gimp_data_directory_file ("file-raw",
"file-darktable-export-on-exit.lua",
NULL);
gchar *lua_script = g_file_get_path (lua_file);
gchar *lua_script_escaped = g_strescape (lua_script, "");
gchar *lua_quoted = g_shell_quote (lua_script_escaped);
gchar *lua_cmd = g_strdup_printf ("dofile(%s)", lua_quoted);
gchar *filename_out = gimp_temp_name ("exr");
gchar *export_filename = g_strdup_printf ("lua/export_on_exit/export_filename=%s",
filename_out);
gchar *darktable_stdout = NULL;
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
/* allow the user to have some insight into why darktable may fail. */
gboolean debug_prints = g_getenv ("DARKTABLE_DEBUG") != NULL;
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
/* linear sRGB for now as GIMP uses that internally in many places anyway */
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
gboolean search_path = FALSE;
plug-ins: add some MacOS support to find RawTherapee. Hopefully it works, since that's untested (I have no MacOS access). This is mostly code from file-darktable.c, made generic and factorized into file-raw-utils.[ch]. At least it still builds and work fine on Linux. I used the CFBundleIdentifier from `tools/osx/Info.plist.in` in RawTherapee code. I didn't add a Win32 registry key base though, since I couldn't find any relevant data for this in RawTherapee code.
2017-07-29 07:15:28 +08:00
gchar *exec_path = file_raw_get_executable_path ("darktable", NULL,
"DARKTABLE_EXECUTABLE",
"org.darktable",
REGISTRY_KEY_BASE,
&search_path);
plug-ins: some alignment cleaning.
2017-07-29 06:15:45 +08:00
gchar *argv[] =
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
{
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
exec_path,
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
"--library", ":memory:",
"--luacmd", lua_cmd,
plug-ins: Actually export to linear sRGB from darktable
2016-04-19 09:29:29 +08:00
"--conf", "plugins/lighttable/export/icctype=3",
plug-ins: don't create a temp dir when using darktable
2016-04-19 09:19:39 +08:00
"--conf", export_filename,
plug-ins: minor cleanups in file-darktable
2016-04-19 09:28:24 +08:00
(gchar *) filename,
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
NULL
};
g_object_unref (lua_file);
g_free (lua_script);
darktable: Add more shell escaping for Windows Apparently Lua chokes when it sees c:\darktable\... as a path to a script, thinking the '\d' was an escape sequence. Thus we have to add an extra layer of escaping. Houdini like. Who came up with the brilliant idea to use '\' as a separator anyway? So much pain just to be different?
2017-09-04 18:56:34 +08:00
g_free (lua_script_escaped);
plug-ins: minor cleanups in file-darktable
2016-04-19 09:28:24 +08:00
g_free (lua_quoted);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
gimp_progress_init_printf (_("Opening '%s'"),
gimp_filename_to_utf8 (filename));
plug-ins: don't create a temp dir when using darktable
2016-04-19 09:19:39 +08:00
if (g_spawn_sync (NULL,
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
argv,
NULL,
plug-ins: use C-style comments. I wonder if these should not rather be simply removed instead, but well I'll leave them if the plugin developer needs these regularly for testing. Use at least C-style comments as per our coding style.
2017-06-28 02:05:52 +08:00
/*G_SPAWN_STDOUT_TO_DEV_NULL |*/
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
G_SPAWN_STDERR_TO_DEV_NULL |
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
(search_path ? G_SPAWN_SEARCH_PATH : 0),
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
NULL,
NULL,
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
&darktable_stdout,
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
NULL,
NULL,
error))
{
image_ID = gimp_file_load (run_mode, filename_out, filename_out);
if (image_ID != -1)
gimp_image_set_filename (image_ID, filename);
}
plug-ins: Hide darktable debug output Only show debugging messages from the darktable raw loader when the environment variable DARKTABLE_DEBUG is set.
2017-11-20 19:48:47 +08:00
if (debug_prints && darktable_stdout && *darktable_stdout)
printf ("%s\n", darktable_stdout);
plug-ins: Only have one thumb loader for darktable
2016-05-03 21:10:32 +08:00
g_free(darktable_stdout);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
g_unlink (filename_out);
g_free (lua_cmd);
g_free (filename_out);
plug-ins: don't create a temp dir when using darktable
2016-04-19 09:19:39 +08:00
g_free (export_filename);
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
g_free (exec_path);
plug-ins: add new plug-in file-darktable Which loads raw files by having them developed in darktable. Also disable NEF support in file-gegl.
2016-04-19 07:18:05 +08:00
gimp_progress_update (1.0);
return image_ID;
}
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
static gint32
load_thumbnail_image (const gchar *filename,
gint thumb_size,
gint *width,
gint *height,
GError **error)
{
darktable: Add more shell escaping for Windows Apparently Lua chokes when it sees c:\darktable\... as a path to a script, thinking the '\d' was an escape sequence. Thus we have to add an extra layer of escaping. Houdini like. Who came up with the brilliant idea to use '\' as a separator anyway? So much pain just to be different?
2017-09-04 18:56:34 +08:00
gint32 image_ID = -1;
gchar *filename_out = gimp_temp_name ("jpg");
gchar *size = g_strdup_printf ("%d", thumb_size);
GFile *lua_file = gimp_data_directory_file ("file-raw",
"file-darktable-get-size.lua",
NULL);
gchar *lua_script = g_file_get_path (lua_file);
darktable: Fix typo in last commit
2017-09-04 20:08:31 +08:00
gchar *lua_script_escaped = g_strescape (lua_script, "");
gchar *lua_quoted = g_shell_quote (lua_script_escaped);
darktable: Add more shell escaping for Windows Apparently Lua chokes when it sees c:\darktable\... as a path to a script, thinking the '\d' was an escape sequence. Thus we have to add an extra layer of escaping. Houdini like. Who came up with the brilliant idea to use '\' as a separator anyway? So much pain just to be different?
2017-09-04 18:56:34 +08:00
gchar *lua_cmd = g_strdup_printf ("dofile(%s)", lua_quoted);
gchar *darktable_stdout = NULL;
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
gboolean search_path = FALSE;
plug-ins: add some MacOS support to find RawTherapee. Hopefully it works, since that's untested (I have no MacOS access). This is mostly code from file-darktable.c, made generic and factorized into file-raw-utils.[ch]. At least it still builds and work fine on Linux. I used the CFBundleIdentifier from `tools/osx/Info.plist.in` in RawTherapee code. I didn't add a Win32 registry key base though, since I couldn't find any relevant data for this in RawTherapee code.
2017-07-29 07:15:28 +08:00
gchar *exec_path = file_raw_get_executable_path ("darktable", "-cli",
"DARKTABLE_EXECUTABLE",
"org.darktable",
REGISTRY_KEY_BASE,
&search_path);
plug-ins: some alignment cleaning.
2017-07-29 06:15:45 +08:00
gchar *argv[] =
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
{
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
exec_path,
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
(gchar *) filename, filename_out,
"--width", size,
"--height", size,
"--hq", "false",
"--core",
"--conf", "plugins/lighttable/export/icctype=3",
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
"--luacmd", lua_cmd,
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
NULL
};
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
g_object_unref (lua_file);
g_free (lua_script);
darktable: Add more shell escaping for Windows Apparently Lua chokes when it sees c:\darktable\... as a path to a script, thinking the '\d' was an escape sequence. Thus we have to add an extra layer of escaping. Houdini like. Who came up with the brilliant idea to use '\' as a separator anyway? So much pain just to be different?
2017-09-04 18:56:34 +08:00
g_free (lua_script_escaped);
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
g_free (lua_quoted);
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
gimp_progress_init_printf (_("Opening thumbnail for '%s'"),
gimp_filename_to_utf8 (filename));
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
*width = *height = thumb_size;
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
if (g_spawn_sync (NULL,
argv,
NULL,
G_SPAWN_STDERR_TO_DEV_NULL |
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
(search_path ? G_SPAWN_SEARCH_PATH : 0),
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
NULL,
NULL,
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
&darktable_stdout,
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
NULL,
NULL,
error))
{
gimp_progress_update (0.5);
image_ID = gimp_file_load (GIMP_RUN_NONINTERACTIVE,
filename_out,
filename_out);
if (image_ID != -1)
{
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
/* the size reported by raw files isn't precise,
* but it should be close enough to get an idea.
*/
gchar *start_of_size = g_strstr_len (darktable_stdout,
-1,
"[dt4gimp]");
if (start_of_size)
sscanf (start_of_size, "[dt4gimp] %d %d", width, height);
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
/* is this needed for thumbnails? */
gimp_image_set_filename (image_ID, filename);
}
}
gimp_progress_update (1.0);
g_unlink (filename_out);
g_free (filename_out);
g_free (size);
plug-ins: Get an image size when creating thumbs with darktable The reported size isn't very precise but close enough to get an idea of what you will get. The problem is that raw files always have some unused regions that get cropped away later. Another source of discrepancy can be manual cropping by the user in darktable, but there isn't much we can do about that.
2016-04-26 19:38:33 +08:00
g_free (lua_cmd);
g_free (darktable_stdout);
plug-ins: darktable: have separate function to obtain executable name
2017-05-15 18:26:51 +08:00
g_free (exec_path);
plug-ins: Don't start darktable when creating thumbnails ... instead use the non-interactive darktable-cli. This is still somewhat work in progress as the image size isn't returned yet.
2016-04-26 07:03:35 +08:00
return image_ID;
}