dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gimp/app/display/gimpcanvasitem.c

733 lines
21 KiB
C
Raw Normal View History

app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
/* GIMP - The GNU Image Manipulation Program
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
*
app: minor cleanup and fixes
2010-09-20 05:46:06 +08:00
* gimpcanvasitem.c
* Copyright (C) 2010 Michael Natterer <mitch@gimp.org>
*
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
Change the license URL from http://www.gnu.org/licenses/ to https://
2018-07-12 05:27:07 +08:00
* along with this program. If not, see <https://www.gnu.org/licenses/>.
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
*/
#include "config.h"
#include <gegl.h>
#include <gtk/gtk.h>
libgimbase: merge gimpparam.h into gimpparamspecs.h which means that it's now included normally via gimpbase.h and not any longer via gimpbasetypes.h which we only did out of lazyness. A *lot* of files in libgimp* and app/ now need to
2019-07-31 16:16:21 +08:00
#include "libgimpbase/gimpbase.h"
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
#include "libgimpmath/gimpmath.h"
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
#include "display-types.h"
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
#include "core/gimpmarshal.h"
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
app: rename gimpdisplayshell-style to gimpcanvas-style because it doesn't and shouldn't depend on GimpDisplayShell at all. In the future, it will take its defaults from the canvas' theme.
2013-04-18 20:21:20 +08:00
#include "gimpcanvas-style.h"
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
#include "gimpcanvasitem.h"
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
#include "gimpdisplay.h"
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
#include "gimpdisplayshell.h"
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
#include "gimpdisplayshell-transform.h"
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
enum
{
PROP_0,
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
PROP_SHELL,
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
PROP_VISIBLE,
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
PROP_LINE_CAP,
PROP_HIGHLIGHT
};
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
enum
{
UPDATE,
LAST_SIGNAL
};
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
struct _GimpCanvasItemPrivate
{
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
GimpDisplayShell *shell;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
gboolean visible;
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
cairo_line_cap_t line_cap;
gboolean highlight;
gint suspend_stroking;
gint suspend_filling;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
gint change_count;
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_t *change_region;
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
};
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
/* local function prototypes */
app: keep GimpCanvasItem from emitting "update" during destruction Simply increase its change_count in dispose(). There is really no reason to build expensive update regions and emitting signals when we are about to go away.
2017-06-11 04:00:38 +08:00
static void gimp_canvas_item_dispose (GObject *object);
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
static void gimp_canvas_item_constructed (GObject *object);
static void gimp_canvas_item_set_property (GObject *object,
guint property_id,
const GValue *value,
GParamSpec *pspec);
static void gimp_canvas_item_get_property (GObject *object,
guint property_id,
GValue *value,
GParamSpec *pspec);
static void gimp_canvas_item_dispatch_properties_changed (GObject *object,
guint n_pspecs,
GParamSpec **pspecs);
static void gimp_canvas_item_real_draw (GimpCanvasItem *item,
cairo_t *cr);
static cairo_region_t * gimp_canvas_item_real_get_extents (GimpCanvasItem *item);
static void gimp_canvas_item_real_stroke (GimpCanvasItem *item,
cairo_t *cr);
static void gimp_canvas_item_real_fill (GimpCanvasItem *item,
cairo_t *cr);
static gboolean gimp_canvas_item_real_hit (GimpCanvasItem *item,
gdouble x,
gdouble y);
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
app, libgimp*, modules: don't use g_type_class_add_private() ... ... and G_TYPE_INSTANCE_GET_PRIVATE() g_type_class_add_private() and G_TYPE_INSTANCE_GET_PRIVATE() were deprecated in GLib 2.58. Instead, use G_DEFINE_[ABSTRACT_]TYPE_WITH_PRIVATE(), and G_ADD_PRIVATE[_DYNAMIC](), and the implictly-defined foo_get_instance_private() functions, all of which are available in the GLib versions we depend on. This commit only covers types registered using one of the G_DEFINE_FOO() macros (i.e., most types), but not types with a custom registration function, of which we still have a few -- GLib currently only provides a (non-deprecated) public API for adding a private struct using the G_DEFINE_FOO() macros. Note that this commit was 99% auto-generated (because I'm not *that* crazy :), so if there are any style mismatches... we'll have to live with them for now.
2018-09-19 00:09:39 +08:00
G_DEFINE_TYPE_WITH_PRIVATE (GimpCanvasItem, gimp_canvas_item, GIMP_TYPE_OBJECT)
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
#define parent_class gimp_canvas_item_parent_class
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
static guint item_signals[LAST_SIGNAL] = { 0 };
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
static void
gimp_canvas_item_class_init (GimpCanvasItemClass *klass)
{
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
GObjectClass *object_class = G_OBJECT_CLASS (klass);
app: keep GimpCanvasItem from emitting "update" during destruction Simply increase its change_count in dispose(). There is really no reason to build expensive update regions and emitting signals when we are about to go away.
2017-06-11 04:00:38 +08:00
object_class->dispose = gimp_canvas_item_dispose;
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
object_class->constructed = gimp_canvas_item_constructed;
object_class->set_property = gimp_canvas_item_set_property;
object_class->get_property = gimp_canvas_item_get_property;
object_class->dispatch_properties_changed = gimp_canvas_item_dispatch_properties_changed;
klass->update = NULL;
klass->draw = gimp_canvas_item_real_draw;
klass->get_extents = gimp_canvas_item_real_get_extents;
klass->stroke = gimp_canvas_item_real_stroke;
klass->fill = gimp_canvas_item_real_fill;
app: add virtual function gboolean GimpCanvasItem::hit() and implement it for GimpCanvasHandle and GimpCanvasGroup.
2011-03-29 00:54:02 +08:00
klass->hit = gimp_canvas_item_real_hit;
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
item_signals[UPDATE] =
g_signal_new ("update",
G_TYPE_FROM_CLASS (klass),
G_SIGNAL_RUN_FIRST,
G_STRUCT_OFFSET (GimpCanvasItemClass, update),
NULL, NULL,
gimp_marshal_VOID__POINTER,
G_TYPE_NONE, 1,
G_TYPE_POINTER);
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
g_object_class_install_property (object_class, PROP_SHELL,
g_param_spec_object ("shell",
NULL, NULL,
GIMP_TYPE_DISPLAY_SHELL,
GIMP_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY));
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
g_object_class_install_property (object_class, PROP_VISIBLE,
g_param_spec_boolean ("visible",
NULL, NULL,
TRUE,
GIMP_PARAM_READWRITE));
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
g_object_class_install_property (object_class, PROP_LINE_CAP,
g_param_spec_int ("line-cap",
NULL, NULL,
CAIRO_LINE_CAP_BUTT,
CAIRO_LINE_CAP_SQUARE,
CAIRO_LINE_CAP_ROUND,
GIMP_PARAM_READWRITE));
g_object_class_install_property (object_class, PROP_HIGHLIGHT,
g_param_spec_boolean ("highlight",
NULL, NULL,
FALSE,
GIMP_PARAM_READWRITE));
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
}
static void
gimp_canvas_item_init (GimpCanvasItem *item)
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
GimpCanvasItemPrivate *private;
app, libgimp*, modules: don't use g_type_class_add_private() ... ... and G_TYPE_INSTANCE_GET_PRIVATE() g_type_class_add_private() and G_TYPE_INSTANCE_GET_PRIVATE() were deprecated in GLib 2.58. Instead, use G_DEFINE_[ABSTRACT_]TYPE_WITH_PRIVATE(), and G_ADD_PRIVATE[_DYNAMIC](), and the implictly-defined foo_get_instance_private() functions, all of which are available in the GLib versions we depend on. This commit only covers types registered using one of the G_DEFINE_FOO() macros (i.e., most types), but not types with a custom registration function, of which we still have a few -- GLib currently only provides a (non-deprecated) public API for adding a private struct using the G_DEFINE_FOO() macros. Note that this commit was 99% auto-generated (because I'm not *that* crazy :), so if there are any style mismatches... we'll have to live with them for now.
2018-09-19 00:09:39 +08:00
item->private = gimp_canvas_item_get_instance_private (item);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
private = item->private;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
private->shell = NULL;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
private->visible = TRUE;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
private->line_cap = CAIRO_LINE_CAP_ROUND;
private->highlight = FALSE;
private->suspend_stroking = 0;
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
private->suspend_filling = 0;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
private->change_count = 1; /* avoid emissions during construction */
private->change_region = NULL;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
}
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
static void
gimp_canvas_item_constructed (GObject *object)
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
GimpCanvasItem *item = GIMP_CANVAS_ITEM (object);
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
app: replace all g_assert() by the newly added gimp_assert() which is just a #define to g_assert for now, but can now easily be turned into something that does some nicer debugging using our new stack trace infrastructure. This commit also reverts all constructed() functions to use assert again.
2018-02-12 05:23:10 +08:00
gimp_assert (GIMP_IS_DISPLAY_SHELL (item->private->shell));
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->change_count = 0; /* undo hack from init() */
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
Chain up unconditionally in GObject::constructed() It's supported since GLib 2.28.
2012-11-13 04:51:22 +08:00
G_OBJECT_CLASS (parent_class)->constructed (object);
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
}
app: keep GimpCanvasItem from emitting "update" during destruction Simply increase its change_count in dispose(). There is really no reason to build expensive update regions and emitting signals when we are about to go away.
2017-06-11 04:00:38 +08:00
static void
gimp_canvas_item_dispose (GObject *object)
{
GimpCanvasItem *item = GIMP_CANVAS_ITEM (object);
item->private->change_count++; /* avoid emissions during destruction */
G_OBJECT_CLASS (parent_class)->dispose (object);
}
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
static void
gimp_canvas_item_set_property (GObject *object,
guint property_id,
const GValue *value,
GParamSpec *pspec)
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
GimpCanvasItem *item = GIMP_CANVAS_ITEM (object);
GimpCanvasItemPrivate *private = item->private;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
switch (property_id)
{
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
case PROP_SHELL:
private->shell = g_value_get_object (value); /* don't ref */
break;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
case PROP_VISIBLE:
private->visible = g_value_get_boolean (value);
break;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
case PROP_LINE_CAP:
private->line_cap = g_value_get_int (value);
break;
case PROP_HIGHLIGHT:
private->highlight = g_value_get_boolean (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
}
static void
gimp_canvas_item_get_property (GObject *object,
guint property_id,
GValue *value,
GParamSpec *pspec)
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
GimpCanvasItem *item = GIMP_CANVAS_ITEM (object);
GimpCanvasItemPrivate *private = item->private;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
switch (property_id)
{
app: add a "shell" property to GimpCanvasItem and pass it to all constructors. The GimpDisplayShell is needed because items are going to become more powerful soon.
2010-10-01 20:13:45 +08:00
case PROP_SHELL:
g_value_set_object (value, private->shell);
break;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
case PROP_VISIBLE:
g_value_set_boolean (value, private->visible);
break;
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
case PROP_LINE_CAP:
g_value_set_int (value, private->line_cap);
break;
case PROP_HIGHLIGHT:
g_value_set_boolean (value, private->highlight);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
}
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
static void
gimp_canvas_item_dispatch_properties_changed (GObject *object,
guint n_pspecs,
GParamSpec **pspecs)
{
GimpCanvasItem *item = GIMP_CANVAS_ITEM (object);
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
G_OBJECT_CLASS (parent_class)->dispatch_properties_changed (object,
n_pspecs,
pspecs);
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
if (_gimp_canvas_item_needs_update (item))
{
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_t *region = gimp_canvas_item_get_extents (item);
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
if (region)
{
g_signal_emit (object, item_signals[UPDATE], 0,
region);
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_destroy (region);
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
}
app: add an "update" signal to GimpCanvasItem which gets emitted when the item wants to be redrawn: - Emit "update" it when any item property changes - Groups connect to their children and forward "update" for them - The shell connects to its group of canvas items and exposed the affected area - Remove gimp_display_shell_expose_item() - Move all the shell's item group code into gimpdisplayshell-items.c
2010-10-01 23:13:00 +08:00
}
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
static void
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
gimp_canvas_item_real_draw (GimpCanvasItem *item,
cairo_t *cr)
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
{
g_warn_if_reached ();
}
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
static cairo_region_t *
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
gimp_canvas_item_real_get_extents (GimpCanvasItem *item)
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
{
app: remove premature canvas item extents caching optimization again
2010-09-22 16:33:41 +08:00
return NULL;
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
}
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
static void
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
gimp_canvas_item_real_stroke (GimpCanvasItem *item,
cairo_t *cr)
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
cairo_set_line_cap (cr, item->private->line_cap);
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
app: rename gimpdisplayshell-style to gimpcanvas-style because it doesn't and shouldn't depend on GimpDisplayShell at all. In the future, it will take its defaults from the canvas' theme.
2013-04-18 20:21:20 +08:00
gimp_canvas_set_tool_bg_style (gimp_canvas_item_get_canvas (item), cr);
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
cairo_stroke_preserve (cr);
app: rename gimpdisplayshell-style to gimpcanvas-style because it doesn't and shouldn't depend on GimpDisplayShell at all. In the future, it will take its defaults from the canvas' theme.
2013-04-18 20:21:20 +08:00
gimp_canvas_set_tool_fg_style (gimp_canvas_item_get_canvas (item), cr,
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->highlight);
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
cairo_stroke (cr);
}
static void
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
gimp_canvas_item_real_fill (GimpCanvasItem *item,
cairo_t *cr)
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
{
app: rename gimpdisplayshell-style to gimpcanvas-style because it doesn't and shouldn't depend on GimpDisplayShell at all. In the future, it will take its defaults from the canvas' theme.
2013-04-18 20:21:20 +08:00
gimp_canvas_set_tool_bg_style (gimp_canvas_item_get_canvas (item), cr);
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
cairo_set_line_width (cr, 2.0);
cairo_stroke_preserve (cr);
app: rename gimpdisplayshell-style to gimpcanvas-style because it doesn't and shouldn't depend on GimpDisplayShell at all. In the future, it will take its defaults from the canvas' theme.
2013-04-18 20:21:20 +08:00
gimp_canvas_set_tool_fg_style (gimp_canvas_item_get_canvas (item), cr,
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->highlight);
app: turn GimpCanvasItem's stroke() and fill() into virtual functions
2010-09-30 05:40:45 +08:00
cairo_fill (cr);
}
app: add virtual function gboolean GimpCanvasItem::hit() and implement it for GimpCanvasHandle and GimpCanvasGroup.
2011-03-29 00:54:02 +08:00
static gboolean
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
gimp_canvas_item_real_hit (GimpCanvasItem *item,
gdouble x,
gdouble y)
app: add virtual function gboolean GimpCanvasItem::hit() and implement it for GimpCanvasHandle and GimpCanvasGroup.
2011-03-29 00:54:02 +08:00
{
return FALSE;
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
/* public functions */
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
GimpDisplayShell *
gimp_canvas_item_get_shell (GimpCanvasItem *item)
{
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), NULL);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
return item->private->shell;
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
}
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
GimpImage *
gimp_canvas_item_get_image (GimpCanvasItem *item)
{
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), NULL);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
return gimp_display_get_image (item->private->shell->display);
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
}
GtkWidget *
gimp_canvas_item_get_canvas (GimpCanvasItem *item)
{
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), NULL);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
return item->private->shell->canvas;
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
void
app: remove "shell" parameter from GimpCanvasItem's public APIs because each item has a shell now. Keep the parameter in the virtual functions though because that saves a lot of code in the subclasses.
2010-10-01 20:54:53 +08:00
gimp_canvas_item_draw (GimpCanvasItem *item,
cairo_t *cr)
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
g_return_if_fail (cr != NULL);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->visible)
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
{
cairo_save (cr);
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
GIMP_CANVAS_ITEM_GET_CLASS (item)->draw (item, cr);
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
cairo_restore (cr);
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
}
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_t *
app: remove "shell" parameter from GimpCanvasItem's public APIs because each item has a shell now. Keep the parameter in the virtual functions though because that saves a lot of code in the subclasses.
2010-10-01 20:54:53 +08:00
gimp_canvas_item_get_extents (GimpCanvasItem *item)
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
{
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), NULL);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->visible)
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
return GIMP_CANVAS_ITEM_GET_CLASS (item)->get_extents (item);
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
return NULL;
}
app: add virtual function gboolean GimpCanvasItem::hit() and implement it for GimpCanvasHandle and GimpCanvasGroup.
2011-03-29 00:54:02 +08:00
gboolean
gimp_canvas_item_hit (GimpCanvasItem *item,
gdouble x,
gdouble y)
{
app: fix return value from NULL to FALSE
2011-03-29 06:23:10 +08:00
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), FALSE);
app: add virtual function gboolean GimpCanvasItem::hit() and implement it for GimpCanvasHandle and GimpCanvasGroup.
2011-03-29 00:54:02 +08:00
app: return FALSE from gimp_canvas_item_hit() when the item is invisible
2017-06-14 06:15:09 +08:00
if (item->private->visible)
return GIMP_CANVAS_ITEM_GET_CLASS (item)->hit (item, x, y);
return FALSE;
app: add virtual function gboolean GimpCanvasItem::hit() and implement it for GimpCanvasHandle and GimpCanvasGroup.
2011-03-29 00:54:02 +08:00
}
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
void
gimp_canvas_item_set_visible (GimpCanvasItem *item,
gboolean visible)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->visible != visible)
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
{
gimp_canvas_item_begin_change (item);
g_object_set (G_OBJECT (item),
"visible", visible,
NULL);
gimp_canvas_item_end_change (item);
}
}
gboolean
gimp_canvas_item_get_visible (GimpCanvasItem *item)
{
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), FALSE);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
return item->private->visible;
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
}
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
void
gimp_canvas_item_set_line_cap (GimpCanvasItem *item,
cairo_line_cap_t line_cap)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->line_cap != line_cap)
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
{
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
gimp_canvas_item_begin_change (item);
g_object_set (G_OBJECT (item),
"line-cap", line_cap,
NULL);
gimp_canvas_item_end_change (item);
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
}
app: change the default item line cap to round but add and API to configure it and set it to suare for handles which are always axis-aligned.
2010-09-26 23:40:10 +08:00
}
app: add a "highlight" mode for the tool FG style such a hack, but looks better than dashed lines
2010-09-24 01:25:22 +08:00
void
gimp_canvas_item_set_highlight (GimpCanvasItem *item,
gboolean highlight)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->highlight != highlight)
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
{
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
g_object_set (G_OBJECT (item),
"highlight", highlight,
NULL);
app: don't bother to emit an "update" region if no handler is connected because constructing the region can be expensive. Also make sure not to use g_object_set() if nothing would change to further reduce "update" emissions.
2010-10-01 23:43:41 +08:00
}
app: add a "highlight" mode for the tool FG style such a hack, but looks better than dashed lines
2010-09-24 01:25:22 +08:00
}
app: add gimp_canvas_item_get_highlight()
2010-09-30 05:46:36 +08:00
gboolean
gimp_canvas_item_get_highlight (GimpCanvasItem *item)
{
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), FALSE);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
return item->private->highlight;
app: add gimp_canvas_item_get_highlight()
2010-09-30 05:46:36 +08:00
}
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
void
gimp_canvas_item_begin_change (GimpCanvasItem *item)
{
GimpCanvasItemPrivate *private;
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
private = item->private;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
private->change_count++;
if (private->change_count == 1 &&
g_signal_has_handler_pending (item, item_signals[UPDATE], 0, FALSE))
{
private->change_region = gimp_canvas_item_get_extents (item);
}
}
void
gimp_canvas_item_end_change (GimpCanvasItem *item)
{
GimpCanvasItemPrivate *private;
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
private = item->private;
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
g_return_if_fail (private->change_count > 0);
private->change_count--;
app: fix last fix for the region leak... The fix was bogusly destroying a region that is still needed for the last end_change() if the change count is > 1.
2010-10-03 03:52:42 +08:00
if (private->change_count == 0)
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
{
app: fix last fix for the region leak... The fix was bogusly destroying a region that is still needed for the last end_change() if the change count is > 1.
2010-10-03 03:52:42 +08:00
if (g_signal_has_handler_pending (item, item_signals[UPDATE], 0, FALSE))
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
{
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_t *region = gimp_canvas_item_get_extents (item);
app: fix last fix for the region leak... The fix was bogusly destroying a region that is still needed for the last end_change() if the change count is > 1.
2010-10-03 03:52:42 +08:00
if (! region)
{
region = private->change_region;
}
else if (private->change_region)
{
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_union (region, private->change_region);
cairo_region_destroy (private->change_region);
app: fix last fix for the region leak... The fix was bogusly destroying a region that is still needed for the last end_change() if the change count is > 1.
2010-10-03 03:52:42 +08:00
}
private->change_region = NULL;
if (region)
{
g_signal_emit (item, item_signals[UPDATE], 0,
region);
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_destroy (region);
app: fix last fix for the region leak... The fix was bogusly destroying a region that is still needed for the last end_change() if the change count is > 1.
2010-10-03 03:52:42 +08:00
}
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
}
app: use a lot of g_clear_object() and g_clear_pointer() More than 2000 lines of code less in app/, instead of if (instance->member) { g_object_unref/g_free/g_whatever (instance->member); instance->member = NULL; } we now simply use g_clear_object/pointer (&instance->member);
2017-07-16 00:38:01 +08:00
else
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
{
app: use a lot of g_clear_object() and g_clear_pointer() More than 2000 lines of code less in app/, instead of if (instance->member) { g_object_unref/g_free/g_whatever (instance->member); instance->member = NULL; } we now simply use g_clear_object/pointer (&instance->member);
2017-07-16 00:38:01 +08:00
g_clear_pointer (&private->change_region, cairo_region_destroy);
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
}
app: don't leak the changed region in gimp_canvas_item_end_change()
2010-10-03 01:57:41 +08:00
}
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
}
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
void
gimp_canvas_item_suspend_stroking (GimpCanvasItem *item)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->suspend_stroking++;
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
}
void
gimp_canvas_item_resume_stroking (GimpCanvasItem *item)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
g_return_if_fail (item->private->suspend_stroking > 0);
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->suspend_stroking--;
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
}
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
void
gimp_canvas_item_suspend_filling (GimpCanvasItem *item)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->suspend_filling++;
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
}
void
gimp_canvas_item_resume_filling (GimpCanvasItem *item)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
g_return_if_fail (item->private->suspend_filling > 0);
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
item->private->suspend_filling--;
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
}
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
void
gimp_canvas_item_transform (GimpCanvasItem *item,
cairo_t *cr)
{
GimpCanvasItemPrivate *private;
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
g_return_if_fail (cr != NULL);
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
private = item->private;
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
cairo_translate (cr, -private->shell->offset_x, -private->shell->offset_y);
cairo_scale (cr, private->shell->scale_x, private->shell->scale_y);
}
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
void
gimp_canvas_item_transform_xy (GimpCanvasItem *item,
gdouble x,
gdouble y,
gint *tx,
gint *ty)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
gimp_display_shell_zoom_xy (item->private->shell, x, y, tx, ty);
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
}
void
gimp_canvas_item_transform_xy_f (GimpCanvasItem *item,
gdouble x,
gdouble y,
gdouble *tx,
gdouble *ty)
{
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
gimp_display_shell_zoom_xy_f (item->private->shell, x, y, tx, ty);
app: add an own GimpCanvasItem API for transforming coords and use it in all subclasses. Removes all gimpdisplayshell-transform dependency from all item implementations.
2013-04-18 19:53:42 +08:00
}
app: add gimp_canvas_item_transform_distance() and transform_distance_square() to allow items to measure distances, exactly like the identical GimpDrawTool API.
2017-06-11 03:55:40 +08:00
/**
* gimp_canvas_item_transform_distance:
* @item: a #GimpCanvasItem
* @x1: start point X in image coordinates
* @y1: start point Y in image coordinates
* @x2: end point X in image coordinates
* @y2: end point Y in image coordinates
*
* If you just need to compare distances, consider to use
* gimp_canvas_item_transform_distance_square() instead.
*
* Returns: the distance between the given points in display coordinates
**/
gdouble
gimp_canvas_item_transform_distance (GimpCanvasItem *item,
gdouble x1,
gdouble y1,
gdouble x2,
gdouble y2)
{
return sqrt (gimp_canvas_item_transform_distance_square (item,
x1, y1, x2, y2));
}
/**
* gimp_canvas_item_transform_distance_square:
* @item: a #GimpCanvasItem
* @x1: start point X in image coordinates
* @y1: start point Y in image coordinates
* @x2: end point X in image coordinates
* @y2: end point Y in image coordinates
*
* This function is more effective than
* gimp_canvas_item_transform_distance() as it doesn't perform a
* sqrt(). Use this if you just need to compare distances.
*
* Returns: the square of the distance between the given points in
* display coordinates
**/
gdouble
gimp_canvas_item_transform_distance_square (GimpCanvasItem *item,
gdouble x1,
gdouble y1,
gdouble x2,
gdouble y2)
{
gdouble tx1, ty1;
gdouble tx2, ty2;
g_return_val_if_fail (GIMP_IS_CANVAS_ITEM (item), 0.0);
gimp_canvas_item_transform_xy_f (item, x1, y1, &tx1, &ty1);
gimp_canvas_item_transform_xy_f (item, x2, y2, &tx2, &ty2);
return SQR (tx2 - tx1) + SQR (ty2 - ty1);
}
app: add gimp_canvas_item_untransform_viewport() ... which untransforms the viewport from display space to the item's coordinate space (i.e., scaled and translated image space).
2019-09-04 23:28:21 +08:00
void
gimp_canvas_item_untransform_viewport (GimpCanvasItem *item,
gint *x,
gint *y,
gint *w,
gint *h)
{
GimpDisplayShell *shell;
gdouble x1, y1;
gdouble x2, y2;
g_return_if_fail (GIMP_IS_CANVAS_ITEM (item));
shell = item->private->shell;
gimp_display_shell_unrotate_bounds (shell,
0.0, 0.0,
shell->disp_width, shell->disp_height,
&x1, &y1,
&x2, &y2);
*x = floor (x1);
*y = floor (y1);
*w = ceil (x2) - *x;
*h = ceil (y2) - *y;
}
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
/* protected functions */
app: refactor the canvas items to return a GdkRegion as extents instead of invalidating the canvas themselves.
2010-09-20 05:20:36 +08:00
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
void
_gimp_canvas_item_update (GimpCanvasItem *item,
app: use cairo_region_t for canvas items if cairo >= 1.10 is available This is a gross hack that typedefs around between GdkRegion and cairo_region_t and has some evil #ifdefs. This is going to die immeditately once we can depend on cairo 1.10.
2010-10-19 01:59:13 +08:00
cairo_region_t *region)
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
{
g_signal_emit (item, item_signals[UPDATE], 0,
region);
}
gboolean
_gimp_canvas_item_needs_update (GimpCanvasItem *item)
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
return (item->private->change_count == 0 &&
app: add a "visible" property and API to GimpCanvasItem and use it to set visibility of guides and sample points, so this reression is fixed. - return NULL extents for invisible items and never draw them - do nothing for invisible items in more places, like the group While hacking this, it turned out that it was a braino to collect an item's region before and after a change in dispatch_properties_changed(), so a new update had to be devised: - add a "change count" and new API begin_change()/end_change() - in begin_change(), remember the item's extents before the change - in end_change(), combine old and current extents and emit "update" - add some protected function to emit "update", and to figure if it makes sense at all to emit "update" on an item.
2010-10-02 02:41:27 +08:00
g_signal_has_handler_pending (item, item_signals[UPDATE], 0, FALSE));
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
void
app: remove "shell" parameter from GimpCanvasItem's public APIs because each item has a shell now. Keep the parameter in the virtual functions though because that saves a lot of code in the subclasses.
2010-10-01 20:54:53 +08:00
_gimp_canvas_item_stroke (GimpCanvasItem *item,
cairo_t *cr)
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->suspend_filling > 0)
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
g_warning ("_gimp_canvas_item_stroke() on an item that is in a filling group");
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->suspend_stroking == 0)
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
{
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
GIMP_CANVAS_ITEM_GET_CLASS (item)->stroke (item, cr);
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
}
else
{
cairo_new_sub_path (cr);
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
}
void
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
_gimp_canvas_item_fill (GimpCanvasItem *item,
cairo_t *cr)
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
{
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->suspend_stroking > 0)
app: add an infrastructure that allows to stroke multiple items at once In order to avoid visually overlapping lines: - GimpCanvasItem got a "suspend_stroking" API that allows to skip stroking and instead starts a new sub-path - GimpCanvasGroup got a "group_stroking" API that sets suspend_stroking on all its children and does one stroke after calling all items' draw().
2010-09-26 20:12:54 +08:00
g_warning ("_gimp_canvas_item_fill() on an item that is in a stroking group");
Bug 642565 - Use private pointer instead GET_PRIVATE macro in GimpCanvasItem Do as the but title says, based on a patch from Javier Jardón.
2016-11-07 21:12:24 +08:00
if (item->private->suspend_filling == 0)
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
{
app: remove GimpDisplayShell parameters from all GimpCanvasItem vfuncs and get the shell from gimp_canvas_item_get_shell() if needed. Remove some cairo_translate() that didn't have any effect and were leftovers from a very early canvas item code.
2013-04-18 21:45:08 +08:00
GIMP_CANVAS_ITEM_GET_CLASS (item)->fill (item, cr);
app: add group filling support to GimpCanvasItem and GimpCanvasGroup The code is almost identical to the group stroking feature.
2010-09-28 04:59:36 +08:00
}
else
{
cairo_new_sub_path (cr);
}
app: some cairo tool drawing infrastructure for review, please have a look
2010-09-20 01:45:51 +08:00
}