mirror of https://github.com/xwiki-labs/cryptpad
add some uncommitted notes as code review
This commit is contained in:
parent
e9b7332357
commit
dad7a16135
www/common
|
@ -465,7 +465,7 @@ Version 4: Data URL when not a realtime link yet (new pad or "static" app)
|
|||
|
||||
if (!/^https*:\/\//.test(href)) {
|
||||
// If it doesn't start with http(s), it should be a relative href
|
||||
if (!/^\//.test(href)) { return ret; }
|
||||
if (!/^\//.test(href)) { return ret; } // XXX this will allow protocol relative URLs
|
||||
idx = href.indexOf('/#');
|
||||
ret.type = href.slice(1, idx);
|
||||
if (idx === -1) { return ret; }
|
||||
|
|
|
@ -408,7 +408,7 @@ var factory = function () {
|
|||
if (err || !u8) { return void fetch(); }
|
||||
|
||||
var size = Decrypt.decodePrefix(u8.subarray(0,2));
|
||||
console.error(size);
|
||||
console.error(size); // XXX noise
|
||||
|
||||
cb(null, u8.subarray(0, size+2));
|
||||
});
|
||||
|
|
|
@ -123,7 +123,7 @@ define([
|
|||
cb = cb || function () {};
|
||||
|
||||
try {
|
||||
Cache.clear(cb);
|
||||
Cache.clear(cb); // XXX might call back twice in extreme circumstances?
|
||||
} catch (e) {
|
||||
console.error(e);
|
||||
cb();
|
||||
|
|
Loading…
Reference in New Issue