dnrops
/
burn
mirror of https://github.com/tracel-ai/burn.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

`NaN` and `Inf` detection in `assert_approx_eq` (#1209)

This commit is contained in:
Joshua Ferguson 2024-02-02 13:53:34 -06:00 committed by GitHub
parent f223297ba1
commit 1d84eb775e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
burn-candle/src/lib.rs
View File

@ -76,8 +76,12 @@ mod tests {
burn_tensor::testgen_maxmin!();
burn_tensor::testgen_mul!();
burn_tensor::testgen_neg!();
burn_tensor::testgen_powf_scalar!();
burn_tensor::testgen_powf!();
// TODO: https://github.com/tracel-ai/burn/issues/1237
//
// burn_tensor::testgen_powf_scalar!();
// burn_tensor::testgen_powf!();
burn_tensor::testgen_random!();
burn_tensor::testgen_repeat!();
burn_tensor::testgen_reshape!();
@ -136,7 +140,6 @@ mod tests {
burn_autodiff::testgen_ad_matmul!();
burn_autodiff::testgen_ad_mul!();
burn_autodiff::testgen_ad_neg!();
burn_autodiff::testgen_ad_powf!();
burn_autodiff::testgen_ad_recip!();
burn_autodiff::testgen_ad_reshape!();
burn_autodiff::testgen_ad_sin!();

11
burn-tensor/src/tensor/data.rs
View File

@ -315,9 +315,18 @@ impl<E: Into<f64> + Clone + core::fmt::Debug + PartialEq, const D: usize> Data<E
let a: f64 = a.into();
let b: f64 = b.into();
//if they are both nan, then they are equally nan
let both_nan = a.is_nan() && b.is_nan();
//this works for both infinities
let both_inf = a.is_infinite() && b.is_infinite() && ((a > 0.) == (b > 0.));
if both_nan || both_inf {
continue;
}
let err = libm::sqrt(libm::pow(a - b, 2.0));
if err > tolerance {
if err > tolerance || err.is_nan() {
// Only print the first 5 different values.
if num_diff < max_num_diff {
message += format!(