From 1ff55475b93ac43748d513794bcaabd5d7df6d9d Mon Sep 17 00:00:00 2001 From: Akash Reddy Date: Thu, 21 Dec 2023 09:27:32 +0530 Subject: [PATCH] Fix opening card info window closes it when already open (#2896) --- qt/aqt/browser/browser.py | 2 +- qt/aqt/browser/card_info.py | 7 ++++--- qt/aqt/reviewer.py | 4 ++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/qt/aqt/browser/browser.py b/qt/aqt/browser/browser.py index b8e7ce1ad..c4511329e 100644 --- a/qt/aqt/browser/browser.py +++ b/qt/aqt/browser/browser.py @@ -687,7 +687,7 @@ class Browser(QMainWindow): ###################################################################### def showCardInfo(self) -> None: - self._card_info.toggle() + self._card_info.show() def _update_card_info(self) -> None: self._card_info.set_card(self.current_card) diff --git a/qt/aqt/browser/card_info.py b/qt/aqt/browser/card_info.py index efa67f688..0d5a7a423 100644 --- a/qt/aqt/browser/card_info.py +++ b/qt/aqt/browser/card_info.py @@ -95,9 +95,10 @@ class CardInfoManager: self._card: Card | None = None self._dialog: CardInfoDialog | None = None - def toggle(self) -> None: + def show(self) -> None: if self._dialog: - self._dialog.reject() + self._dialog.activateWindow() + self._dialog.raise_() else: self._dialog = CardInfoDialog( None, @@ -115,7 +116,7 @@ class CardInfoManager: def close(self) -> None: if self._dialog: - self.toggle() + self._dialog.reject() def _on_close(self) -> None: self._dialog = None diff --git a/qt/aqt/reviewer.py b/qt/aqt/reviewer.py index eac9b23c7..322a62ad0 100644 --- a/qt/aqt/reviewer.py +++ b/qt/aqt/reviewer.py @@ -1032,10 +1032,10 @@ timerStopped = false; confirm_deck_then_display_options(self.card) def on_previous_card_info(self) -> None: - self._previous_card_info.toggle() + self._previous_card_info.show() def on_card_info(self) -> None: - self._card_info.toggle() + self._card_info.show() def set_flag_on_current_card(self, desired_flag: int) -> None: # need to toggle off?