* Initial implementation * Improved error handling and stability * Added unit tests * Updated test to use `max_features_` instead of `max_features` * Added documentation for new private attribute `max_features_` * Improved error handling for callables * Updated whats_new * Removed incorrect term reference to `max_features` * Removed float case and improved testing * Updated test names to more clearly reflect intention * Added a sample callable in `max_features` description * Improved documentation and streamlined error handling * Updated example to include demonstrate using a callable for max_features * Separated out callable demo into separate example * Removed demo from `max_features` docs (now in example) * Updated changelog * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Trimmed unneeded comments * Updated tests to reflect new error handling * Removed new line at end of docstring * Updated docstring * Fixed example syntax error * Fixed example syntax * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Reverted irrelevant changes * Update sklearn/feature_selection/_from_model.py Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Fixed error message * Improved test coverage * Minor doc improvement -- added a list for `max_features` type * Update sklearn/feature_selection/_from_model.py Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> * Improved input validation and added test for array-like * Updated doc to use no longer use lambda function * Fixed docstring list * Added missing whitespace for list format in docstring Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> |
||
|---|---|---|
| .. | ||
| tests | ||
| __init__.py | ||
| _base.py | ||
| _from_model.py | ||
| _mutual_info.py | ||
| _rfe.py | ||
| _sequential.py | ||
| _univariate_selection.py | ||
| _variance_threshold.py | ||