Commit Graph

168 Commits

Author SHA1 Message Date
Arnaud Rachez 5db2adf93c MAINT Removed deprecated stuff. 2015-10-21 10:24:23 +02:00
Andreas Mueller 79fa25ade3 MAINT don't print things in testing. 2015-10-15 15:23:00 -04:00
Olivier Grisel f1c5924b36 ENH better error message for estimators with ensure_min_* checks 2015-10-01 14:44:05 +02:00
Vighnesh Birodkar 2f099334f9 MAINT deprecate 1d input arrays for all estimators
Passing 1D arrays to check_array, without setting `ensure_2d` to false now
raises a deprecation warning before reshaping it. This will later throw an
error.

All Scaler classes also throw warnings when 1D arrays are passed.

All unit tests/doctests are modified to ensure that no 1D arrays are passed,
except in explicit 1D array tests where the warnings have been silenced.

Additional tests are also included which check for different 1D array cases.

2D array tests with one samples and one features are also added and where
they failed, `check_array` call has been modified to give a more useful error
message
2015-09-09 15:49:58 +02:00
Andreas Mueller 0650d5502e DOC adding backlinks to docstrings 2015-06-03 00:24:04 -04:00
Olivier Grisel 05ad7459f3 STYLE cosmetic fixes in sklearn.mixture.gmm 2015-06-02 16:40:36 +02:00
Andreas Mueller a8626b36a6 TST/COSMIT remove nose call boilerplate 2015-05-28 14:54:01 -04:00
Sebastian Saeger d2382e1be2 Cleaned the code. pep8, pyflakes and added comments. 2015-05-03 00:50:40 +02:00
Sebastian Saeger 43a46365cc Removed the deprecation and added a test for a boolean flag value. 2015-05-02 20:28:18 +02:00
Sebastian Saeger 8f34306a05 Added tests for the adapted verbose flag of DPGMM. 2015-05-01 10:11:37 +02:00
Sebastian Saeger 0ae311049a Adapted the verbose flag of DPGMM. Boolean flag is deprecated now. 2015-05-01 10:11:37 +02:00
Sebastian Saeger 0bb91dcfd7 Fixed pep8 and removed unused variable. 2015-05-01 10:11:37 +02:00
Sebastian Saeger eb05c53d9f Added tests for the verbose flag of GMM. 2015-05-01 10:11:37 +02:00
Sebastian Saeger 1b9f4b9a1f Fixed pep8 warnings. 2015-05-01 10:09:29 +02:00
Sebastian Saeger 1a1a69c2f9 Fixed doctests. 2015-05-01 10:09:29 +02:00
Sebastian Saeger dc34af7444 Fixed typos. 2015-05-01 10:09:29 +02:00
Sebastian Saeger 3b23d253f0 Added a verbose flag to the GMM class. 2015-05-01 09:57:48 +02:00
Cory Lorenz fc87eb33ff Add a fit_predict method for the GMM classes
With low iterations, the prediction might not be 100% accurate due to
the final maximization step in the EM algorithm.
2015-04-30 11:49:23 -07:00
Wei Xue 9c57ee3b5c Raise ValueError when log_multivariate_normal_density has non positive definite covariance 2015-03-24 20:15:22 -04:00
Raghav R V cd2ee7e454 MAINT docstring --> comments to prevent nose from using doc in verbose mode 2015-03-21 11:16:49 +05:30
Martin Ku 46470b418a Fix typo of DPGMM doc 2015-03-04 19:36:37 +08:00
Olivier Grisel 3f5277e835 Merge pull request #4284 from hbredin/dgpmm_convergence
[MRG + 1] Improve DPGMM/VBGMM convergence check
2015-02-25 09:46:04 +01:00
Herve Bredin 4a0e281510 DOC: make it clear 'thresh' should be removed in v0.18 2015-02-25 08:38:37 +01:00
Olivier Grisel 2c3e5640d9 DOC cosmetics in test docstring 2015-02-24 23:35:24 +01:00
Alexis Mignon 86392dbc6d Put the error state change about underflow errors in a 'with' statement in '_covar_mstep_full'. 2015-02-24 23:35:24 +01:00
Alexis Mignon fa3ecbc96d Converted docstring of 'test_positive_definite_covars' into a comment to avoid description ptoblems with nose (Related to issue #4250) 2015-02-24 23:35:23 +01:00
Alexis Mignon db2eddaa02 Converted test_positive_definite_covars to a generator. 2015-02-24 23:35:23 +01:00
Alexis Mignon 3e069d51ed Clarified a comment and factorized the tests for all covariance types 2015-02-24 23:35:23 +01:00
Alexis Mignon e0536d93b5 Cosmetic changes in the doc string. Added an indentation level 2015-02-24 23:35:23 +01:00
Alexis Mignon 739efd6e82 Added test to check that obtained covariance matrices are positive definite after learning a GMM 2015-02-24 23:35:23 +01:00
Alexis Mignon 5c893e5280 Change the way the covariance is computed to avoid problem with not positively defined covariance matrices 2015-02-24 23:35:22 +01:00
Herve Bredin 0c00f1a1b5 ENH: better convergence check 2015-02-23 17:14:26 +01:00
Andreas Mueller 8ef0b9a82f fixes in GMM, TSNE, MDS, LSHForest, exclude SpectralEmbedding 2015-02-10 18:34:31 -05:00
Andreas Mueller e3e0827243 FIX check (and enforce) that estimators can accept different dtypes. 2015-02-10 15:37:15 -05:00
Loïc Estève 5c0c5c672c MAINT use absolute imports in tests
as per the guideline in:
http://scikit-learn.org/stable/developers/#coding-guidelines
2015-02-10 13:40:31 +01:00
Olivier Grisel a3283c6d6b FIX tests in gmm broken by previous rebase 2015-02-08 23:50:02 +01:00
Herve Bredin 0f6f48a6f2 a few changes according to comments by @ogrisel 2015-02-08 23:00:54 +01:00
Herve Bredin 371c2f672a FIX: fix doctest 2015-02-08 22:59:46 +01:00
Herve Bredin bdecd1f447 ENH: issue #4178 (cont.) 2015-02-08 22:59:46 +01:00
Herve Bredin 79144e4444 ENH: improve GMM convergence check #4178 2015-02-08 22:59:45 +01:00
Andreas Mueller 364fdd6496 minor fixes, addressing @agramfort's comments. 2015-02-03 17:30:08 +01:00
wadawson 87c9ba7d26 Corrected two bugs related to 'tied' covariance_type in mixture.GMM(), added test, closes #4036
The first bug was with the Gaussian log-density calculation for the 'tied' covariance_type.
Rather than fix this equation I reformatted the covars data structure so that it could be fed
into the 'full' covariance_type log-density calculation. It might be a tiny bit slower but I think
it is better to have the least amount of potentially redundant code as this should minimize
the potential for such errors.

The second bug I fixed was related to the _covar_mstep_tied() function, only the first part
of the equation should be divided by X.shape[0].
2015-02-03 17:29:26 +01:00
Raghav R V b3fbccca38 FIX various mismatch between docstring and signature params
DOC max_iterations -> max_iter. Make it consistent with kmeans

MAINT Replace the deprecated dx parameter with d in the docstrings

MAINT Deprecation warning for max_iterations parameter.
2015-01-16 11:54:57 -05:00
Raghav R V abd31d2cad MAINT Make uniform the error raised for not fitted condition 2015-01-12 00:33:40 +05:30
Raghav R V 88555987cc PEP8 Fix E101, E111 errors and W191, W293, W293 and W391 warnings. 2015-01-08 04:28:24 +05:30
Nicola Montecchio 52472bc924 unused variables are redefined later 2014-11-07 10:31:46 -05:00
Félix-Antoine Fortin f0405a2a19 DOC: Remove extra # from url in fit.
The extra # messes with the rst parser which produces an invalid URL where the ".html" suffix is missing.
2014-10-24 12:16:55 -04:00
Jake VanderPlas beb0843072 DOC: fix doc inconsistency in GMM 2014-10-18 12:46:07 -07:00
Joel Nothman b3bdb08964 DOC fix formatting of attributes etc. in docstrings 2014-07-28 19:04:59 +10:00
Lars Buitinck 56057c9630 MAINT remove deprecated code 2014-07-23 16:19:40 +02:00